)]}'
{"manila_ui/dashboards/admin/shares/views.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b4c2f99903124be9823ec0b07d1f4dd0ed989488","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":176,"context_line":"        context \u003d super(UpdateShareTypeView, self).get_context_data(**kwargs)"},{"line_number":177,"context_line":"        args \u003d (self.get_object().id,)"},{"line_number":178,"context_line":"        context[\u0027submit_url\u0027] \u003d reverse(self.submit_url, args\u003dargs)"},{"line_number":179,"context_line":"        return context"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def get_initial(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_a991e6f3","line":178,"range":{"start_line":177,"start_character":8,"end_line":178,"end_character":67},"updated":"2016-06-15 11:21:17.000000000","message":"Same here as in https://review.openstack.org/#/c/329441/1/manila_ui/dashboards/project/shares/security_services/views.py","commit_id":"f25e9f34033b8ae1a968af073c2e4a89f6485203"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"6f41dfc98ffd3c8d453d0514d37b987ae3840c4d","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":176,"context_line":"        context \u003d super(UpdateShareTypeView, self).get_context_data(**kwargs)"},{"line_number":177,"context_line":"        args \u003d (self.get_object().id,)"},{"line_number":178,"context_line":"        context[\u0027submit_url\u0027] \u003d reverse(self.submit_url, args\u003dargs)"},{"line_number":179,"context_line":"        return context"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def get_initial(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_938b361e","line":178,"range":{"start_line":177,"start_character":8,"end_line":178,"end_character":67},"in_reply_to":"7aa08908_a991e6f3","updated":"2016-06-21 09:28:02.000000000","message":"Done","commit_id":"f25e9f34033b8ae1a968af073c2e4a89f6485203"}],"manila_ui/tests/dashboards/admin/shares/tests.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eeeeeaaba27a602cc49bba3a79d8e3066d37219b","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        self.assertTemplateUsed(res, \u0027admin/shares/update_share_type.html\u0027)"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def test_update_share_type_post(self):"},{"line_number":675,"context_line":"        share_type \u003d test_data.share_type"},{"line_number":676,"context_line":"        data \u003d {"},{"line_number":677,"context_line":"            \u0027extra_specs\u0027: \u0027driver_handles_share_servers\u003dTrue\u0027"},{"line_number":678,"context_line":"        }"},{"line_number":679,"context_line":"        form_data \u003d {"},{"line_number":680,"context_line":"            \u0027extra_specs\u0027: {\u0027driver_handles_share_servers\u0027: \u0027True\u0027},"},{"line_number":681,"context_line":"        }"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        url \u003d reverse(\u0027horizon:admin:shares:update_type\u0027, args\u003d[share_type.id])"},{"line_number":684,"context_line":"        self.mock_object("},{"line_number":685,"context_line":"            api_manila, \"share_type_get\", mock.Mock(return_value\u003dshare_type))"},{"line_number":686,"context_line":"        self.mock_object(api_manila, \"share_type_set_extra_specs\")"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        res \u003d self.client.post(url, data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_937cd6ec","line":685,"range":{"start_line":675,"start_character":8,"end_line":685,"end_character":77},"updated":"2016-06-21 09:33:43.000000000","message":"Lines 675,683,684,685 could be defined in setUp method. The same for test above.","commit_id":"3bf3700c539d82951c77103e38b54b78f01dc981"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"303a7127873a177c67960cbdea66818877b1317e","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        self.assertTemplateUsed(res, \u0027admin/shares/update_share_type.html\u0027)"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    def test_update_share_type_post(self):"},{"line_number":675,"context_line":"        share_type \u003d test_data.share_type"},{"line_number":676,"context_line":"        data \u003d {"},{"line_number":677,"context_line":"            \u0027extra_specs\u0027: \u0027driver_handles_share_servers\u003dTrue\u0027"},{"line_number":678,"context_line":"        }"},{"line_number":679,"context_line":"        form_data \u003d {"},{"line_number":680,"context_line":"            \u0027extra_specs\u0027: {\u0027driver_handles_share_servers\u0027: \u0027True\u0027},"},{"line_number":681,"context_line":"        }"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"        url \u003d reverse(\u0027horizon:admin:shares:update_type\u0027, args\u003d[share_type.id])"},{"line_number":684,"context_line":"        self.mock_object("},{"line_number":685,"context_line":"            api_manila, \"share_type_get\", mock.Mock(return_value\u003dshare_type))"},{"line_number":686,"context_line":"        self.mock_object(api_manila, \"share_type_set_extra_specs\")"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        res \u003d self.client.post(url, data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_16c0d47b","line":685,"range":{"start_line":675,"start_character":8,"end_line":685,"end_character":77},"in_reply_to":"5a9d85d2_937cd6ec","updated":"2016-06-21 09:41:41.000000000","message":"Thanks!","commit_id":"3bf3700c539d82951c77103e38b54b78f01dc981"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eeeeeaaba27a602cc49bba3a79d8e3066d37219b","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        url \u003d reverse(\u0027horizon:admin:shares:update_type\u0027, args\u003d[share_type.id])"},{"line_number":684,"context_line":"        self.mock_object("},{"line_number":685,"context_line":"            api_manila, \"share_type_get\", mock.Mock(return_value\u003dshare_type))"},{"line_number":686,"context_line":"        self.mock_object(api_manila, \"share_type_set_extra_specs\")"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        res \u003d self.client.post(url, data)"},{"line_number":689,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_d35dbe7a","line":686,"range":{"start_line":686,"start_character":8,"end_line":686,"end_character":66},"updated":"2016-06-21 09:33:43.000000000","message":"It is mocked but not verified that is not called.","commit_id":"3bf3700c539d82951c77103e38b54b78f01dc981"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"484a97e4964ac4ed25b384721de68639101ca0ca","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        url \u003d reverse(\u0027horizon:admin:shares:update_type\u0027, args\u003d[share_type.id])"},{"line_number":684,"context_line":"        self.mock_object("},{"line_number":685,"context_line":"            api_manila, \"share_type_get\", mock.Mock(return_value\u003dshare_type))"},{"line_number":686,"context_line":"        self.mock_object(api_manila, \"share_type_set_extra_specs\")"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        res \u003d self.client.post(url, data)"},{"line_number":689,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_8d614bab","line":686,"range":{"start_line":686,"start_character":8,"end_line":686,"end_character":66},"in_reply_to":"5a9d85d2_0721bcb4","updated":"2016-06-21 11:19:14.000000000","message":"It happens that code does redundant things, and I was mentioning it. Testing could verify that \"redundant things are not called\". But it is ok as is.","commit_id":"3bf3700c539d82951c77103e38b54b78f01dc981"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"56062b568fa68b994ba8a7660a809c3c7263b44f","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        url \u003d reverse(\u0027horizon:admin:shares:update_type\u0027, args\u003d[share_type.id])"},{"line_number":684,"context_line":"        self.mock_object("},{"line_number":685,"context_line":"            api_manila, \"share_type_get\", mock.Mock(return_value\u003dshare_type))"},{"line_number":686,"context_line":"        self.mock_object(api_manila, \"share_type_set_extra_specs\")"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        res \u003d self.client.post(url, data)"},{"line_number":689,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_b663c019","line":686,"range":{"start_line":686,"start_character":8,"end_line":686,"end_character":66},"in_reply_to":"5a9d85d2_3697d091","updated":"2016-06-21 09:52:59.000000000","message":"Oh, it exists. Sorry. Looked at above test \u003e\u003c\nBut you still may consider making such assertion there - \"not called\".","commit_id":"3bf3700c539d82951c77103e38b54b78f01dc981"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"e8ef701793d3885989ded2f955505f8820aac962","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        url \u003d reverse(\u0027horizon:admin:shares:update_type\u0027, args\u003d[share_type.id])"},{"line_number":684,"context_line":"        self.mock_object("},{"line_number":685,"context_line":"            api_manila, \"share_type_get\", mock.Mock(return_value\u003dshare_type))"},{"line_number":686,"context_line":"        self.mock_object(api_manila, \"share_type_set_extra_specs\")"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        res \u003d self.client.post(url, data)"},{"line_number":689,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_0721bcb4","line":686,"range":{"start_line":686,"start_character":8,"end_line":686,"end_character":66},"in_reply_to":"5a9d85d2_b663c019","updated":"2016-06-21 10:50:00.000000000","message":"I don\u0027t quite understand what assertion do you mean. All mocked objects are asserted, all not mocked objects are not needed.","commit_id":"3bf3700c539d82951c77103e38b54b78f01dc981"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"303a7127873a177c67960cbdea66818877b1317e","unresolved":false,"context_lines":[{"line_number":683,"context_line":"        url \u003d reverse(\u0027horizon:admin:shares:update_type\u0027, args\u003d[share_type.id])"},{"line_number":684,"context_line":"        self.mock_object("},{"line_number":685,"context_line":"            api_manila, \"share_type_get\", mock.Mock(return_value\u003dshare_type))"},{"line_number":686,"context_line":"        self.mock_object(api_manila, \"share_type_set_extra_specs\")"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        res \u003d self.client.post(url, data)"},{"line_number":689,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_3697d091","line":686,"range":{"start_line":686,"start_character":8,"end_line":686,"end_character":66},"in_reply_to":"5a9d85d2_d35dbe7a","updated":"2016-06-21 09:41:41.000000000","message":"L#692? Is it a verification you\u0027re talking about?","commit_id":"3bf3700c539d82951c77103e38b54b78f01dc981"}]}
