)]}'
{"manila_ui/dashboards/admin/shares/tables.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e2dae104f59196c89de125c316b695e0dba99bcc","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        status_columns \u003d [\"status\"]"},{"line_number":172,"context_line":"        row_class \u003d shares_tables.UpdateRow"},{"line_number":173,"context_line":"        table_actions \u003d ("},{"line_number":174,"context_line":"            SharesFilterAction, ManageShareAction, shares_tables.DeleteShare)"},{"line_number":175,"context_line":"        row_actions \u003d (UnmanageShareAction, shares_tables.DeleteShare)"},{"line_number":176,"context_line":"        columns \u003d ("},{"line_number":177,"context_line":"            \u0027tenant\u0027, \u0027host\u0027, \u0027name\u0027, \u0027size\u0027, \u0027status\u0027, \u0027visibility\u0027,"},{"line_number":178,"context_line":"            \u0027share_type\u0027, \u0027protocol\u0027, \u0027share_server\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_74ce102e","line":175,"range":{"start_line":174,"start_character":12,"end_line":175,"end_character":70},"updated":"2016-07-12 13:29:29.000000000","message":"For ease of constant update it is more usable to keep it one per line as it was, it reduces probability of merge conflicts.","commit_id":"90e1c1f06d51a005e4c9d63a120c5bd8d28bd163"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"219b178767d5ba2f7630afdc32cec76e49b46c01","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        status_columns \u003d [\"status\"]"},{"line_number":172,"context_line":"        row_class \u003d shares_tables.UpdateRow"},{"line_number":173,"context_line":"        table_actions \u003d ("},{"line_number":174,"context_line":"            SharesFilterAction, ManageShareAction, shares_tables.DeleteShare)"},{"line_number":175,"context_line":"        row_actions \u003d (UnmanageShareAction, shares_tables.DeleteShare)"},{"line_number":176,"context_line":"        columns \u003d ("},{"line_number":177,"context_line":"            \u0027tenant\u0027, \u0027host\u0027, \u0027name\u0027, \u0027size\u0027, \u0027status\u0027, \u0027visibility\u0027,"},{"line_number":178,"context_line":"            \u0027share_type\u0027, \u0027protocol\u0027, \u0027share_server\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_4a7b4abe","line":175,"range":{"start_line":174,"start_character":12,"end_line":175,"end_character":70},"in_reply_to":"1aa78d24_74ce102e","updated":"2016-07-27 08:45:18.000000000","message":"Strongly agreed. Let\u0027s fix it everywhere.","commit_id":"90e1c1f06d51a005e4c9d63a120c5bd8d28bd163"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e2dae104f59196c89de125c316b695e0dba99bcc","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return True"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"class SnapshotsFilterAction(tables.FilterAction):"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def filter(self, table, snapshots, filter_string):"},{"line_number":219,"context_line":"        \"\"\"Naive case-insensitive search.\"\"\""},{"line_number":220,"context_line":"        q \u003d filter_string.lower()"},{"line_number":221,"context_line":"        return [sn for sn in snapshots if q in sn.name.lower()]"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"class SnapshotsTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_34b768d9","line":221,"range":{"start_line":216,"start_character":0,"end_line":221,"end_character":63},"updated":"2016-07-12 13:29:29.000000000","message":"None of such new filter classes covered with unit tests. It is the reason \"cover\" job fails, see [1].\n\nAlso, all these \"new filter classes\" duplicate each other. Why do you need all of them and cannot use single class?\n\n[1] http://logs.openstack.org/68/340768/1/check/manila-ui-coverage/91315ef/console.html","commit_id":"90e1c1f06d51a005e4c9d63a120c5bd8d28bd163"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"219b178767d5ba2f7630afdc32cec76e49b46c01","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return True"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"class SnapshotsFilterAction(tables.FilterAction):"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def filter(self, table, snapshots, filter_string):"},{"line_number":219,"context_line":"        \"\"\"Naive case-insensitive search.\"\"\""},{"line_number":220,"context_line":"        q \u003d filter_string.lower()"},{"line_number":221,"context_line":"        return [sn for sn in snapshots if q in sn.name.lower()]"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"class SnapshotsTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_ea395ef3","line":221,"range":{"start_line":216,"start_character":0,"end_line":221,"end_character":63},"in_reply_to":"1aa78d24_34b768d9","updated":"2016-07-27 08:45:18.000000000","message":"Agreed. We can simply reuse horizon\u0027s NameFilterAction everywhere.","commit_id":"90e1c1f06d51a005e4c9d63a120c5bd8d28bd163"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e2dae104f59196c89de125c316b695e0dba99bcc","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        verbose_name \u003d _(\"Share Server\")"},{"line_number":447,"context_line":"        table_actions \u003d (DeleteShareServer, SharesServersFilterAction)"},{"line_number":448,"context_line":"        row_class \u003d UpdateShareServerRow"},{"line_number":449,"context_line":"        row_actions \u003d (DeleteShareServer,)"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"class ShareInstancesTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_7480d0bf","line":449,"range":{"start_line":449,"start_character":8,"end_line":449,"end_character":42},"updated":"2016-07-12 13:29:29.000000000","message":"Such changes look redundant for the goal of commit.","commit_id":"90e1c1f06d51a005e4c9d63a120c5bd8d28bd163"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4aaacd451b8165c4a6672c954727e947bb8a1afc","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            tables.NameFilterAction,"},{"line_number":251,"context_line":"            DeleteSnapshot)"},{"line_number":252,"context_line":"        row_actions \u003d ("},{"line_number":253,"context_line":"            DeleteSnapshot,)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"class DeleteSecurityService(tables.DeleteAction):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_436695bb","line":253,"range":{"start_line":253,"start_character":12,"end_line":253,"end_character":28},"updated":"2016-07-27 09:06:10.000000000","message":"Since, you state that \"deleteFOO\" should always be the last button, better to remove comma.","commit_id":"aba6af3e53e48ee48a33f8819d7bbfd97bb6060e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cb814d5d6436afbeaa5310fc953952db7565aeab","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            tables.NameFilterAction,"},{"line_number":251,"context_line":"            DeleteSnapshot)"},{"line_number":252,"context_line":"        row_actions \u003d ("},{"line_number":253,"context_line":"            DeleteSnapshot,)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"class DeleteSecurityService(tables.DeleteAction):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_b93982a6","line":253,"range":{"start_line":253,"start_character":12,"end_line":253,"end_character":28},"in_reply_to":"dada55a8_436695bb","updated":"2016-07-27 09:40:51.000000000","message":"We cannot remove comma. It will change the type and we\u0027ll get the TypeError.","commit_id":"aba6af3e53e48ee48a33f8819d7bbfd97bb6060e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4aaacd451b8165c4a6672c954727e947bb8a1afc","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            tables.NameFilterAction,"},{"line_number":305,"context_line":"            DeleteSecurityService)"},{"line_number":306,"context_line":"        row_actions \u003d ("},{"line_number":307,"context_line":"            DeleteSecurityService,)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"class UpdateShareServerRow(tables.Row):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_23756163","line":307,"range":{"start_line":307,"start_character":12,"end_line":307,"end_character":35},"updated":"2016-07-27 09:06:10.000000000","message":"ditto","commit_id":"aba6af3e53e48ee48a33f8819d7bbfd97bb6060e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4aaacd451b8165c4a6672c954727e947bb8a1afc","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            tables.NameFilterAction,"},{"line_number":341,"context_line":"            share_networks_tables.Delete)"},{"line_number":342,"context_line":"        row_class \u003d share_networks_tables.UpdateRow"},{"line_number":343,"context_line":"        row_actions \u003d (share_networks_tables.Delete,)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"class NeutronShareNetworkTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_e3c869aa","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":53},"updated":"2016-07-27 09:06:10.000000000","message":"This one does not follow commited approach.","commit_id":"aba6af3e53e48ee48a33f8819d7bbfd97bb6060e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"cb814d5d6436afbeaa5310fc953952db7565aeab","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            tables.NameFilterAction,"},{"line_number":341,"context_line":"            share_networks_tables.Delete)"},{"line_number":342,"context_line":"        row_class \u003d share_networks_tables.UpdateRow"},{"line_number":343,"context_line":"        row_actions \u003d (share_networks_tables.Delete,)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"class NeutronShareNetworkTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_f9565acc","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":53},"in_reply_to":"dada55a8_e3c869aa","updated":"2016-07-27 09:40:51.000000000","message":"Ok, I\u0027ll fix it.","commit_id":"aba6af3e53e48ee48a33f8819d7bbfd97bb6060e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4aaacd451b8165c4a6672c954727e947bb8a1afc","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            tables.NameFilterAction,"},{"line_number":370,"context_line":"            share_networks_tables.Delete)"},{"line_number":371,"context_line":"        row_class \u003d share_networks_tables.UpdateRow"},{"line_number":372,"context_line":"        row_actions \u003d (share_networks_tables.Delete,)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"class ShareServerTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_43e17529","line":372,"range":{"start_line":372,"start_character":8,"end_line":372,"end_character":53},"updated":"2016-07-27 09:06:10.000000000","message":"ditto","commit_id":"aba6af3e53e48ee48a33f8819d7bbfd97bb6060e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4aaacd451b8165c4a6672c954727e947bb8a1afc","unresolved":false,"context_lines":[{"line_number":422,"context_line":"            DeleteShareServer)"},{"line_number":423,"context_line":"        row_class \u003d UpdateShareServerRow"},{"line_number":424,"context_line":"        row_actions \u003d ("},{"line_number":425,"context_line":"            DeleteShareServer,)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"class ShareInstancesTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_830a4dd0","line":425,"range":{"start_line":425,"start_character":12,"end_line":425,"end_character":31},"updated":"2016-07-27 09:06:10.000000000","message":"ditto","commit_id":"aba6af3e53e48ee48a33f8819d7bbfd97bb6060e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4aaacd451b8165c4a6672c954727e947bb8a1afc","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        verbose_name \u003d _(\"Share Instances\")"},{"line_number":458,"context_line":"        status_columns \u003d (\"status\", )"},{"line_number":459,"context_line":"        table_actions \u003d ("},{"line_number":460,"context_line":"            tables.NameFilterAction,)"},{"line_number":461,"context_line":"        multi_select \u003d False"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    def get_share_network_link(share_instance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c310c502","line":460,"range":{"start_line":460,"start_character":12,"end_line":460,"end_character":37},"updated":"2016-07-27 09:06:10.000000000","message":"ditto","commit_id":"aba6af3e53e48ee48a33f8819d7bbfd97bb6060e"}]}