)]}'
{"manila_ui/dashboards/project/shares/snapshots/views.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"43cd1f1a6e0bd7f3825e73e354212e4bfaf39362","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        context[\u0027share_id\u0027] \u003d self.kwargs[\u0027share_id\u0027]"},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            share \u003d manila.share_get(self.request, context[\u0027share_id\u0027])"},{"line_number":81,"context_line":"            if share.status \u003d\u003d \u0027in-use\u0027:"},{"line_number":82,"context_line":"                context[\u0027attached\u0027] \u003d True"},{"line_number":83,"context_line":"                context[\u0027form\u0027].set_warning("},{"line_number":84,"context_line":"                    _(\"This share is currently attached to an instance. \""},{"line_number":85,"context_line":"                      \"In some cases, creating a snapshot from an attached \""},{"line_number":86,"context_line":"                      \"share can result in a corrupted snapshot.\"))"},{"line_number":87,"context_line":"            context[\u0027usages\u0027] \u003d quotas.tenant_limit_usages(self.request)"},{"line_number":88,"context_line":"        except Exception:"},{"line_number":89,"context_line":"            exceptions.handle(self.request,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_40e04b96","line":86,"range":{"start_line":81,"start_character":12,"end_line":86,"end_character":67},"updated":"2016-07-21 10:00:04.000000000","message":"It is dead code. Left-over from cinder. Condition is always False. You should not change it based on scope of your commit, but if you do, do it in proper way - just remove lines 83-88.\n\nBut in this case line 80 becomes redundant. So, it should be removed too.","commit_id":"7eeba3bf2724237cef912b2eedee96b532893369"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a18ec00e52fda4e309aa1c8c539e2cac7d6a51e3","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        context[\u0027share_id\u0027] \u003d self.kwargs[\u0027share_id\u0027]"},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            share \u003d manila.share_get(self.request, context[\u0027share_id\u0027])"},{"line_number":81,"context_line":"            if share.status \u003d\u003d \u0027in-use\u0027:"},{"line_number":82,"context_line":"                context[\u0027attached\u0027] \u003d True"},{"line_number":83,"context_line":"                context[\u0027form\u0027].set_warning("},{"line_number":84,"context_line":"                    _(\"This share is currently attached to an instance. \""},{"line_number":85,"context_line":"                      \"In some cases, creating a snapshot from an attached \""},{"line_number":86,"context_line":"                      \"share can result in a corrupted snapshot.\"))"},{"line_number":87,"context_line":"            context[\u0027usages\u0027] \u003d quotas.tenant_limit_usages(self.request)"},{"line_number":88,"context_line":"        except Exception:"},{"line_number":89,"context_line":"            exceptions.handle(self.request,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_bfdfd438","line":86,"range":{"start_line":81,"start_character":12,"end_line":86,"end_character":67},"in_reply_to":"dada55a8_40e04b96","updated":"2016-07-26 13:09:36.000000000","message":"You know, my point is quite simple: small cleanups are always out of scope -- and are always in. If you see some redundant parenthesis on your way to a better code, just remove them and go on. Reviewers life is not that boring to make them review another separate patch for the parenthesis. Anyways, to the change: I got your point and it seems better to me to remove this leftovers in another patch, because it\u0027s definitely more than just parenthesis.","commit_id":"7eeba3bf2724237cef912b2eedee96b532893369"}]}
