)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"855a096b736841f3711cdae55d0bedc2ef05eb1b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use parse_isotime filters for Share Replicas table columns"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Share Replicas table has two date columns: \"Created At\" and \"Updated At\"."},{"line_number":10,"context_line":"This change adds parse_isotime filters to them to make their content more"},{"line_number":11,"context_line":"readable: \"Sept. 7, 2016, 8:23 a.m.\" instead of \"2016-09-07T08:23:29.000000\"."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I03ae35b67e76b382b04747541afab0e4f574942a"},{"line_number":14,"context_line":"Closes-Bug: #1622530"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5da102_37794bf7","line":11,"range":{"start_line":10,"start_character":65,"end_line":11,"end_character":77},"updated":"2016-10-31 18:13:02.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"40eeef91c939bb7498cd0c3ce35d5de8b5a2df1c"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"17be005a44282c206da4a7ac90c47b40250f08a1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use parse_isotime filters for Share Replicas table columns"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Share Replicas table has two date columns: \"Created At\" and \"Updated At\"."},{"line_number":10,"context_line":"This change adds parse_isotime filters to them to make their content more"},{"line_number":11,"context_line":"readable: \"Sept. 7, 2016, 8:23 a.m.\" instead of \"2016-09-07T08:23:29.000000\"."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I03ae35b67e76b382b04747541afab0e4f574942a"},{"line_number":14,"context_line":"Closes-Bug: #1622530"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_281b25ca","line":11,"range":{"start_line":10,"start_character":65,"end_line":11,"end_character":77},"in_reply_to":"ba5da102_37794bf7","updated":"2017-06-05 14:09:09.000000000","message":"Done","commit_id":"40eeef91c939bb7498cd0c3ce35d5de8b5a2df1c"}],"manila_ui/dashboards/project/shares/replicas/tables.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"153b3a639196a857e552d2e0505f26325d62fa43","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    replica_state \u003d tables.Column("},{"line_number":143,"context_line":"        \"replica_state\", verbose_name\u003d_(\"Replica State\"))"},{"line_number":144,"context_line":"    host \u003d tables.Column(\"host\", verbose_name\u003d_(\"Host\"))"},{"line_number":145,"context_line":"    created_at \u003d tables.Column("},{"line_number":146,"context_line":"        \"created_at\", verbose_name\u003d_(\"Created At\"),"},{"line_number":147,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":148,"context_line":"    updated_at \u003d tables.Column("},{"line_number":149,"context_line":"        \"updated_at\", verbose_name\u003d_(\"Updated At\"),"},{"line_number":150,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_object_display(self, obj):"},{"line_number":153,"context_line":"        return obj.id"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_07ba430a","line":150,"range":{"start_line":145,"start_character":4,"end_line":150,"end_character":41},"updated":"2016-09-12 13:18:28.000000000","message":"Results of this filter can easily be tested. Please, add unit tests for it.","commit_id":"40eeef91c939bb7498cd0c3ce35d5de8b5a2df1c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"399a2ae14263b343646aea2486c6cc5a23cbf198","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    replica_state \u003d tables.Column("},{"line_number":143,"context_line":"        \"replica_state\", verbose_name\u003d_(\"Replica State\"))"},{"line_number":144,"context_line":"    host \u003d tables.Column(\"host\", verbose_name\u003d_(\"Host\"))"},{"line_number":145,"context_line":"    created_at \u003d tables.Column("},{"line_number":146,"context_line":"        \"created_at\", verbose_name\u003d_(\"Created At\"),"},{"line_number":147,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":148,"context_line":"    updated_at \u003d tables.Column("},{"line_number":149,"context_line":"        \"updated_at\", verbose_name\u003d_(\"Updated At\"),"},{"line_number":150,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_object_display(self, obj):"},{"line_number":153,"context_line":"        return obj.id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_c192a2f5","line":150,"range":{"start_line":145,"start_character":4,"end_line":150,"end_character":41},"in_reply_to":"1a95cdbc_a1f6768c","updated":"2016-10-10 13:00:42.000000000","message":"How manila UI knows that you use here expected *tested* filter? Right now - nohow. It is untested change.\nAnd it cannot be \"test again\" because generated page by manila UI is not tested in scope of this change.","commit_id":"40eeef91c939bb7498cd0c3ce35d5de8b5a2df1c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"39bc35da586a1f9afec5a12d35a78736b48286d7","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    replica_state \u003d tables.Column("},{"line_number":143,"context_line":"        \"replica_state\", verbose_name\u003d_(\"Replica State\"))"},{"line_number":144,"context_line":"    host \u003d tables.Column(\"host\", verbose_name\u003d_(\"Host\"))"},{"line_number":145,"context_line":"    created_at \u003d tables.Column("},{"line_number":146,"context_line":"        \"created_at\", verbose_name\u003d_(\"Created At\"),"},{"line_number":147,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":148,"context_line":"    updated_at \u003d tables.Column("},{"line_number":149,"context_line":"        \"updated_at\", verbose_name\u003d_(\"Updated At\"),"},{"line_number":150,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_object_display(self, obj):"},{"line_number":153,"context_line":"        return obj.id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_341706a7","line":150,"range":{"start_line":145,"start_character":4,"end_line":150,"end_character":41},"in_reply_to":"1a95cdbc_c192a2f5","updated":"2017-04-28 14:54:06.000000000","message":"Here is what I meant: http://paste.openstack.org/show/608339/\n\nJust one simple test that verifies this change. Would you mind adding it to this change?","commit_id":"40eeef91c939bb7498cd0c3ce35d5de8b5a2df1c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"053852abab88859cb1d93e445572704545d8537b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    replica_state \u003d tables.Column("},{"line_number":143,"context_line":"        \"replica_state\", verbose_name\u003d_(\"Replica State\"))"},{"line_number":144,"context_line":"    host \u003d tables.Column(\"host\", verbose_name\u003d_(\"Host\"))"},{"line_number":145,"context_line":"    created_at \u003d tables.Column("},{"line_number":146,"context_line":"        \"created_at\", verbose_name\u003d_(\"Created At\"),"},{"line_number":147,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":148,"context_line":"    updated_at \u003d tables.Column("},{"line_number":149,"context_line":"        \"updated_at\", verbose_name\u003d_(\"Updated At\"),"},{"line_number":150,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_object_display(self, obj):"},{"line_number":153,"context_line":"        return obj.id"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_54de12da","line":150,"range":{"start_line":145,"start_character":4,"end_line":150,"end_character":41},"in_reply_to":"5ff73747_341706a7","updated":"2017-04-28 14:57:11.000000000","message":"Or here:\n\n$ git diff\ndiff --git a/manila_ui/tests/dashboards/project/shares/replicas/tests.py b/manila_ui/tests/dashboards/project/shares/replicas/tests.py\nindex c7744a5..741f4e0 100644\n--- a/manila_ui/tests/dashboards/project/shares/replicas/tests.py\n+++ b/manila_ui/tests/dashboards/project/shares/replicas/tests.py\n@@ -18,6 +18,7 @@ from django.core.urlresolvers import reverse\n import mock\n \n from manila_ui.api import manila as api_manila\n+from manila_ui.dashboards.project.shares.replicas import tables as r_tables\n from manila_ui.tests.dashboards.project.shares import test_data\n from manila_ui.tests import helpers as test\n \n@@ -311,3 +312,17 @@ class ReplicasTests(test.TestCase):\n \n         self.assertRedirectsNoFollow(\n             res, reverse(\"horizon:project:shares:index\"))\n+\n+    def test_replicas_table(self):\n+        replicas_table \u003d r_tables.ReplicasTable(self.request)\n+        counter \u003d 0\n+        for column in replicas_table.get_columns():\n+            if column.name in (\u0027created_at\u0027, \u0027updated_at\u0027):\n+                self.assertEqual(1, len(column.filters))\n+                self.assertEqual(\n+                    column.filters[0], r_tables.filters.parse_isotime)\n+                counter +\u003d 1\n+        self.assertEqual(\n+            2, counter,\n+            \"Didn\u0027t find one or two of following columns: \u0027created_at\u0027 and/or \"\n+            \"\u0027updated_at\u0027 in \u0027ReplicasTable\u0027.\")","commit_id":"40eeef91c939bb7498cd0c3ce35d5de8b5a2df1c"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"17be005a44282c206da4a7ac90c47b40250f08a1","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    replica_state \u003d tables.Column("},{"line_number":143,"context_line":"        \"replica_state\", verbose_name\u003d_(\"Replica State\"))"},{"line_number":144,"context_line":"    host \u003d tables.Column(\"host\", verbose_name\u003d_(\"Host\"))"},{"line_number":145,"context_line":"    created_at \u003d tables.Column("},{"line_number":146,"context_line":"        \"created_at\", verbose_name\u003d_(\"Created At\"),"},{"line_number":147,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":148,"context_line":"    updated_at \u003d tables.Column("},{"line_number":149,"context_line":"        \"updated_at\", verbose_name\u003d_(\"Updated At\"),"},{"line_number":150,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_object_display(self, obj):"},{"line_number":153,"context_line":"        return obj.id"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_a80f3586","line":150,"range":{"start_line":145,"start_character":4,"end_line":150,"end_character":41},"in_reply_to":"5ff73747_54de12da","updated":"2017-06-05 14:09:09.000000000","message":"Okay, let\u0027s test that we really have these columns.","commit_id":"40eeef91c939bb7498cd0c3ce35d5de8b5a2df1c"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a17695bd86329ea629cdce881ce3533dc1cfebf1","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    replica_state \u003d tables.Column("},{"line_number":143,"context_line":"        \"replica_state\", verbose_name\u003d_(\"Replica State\"))"},{"line_number":144,"context_line":"    host \u003d tables.Column(\"host\", verbose_name\u003d_(\"Host\"))"},{"line_number":145,"context_line":"    created_at \u003d tables.Column("},{"line_number":146,"context_line":"        \"created_at\", verbose_name\u003d_(\"Created At\"),"},{"line_number":147,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":148,"context_line":"    updated_at \u003d tables.Column("},{"line_number":149,"context_line":"        \"updated_at\", verbose_name\u003d_(\"Updated At\"),"},{"line_number":150,"context_line":"        filters\u003d(filters.parse_isotime,))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def get_object_display(self, obj):"},{"line_number":153,"context_line":"        return obj.id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_a1f6768c","line":150,"range":{"start_line":145,"start_character":4,"end_line":150,"end_character":41},"in_reply_to":"9a89bdaa_07ba430a","updated":"2016-10-10 12:56:55.000000000","message":"Could you please specify what exactly, where and why should be tested? parse_isotime filter is already tested in horizon, why and where should we test it again?","commit_id":"40eeef91c939bb7498cd0c3ce35d5de8b5a2df1c"}]}