)]}'
{"README.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Configuring"},{"line_number":80,"context_line":"-----------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_bb11f8ae","line":82,"range":{"start_line":82,"start_character":59,"end_line":82,"end_character":60},"updated":"2016-10-23 09:03:05.000000000","message":"s/,/.","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Configuring"},{"line_number":80,"context_line":"-----------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_db26ac15","line":82,"range":{"start_line":82,"start_character":67,"end_line":82,"end_character":70},"updated":"2016-10-23 09:03:05.000000000","message":"to do so,","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Configuring"},{"line_number":80,"context_line":"-----------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_932d7daa","line":82,"range":{"start_line":82,"start_character":59,"end_line":82,"end_character":60},"in_reply_to":"da6895a0_bb11f8ae","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":79,"context_line":"Configuring"},{"line_number":80,"context_line":"-----------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_d319b589","line":82,"range":{"start_line":82,"start_character":67,"end_line":82,"end_character":70},"in_reply_to":"da6895a0_db26ac15","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"-----------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_fb237003","line":83,"range":{"start_line":83,"start_character":13,"end_line":83,"end_character":14},"updated":"2016-10-23 09:03:05.000000000","message":"s/,//","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":80,"context_line":"-----------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_56b11346","line":83,"range":{"start_line":83,"start_character":13,"end_line":83,"end_character":14},"in_reply_to":"ba5da102_85cd3a87","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":80,"context_line":"-----------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_36a81fdb","line":83,"range":{"start_line":83,"start_character":13,"end_line":83,"end_character":14},"in_reply_to":"da6895a0_fb237003","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f6a2a4b72f8d1af028f3a5fb57cd038b9e4c6d90","unresolved":false,"context_lines":[{"line_number":80,"context_line":"-----------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_85cd3a87","line":83,"range":{"start_line":83,"start_character":13,"end_line":83,"end_character":14},"in_reply_to":"da6895a0_fb237003","updated":"2016-11-02 16:27:58.000000000","message":"s/look at/look for/","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f6a2a4b72f8d1af028f3a5fb57cd038b9e4c6d90","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    * enable_replication"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_e5def60f","line":84,"updated":"2016-11-02 16:27:58.000000000","message":"s/values of python dict/the values of the OPENSTACK_MANILA_FEATURES dict/","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    * enable_replication"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_b68b4f67","line":84,"in_reply_to":"ba5da102_e5def60f","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f6a2a4b72f8d1af028f3a5fb57cd038b9e4c6d90","unresolved":false,"context_lines":[{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    * enable_replication"},{"line_number":88,"context_line":"    * enable_migration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_a0b78938","line":85,"updated":"2016-11-02 16:27:58.000000000","message":"Remove this line","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features, to do it,"},{"line_number":83,"context_line":"look at files, located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine values of python dict"},{"line_number":85,"context_line":"called \"OPENSTACK_MANILA_FEATURES\", such as:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    * enable_replication"},{"line_number":88,"context_line":"    * enable_migration"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_36f65ff9","line":85,"in_reply_to":"ba5da102_a0b78938","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    * enable_migration"},{"line_number":89,"context_line":"    * enable_public_share_type_creation"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Note, that there is separate list of configurations for each of dashboards -"},{"line_number":92,"context_line":"\"admin\" and \"project\". Also, it is possible to define any kind of options,"},{"line_number":93,"context_line":"case of enable/disalbe features is just the most popular use case."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Contributing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_5b79bcfb","line":92,"range":{"start_line":91,"start_character":52,"end_line":92,"end_character":21},"updated":"2016-10-23 09:03:05.000000000","message":"for \"admin\" and \"project\" dashboards.","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    * enable_migration"},{"line_number":89,"context_line":"    * enable_public_share_type_creation"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Note, that there is separate list of configurations for each of dashboards -"},{"line_number":92,"context_line":"\"admin\" and \"project\". Also, it is possible to define any kind of options,"},{"line_number":93,"context_line":"case of enable/disalbe features is just the most popular use case."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Contributing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_11b24506","line":92,"range":{"start_line":91,"start_character":52,"end_line":92,"end_character":21},"in_reply_to":"ba5da102_3d01e26a","updated":"2016-11-02 17:30:01.000000000","message":"It is readme of Manila UI. Only Manila UI related.","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    * enable_migration"},{"line_number":89,"context_line":"    * enable_public_share_type_creation"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Note, that there is separate list of configurations for each of dashboards -"},{"line_number":92,"context_line":"\"admin\" and \"project\". Also, it is possible to define any kind of options,"},{"line_number":93,"context_line":"case of enable/disalbe features is just the most popular use case."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Contributing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_b667cfb5","line":92,"range":{"start_line":91,"start_character":52,"end_line":92,"end_character":21},"in_reply_to":"da6895a0_5b79bcfb","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f6a2a4b72f8d1af028f3a5fb57cd038b9e4c6d90","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    * enable_migration"},{"line_number":89,"context_line":"    * enable_public_share_type_creation"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Note, that there is separate list of configurations for each of dashboards -"},{"line_number":92,"context_line":"\"admin\" and \"project\". Also, it is possible to define any kind of options,"},{"line_number":93,"context_line":"case of enable/disalbe features is just the most popular use case."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Contributing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_3d01e26a","line":92,"range":{"start_line":91,"start_character":52,"end_line":92,"end_character":21},"in_reply_to":"da6895a0_5b79bcfb","updated":"2016-11-02 16:27:58.000000000","message":"What do you mean with \"define any kind of options\"? Manila related or Dashboard related? This phrase could be confusing.","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Note, that there is separate list of configurations for each of dashboards -"},{"line_number":92,"context_line":"\"admin\" and \"project\". Also, it is possible to define any kind of options,"},{"line_number":93,"context_line":"case of enable/disalbe features is just the most popular use case."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Contributing"},{"line_number":96,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_bb8818e9","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":22},"updated":"2016-10-23 09:03:05.000000000","message":"the case of enabling or disabling features","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Note, that there is separate list of configurations for each of dashboards -"},{"line_number":92,"context_line":"\"admin\" and \"project\". Also, it is possible to define any kind of options,"},{"line_number":93,"context_line":"case of enable/disalbe features is just the most popular use case."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Contributing"},{"line_number":96,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_966acb7f","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":22},"in_reply_to":"da6895a0_bb8818e9","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f6a2a4b72f8d1af028f3a5fb57cd038b9e4c6d90","unresolved":false,"context_lines":[{"line_number":98,"context_line":"It is expected that each addition of new logic to Manila UI is covered by"},{"line_number":99,"context_line":"unit tests."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Test modules should be located under \"manila_ui/tests\" directory, it should"},{"line_number":102,"context_line":"satisfy following template:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    * \"manila_ui[/tests]/path/to/[test_]modulename.py\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_80128555","line":101,"updated":"2016-11-02 16:27:58.000000000","message":"Test modules should be located under \"manila_ui/tests\", satisfying the following template when test are written for a specific module:","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":98,"context_line":"It is expected that each addition of new logic to Manila UI is covered by"},{"line_number":99,"context_line":"unit tests."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Test modules should be located under \"manila_ui/tests\" directory, it should"},{"line_number":102,"context_line":"satisfy following template:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    * \"manila_ui[/tests]/path/to/[test_]modulename.py\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_96748b36","line":101,"in_reply_to":"ba5da102_80128555","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Test modules should be located under \"manila_ui/tests\" directory, it should"},{"line_number":102,"context_line":"satisfy following template:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    * \"manila_ui[/tests]/path/to/[test_]modulename.py\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"When tests are written for specific module."},{"line_number":107,"context_line":"But it can satisfy following one:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_db6dcc33","line":104,"range":{"start_line":104,"start_character":16,"end_line":104,"end_character":24},"updated":"2016-10-23 09:03:05.000000000","message":"?\n\nthis should be manila_ui/tests/path/to/test_[modulename].py","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":101,"context_line":"Test modules should be located under \"manila_ui/tests\" directory, it should"},{"line_number":102,"context_line":"satisfy following template:"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    * \"manila_ui[/tests]/path/to/[test_]modulename.py\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"When tests are written for specific module."},{"line_number":107,"context_line":"But it can satisfy following one:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_b6c34f56","line":104,"range":{"start_line":104,"start_character":16,"end_line":104,"end_character":24},"in_reply_to":"da6895a0_db6dcc33","updated":"2016-11-02 17:30:01.000000000","message":"No, it should not. Case with brackets is path to test module, case without brackets is path to tested module.\nBrackets mean string that can be omitted. It is common agreement in our world.\n\nYou propose this:\n1) manila_ui/tests/path/to/test_modulename.py\n2) manila_ui/tests/path/to/test_.py\n\nWhere (2) is completely wrong and none of these two is main module.","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f6a2a4b72f8d1af028f3a5fb57cd038b9e4c6d90","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    * \"manila_ui[/tests]/path/to/[test_]modulename.py\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"When tests are written for specific module."},{"line_number":107,"context_line":"But it can satisfy following one:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    * \"manila_ui[/tests]/path/to/directory/tests.py\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_e04ee16d","line":106,"updated":"2016-11-02 16:27:58.000000000","message":"Remove this line.","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    * \"manila_ui[/tests]/path/to/[test_]modulename.py\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"When tests are written for specific module."},{"line_number":107,"context_line":"But it can satisfy following one:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    * \"manila_ui[/tests]/path/to/directory/tests.py\""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_16807bf6","line":106,"in_reply_to":"ba5da102_e04ee16d","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    * \"manila_ui[/tests]/path/to/[test_]modulename.py\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"When tests are written for specific module."},{"line_number":107,"context_line":"But it can satisfy following one:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    * \"manila_ui[/tests]/path/to/directory/tests.py\""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_7b65a043","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":32},"updated":"2016-10-23 09:03:05.000000000","message":"However, when testing the flow between different modules, the tests can be added to a test module that can satisfy the following template::","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    * \"manila_ui[/tests]/path/to/[test_]modulename.py\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"When tests are written for specific module."},{"line_number":107,"context_line":"But it can satisfy following one:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    * \"manila_ui[/tests]/path/to/directory/tests.py\""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_d12d2d47","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":32},"in_reply_to":"da6895a0_7b65a043","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f6a2a4b72f8d1af028f3a5fb57cd038b9e4c6d90","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    * \"manila_ui[/tests]/path/to/[test_]modulename.py\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"When tests are written for specific module."},{"line_number":107,"context_line":"But it can satisfy following one:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    * \"manila_ui[/tests]/path/to/directory/tests.py\""},{"line_number":110,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_00f035fd","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":32},"in_reply_to":"da6895a0_7b65a043","updated":"2016-11-02 16:27:58.000000000","message":"Otherwise, if your test covers more modules, sticking to next template is the way to go:","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"When tests are written for specific module."},{"line_number":107,"context_line":"But it can satisfy following one:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    * \"manila_ui[/tests]/path/to/directory/tests.py\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"In case we test things using test app which touching lots of different modules."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_3b75e8f8","line":109,"range":{"start_line":109,"start_character":7,"end_line":109,"end_character":51},"updated":"2016-10-23 09:03:05.000000000","message":"manila_ui/tests/path/to/directory/tests.py","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":106,"context_line":"When tests are written for specific module."},{"line_number":107,"context_line":"But it can satisfy following one:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    * \"manila_ui[/tests]/path/to/directory/tests.py\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"In case we test things using test app which touching lots of different modules."},{"line_number":112,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_16aebb80","line":109,"range":{"start_line":109,"start_character":7,"end_line":109,"end_character":51},"in_reply_to":"da6895a0_3b75e8f8","updated":"2016-11-02 17:30:01.000000000","message":"Answer is above.","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f6a2a4b72f8d1af028f3a5fb57cd038b9e4c6d90","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"In case we test things using test app which touching lots of different modules."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Manila UI tests use \"mock\" lib, not \"mox\" as Horizon does."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementing new feature, you may think about making it optional, so it could"},{"line_number":116,"context_line":"be enabled or disabled. Or add some variables with strings values..."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_1d397ef2","line":113,"updated":"2016-11-02 16:27:58.000000000","message":"I wouldn\u0027t reference Horizon testing, we only care about Manila UI in this case. I\u0027d say something as \"Manila UI tests use the mock library for testing\". Or something like that.","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"In case we test things using test app which touching lots of different modules."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Manila UI tests use \"mock\" lib, not \"mox\" as Horizon does."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementing new feature, you may think about making it optional, so it could"},{"line_number":116,"context_line":"be enabled or disabled. Or add some variables with strings values..."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_7688d7c5","line":113,"in_reply_to":"ba5da102_1d397ef2","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f6a2a4b72f8d1af028f3a5fb57cd038b9e4c6d90","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Manila UI tests use \"mock\" lib, not \"mox\" as Horizon does."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementing new feature, you may think about making it optional, so it could"},{"line_number":116,"context_line":"be enabled or disabled. Or add some variables with strings values..."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"How to use it:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_60c6519b","line":115,"updated":"2016-11-02 16:27:58.000000000","message":"Didn\u0027t understand what you mean here.","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"Manila UI tests use \"mock\" lib, not \"mox\" as Horizon does."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementing new feature, you may think about making it optional, so it could"},{"line_number":116,"context_line":"be enabled or disabled. Or add some variables with strings values..."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"How to use it:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_d69603ef","line":115,"in_reply_to":"ba5da102_60c6519b","updated":"2016-11-02 17:30:01.000000000","message":"Removed second sentence, as it could cause confusion. Idea is in ability to disable some features in UI if we need to.","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Manila UI tests use \"mock\" lib, not \"mox\" as Horizon does."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementing new feature, you may think about making it optional, so it could"},{"line_number":116,"context_line":"be enabled or disabled. Or add some variables with strings values..."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"How to use it:"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_9b5a7482","line":116,"range":{"start_line":116,"start_character":66,"end_line":116,"end_character":68},"updated":"2016-10-23 09:03:05.000000000","message":"remove","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Manila UI tests use \"mock\" lib, not \"mox\" as Horizon does."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementing new feature, you may think about making it optional, so it could"},{"line_number":116,"context_line":"be enabled or disabled. Or add some variables with strings values..."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"How to use it:"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_961e4bb9","line":116,"range":{"start_line":116,"start_character":66,"end_line":116,"end_character":68},"in_reply_to":"da6895a0_9b5a7482","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    manila_config \u003d getattr(settings, \u0027OPENSTACK_MANILA_FEATURES\u0027, {})"},{"line_number":122,"context_line":"    manila_config.get(\u0027your_new_config_option\u0027, \u0027value_of_config_option\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Definition of it can be found in `Configuring` section."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Running Unit Testing"},{"line_number":127,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_bb5f3871","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":55},"updated":"2016-10-23 09:03:05.000000000","message":"Link it, or remove..","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    manila_config \u003d getattr(settings, \u0027OPENSTACK_MANILA_FEATURES\u0027, {})"},{"line_number":122,"context_line":"    manila_config.get(\u0027your_new_config_option\u0027, \u0027value_of_config_option\u0027)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Definition of it can be found in `Configuring` section."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Running Unit Testing"},{"line_number":127,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_f61867d5","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":55},"in_reply_to":"da6895a0_bb5f3871","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Definition of it can be found in `Configuring` section."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Running Unit Testing"},{"line_number":127,"context_line":"--------------------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"The unit tests can be executed directly from within this Manila UI plugin"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_3b47a8bc","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":20},"updated":"2016-10-23 09:03:05.000000000","message":"unit tests","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Definition of it can be found in `Configuring` section."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Running Unit Testing"},{"line_number":127,"context_line":"--------------------"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"The unit tests can be executed directly from within this Manila UI plugin"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_96d9eb24","line":126,"range":{"start_line":126,"start_character":8,"end_line":126,"end_character":20},"in_reply_to":"da6895a0_3b47a8bc","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"horizon source, which pulls down all of the horizon and openstack_dashboard"},{"line_number":137,"context_line":"modules that the plugin uses."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"To run only py27 unit tests, use following command:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    $ tox -e py27"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_5b129cb5","line":139,"range":{"start_line":139,"start_character":50,"end_line":139,"end_character":51},"updated":"2016-10-23 09:03:05.000000000","message":"::","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":136,"context_line":"horizon source, which pulls down all of the horizon and openstack_dashboard"},{"line_number":137,"context_line":"modules that the plugin uses."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"To run only py27 unit tests, use following command:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    $ tox -e py27"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_56d3d303","line":139,"range":{"start_line":139,"start_character":50,"end_line":139,"end_character":51},"in_reply_to":"da6895a0_5b129cb5","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    $ tox -e py27"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"To run only py34 unit tests, use following command:"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    $ tox -e py34"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_7b1760a3","line":143,"range":{"start_line":143,"start_character":50,"end_line":143,"end_character":51},"updated":"2016-10-23 09:03:05.000000000","message":"::","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    $ tox -e py27"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"To run only py34 unit tests, use following command:"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    $ tox -e py34"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_36eadfac","line":143,"range":{"start_line":143,"start_character":50,"end_line":143,"end_character":51},"in_reply_to":"da6895a0_7b1760a3","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    $ tox -e py34"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"To run unit tests using specific Django version use some of the following:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    $ tox -e py27dj17"},{"line_number":150,"context_line":"    $ tox -e py27dj18"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_9b0c3496","line":147,"range":{"start_line":147,"start_character":73,"end_line":147,"end_character":74},"updated":"2016-10-23 09:03:05.000000000","message":"::","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4f50430d0259fd3499e4a3c93cd3b635cab0b5","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    $ tox -e py34"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"To run unit tests using specific Django version use some of the following:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    $ tox -e py27dj17"},{"line_number":150,"context_line":"    $ tox -e py27dj18"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da6895a0_1b4ae4c5","line":147,"range":{"start_line":147,"start_character":52,"end_line":147,"end_character":59},"updated":"2016-10-23 09:03:05.000000000","message":"nit: remove","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    $ tox -e py34"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"To run unit tests using specific Django version use some of the following:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    $ tox -e py27dj17"},{"line_number":150,"context_line":"    $ tox -e py27dj18"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_b6bfcfa8","line":147,"range":{"start_line":147,"start_character":52,"end_line":147,"end_character":59},"in_reply_to":"da6895a0_1b4ae4c5","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"20b5c9928ecca2b952326ef64bffe53dd5653c01","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    $ tox -e py34"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"To run unit tests using specific Django version use some of the following:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    $ tox -e py27dj17"},{"line_number":150,"context_line":"    $ tox -e py27dj18"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5da102_96c2cb32","line":147,"range":{"start_line":147,"start_character":73,"end_line":147,"end_character":74},"in_reply_to":"da6895a0_9b0c3496","updated":"2016-11-02 17:30:01.000000000","message":"Done","commit_id":"6e6b3b939aaeae1a7cfe0585d53d1c578397df0f"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"b86b6850e0bb3bd1bbe1dc782eaefb0e689e9852","unresolved":false,"context_lines":[{"line_number":76,"context_line":"the Shares tab under Project \u003e Compute. You can access Horizon with"},{"line_number":77,"context_line":"Manila UI using the same URL and port as before."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"`Configuring`_"},{"line_number":80,"context_line":"--------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features. To do so,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_ece33ad7","line":79,"range":{"start_line":79,"start_character":1,"end_line":79,"end_character":12},"updated":"2016-11-02 18:03:04.000000000","message":"nit: Configuration","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b0c038d5df7df582e91d85db14f5d9df5a53a020","unresolved":false,"context_lines":[{"line_number":76,"context_line":"the Shares tab under Project \u003e Compute. You can access Horizon with"},{"line_number":77,"context_line":"Manila UI using the same URL and port as before."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"`Configuring`_"},{"line_number":80,"context_line":"--------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features. To do so,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_4774ff66","line":79,"range":{"start_line":79,"start_character":1,"end_line":79,"end_character":12},"in_reply_to":"ba5da102_ece33ad7","updated":"2016-11-02 18:19:04.000000000","message":"Done","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"b86b6850e0bb3bd1bbe1dc782eaefb0e689e9852","unresolved":false,"context_lines":[{"line_number":79,"context_line":"`Configuring`_"},{"line_number":80,"context_line":"--------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features. To do so,"},{"line_number":83,"context_line":"look for files located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine the values of the OPENSTACK_MANILA_FEATURES dict::"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_2cea92ac","line":82,"range":{"start_line":82,"start_character":41,"end_line":82,"end_character":47},"updated":"2016-11-02 18:03:04.000000000","message":"nit: manila","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b0c038d5df7df582e91d85db14f5d9df5a53a020","unresolved":false,"context_lines":[{"line_number":79,"context_line":"`Configuring`_"},{"line_number":80,"context_line":"--------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features. To do so,"},{"line_number":83,"context_line":"look for files located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine the values of the OPENSTACK_MANILA_FEATURES dict::"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_275b8bf7","line":82,"range":{"start_line":82,"start_character":41,"end_line":82,"end_character":47},"in_reply_to":"ba5da102_2cea92ac","updated":"2016-11-02 18:19:04.000000000","message":"It is the approach that is already used in this doc. Leaving as is.","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"b86b6850e0bb3bd1bbe1dc782eaefb0e689e9852","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features. To do so,"},{"line_number":83,"context_line":"look for files located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine the values of the OPENSTACK_MANILA_FEATURES dict::"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    * enable_replication"},{"line_number":87,"context_line":"    * enable_migration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_4cfa6676","line":84,"range":{"start_line":84,"start_character":23,"end_line":84,"end_character":26},"updated":"2016-11-02 18:03:04.000000000","message":"nit: `these` ?","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b0c038d5df7df582e91d85db14f5d9df5a53a020","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"It is possible to enable or disable some Manila UI features. To do so,"},{"line_number":83,"context_line":"look for files located in \"manila_ui/enabled\" directory,"},{"line_number":84,"context_line":"where you can redefine the values of the OPENSTACK_MANILA_FEATURES dict::"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    * enable_replication"},{"line_number":87,"context_line":"    * enable_migration"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_47fb1fc1","line":84,"range":{"start_line":84,"start_character":23,"end_line":84,"end_character":26},"in_reply_to":"ba5da102_4cfa6676","updated":"2016-11-02 18:19:04.000000000","message":"no.","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"b86b6850e0bb3bd1bbe1dc782eaefb0e689e9852","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    * enable_migration"},{"line_number":88,"context_line":"    * enable_public_share_type_creation"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Note, that there is separate list of configurations for \"admin\" and"},{"line_number":91,"context_line":"\"project\" dashboards. Also, it is possible to define any kind of options,"},{"line_number":92,"context_line":"the case of enabling or disabling features is just the most popular use case."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_8c471ebb","line":90,"range":{"start_line":90,"start_character":20,"end_line":90,"end_character":28},"updated":"2016-11-02 18:03:04.000000000","message":"nit: a seprate","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"b86b6850e0bb3bd1bbe1dc782eaefb0e689e9852","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    * enable_migration"},{"line_number":88,"context_line":"    * enable_public_share_type_creation"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Note, that there is separate list of configurations for \"admin\" and"},{"line_number":91,"context_line":"\"project\" dashboards. Also, it is possible to define any kind of options,"},{"line_number":92,"context_line":"the case of enabling or disabling features is just the most popular use case."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_0c330e63","line":90,"range":{"start_line":90,"start_character":4,"end_line":90,"end_character":5},"updated":"2016-11-02 18:03:04.000000000","message":"no need","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"b86b6850e0bb3bd1bbe1dc782eaefb0e689e9852","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    * enable_migration"},{"line_number":88,"context_line":"    * enable_public_share_type_creation"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Note, that there is separate list of configurations for \"admin\" and"},{"line_number":91,"context_line":"\"project\" dashboards. Also, it is possible to define any kind of options,"},{"line_number":92,"context_line":"the case of enabling or disabling features is just the most popular use case."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_6c3e4a29","line":90,"range":{"start_line":90,"start_character":6,"end_line":90,"end_character":10},"updated":"2016-11-02 18:03:04.000000000","message":"that,","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b0c038d5df7df582e91d85db14f5d9df5a53a020","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    * enable_migration"},{"line_number":88,"context_line":"    * enable_public_share_type_creation"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Note, that there is separate list of configurations for \"admin\" and"},{"line_number":91,"context_line":"\"project\" dashboards. Also, it is possible to define any kind of options,"},{"line_number":92,"context_line":"the case of enabling or disabling features is just the most popular use case."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_87eff7e7","line":90,"range":{"start_line":90,"start_character":20,"end_line":90,"end_character":28},"in_reply_to":"ba5da102_8c471ebb","updated":"2016-11-02 18:19:04.000000000","message":"Done","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"b86b6850e0bb3bd1bbe1dc782eaefb0e689e9852","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Contributing"},{"line_number":95,"context_line":"------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"It is expected that each addition of new logic to Manila UI is covered by"},{"line_number":98,"context_line":"unit tests."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Test modules should be located under \"manila_ui/tests\","}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_ec189ad5","line":97,"range":{"start_line":97,"start_character":50,"end_line":97,"end_character":56},"updated":"2016-11-02 18:03:04.000000000","message":"nit: manila","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b0c038d5df7df582e91d85db14f5d9df5a53a020","unresolved":false,"context_lines":[{"line_number":94,"context_line":"Contributing"},{"line_number":95,"context_line":"------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"It is expected that each addition of new logic to Manila UI is covered by"},{"line_number":98,"context_line":"unit tests."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Test modules should be located under \"manila_ui/tests\","}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_c75f2fe3","line":97,"range":{"start_line":97,"start_character":50,"end_line":97,"end_character":56},"in_reply_to":"ba5da102_ec189ad5","updated":"2016-11-02 18:19:04.000000000","message":"It is the approach that is already used in this doc. Leaving as is.","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"b86b6850e0bb3bd1bbe1dc782eaefb0e689e9852","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    * \"manila_ui[/tests]/path/to/directory/tests.py\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"In case we test things using test app which touches lots of different modules."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Manila UI tests use the mock library for testing."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_6c01ea37","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":78},"updated":"2016-11-02 18:03:04.000000000","message":"It would be nice to rephrase this sentence, It is not quite clear what it relates to.","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b0c038d5df7df582e91d85db14f5d9df5a53a020","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    * \"manila_ui[/tests]/path/to/directory/tests.py\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"In case we test things using test app which touches lots of different modules."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Manila UI tests use the mock library for testing."},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_c7d1ef58","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":78},"in_reply_to":"ba5da102_6c01ea37","updated":"2016-11-02 18:19:04.000000000","message":"Done","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"b86b6850e0bb3bd1bbe1dc782eaefb0e689e9852","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Manila UI tests use the mock library for testing."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Implementing new feature, you may think about making it optional, so it could"},{"line_number":117,"context_line":"be enabled or disabled in different deployments."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"How to use it:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_2ca2924b","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":12},"updated":"2016-11-02 18:03:04.000000000","message":"Couldn\u0027t we change this to something like `When implementing a new feature`","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b0c038d5df7df582e91d85db14f5d9df5a53a020","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Manila UI tests use the mock library for testing."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Implementing new feature, you may think about making it optional, so it could"},{"line_number":117,"context_line":"be enabled or disabled in different deployments."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"How to use it:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_47c6bf9a","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":12},"in_reply_to":"ba5da102_2ca2924b","updated":"2016-11-02 18:19:04.000000000","message":"Done","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"b86b6850e0bb3bd1bbe1dc782eaefb0e689e9852","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    manila_config \u003d getattr(settings, \u0027OPENSTACK_MANILA_FEATURES\u0027, {})"},{"line_number":123,"context_line":"    manila_config.get(\u0027your_new_config_option\u0027, \u0027value_of_config_option\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Definition of it can be found in _`Configuring` section."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Running Unit Tests"},{"line_number":128,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_6c880ac6","line":125,"range":{"start_line":125,"start_character":35,"end_line":125,"end_character":46},"updated":"2016-11-02 18:03:04.000000000","message":"Configuration","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b0c038d5df7df582e91d85db14f5d9df5a53a020","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    manila_config \u003d getattr(settings, \u0027OPENSTACK_MANILA_FEATURES\u0027, {})"},{"line_number":123,"context_line":"    manila_config.get(\u0027your_new_config_option\u0027, \u0027value_of_config_option\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Definition of it can be found in _`Configuring` section."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Running Unit Tests"},{"line_number":128,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba5da102_c79c8fc2","line":125,"range":{"start_line":125,"start_character":35,"end_line":125,"end_character":46},"in_reply_to":"ba5da102_6c880ac6","updated":"2016-11-02 18:19:04.000000000","message":"Done","commit_id":"715eb9f0cca1cf752eb6e5a7a424596a092dcc03"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c652117794a3a327f21fc6f0127c16809c6daece","unresolved":false,"context_lines":[{"line_number":91,"context_line":"\"project\" dashboards. Also, it is possible to define any kind of options,"},{"line_number":92,"context_line":"the case of enabling or disabling features is just the most popular use case."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Contributing"},{"line_number":95,"context_line":"------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"It is expected that each addition of new logic to Manila UI is covered by"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_e9c87057","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":12},"updated":"2016-11-03 10:34:36.000000000","message":"Section title is named \"Contributing\" and then you start by talking about unit tests. For a better reading flow, I suggest starting with the \"When implementing a new feature...\" paragraph, and then \"It is expected that each addition...\" after \"Definition of it...\"","commit_id":"0a4ec2454783517106f19b9a7a9ec4d4171aa0cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"686c4f5c525594de26ec0f3a039a2b42798a5656","unresolved":false,"context_lines":[{"line_number":91,"context_line":"\"project\" dashboards. Also, it is possible to define any kind of options,"},{"line_number":92,"context_line":"the case of enabling or disabling features is just the most popular use case."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Contributing"},{"line_number":95,"context_line":"------------"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"It is expected that each addition of new logic to Manila UI is covered by"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_c961ec06","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":12},"in_reply_to":"ba5da102_e9c87057","updated":"2016-11-03 10:46:38.000000000","message":"Done","commit_id":"0a4ec2454783517106f19b9a7a9ec4d4171aa0cf"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1be936feb9f08a35b7c9f46c5211db3d4daba898","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    manila_config \u003d getattr(settings, \u0027OPENSTACK_MANILA_FEATURES\u0027, {})"},{"line_number":123,"context_line":"    manila_config.get(\u0027your_new_config_option\u0027, \u0027value_of_config_option\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Definition of it can be found in `Configuration`_ section."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Running Unit Tests"},{"line_number":128,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_763290a8","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":17},"updated":"2016-11-02 19:53:10.000000000","message":"\"Definitition of it\" is kind of vague.  Maybe \"See \u0027Conf..\u0027 for more details...\". Or something like that.","commit_id":"0a4ec2454783517106f19b9a7a9ec4d4171aa0cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"686c4f5c525594de26ec0f3a039a2b42798a5656","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    manila_config \u003d getattr(settings, \u0027OPENSTACK_MANILA_FEATURES\u0027, {})"},{"line_number":123,"context_line":"    manila_config.get(\u0027your_new_config_option\u0027, \u0027value_of_config_option\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Definition of it can be found in `Configuration`_ section."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Running Unit Tests"},{"line_number":128,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_e9007036","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":17},"in_reply_to":"ba5da102_763290a8","updated":"2016-11-03 10:46:38.000000000","message":"Done","commit_id":"0a4ec2454783517106f19b9a7a9ec4d4171aa0cf"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"1be936feb9f08a35b7c9f46c5211db3d4daba898","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Definition of it can be found in `Configuration`_ section."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Running Unit Tests"},{"line_number":128,"context_line":"------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The unit tests can be executed directly from within this Manila UI plugin"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_366738b8","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":18},"updated":"2016-11-02 19:53:10.000000000","message":"nit: this one is using upper case title style but others are using sentence style (only first word upper). OS manuals prefer sentence style so this would be \"Running unit tests\"","commit_id":"0a4ec2454783517106f19b9a7a9ec4d4171aa0cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f34ea1813c233c7da6f09244aa049b9d7cf7216","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Definition of it can be found in `Configuration`_ section."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Running Unit Tests"},{"line_number":128,"context_line":"------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The unit tests can be executed directly from within this Manila UI plugin"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_ea98737a","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":18},"in_reply_to":"ba5da102_366738b8","updated":"2016-11-02 22:10:43.000000000","message":"+1","commit_id":"0a4ec2454783517106f19b9a7a9ec4d4171aa0cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"686c4f5c525594de26ec0f3a039a2b42798a5656","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Definition of it can be found in `Configuration`_ section."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Running Unit Tests"},{"line_number":128,"context_line":"------------------"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"The unit tests can be executed directly from within this Manila UI plugin"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ba5da102_29726811","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":18},"in_reply_to":"ba5da102_ea98737a","updated":"2016-11-03 10:46:38.000000000","message":"Done","commit_id":"0a4ec2454783517106f19b9a7a9ec4d4171aa0cf"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"24e81ea3be92e2f4ad9766546870b5b2dbfd2898","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    * enable_public_share_type_creation"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Note that there is a separate list of configurations for \"admin\" and"},{"line_number":91,"context_line":"\"project\" dashboards. Also, it is possible to define any kind of options,"},{"line_number":92,"context_line":"the case of enabling or disabling features is just the most popular use case."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Contributing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5da102_4f7eb56a","line":91,"updated":"2016-11-03 13:15:19.000000000","message":"AFAIK we only have boolean options for now. Reading this, I might thing I\u0027m able to add options for whatever I want and have them interpreted by Manila UI. Hence, I don\u0027t think this line is necessary for now. Does this make sense?","commit_id":"a83275dbc3b454e9a0c9abf2081eaf4c508c282d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fbe478c63e5c6675bebc109669d974a34ba66c13","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    * enable_public_share_type_creation"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"Note that there is a separate list of configurations for \"admin\" and"},{"line_number":91,"context_line":"\"project\" dashboards. Also, it is possible to define any kind of options,"},{"line_number":92,"context_line":"the case of enabling or disabling features is just the most popular use case."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Contributing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_786eab97","line":91,"in_reply_to":"ba5da102_4f7eb56a","updated":"2016-11-14 10:43:06.000000000","message":"Done","commit_id":"a83275dbc3b454e9a0c9abf2081eaf4c508c282d"}]}
