)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a6c3276f968d7f47f8abdb31cdbea6c2334319ea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaixin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-20 17:28:49 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add update share-type name description or public access"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, only the name and public access of share-type"},{"line_number":10,"context_line":"is set when the share-type is created, and not allowed to be edited"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_84a4f4ba","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":26},"updated":"2019-09-20 10:02:25.000000000","message":"Maybe say \u0027name, description and/or public access\u0027 looks better.","commit_id":"fc1c2648404973ac529078852b1c3386ab10d3bb"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c2eeadc3e8ed4a09fea4f4833c7f9ec43770b9db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaixin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-20 17:28:49 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add update share-type name description or public access"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, only the name and public access of share-type"},{"line_number":10,"context_line":"is set when the share-type is created, and not allowed to be edited"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_41501133","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":26},"in_reply_to":"3fa7e38b_84a4f4ba","updated":"2019-09-23 02:34:50.000000000","message":"Done","commit_id":"fc1c2648404973ac529078852b1c3386ab10d3bb"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92ca17577e0da0bd9854e47a9c71ec7807384e08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3fa7e38b_2359cb8c","updated":"2019-10-17 12:46:13.000000000","message":"I\u0027ve identified some things in you commit message that may need an improvement. We have some guidelines [1] to follow while writing commit messages. Please take a look in the link I\u0027ve pasted here :)\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"af11e813212cdd2ff83d06d479c35a139291f07f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, only the name and public access of share-type is set when the"},{"line_number":10,"context_line":"share-type is created, and not allowed to be edited after the share-type"},{"line_number":11,"context_line":"is created. We can only set extra spec for share-type. This commit"},{"line_number":12,"context_line":"suppport update name,description or public access of share-type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia59ae574482fa8015f0151cd983ef880e180640a"},{"line_number":15,"context_line":"Partially-Implements: blueprint update-share-type-name-or-description"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3fa7e38b_ad2f41f4","line":12,"range":{"start_line":12,"start_character":21,"end_line":12,"end_character":22},"updated":"2019-11-21 12:34:58.000000000","message":"nit: blank space between the comma and the description word.","commit_id":"4b465bd94a055e318c4cf3e015f8148a2e197aa1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"af11e813212cdd2ff83d06d479c35a139291f07f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, only the name and public access of share-type is set when the"},{"line_number":10,"context_line":"share-type is created, and not allowed to be edited after the share-type"},{"line_number":11,"context_line":"is created. We can only set extra spec for share-type. This commit"},{"line_number":12,"context_line":"suppport update name,description or public access of share-type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia59ae574482fa8015f0151cd983ef880e180640a"},{"line_number":15,"context_line":"Partially-Implements: blueprint update-share-type-name-or-description"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"3fa7e38b_cdee3db4","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":8},"updated":"2019-11-21 12:34:58.000000000","message":"nit: support","commit_id":"4b465bd94a055e318c4cf3e015f8148a2e197aa1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34716,"name":"Hassan Asghar","email":"hassanasghar666@gmail.com","username":"hassanasghar"},"change_message_id":"d90009b1ba6f45a572e3d96fd13a5416023f6b4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b24db120_861c0fe0","updated":"2023-02-01 11:42:59.000000000","message":"Verified, working as expected!","commit_id":"0e971152f70638f88da805e14741636bfb99a896"}],"manila_ui/api/manila.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a6c3276f968d7f47f8abdb31cdbea6c2334319ea","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE(vponomaryov): update version to 2.50 when manilaclient is released with"},{"line_number":34,"context_line":"# its support. It will allow to show \u0027availability zones\u0027 for share groups."},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8492b44a","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":75},"updated":"2019-09-20 10:02:25.000000000","message":"This comments you should rewrite. the \u0027availability zones\u0027 is not related with v2.50","commit_id":"fc1c2648404973ac529078852b1c3386ab10d3bb"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c2eeadc3e8ed4a09fea4f4833c7f9ec43770b9db","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE(vponomaryov): update version to 2.50 when manilaclient is released with"},{"line_number":34,"context_line":"# its support. It will allow to show \u0027availability zones\u0027 for share groups."},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_014a197f","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":75},"in_reply_to":"3fa7e38b_8492b44a","updated":"2019-09-23 02:34:50.000000000","message":"Done","commit_id":"fc1c2648404973ac529078852b1c3386ab10d3bb"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a6c3276f968d7f47f8abdb31cdbea6c2334319ea","unresolved":false,"context_lines":[{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE(vponomaryov): update version to 2.50 when manilaclient is released with"},{"line_number":34,"context_line":"# its support. It will allow to show \u0027availability zones\u0027 for share groups."},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# API static values"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_64c77814","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":54},"updated":"2019-09-20 10:02:25.000000000","message":"I think manilaclinet in 1.29,0（https://review.opendev.org/#/c/682208/2/deliverables/train/python-manilaclient.yaml@14） is ok, beacause  https://review.opendev.org/#/c/670750/ before the https://review.opendev.org/#/c/681524/.","commit_id":"fc1c2648404973ac529078852b1c3386ab10d3bb"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c2eeadc3e8ed4a09fea4f4833c7f9ec43770b9db","unresolved":false,"context_lines":[{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE(vponomaryov): update version to 2.50 when manilaclient is released with"},{"line_number":34,"context_line":"# its support. It will allow to show \u0027availability zones\u0027 for share groups."},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# API static values"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c15ba151","line":35,"range":{"start_line":35,"start_character":48,"end_line":35,"end_character":54},"in_reply_to":"3fa7e38b_64c77814","updated":"2019-09-23 02:34:50.000000000","message":"Done","commit_id":"fc1c2648404973ac529078852b1c3386ab10d3bb"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"94129d963da1a97fabea261a4d7a862c046f284c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE(vponomaryov): update version to 2.34 when manilaclient is released with"},{"line_number":34,"context_line":"# its support. It will allow to show \u0027availability zones\u0027 for share groups."},{"line_number":35,"context_line":"# NOTE: update version to 2.50 when manilaclient is released with its support."},{"line_number":36,"context_line":"# It will allow to update name description and/or public access of share type."},{"line_number":37,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_c385d0d0","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":75},"updated":"2019-09-24 06:54:56.000000000","message":"Remove these comment.","commit_id":"a9325d2bc15a5e4bfd54ca248a1bf8a5e866f3bb"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"9f0fcfbc665c868874f1e50807f4890e5e174d28","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE(vponomaryov): update version to 2.34 when manilaclient is released with"},{"line_number":34,"context_line":"# its support. It will allow to show \u0027availability zones\u0027 for share groups."},{"line_number":35,"context_line":"# NOTE: update version to 2.50 when manilaclient is released with its support."},{"line_number":36,"context_line":"# It will allow to update name description and/or public access of share type."},{"line_number":37,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_dbb4d4d3","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":75},"in_reply_to":"3fa7e38b_c385d0d0","updated":"2019-09-24 09:11:18.000000000","message":"Done","commit_id":"a9325d2bc15a5e4bfd54ca248a1bf8a5e866f3bb"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"94129d963da1a97fabea261a4d7a862c046f284c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# NOTE(vponomaryov): update version to 2.34 when manilaclient is released with"},{"line_number":34,"context_line":"# its support. It will allow to show \u0027availability zones\u0027 for share groups."},{"line_number":35,"context_line":"# NOTE: update version to 2.50 when manilaclient is released with its support."},{"line_number":36,"context_line":"# It will allow to update name description and/or public access of share type."},{"line_number":37,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":38,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_4371e00b","line":36,"range":{"start_line":36,"start_character":26,"end_line":36,"end_character":30},"updated":"2019-09-24 06:54:56.000000000","message":"name,","commit_id":"a9325d2bc15a5e4bfd54ca248a1bf8a5e866f3bb"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"9f0fcfbc665c868874f1e50807f4890e5e174d28","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# NOTE(vponomaryov): update version to 2.34 when manilaclient is released with"},{"line_number":34,"context_line":"# its support. It will allow to show \u0027availability zones\u0027 for share groups."},{"line_number":35,"context_line":"# NOTE: update version to 2.50 when manilaclient is released with its support."},{"line_number":36,"context_line":"# It will allow to update name description and/or public access of share type."},{"line_number":37,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":38,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3fa7e38b_7bcda064","line":36,"range":{"start_line":36,"start_character":26,"end_line":36,"end_character":30},"in_reply_to":"3fa7e38b_4371e00b","updated":"2019-09-24 09:11:18.000000000","message":"Done","commit_id":"a9325d2bc15a5e4bfd54ca248a1bf8a5e866f3bb"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92ca17577e0da0bd9854e47a9c71ec7807384e08","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE: update version to 2.50 when manilaclient is released with its support."},{"line_number":34,"context_line":"# It will allow to update name,description and/or public access of share type."},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_dedd2c70","line":33,"updated":"2019-10-17 12:46:13.000000000","message":"NOTE(haixin)","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7ea58408a55d71141105171463a3576e90498c37","unresolved":false,"context_lines":[{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE: update version to 2.50 when manilaclient is released with its support."},{"line_number":34,"context_line":"# It will allow to update name,description and/or public access of share type."},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_bfff00aa","line":33,"in_reply_to":"3fa7e38b_dedd2c70","updated":"2019-10-18 03:28:37.000000000","message":"Done","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92ca17577e0da0bd9854e47a9c71ec7807384e08","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE: update version to 2.50 when manilaclient is released with its support."},{"line_number":34,"context_line":"# It will allow to update name,description and/or public access of share type."},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_3ecc80b9","line":34,"updated":"2019-10-17 12:46:13.000000000","message":"nit: please add a blank space here","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7ea58408a55d71141105171463a3576e90498c37","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE: update version to 2.50 when manilaclient is released with its support."},{"line_number":34,"context_line":"# It will allow to update name,description and/or public access of share type."},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_7f2bc832","line":34,"in_reply_to":"3fa7e38b_3ecc80b9","updated":"2019-10-18 03:28:37.000000000","message":"Done","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"803ecf022ebaf568010145f89639a89b750871ed","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# its support."},{"line_number":35,"context_line":"# It will allow to update name,description and/or public access of share type."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":38,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# API static values"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_e744634a","line":37,"updated":"2019-11-20 18:46:10.000000000","message":"We need to bump versioning but it would be advisable that we do this gradually. Going from 2.32 to 2.50 seems a bit dangerous.","commit_id":"7b9bc41da82a3b231d66ed35780e04894820fa29"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5f6aa80befdf106ce1682d5bd2fdc4f4ce4aefca","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# its support."},{"line_number":35,"context_line":"# It will allow to update name,description and/or public access of share type."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":38,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# API static values"}],"source_content_type":"text/x-python","patch_set":15,"id":"3fa7e38b_9d6845f4","line":37,"in_reply_to":"3fa7e38b_e744634a","updated":"2019-11-22 01:45:00.000000000","message":"Yes, there are a lot of changes in the microversion from 2.32 to 2.50, if we want to perfect this I think there is a long time work.\n\nAnd I agree with haixin, this change just bump to 2.50, if we dont request 2.50, it will be rejected. From a functional point of view, 2.50 is OK. On the other hand, this is a new interface that does not affect other interfaces.","commit_id":"7b9bc41da82a3b231d66ed35780e04894820fa29"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"2fa7a9f85096de8d63e07ea4a6755010b05699a3","unresolved":true,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":31,"context_line":"# NOTE(haixin): update version to 2.50 when manilaclient is released with"},{"line_number":32,"context_line":"# its support."},{"line_number":33,"context_line":"# It will allow to update name,description and/or public access of share type."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"b3e153e7_261ecccb","line":31,"updated":"2021-03-23 15:53:00.000000000","message":"Hi haixin, I think this comment is no longer needed, as manilaclient is already higher then 2.50.","commit_id":"40021221cdb993388c9842149642ad40d4eb7e8c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bcdf551c968ea5d826f815939452daf955057cfe","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":31,"context_line":"# NOTE(haixin): update version to 2.50 when manilaclient is released with"},{"line_number":32,"context_line":"# its support."},{"line_number":33,"context_line":"# It will allow to update name,description and/or public access of share type."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"edce59cd_9ac47c32","line":31,"in_reply_to":"b3e153e7_261ecccb","updated":"2021-03-24 05:48:24.000000000","message":"Done","commit_id":"40021221cdb993388c9842149642ad40d4eb7e8c"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"2fa7a9f85096de8d63e07ea4a6755010b05699a3","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# its support."},{"line_number":33,"context_line":"# It will allow to update name,description and/or public access of share type."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# API static values"}],"source_content_type":"text/x-python","patch_set":17,"id":"e5306614_6f276d96","line":35,"updated":"2021-03-23 15:53:00.000000000","message":"comment here is also not needed.","commit_id":"40021221cdb993388c9842149642ad40d4eb7e8c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bcdf551c968ea5d826f815939452daf955057cfe","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# its support."},{"line_number":33,"context_line":"# It will allow to update name,description and/or public access of share type."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.50\"  # requires manilaclient 1.29.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# API static values"}],"source_content_type":"text/x-python","patch_set":17,"id":"e8758677_6be475d8","line":35,"in_reply_to":"e5306614_6f276d96","updated":"2021-03-24 05:48:24.000000000","message":"Done","commit_id":"40021221cdb993388c9842149642ad40d4eb7e8c"}],"manila_ui/dashboards/admin/share_types/forms.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a6c3276f968d7f47f8abdb31cdbea6c2334319ea","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":95,"context_line":"        super(UpdateShareType, self).__init__(*args, **kwargs)"},{"line_number":96,"context_line":"        # NOTE(vponomaryov): parse existing extra specs"},{"line_number":97,"context_line":"        #                    to str view for textarea html element"},{"line_number":98,"context_line":"        es_str \u003d \"\""},{"line_number":99,"context_line":"        for k, v in self.initial[\"extra_specs\"].items():"},{"line_number":100,"context_line":"            es_str +\u003d \"%s\u003d%s\\r\\n\" % (k, v)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e4036841","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":66},"updated":"2019-09-20 10:02:25.000000000","message":"Can you rewrite this comments?","commit_id":"fc1c2648404973ac529078852b1c3386ab10d3bb"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"c2eeadc3e8ed4a09fea4f4833c7f9ec43770b9db","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":95,"context_line":"        super(UpdateShareType, self).__init__(*args, **kwargs)"},{"line_number":96,"context_line":"        # NOTE(vponomaryov): parse existing extra specs"},{"line_number":97,"context_line":"        #                    to str view for textarea html element"},{"line_number":98,"context_line":"        es_str \u003d \"\""},{"line_number":99,"context_line":"        for k, v in self.initial[\"extra_specs\"].items():"},{"line_number":100,"context_line":"            es_str +\u003d \"%s\u003d%s\\r\\n\" % (k, v)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e13b3de8","line":97,"range":{"start_line":96,"start_character":0,"end_line":97,"end_character":66},"in_reply_to":"3fa7e38b_e4036841","updated":"2019-09-23 02:34:50.000000000","message":"it is not necessary to rewrite, wo also need to parse existing extra specs.","commit_id":"fc1c2648404973ac529078852b1c3386ab10d3bb"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"2fa7a9f85096de8d63e07ea4a6755010b05699a3","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    extra_specs \u003d forms.CharField("},{"line_number":97,"context_line":"        required\u003dFalse, label\u003d_(\"Extra specs\"),"},{"line_number":98,"context_line":"        widget\u003dforms.widgets.Textarea(attrs\u003dST_EXTRA_SPECS_FORM_ATTRS))"},{"line_number":99,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Name\"), required\u003dTrue)"},{"line_number":100,"context_line":"    description \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Description\"),"},{"line_number":101,"context_line":"                                  required\u003dFalse)"},{"line_number":102,"context_line":"    is_public \u003d forms.BooleanField("}],"source_content_type":"text/x-python","patch_set":17,"id":"b89d27b5_8a66b451","line":99,"updated":"2021-03-23 15:53:00.000000000","message":"maybe change ordering here, move extra_specs field below is_public field, i think visually it will be better.","commit_id":"40021221cdb993388c9842149642ad40d4eb7e8c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bcdf551c968ea5d826f815939452daf955057cfe","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    extra_specs \u003d forms.CharField("},{"line_number":97,"context_line":"        required\u003dFalse, label\u003d_(\"Extra specs\"),"},{"line_number":98,"context_line":"        widget\u003dforms.widgets.Textarea(attrs\u003dST_EXTRA_SPECS_FORM_ATTRS))"},{"line_number":99,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Name\"), required\u003dTrue)"},{"line_number":100,"context_line":"    description \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Description\"),"},{"line_number":101,"context_line":"                                  required\u003dFalse)"},{"line_number":102,"context_line":"    is_public \u003d forms.BooleanField("}],"source_content_type":"text/x-python","patch_set":17,"id":"14008ee6_a3743ca3","line":99,"in_reply_to":"b89d27b5_8a66b451","updated":"2021-03-24 05:48:24.000000000","message":"Done","commit_id":"40021221cdb993388c9842149642ad40d4eb7e8c"}],"manila_ui/tests/dashboards/admin/share_types/test_forms.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92ca17577e0da0bd9854e47a9c71ec7807384e08","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertTrue(result)"},{"line_number":80,"context_line":"        mock_horizon_messages_success.assert_called_once_with("},{"line_number":81,"context_line":"            mock.ANY, mock.ANY)"},{"line_number":82,"context_line":"        self.manilaclient.share_types.get.assert_called_with("},{"line_number":83,"context_line":"            initial[\u0027id\u0027])"},{"line_number":84,"context_line":"        self.manilaclient.share_types.get.return_value.set_keys.\\"},{"line_number":85,"context_line":"            assert_called_once_with({\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":86,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_9e4c94c8","line":83,"range":{"start_line":82,"start_character":8,"end_line":83,"end_character":26},"updated":"2019-10-17 12:46:13.000000000","message":"you could also use assert_has_calls if you know all the calls this method is going to receive.","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"af11e813212cdd2ff83d06d479c35a139291f07f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertTrue(result)"},{"line_number":80,"context_line":"        mock_horizon_messages_success.assert_called_once_with("},{"line_number":81,"context_line":"            mock.ANY, mock.ANY)"},{"line_number":82,"context_line":"        self.manilaclient.share_types.get.assert_called_with("},{"line_number":83,"context_line":"            initial[\u0027id\u0027])"},{"line_number":84,"context_line":"        self.manilaclient.share_types.get.return_value.set_keys.\\"},{"line_number":85,"context_line":"            assert_called_once_with({\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":86,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_3684e05d","line":83,"range":{"start_line":82,"start_character":8,"end_line":83,"end_character":26},"in_reply_to":"3fa7e38b_3a81defc","updated":"2019-11-21 12:34:58.000000000","message":"When you use assert has calls, you can do it nin another way as well. \nFor instance in this case:\nself.manilaclient.share_types.get.assert_has_calls([mock.call(initial[\u0027id\u0027])])\nIn this way, the test may be fixed.","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7ea58408a55d71141105171463a3576e90498c37","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertTrue(result)"},{"line_number":80,"context_line":"        mock_horizon_messages_success.assert_called_once_with("},{"line_number":81,"context_line":"            mock.ANY, mock.ANY)"},{"line_number":82,"context_line":"        self.manilaclient.share_types.get.assert_called_with("},{"line_number":83,"context_line":"            initial[\u0027id\u0027])"},{"line_number":84,"context_line":"        self.manilaclient.share_types.get.return_value.set_keys.\\"},{"line_number":85,"context_line":"            assert_called_once_with({\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":86,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_5f2a8c2c","line":83,"range":{"start_line":82,"start_character":8,"end_line":83,"end_character":26},"in_reply_to":"3fa7e38b_9e4c94c8","updated":"2019-10-18 03:28:37.000000000","message":"Done,i will try it.","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1a0f5bd9923526e71b182529616671ea5452f27c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertTrue(result)"},{"line_number":80,"context_line":"        mock_horizon_messages_success.assert_called_once_with("},{"line_number":81,"context_line":"            mock.ANY, mock.ANY)"},{"line_number":82,"context_line":"        self.manilaclient.share_types.get.assert_called_with("},{"line_number":83,"context_line":"            initial[\u0027id\u0027])"},{"line_number":84,"context_line":"        self.manilaclient.share_types.get.return_value.set_keys.\\"},{"line_number":85,"context_line":"            assert_called_once_with({\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":86,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_3a81defc","line":83,"range":{"start_line":82,"start_character":8,"end_line":83,"end_character":26},"in_reply_to":"3fa7e38b_9e4c94c8","updated":"2019-10-18 05:48:31.000000000","message":"use assert_has_calls will lead to error in unittest.https://zuul.opendev.org/t/openstack/build/668f0beba74544f99879681f194a6418","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92ca17577e0da0bd9854e47a9c71ec7807384e08","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    )"},{"line_number":168,"context_line":"    @ddt.unpack"},{"line_number":169,"context_line":"    @mock.patch(\u0027horizon.messages.success\u0027)"},{"line_number":170,"context_line":"    def test_update_share_type_name_description_public("},{"line_number":171,"context_line":"            self, name, description, is_public,"},{"line_number":172,"context_line":"            mock_horizon_messages_success):"},{"line_number":173,"context_line":"        initial \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_feffc830","line":170,"updated":"2019-10-17 12:46:13.000000000","message":"what about adding tests for the negative scenarios as well?","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"af11e813212cdd2ff83d06d479c35a139291f07f","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    )"},{"line_number":168,"context_line":"    @ddt.unpack"},{"line_number":169,"context_line":"    @mock.patch(\u0027horizon.messages.success\u0027)"},{"line_number":170,"context_line":"    def test_update_share_type_name_description_public("},{"line_number":171,"context_line":"            self, name, description, is_public,"},{"line_number":172,"context_line":"            mock_horizon_messages_success):"},{"line_number":173,"context_line":"        initial \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_d6d78c4e","line":170,"in_reply_to":"3fa7e38b_7f49888c","updated":"2019-11-21 12:34:58.000000000","message":"Oh, alright. Thanks for answering.","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7ea58408a55d71141105171463a3576e90498c37","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    )"},{"line_number":168,"context_line":"    @ddt.unpack"},{"line_number":169,"context_line":"    @mock.patch(\u0027horizon.messages.success\u0027)"},{"line_number":170,"context_line":"    def test_update_share_type_name_description_public("},{"line_number":171,"context_line":"            self, name, description, is_public,"},{"line_number":172,"context_line":"            mock_horizon_messages_success):"},{"line_number":173,"context_line":"        initial \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_7f49888c","line":170,"in_reply_to":"3fa7e38b_feffc830","updated":"2019-10-18 03:28:37.000000000","message":"here, we just want to update share name, description or access public, All input values are automatically checked at get data from UI form,(https://review.opendev.org/#/c/683336/11/manila_ui/dashboards/admin/share_types/forms.py@108), set extra_specs has negative scenarios because UI form can not check it whether it conforms to the key-value pair format, so after get data from UI, have to check again, but name,description is different, that means manila server will not get wrong value about name or description from UI. so we add negative scenarios is \nunnecessary, just like create share type below(https://review.opendev.org/#/c/683336/11/manila_ui/tests/dashboards/admin/share_types/test_forms.py@201),it has no negative scenarios too.","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cc225838bbee28a3f281fcfd1e57651dd634f6b2","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        }"},{"line_number":187,"context_line":"        result \u003d form.handle(self.request, data)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.assertTrue(result)"},{"line_number":190,"context_line":"        mock_horizon_messages_success.assert_called_once_with("},{"line_number":191,"context_line":"            mock.ANY, mock.ANY)"},{"line_number":192,"context_line":"        self.manilaclient.share_types.get.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_7386aa68","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":31},"updated":"2019-10-17 17:02:31.000000000","message":"Using assertIs(True, result) is better in this case, since you need to make sure that the value being returned is boolean.\n\nhttps://jamescooke.info/python-unittest-asserttrue-is-truthy-assertfalse-is-falsy.html","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"af11e813212cdd2ff83d06d479c35a139291f07f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        }"},{"line_number":187,"context_line":"        result \u003d form.handle(self.request, data)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.assertTrue(result)"},{"line_number":190,"context_line":"        mock_horizon_messages_success.assert_called_once_with("},{"line_number":191,"context_line":"            mock.ANY, mock.ANY)"},{"line_number":192,"context_line":"        self.manilaclient.share_types.get.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_964b5426","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":31},"in_reply_to":"3fa7e38b_5f484c86","updated":"2019-11-21 12:34:58.000000000","message":"Yeah. We have lots of occurrences of this being done like the line you just pointed out. Since we knew the things that were explained in link I sent you, we rather to do asserts as I\u0027ve suggested you than doing as assertTrue.","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7ea58408a55d71141105171463a3576e90498c37","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        }"},{"line_number":187,"context_line":"        result \u003d form.handle(self.request, data)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.assertTrue(result)"},{"line_number":190,"context_line":"        mock_horizon_messages_success.assert_called_once_with("},{"line_number":191,"context_line":"            mock.ANY, mock.ANY)"},{"line_number":192,"context_line":"        self.manilaclient.share_types.get.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_5f484c86","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":31},"in_reply_to":"3fa7e38b_7386aa68","updated":"2019-10-18 03:28:37.000000000","message":"Done, i have changed, but i found this format is used everywhere else, like line 223.","commit_id":"a7df8b3260179655a45cbed0a02e65d84263a412"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0560edc0ade09a9f14597c6e032c50f7209a35c4","unresolved":true,"context_lines":[{"line_number":191,"context_line":"            mock.ANY, mock.ANY)"},{"line_number":192,"context_line":"        self.manilaclient.share_types.get.assert_called_once_with("},{"line_number":193,"context_line":"            initial[\u0027id\u0027])"},{"line_number":194,"context_line":"        self.manilaclient.share_types.get.return_value.update.\\"},{"line_number":195,"context_line":"            assert_called_once_with(name\u003ddata[\u0027name\u0027],"},{"line_number":196,"context_line":"                                    description\u003ddata[\u0027description\u0027],"},{"line_number":197,"context_line":"                                    is_public\u003ddata[\u0027is_public\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"f24d5a91_04f9f490","line":194,"updated":"2021-03-24 22:37:14.000000000","message":"NIT Use () instead of \\ to break lines","commit_id":"d5d37adca5119edc9370a20e0d69d113d51f81a2"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5673f8d45dd2ae628f08a9e584c33767f0efe3d5","unresolved":true,"context_lines":[{"line_number":191,"context_line":"            mock.ANY, mock.ANY)"},{"line_number":192,"context_line":"        self.manilaclient.share_types.get.assert_called_once_with("},{"line_number":193,"context_line":"            initial[\u0027id\u0027])"},{"line_number":194,"context_line":"        self.manilaclient.share_types.get.return_value.update.\\"},{"line_number":195,"context_line":"            assert_called_once_with(name\u003ddata[\u0027name\u0027],"},{"line_number":196,"context_line":"                                    description\u003ddata[\u0027description\u0027],"},{"line_number":197,"context_line":"                                    is_public\u003ddata[\u0027is_public\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"a9c085e1_3c438f8b","line":194,"in_reply_to":"f24d5a91_04f9f490","updated":"2021-04-06 01:45:13.000000000","message":"In some degree, I agree to use () instead of \\, such as param_a \u003d self.manilaclient.share_types.get.return_value.(xxx), but now this in online I think it\u0027s ok to  keep this way.","commit_id":"d5d37adca5119edc9370a20e0d69d113d51f81a2"}],"releasenotes/notes/bp-update-share-type-name-or-description-cc5357feee2a3b61.yaml":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"94129d963da1a97fabea261a4d7a862c046f284c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``name``, ``description`` and/or ``share_type_access:is_public``"},{"line_number":5,"context_line":"    attributes of share types can be updated with API version ``2.50``"},{"line_number":6,"context_line":"    and beyond."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_43dfa0d5","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":15},"updated":"2019-09-24 06:54:56.000000000","message":"nit: s/or greater./and beyond./","commit_id":"a9325d2bc15a5e4bfd54ca248a1bf8a5e866f3bb"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"9f0fcfbc665c868874f1e50807f4890e5e174d28","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``name``, ``description`` and/or ``share_type_access:is_public``"},{"line_number":5,"context_line":"    attributes of share types can be updated with API version ``2.50``"},{"line_number":6,"context_line":"    and beyond."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_7b96004f","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":15},"in_reply_to":"3fa7e38b_43dfa0d5","updated":"2019-09-24 09:11:18.000000000","message":"Done","commit_id":"a9325d2bc15a5e4bfd54ca248a1bf8a5e866f3bb"}]}