)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"7e172c381c5310edfc9f24cbb4805ddff45476f8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-11-21 03:11:55 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add create share type with description"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib665c7a9b02be902c89422221f640364390d7eba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_a922ebb8","line":8,"updated":"2019-12-06 08:00:15.000000000","message":"Here need to add some change details info what are you doing.","commit_id":"7a42cd4c8a57e601b67ea5db7dad0867df7e336e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"efec3b4676699bae855b0014d717a5124eac98f4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-11-21 03:11:55 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add create share type with description"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib665c7a9b02be902c89422221f640364390d7eba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_6dfe296b","line":8,"in_reply_to":"3fa7e38b_a922ebb8","updated":"2019-12-09 02:19:45.000000000","message":"Done","commit_id":"7a42cd4c8a57e601b67ea5db7dad0867df7e336e"}],"manila_ui/api/manila.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"7e172c381c5310edfc9f24cbb4805ddff45476f8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":33,"context_line":"# NOTE(haixin): update version to 2.41 when manilaclient is released with"},{"line_number":34,"context_line":"# its support. It will allow create share type with description."},{"line_number":35,"context_line":"MANILA_VERSION \u003d \"2.41\"  # requires manilaclient 1.13.0 or newer"},{"line_number":36,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# API static values"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_4c02650b","line":35,"range":{"start_line":35,"start_character":25,"end_line":35,"end_character":64},"updated":"2019-12-06 08:00:15.000000000","message":"I think we also should add create share type with description to manilaclinet.\n\nAnd I am not sure the manilaclient 1.13.0 is need to change, @Goutham and others can provide some suggestion?","commit_id":"7a42cd4c8a57e601b67ea5db7dad0867df7e336e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a511e948dfb7a67965e827eb40c43f19aef9bebf","unresolved":true,"context_lines":[{"line_number":30,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":31,"context_line":"# NOTE(haixin): update version to 2.41 when manilaclient is released with"},{"line_number":32,"context_line":"# its support. It will allow create share type with description."},{"line_number":33,"context_line":"MANILA_VERSION \u003d \"2.41\"  # requires manilaclient 1.13.0 or newer"},{"line_number":34,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# API static values"}],"source_content_type":"text/x-python","patch_set":10,"id":"48dd0fad_0d7d5c22","line":33,"updated":"2021-01-13 00:35:42.000000000","message":"Requirements have been bumped to manilaclient 1.19.0, we can remove this comment already","commit_id":"37821b439c1be4217d912d46e477c3b2d4da09d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e6425e3961bf1fdacffc70ef218154d2ee5e885","unresolved":true,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":31,"context_line":"# NOTE(haixin): update version to 2.41 when manilaclient is released with"},{"line_number":32,"context_line":"# its support. It will allow create share type with description."},{"line_number":33,"context_line":"MANILA_VERSION \u003d \"2.41\""},{"line_number":34,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"6adbde47_9d59f4ce","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":64},"updated":"2021-01-20 23:56:22.000000000","message":"Lets remove this comment, the minimum version of python-manilaclient required by this project is 1.29.0 [1]\n\nThe maximum API version supported by the release at 1.29.0 is: 2.51 [2]\n\n\n[1] https://opendev.org/openstack/manila-ui/src/commit/dcc36345553d45e6ba88ff2f5a9aad0f3d035ec0/requirements.txt#L11\n[2] https://opendev.org/openstack/python-manilaclient/src/tag/1.29.0/manilaclient/api_versions.py#L30","commit_id":"2fdd0802c0fd259725478de7deb315e6e3863236"}],"manila_ui/tests/api/test_manila.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"34925540fefe9d5bd16431153fb1bfe955c0acd9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self.manilaclient.shares.revert_to_snapshot.assert_called_once_with("},{"line_number":116,"context_line":"            share, snapshot)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @ddt.data(True, False)"},{"line_number":119,"context_line":"    def test_share_type_create_with_default_values(self, dhss):"},{"line_number":120,"context_line":"        name \u003d \u0027fake_share_type_name\u0027"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_f2943443","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":25},"updated":"2019-12-08 21:28:12.000000000","message":"Just for the sake of completeness, as you tested all possible combinations of (dhss, is_public) in test_share_type_create_with_custom_values but left description a constant, I\u0027d also add all 4 options for dhss and is_public here (or modify the other test to accept description as optional). I know you had it that way in one of the first commits, not sure it was a bad idea. :)","commit_id":"7a42cd4c8a57e601b67ea5db7dad0867df7e336e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"efec3b4676699bae855b0014d717a5124eac98f4","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self.manilaclient.shares.revert_to_snapshot.assert_called_once_with("},{"line_number":116,"context_line":"            share, snapshot)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @ddt.data(True, False)"},{"line_number":119,"context_line":"    def test_share_type_create_with_default_values(self, dhss):"},{"line_number":120,"context_line":"        name \u003d \u0027fake_share_type_name\u0027"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_adbae1bc","line":118,"range":{"start_line":118,"start_character":4,"end_line":118,"end_character":25},"in_reply_to":"3fa7e38b_f2943443","updated":"2019-12-09 02:19:45.000000000","message":"hello, Amit Oren.\nfirst thank for your review.\nin test_share_type_create_with_custom_values, i removed snapshot_support. because it(https://review.opendev.org/#/c/692081/) will lead to merge conflict.we can not consider description a constant here, description is an string. Even if it\u0027s the same, it\u0027s custom.it also work fine here.that means whether the description is the same or not is not the key, the key is custom.","commit_id":"7a42cd4c8a57e601b67ea5db7dad0867df7e336e"}],"releasenotes/notes/add-create-share-type-with-description-d57f4c734d107554.yaml":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"7e172c381c5310edfc9f24cbb4805ddff45476f8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added possibility to create share type with description."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_0c08ed24","line":3,"updated":"2019-12-06 08:00:15.000000000","message":"I think we also should need declare we need microversion 2.41 while it was requested.","commit_id":"7a42cd4c8a57e601b67ea5db7dad0867df7e336e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"efec3b4676699bae855b0014d717a5124eac98f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added possibility to create share type with description."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_4df9ed7f","line":3,"in_reply_to":"3fa7e38b_0c08ed24","updated":"2019-12-09 02:19:45.000000000","message":"Done","commit_id":"7a42cd4c8a57e601b67ea5db7dad0867df7e336e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e6425e3961bf1fdacffc70ef218154d2ee5e885","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added possibility to create share type with description."},{"line_number":4,"context_line":"    We need 2.41 or higher microversion while it was requested."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e1c7d338_039caa18","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":63},"updated":"2021-01-20 23:56:22.000000000","message":"remove this, api microversions can\u0027t be controlled by users/deployers of manila-ui.","commit_id":"2fdd0802c0fd259725478de7deb315e6e3863236"}]}