)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ea61c6223005d08f7ea269fbc802b7f2bf4c1e5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Create share type with snashot_support\u003dFalse"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We were incorrectly seeting snapshot_support\u003dTrue by default."},{"line_number":10,"context_line":"Not all backends support this, so the right thing do to is to"},{"line_number":11,"context_line":"use False as default."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0440bfa1b182330020f8cb3c37d33e226801f3e9"},{"line_number":14,"context_line":"Closes-Bug: #1685655"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_30a2a8af","line":11,"range":{"start_line":10,"start_character":38,"end_line":11,"end_character":21},"updated":"2019-10-30 21:25:08.000000000","message":"Nope, this will cause the manila scheduler to find a valid host in case there are *only* backends that support snapshot-support. \n\nHere\u0027s the behavior in the manila scheduler:\n\n- If \"snapshot_support\" in a share type is set to True, the scheduler will only match backends that allow taking snapshots. \n- If \"snapshot_support\" in a share type is set to False, the scheduler will only match backends that do not support snapshots. \n- If \"snapshot_support\" is not set in a share type, the scheduler places the share on any backend irrespective of whether snapshots or supported or not. However, users will be prevented from taking snapshots of such shares. \n\nWhat you really want is the third behavior of the scheduler. This way, you\u0027ll force the administrators to specify \"snapshot_support\" in case they want behaviors 1 or 2.","commit_id":"846b8730cd5e4237e841b56b0f4039ddb7fecb84"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"20b8fabcd43173dd923db95eb93df8076ef94ae7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  scheduler will only match backends that do not support snapshots."},{"line_number":17,"context_line":"- If \"snapshot_support\" is not set in a share type, the scheduler"},{"line_number":18,"context_line":"  places the share on any backend irrespective of whether snapshots"},{"line_number":19,"context_line":"  or supported or not. However, users will be prevented from taking"},{"line_number":20,"context_line":"  snapshots of such shares."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"We want to mimic the third behavior of the scheduler. That means,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_1e10a458","line":19,"range":{"start_line":19,"start_character":2,"end_line":19,"end_character":4},"updated":"2019-11-05 14:18:26.000000000","message":"are","commit_id":"bf1041d635071593eeca4c53892cfc309809d780"}],"manila_ui/api/manila.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9ea61c6223005d08f7ea269fbc802b7f2bf4c1e5","unresolved":false,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"def share_type_create(request, name, spec_driver_handles_share_servers,"},{"line_number":400,"context_line":"                      spec_snapshot_support\u003dFalse, is_public\u003dTrue):"},{"line_number":401,"context_line":"    return manilaclient(request).share_types.create("},{"line_number":402,"context_line":"        name\u003dname,"},{"line_number":403,"context_line":"        spec_driver_handles_share_servers\u003dspec_driver_handles_share_servers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7074a036","line":400,"range":{"start_line":400,"start_character":44,"end_line":400,"end_character":49},"updated":"2019-10-30 21:25:08.000000000","message":"My suggestion is to drop this kwarg altogether and add a release note saying that:\n\n\n \n\n\"snapshot_support\" is no longer automatically included as an extra-spec in share types created via manila-ui. If the share type has to match backends that support snapshots, explicitly specify \"snapshot_support\" in the \"Extra specs\" field while creating share types. This change does not modify pre-existing share types.","commit_id":"846b8730cd5e4237e841b56b0f4039ddb7fecb84"}],"manila_ui/tests/api/test_manila.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6650bfa048b6e002964d4c347be508bac02d05e2","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            is_public\u003dTrue)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    @ddt.data("},{"line_number":130,"context_line":"        (True, True, True),"},{"line_number":131,"context_line":"        (True, True, False),"},{"line_number":132,"context_line":"        (True, False, True),"},{"line_number":133,"context_line":"        (False, True, True),"},{"line_number":134,"context_line":"        (True, False, False),"},{"line_number":135,"context_line":"        (False, False, True),"},{"line_number":136,"context_line":"        (False, True, False),"},{"line_number":137,"context_line":"        (True, True, True),"},{"line_number":138,"context_line":"    )"},{"line_number":139,"context_line":"    @ddt.unpack"},{"line_number":140,"context_line":"    def test_share_type_create_with_custom_values("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_bbd2d45a","line":137,"range":{"start_line":130,"start_character":0,"end_line":137,"end_character":27},"updated":"2019-11-03 19:21:14.000000000","message":"Please drop the middle parameter from each of these tuples and remove duplicates - you\u0027re removing the usage of snapshot_support below, so we don\u0027t need the second param any longer...","commit_id":"e8c5c31eceb169bd60cd2bc586ddce90a181d5a4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6650bfa048b6e002964d4c347be508bac02d05e2","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    )"},{"line_number":139,"context_line":"    @ddt.unpack"},{"line_number":140,"context_line":"    def test_share_type_create_with_custom_values("},{"line_number":141,"context_line":"            self, dhss, snapshot_support, is_public):"},{"line_number":142,"context_line":"        name \u003d \u0027fake_share_type_name\u0027"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        api.share_type_create("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7bc8dca6","line":141,"range":{"start_line":141,"start_character":24,"end_line":141,"end_character":40},"updated":"2019-11-03 19:21:14.000000000","message":"remove..","commit_id":"e8c5c31eceb169bd60cd2bc586ddce90a181d5a4"}]}