)]}'
{"manila_ui/dashboards/admin/defaults/workflows.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1b1936b6a4469b3cc150a4c3fe41655d64f29ff5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                # Share group quotas are removed here because default"},{"line_number":51,"context_line":"                # quota update for share groups is not possible yet, see"},{"line_number":52,"context_line":"                # LP #1871252"},{"line_number":53,"context_line":"                allowed_updates \u003d (api_manila.MANILA_QUOTA_FIELDS"},{"line_number":54,"context_line":"                                   - {\u0027share_groups\u0027, \u0027share_group_snapshots\u0027})"},{"line_number":55,"context_line":"                for key in allowed_updates:"},{"line_number":56,"context_line":"                    manila_data[key] \u003d data[key]"},{"line_number":57,"context_line":"                api_manila.default_quota_update(request, **manila_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_86983475","line":54,"range":{"start_line":53,"start_character":16,"end_line":54,"end_character":79},"updated":"2020-04-29 10:04:52.000000000","message":"i think there should be:\nallowd_updates \u003d (api_manila.MANILA_QUOTA_FIELDS -\n                  {\u0027share_groups\u0027, \u0027share_group_snapshots\u0027})","commit_id":"4e131a7787de95efe54dadce0cfa68cac403774f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8863f66202a32702551511f18d1655125a2b2a9f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                # quota update for share groups is not possible yet, see"},{"line_number":52,"context_line":"                # LP #1871252"},{"line_number":53,"context_line":"                allowed_updates \u003d (api_manila.MANILA_QUOTA_FIELDS"},{"line_number":54,"context_line":"                                   - {\u0027share_groups\u0027, \u0027share_group_snapshots\u0027})"},{"line_number":55,"context_line":"                for key in allowed_updates:"},{"line_number":56,"context_line":"                    manila_data[key] \u003d data[key]"},{"line_number":57,"context_line":"                api_manila.default_quota_update(request, **manila_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_ad7cb6b5","line":54,"updated":"2020-04-07 01:40:43.000000000","message":"pep8: W503 line break before binary operator","commit_id":"4e131a7787de95efe54dadce0cfa68cac403774f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"04546a3ffc70cb5adfc01f8e000b3d7aab078891","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                # Share group quotas are removed here because default"},{"line_number":51,"context_line":"                # quota update for share groups is not possible yet, see"},{"line_number":52,"context_line":"                # LP #1871252"},{"line_number":53,"context_line":"                allowed_updates \u003d (api_manila.MANILA_QUOTA_FIELDS"},{"line_number":54,"context_line":"                                   - {\u0027share_groups\u0027, \u0027share_group_snapshots\u0027})"},{"line_number":55,"context_line":"                for key in allowed_updates:"},{"line_number":56,"context_line":"                    manila_data[key] \u003d data[key]"},{"line_number":57,"context_line":"                api_manila.default_quota_update(request, **manila_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_513a57e6","line":54,"range":{"start_line":53,"start_character":16,"end_line":54,"end_character":79},"in_reply_to":"1f493fa4_86983475","updated":"2020-04-29 18:55:36.000000000","message":"ack, \n\nalthough there was a recent clarification to W503: https://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator\n\nSo we should be fixing the pep8 job to disable W503, and enable W504 instead: https://www.flake8rules.com/rules/W504.html","commit_id":"4e131a7787de95efe54dadce0cfa68cac403774f"}]}