)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2df0c710436a622a6fedf3a59d5c689892f9f9b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve unit test coverage for manila.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie8646046ee57d3a032a2884887e33c3f6950009e"},{"line_number":10,"context_line":"Closes-Bug: bug/1895172"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f560f44_d34d23c5","line":10,"range":{"start_line":10,"start_character":15,"end_line":10,"end_character":16},"updated":"2020-09-18 22:14:56.000000000","message":"#","commit_id":"6ead888da8f42822a1a0b6989a4386f439cb8d50"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6f70d3b32e751faebe42690d83fbdeec2a191899","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve unit test coverage for manila.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ie8646046ee57d3a032a2884887e33c3f6950009e"},{"line_number":10,"context_line":"Closes-Bug: bug#1895172"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_814fbe33","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":16},"updated":"2020-09-21 19:33:32.000000000","message":"just #\n\nGerrit recognizes the following formats:\n\nCloses-Bug: #1895172\nCloses-bug: 1895172\nCloses bug 1895172","commit_id":"b3ca931de6e1dfdd9986cb5b16472defce2a7420"}],"manila_ui/tests/api/test_manila.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2df0c710436a622a6fedf3a59d5c689892f9f9b","unresolved":false,"context_lines":[{"line_number":828,"context_line":"    # Absolute limits tests"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"    def test_tenant_absolute_limits(self):"},{"line_number":831,"context_line":"        pass"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    # Share instance tests"},{"line_number":834,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_335d7f79","line":831,"range":{"start_line":831,"start_character":8,"end_line":831,"end_character":12},"updated":"2020-09-18 22:14:56.000000000","message":"did you mean to add this test?","commit_id":"6ead888da8f42822a1a0b6989a4386f439cb8d50"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7f919c29199bcc82cc67015268dec203e90d20d2","unresolved":false,"context_lines":[{"line_number":828,"context_line":"    # Absolute limits tests"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"    def test_tenant_absolute_limits(self):"},{"line_number":831,"context_line":"        pass"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    # Share instance tests"},{"line_number":834,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_85d8731e","line":831,"range":{"start_line":831,"start_character":8,"end_line":831,"end_character":12},"in_reply_to":"9f560f44_335d7f79","updated":"2020-09-21 13:50:36.000000000","message":"I have been thinking a bit about this test. In order to add it we need to do a fake limit object. We keep fakes for the dashboard tests, but we don\u0027t use the fakes in here. So either I create a fake limit and use it here, or we do another iteration and refactor the code a bit so we can use other fakes as well. What do you think?","commit_id":"6ead888da8f42822a1a0b6989a4386f439cb8d50"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb9ce1c7b48efb28732dcad0abb6cdc767e36586","unresolved":false,"context_lines":[{"line_number":828,"context_line":"    # Absolute limits tests"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"    def test_tenant_absolute_limits(self):"},{"line_number":831,"context_line":"        pass"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    # Share instance tests"},{"line_number":834,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_76a7cea9","line":831,"range":{"start_line":831,"start_character":8,"end_line":831,"end_character":12},"in_reply_to":"9f560f44_85d8731e","updated":"2020-09-21 18:57:43.000000000","message":"I think another iteration is fine, lets get this change in since it significantly improves test coverage - we can remove this test and add it back when we\u0027ve answered that question regarding the fakes. \n\nAs far as the fakes are concerned, we can make a fake specifically for limits - we can choose to make others as an enhancement. :)","commit_id":"6ead888da8f42822a1a0b6989a4386f439cb8d50"}]}