)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2338310702f7915238a02531932ee6b297e3e50c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dina Saparbaeva \u003cdinas27@outlook.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-27 01:20:21 +0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changes to Share Update Functionality in Manila Ui"},{"line_number":8,"context_line":"In the manila_api modula there is a check for is_public"},{"line_number":9,"context_line":"param as if it was a string, but it is laways a boolean"},{"line_number":10,"context_line":"so this control is not necessary and needs to be removed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f65232a_cbf3d909","line":7,"updated":"2020-10-27 00:22:46.000000000","message":"Add a new line between L7 (title) and L8 (commit message)","commit_id":"50e3dcc47e102fc959ea89759a11cca599f82db5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2338310702f7915238a02531932ee6b297e3e50c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-10-27 01:20:21 +0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changes to Share Update Functionality in Manila Ui"},{"line_number":8,"context_line":"In the manila_api modula there is a check for is_public"},{"line_number":9,"context_line":"param as if it was a string, but it is laways a boolean"},{"line_number":10,"context_line":"so this control is not necessary and needs to be removed."},{"line_number":11,"context_line":"Removed control for public_param in share_update in manila_api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f65232a_0bddd16f","line":8,"updated":"2020-10-27 00:22:46.000000000","message":"module*","commit_id":"50e3dcc47e102fc959ea89759a11cca599f82db5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2338310702f7915238a02531932ee6b297e3e50c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changes to Share Update Functionality in Manila Ui"},{"line_number":8,"context_line":"In the manila_api modula there is a check for is_public"},{"line_number":9,"context_line":"param as if it was a string, but it is laways a boolean"},{"line_number":10,"context_line":"so this control is not necessary and needs to be removed."},{"line_number":11,"context_line":"Removed control for public_param in share_update in manila_api."},{"line_number":12,"context_line":"Updated forms to expect Boolean not a string in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f65232a_ebd7b54e","line":9,"updated":"2020-10-27 00:22:46.000000000","message":"always*","commit_id":"50e3dcc47e102fc959ea89759a11cca599f82db5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2338310702f7915238a02531932ee6b297e3e50c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"In the manila_api modula there is a check for is_public"},{"line_number":9,"context_line":"param as if it was a string, but it is laways a boolean"},{"line_number":10,"context_line":"so this control is not necessary and needs to be removed."},{"line_number":11,"context_line":"Removed control for public_param in share_update in manila_api."},{"line_number":12,"context_line":"Updated forms to expect Boolean not a string in"},{"line_number":13,"context_line":"manila_dashboards module."},{"line_number":14,"context_line":"Made changes to tests module to work with Boolean,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f65232a_4be7c941","line":11,"updated":"2020-10-27 00:22:46.000000000","message":"is_public param*","commit_id":"50e3dcc47e102fc959ea89759a11cca599f82db5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2338310702f7915238a02531932ee6b297e3e50c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"manila_dashboards module."},{"line_number":14,"context_line":"Made changes to tests module to work with Boolean,"},{"line_number":15,"context_line":"not a string."},{"line_number":16,"context_line":"Closes-Bug: #1896533"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iac94219b883b5fd9a55453cdcf6fa9b6f540e63d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f65232a_abf65df8","line":16,"updated":"2020-10-27 00:22:46.000000000","message":"Add a new line between L15 and L16","commit_id":"50e3dcc47e102fc959ea89759a11cca599f82db5"}],"manila_ui/api/manila.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a036ad8034c90a4110fbafe895a126ebe970943","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def share_update(request, share_id, name, description, is_public\u003dFalse):"},{"line_number":114,"context_line":"    share_data \u003d {"},{"line_number":115,"context_line":"        \u0027display_name\u0027: name,"},{"line_number":116,"context_line":"        \u0027display_description\u0027: description,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_1de6dc17","line":113,"range":{"start_line":113,"start_character":65,"end_line":113,"end_character":70},"updated":"2020-10-29 18:04:12.000000000","message":"What you need here is tri-valued boolean. \n\nIf you set is_public\u003dNone, you can test that value and update it only if it is necessary. By defaulting is_public to False, you\u0027re *always* going to update it no matter if the user wants to or not!\n\nI agree, we don\u0027t need to stringify the value of is_public and test it. Perhaps something like this preserves the behavior we need:\n\n\n  def share_update(request, share_id, name, description, is_public\u003dNone):\n    share_data \u003d {\n        \u0027display_name\u0027: name,\n        \u0027display_description\u0027: description,\n    }\n    if is_public is not None:\n        share_data[\u0027is_public\u0027] \u003d is_public\n    return manilaclient(request).shares.update(share_id, **share_data)","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c2d69b8f8b83d38779916e85b786538698aa58be","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def share_update(request, share_id, name, description, is_public\u003dFalse):"},{"line_number":114,"context_line":"    share_data \u003d {"},{"line_number":115,"context_line":"        \u0027display_name\u0027: name,"},{"line_number":116,"context_line":"        \u0027display_description\u0027: description,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_58da2217","line":113,"range":{"start_line":113,"start_character":65,"end_line":113,"end_character":70},"in_reply_to":"1f621f24_1de6dc17","updated":"2020-10-29 19:30:18.000000000","message":"We always expect to get a value here, either True or False. We could get away by just removing the default value.","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"979ac0c7c3f509d4618120535c6ef34adab0c453","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def share_update(request, share_id, name, description, is_public\u003dFalse):"},{"line_number":114,"context_line":"    share_data \u003d {"},{"line_number":115,"context_line":"        \u0027display_name\u0027: name,"},{"line_number":116,"context_line":"        \u0027display_description\u0027: description,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_f8720ee3","line":113,"range":{"start_line":113,"start_character":65,"end_line":113,"end_character":70},"in_reply_to":"1f621f24_58da2217","updated":"2020-10-29 19:58:13.000000000","message":"We don\u0027t; the form needn\u0027t set a value, and can send None.","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e55561094f6553004f3666720e1a25de37f57392","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    )"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def share_update(request, share_id, name, description, is_public\u003dFalse):"},{"line_number":114,"context_line":"    share_data \u003d {"},{"line_number":115,"context_line":"        \u0027display_name\u0027: name,"},{"line_number":116,"context_line":"        \u0027display_description\u0027: description,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_d37d756f","line":113,"range":{"start_line":113,"start_character":65,"end_line":113,"end_character":70},"in_reply_to":"1f621f24_f8720ee3","updated":"2020-10-29 20:16:00.000000000","message":"\u003e We don\u0027t; the form needn\u0027t set a value, and can send None.\n\nBut, no harm done if we send a value always too.","commit_id":"7127028af8beb356125ce2563cf4f29069124011"}],"manila_ui/dashboards/project/shares/forms.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2338310702f7915238a02531932ee6b297e3e50c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Visibility\"), required\u003dFalse,"},{"line_number":260,"context_line":"        initial\u003dFalse,"},{"line_number":261,"context_line":"        help_text\u003d(\"If set then all tenants will be able to see this share.\"))"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_5008142b","line":260,"updated":"2020-10-27 00:22:46.000000000","message":"We don\u0027t need to initialize to false in here. At this point, it will already have a value assigned: either true or false.","commit_id":"50e3dcc47e102fc959ea89759a11cca599f82db5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c0dec6ff67fd195d09687df662f36aa78b29a931","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make Visible to All\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d(\"If set then all tenants will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_5c55cac5","line":260,"updated":"2020-10-27 12:28:27.000000000","message":"missing _ before (\nIt should be help_text\u003d_(\"If set then all tenants will be able to see this share.\")\n\nAlso, NIT, add a comma here and replace tenants word: \"If set, all projects will be able to see this share\"","commit_id":"3a0ec929c338753da3e3ed5334d7a0269a21fd2e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"741a6dcc4fa65f9563970644040992de011668f9","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make Visible to All\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d(\"If set then all tenants will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_fcac9636","line":260,"updated":"2020-10-27 13:15:06.000000000","message":"We need to fix it here too\n\n_(\"If set, then all projects will be able to see this share.\")","commit_id":"424b2dd5f08c8bbf7c94351be7b7eb1e16045181"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"379b51189a146f0565579104fd5c0fdeef22b95c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            self.fields[\u0027is_public\u0027] \u003d forms.BooleanField("},{"line_number":114,"context_line":"                label\u003d_(\"Make visible for all\"), required\u003dFalse,"},{"line_number":115,"context_line":"                help_text\u003d("},{"line_number":116,"context_line":"                    \"If set then all tenants will be able to see this share.\"))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        self.fields[\u0027share_proto\u0027].choices \u003d [(sp, sp) for sp in"},{"line_number":119,"context_line":"                                              self.enabled_share_protocols]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_91093ddf","line":116,"updated":"2020-10-29 13:50:47.000000000","message":"Update this string as well :)","commit_id":"4f692ec0327e546624799715a29fe3e452f4d44d"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"379b51189a146f0565579104fd5c0fdeef22b95c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make Visible to All\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d(\"If set, all projects will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_f140710a","line":260,"updated":"2020-10-29 13:50:47.000000000","message":"Add the leading _\n\nPrecisely, _(\"If set, all projects will be able to see this share.\")\n\n_ is to indicate that the string is translatable (for i18n)","commit_id":"4f692ec0327e546624799715a29fe3e452f4d44d"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"074805fdb5cf16285e108e68ee0fa52f861c1838","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make Visible to All\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d(\"If set, all projects will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_847a9d85","line":260,"in_reply_to":"1f621f24_f140710a","updated":"2020-10-29 19:03:43.000000000","message":"Done","commit_id":"4f692ec0327e546624799715a29fe3e452f4d44d"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ce93844fb3a62cac7f470cc49970764750c402e6","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    description \u003d forms.CharField(widget\u003dforms.Textarea,"},{"line_number":256,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":257,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":258,"context_line":"        label\u003d_(\"Make Visible to All\"), required\u003dFalse,"},{"line_number":259,"context_line":"        help_text\u003d_(\"If set, all projects will be able to see this share.\"))"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f621f24_246909be","line":258,"updated":"2020-10-29 14:23:57.000000000","message":"NIT Make visible for all","commit_id":"a33418ae933e76e6d9e9cef0e125133ddb76a29b"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4a77bc78b640d972bd631b64dfd5e214ec51f1fb","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        if self.enable_public_shares:"},{"line_number":113,"context_line":"            self.fields[\u0027is_public\u0027] \u003d forms.BooleanField("},{"line_number":114,"context_line":"                label\u003d_(\"Make visible for all\"), required\u003dFalse,"},{"line_number":115,"context_line":"                help_text\u003d_(\"If set, all projects will be able to see this share.\"))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        self.fields[\u0027share_proto\u0027].choices \u003d [(sp, sp) for sp in"},{"line_number":118,"context_line":"                                              self.enabled_share_protocols]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f621f24_07c20f86","line":115,"updated":"2020-10-29 15:35:26.000000000","message":"pep8: E501 line too long (84 \u003e 79 characters)","commit_id":"c360745c58caac4761112a2ea98ad6eefcf9d021"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a036ad8034c90a4110fbafe895a126ebe970943","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Share Name\"))"},{"line_number":256,"context_line":"    description \u003d forms.CharField(widget\u003dforms.Textarea,"},{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make visible for all\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d_(\"If set, all projects will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_3dc63869","line":260,"range":{"start_line":258,"start_character":4,"end_line":260,"end_character":76},"updated":"2020-10-29 18:04:12.000000000","message":"like the comments in the previous file, we need to allow users to choose not to update this field at all. So the previous code was correct.. \n\nWith this change, two things happen - you\u0027ve allowed this to become a Boolean field which forces the choice to be \u0027True\u0027 (default) or \u0027False\u0027. Screenshot here: https://imgur.com/a/NI62vmR\n\nThe previous behavior: https://imgur.com/a/AB1c4vf","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c2d69b8f8b83d38779916e85b786538698aa58be","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Share Name\"))"},{"line_number":256,"context_line":"    description \u003d forms.CharField(widget\u003dforms.Textarea,"},{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make visible for all\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d_(\"If set, all projects will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_b804167d","line":260,"range":{"start_line":258,"start_character":4,"end_line":260,"end_character":76},"in_reply_to":"1f621f24_3dc63869","updated":"2020-10-29 19:30:18.000000000","message":"Disagree with this point Goutham. When we create a share, we can set the visibility status to be either public or private (visible or not visible). If the user doesn\u0027t set any value, the default value is false. We do this in the API. In the DB the value that is stored is False. Check out https://github.com/openstack/manila/blob/master/manila/api/v1/shares.py#L289.\n\nSo at this point, when you update a share, you will get the visibility status you have in the DB, and you can opt to change it.\n\n\"None\" is not a valid value. Your share is either visible or not visible to other tenants.","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e55561094f6553004f3666720e1a25de37f57392","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Share Name\"))"},{"line_number":256,"context_line":"    description \u003d forms.CharField(widget\u003dforms.Textarea,"},{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make visible for all\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d_(\"If set, all projects will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_9383fd56","line":260,"range":{"start_line":258,"start_character":4,"end_line":260,"end_character":76},"in_reply_to":"1f621f24_58598258","updated":"2020-10-29 20:16:00.000000000","message":"I spoke with Victoria on IRC; and she made me realize that while we\u0027re always going to update the value of \"is_public\" - the update itself won\u0027t be detrimental. \n\nThe form currently has a checkbox\n\n\"Make visible for all\" which is checked if the share is currently public, and is unchecked if the share is private. \nUsers can toggle this checkbox if necessary, or just leave it alone to retain whatever value the share has. \n\nThat seems fine to me; although i feel we can rephrase the label text a little bit:\n\n\"Make visible *to* all\" is correct grammatically; but if you wanted to be more explicit (the help text does a good job of clarifying, but one needs to uncover it by hovering on the question icon next to the label)\n\nPerhaps consider changing the label to:\n\n \"This share must be visible to users from all projects\"\n\nHow does that sound?","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"93116ad71cbf6e66563432e3cd354030b3164ad8","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Share Name\"))"},{"line_number":256,"context_line":"    description \u003d forms.CharField(widget\u003dforms.Textarea,"},{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make visible for all\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d_(\"If set, all projects will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_f346b121","line":260,"range":{"start_line":258,"start_character":4,"end_line":260,"end_character":76},"in_reply_to":"1f621f24_9383fd56","updated":"2020-10-29 20:26:56.000000000","message":"Ok,  I will update L115 and L260 as \"This share must be visible to users from all projects\" and delete help_text in line115 and L260","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"41a2e0c8a5dcb21a2244968cb9e987cb1e49afe9","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Share Name\"))"},{"line_number":256,"context_line":"    description \u003d forms.CharField(widget\u003dforms.Textarea,"},{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make visible for all\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d_(\"If set, all projects will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_b3eef985","line":260,"range":{"start_line":258,"start_character":4,"end_line":260,"end_character":76},"in_reply_to":"1f621f24_9383fd56","updated":"2020-10-29 21:06:35.000000000","message":"is it fine to make label: \"Make visible to users from all projects\" in order not make it long, short is better for look and delete help_text?","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e39627cd1a8a41a2a75f46cdd7ec7edbde253f6f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Share Name\"))"},{"line_number":256,"context_line":"    description \u003d forms.CharField(widget\u003dforms.Textarea,"},{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make visible for all\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d_(\"If set, all projects will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_d72720b6","line":260,"range":{"start_line":258,"start_character":4,"end_line":260,"end_character":76},"in_reply_to":"1f621f24_b3eef985","updated":"2020-10-29 21:30:50.000000000","message":"I like your suggestion. Please feel free to update it with another change, we\u0027ll merge this one as is :)","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"979ac0c7c3f509d4618120535c6ef34adab0c453","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Share Name\"))"},{"line_number":256,"context_line":"    description \u003d forms.CharField(widget\u003dforms.Textarea,"},{"line_number":257,"context_line":"                                  label\u003d_(\"Description\"), required\u003dFalse)"},{"line_number":258,"context_line":"    is_public \u003d forms.BooleanField("},{"line_number":259,"context_line":"        label\u003d_(\"Make visible for all\"), required\u003dFalse,"},{"line_number":260,"context_line":"        help_text\u003d_(\"If set, all projects will be able to see this share.\"))"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":263,"context_line":"        super(UpdateForm, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_58598258","line":260,"range":{"start_line":258,"start_character":4,"end_line":260,"end_character":76},"in_reply_to":"1f621f24_b804167d","updated":"2020-10-29 19:58:13.000000000","message":"\u003e Disagree with this point Goutham. When we create a share, we can\n \u003e set the visibility status to be either public or private (visible\n \u003e or not visible). If the user doesn\u0027t set any value, the default\n \u003e value is false. We do this in the API. In the DB the value that is\n\nYes, that makes sense for share creation :)\n\n \u003e stored is False. Check out https://github.com/openstack/manila/blob/master/manila/api/v1/shares.py#L289.\n \u003e \n \u003e So at this point, when you update a share, you will get the\n \u003e visibility status you have in the DB, and you can opt to change it.\n\nWe\u0027re allowing them to update the visibility only if they want. We shouldn\u0027t force them to pick a visibility; users can use this form to update one or more of these three optionally:\n- Name\n- Description\n- is_public\n\nSo think of users that just want to change Name and/or description, and leave the visibility as it is. That\u0027s what the form was allowing users to do prior. \n\n \u003e \n \u003e \"None\" is not a valid value. Your share is either visible or not\n\nNone isn\u0027t a valid value; you can choose to update the \n\n \u003e visible to other tenants.","commit_id":"7127028af8beb356125ce2563cf4f29069124011"}],"manila_ui/dashboards/project/shares/views.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a036ad8034c90a4110fbafe895a126ebe970943","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        share \u003d self.get_object()"},{"line_number":173,"context_line":"        return {\u0027share_id\u0027: self.kwargs[\"share_id\"],"},{"line_number":174,"context_line":"                \u0027name\u0027: share.name,"},{"line_number":175,"context_line":"                \u0027description\u0027: share.description,"},{"line_number":176,"context_line":"                \u0027is_public\u0027: share.is_public}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class UpdateMetadataView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_bd88881f","line":176,"range":{"start_line":175,"start_character":49,"end_line":176,"end_character":45},"updated":"2020-10-29 18:04:12.000000000","message":"is this change required?","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e55561094f6553004f3666720e1a25de37f57392","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        share \u003d self.get_object()"},{"line_number":173,"context_line":"        return {\u0027share_id\u0027: self.kwargs[\"share_id\"],"},{"line_number":174,"context_line":"                \u0027name\u0027: share.name,"},{"line_number":175,"context_line":"                \u0027description\u0027: share.description,"},{"line_number":176,"context_line":"                \u0027is_public\u0027: share.is_public}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class UpdateMetadataView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_13408d35","line":176,"range":{"start_line":175,"start_character":49,"end_line":176,"end_character":45},"in_reply_to":"1f621f24_18f9ca7f","updated":"2020-10-29 20:16:00.000000000","message":"Ah! Thanks, this made me scratch my head, and misunderstand the whole intent of this change.","commit_id":"7127028af8beb356125ce2563cf4f29069124011"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c2d69b8f8b83d38779916e85b786538698aa58be","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        share \u003d self.get_object()"},{"line_number":173,"context_line":"        return {\u0027share_id\u0027: self.kwargs[\"share_id\"],"},{"line_number":174,"context_line":"                \u0027name\u0027: share.name,"},{"line_number":175,"context_line":"                \u0027description\u0027: share.description,"},{"line_number":176,"context_line":"                \u0027is_public\u0027: share.is_public}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"class UpdateMetadataView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f621f24_18f9ca7f","line":176,"range":{"start_line":175,"start_character":49,"end_line":176,"end_character":45},"in_reply_to":"1f621f24_bd88881f","updated":"2020-10-29 19:30:18.000000000","message":"It is, so the update modal (the view) gets the visibility status that is stored in the db.","commit_id":"7127028af8beb356125ce2563cf4f29069124011"}]}