)]}'
{"manila_ui/dashboards/admin/shares/templates/shares/index.html":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7f2730518c11050b1830af1297233dbb6fa2bac9","unresolved":true,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Shares\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"\u003cdiv class\u003d\"row\"\u003e "},{"line_number":7,"context_line":"  \u003cdiv class\u003d\"col-sm-12\"\u003e"},{"line_number":8,"context_line":"  \u003cp class\u003d\"text-left\"\u003e"},{"line_number":9,"context_line":"    \u003cb\u003e{% trans \"Shares in total\" %}: {{shares_count}}\u003c/b\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"9adf6550_4100f561","line":6,"updated":"2021-02-11 09:52:53.000000000","message":"NIT remove space","commit_id":"f57419799fdb767168ed4c541b3e6f7c92f478c4"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7f2730518c11050b1830af1297233dbb6fa2bac9","unresolved":true,"context_lines":[{"line_number":6,"context_line":"\u003cdiv class\u003d\"row\"\u003e "},{"line_number":7,"context_line":"  \u003cdiv class\u003d\"col-sm-12\"\u003e"},{"line_number":8,"context_line":"  \u003cp class\u003d\"text-left\"\u003e"},{"line_number":9,"context_line":"    \u003cb\u003e{% trans \"Shares in total\" %}: {{shares_count}}\u003c/b\u003e"},{"line_number":10,"context_line":"   \u003c/p\u003e"},{"line_number":11,"context_line":"\u003c/div\u003e"},{"line_number":12,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"9c41791c_8381cddd","line":9,"updated":"2021-02-11 09:52:53.000000000","message":"NIT add spacing between {{ shares_count }}","commit_id":"f57419799fdb767168ed4c541b3e6f7c92f478c4"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"4d45490d9b2058a2e4efc7565d9d785da00f3716","unresolved":true,"context_lines":[{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":7,"context_line":"  \u003cdiv class\u003d\"col-sm-12\"\u003e"},{"line_number":8,"context_line":"  \u003cp class\u003d\"text-left\"\u003e"},{"line_number":9,"context_line":"    \u003cb\u003e{% trans \"Shares in total\" %}: {{ shares_count }}\u003c/b\u003e"},{"line_number":10,"context_line":"   \u003c/p\u003e"},{"line_number":11,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"0114593c_7182dd7b","line":8,"updated":"2021-02-17 14:53:55.000000000","message":"Remove this","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"730e80c0b710cb17533e90897b8ce5d1c43a6586","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":7,"context_line":"  \u003cdiv class\u003d\"col-sm-12\"\u003e"},{"line_number":8,"context_line":"  \u003cp class\u003d\"text-left\"\u003e"},{"line_number":9,"context_line":"    \u003cb\u003e{% trans \"Shares in total\" %}: {{ shares_count }}\u003c/b\u003e"},{"line_number":10,"context_line":"   \u003c/p\u003e"},{"line_number":11,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"7963491c_626a6f5e","line":8,"in_reply_to":"0114593c_7182dd7b","updated":"2021-02-17 19:05:16.000000000","message":"Done","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"}],"manila_ui/dashboards/admin/shares/views.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"4d45490d9b2058a2e4efc7565d9d785da00f3716","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    page_title \u003d _(\"Shares\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @memoized.memoized_method"},{"line_number":43,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":44,"context_line":"        context \u003d super(SharesView, self).get_context_data(**kwargs)"},{"line_number":45,"context_line":"        shares \u003d manila.share_list("},{"line_number":46,"context_line":"            self.request,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c5302cc2_421f0164","line":43,"updated":"2021-02-17 14:53:55.000000000","message":"Remove this function","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"730e80c0b710cb17533e90897b8ce5d1c43a6586","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    page_title \u003d _(\"Shares\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @memoized.memoized_method"},{"line_number":43,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":44,"context_line":"        context \u003d super(SharesView, self).get_context_data(**kwargs)"},{"line_number":45,"context_line":"        shares \u003d manila.share_list("},{"line_number":46,"context_line":"            self.request,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dda5be9f_e494f693","line":43,"in_reply_to":"c5302cc2_421f0164","updated":"2021-02-17 19:05:16.000000000","message":"Same comments as to project/shares/views.py","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"4d45490d9b2058a2e4efc7565d9d785da00f3716","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    def get_shares_data(self):"},{"line_number":54,"context_line":"        shares \u003d []"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            shares \u003d manila.share_list("},{"line_number":57,"context_line":"                self.request, search_opts\u003d{\u0027all_tenants\u0027: True})"},{"line_number":58,"context_line":"            snapshots \u003d manila.share_snapshot_list("},{"line_number":59,"context_line":"                self.request, detailed\u003dTrue, search_opts\u003d{\u0027all_tenants\u0027: True})"}],"source_content_type":"text/x-python","patch_set":5,"id":"c294351f_aa88e62a","line":56,"updated":"2021-02-17 14:53:55.000000000","message":"Add the with_count param set to true to this search_opts","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"730e80c0b710cb17533e90897b8ce5d1c43a6586","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def get_shares_data(self):"},{"line_number":54,"context_line":"        shares \u003d []"},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            shares \u003d manila.share_list("},{"line_number":57,"context_line":"                self.request, search_opts\u003d{\u0027all_tenants\u0027: True})"},{"line_number":58,"context_line":"            snapshots \u003d manila.share_snapshot_list("},{"line_number":59,"context_line":"                self.request, detailed\u003dTrue, search_opts\u003d{\u0027all_tenants\u0027: True})"}],"source_content_type":"text/x-python","patch_set":5,"id":"392cd7d4_4acdacda","line":56,"in_reply_to":"c294351f_aa88e62a","updated":"2021-02-17 19:05:16.000000000","message":"Same comments as to project/shares/views.py","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"}],"manila_ui/dashboards/project/shares/templates/shares/index.html":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7f2730518c11050b1830af1297233dbb6fa2bac9","unresolved":true,"context_lines":[{"line_number":6,"context_line":"\u003cdiv class\u003d\"row\"\u003e "},{"line_number":7,"context_line":"  \u003cdiv class\u003d\"col-sm-12\"\u003e"},{"line_number":8,"context_line":"  \u003cp class\u003d\"text-left\"\u003e"},{"line_number":9,"context_line":"    \u003cb\u003e{% trans \"Shares in total\" %}: {{shares_count}}\u003c/b\u003e"},{"line_number":10,"context_line":"   \u003c/p\u003e"},{"line_number":11,"context_line":"\u003c/div\u003e"},{"line_number":12,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"958fb4cd_f5c67cd0","line":9,"updated":"2021-02-11 09:52:53.000000000","message":"Ditto","commit_id":"f57419799fdb767168ed4c541b3e6f7c92f478c4"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"4d45490d9b2058a2e4efc7565d9d785da00f3716","unresolved":true,"context_lines":[{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":7,"context_line":"  \u003cdiv class\u003d\"col-sm-12\"\u003e"},{"line_number":8,"context_line":"  \u003cp class\u003d\"text-left\"\u003e"},{"line_number":9,"context_line":"    \u003cb\u003e{% trans \"Shares in total\" %}: {{ shares_count }}\u003c/b\u003e"},{"line_number":10,"context_line":"   \u003c/p\u003e"},{"line_number":11,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"8fa41845_bed9f661","line":8,"updated":"2021-02-17 14:53:55.000000000","message":"Remove this","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"730e80c0b710cb17533e90897b8ce5d1c43a6586","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":7,"context_line":"  \u003cdiv class\u003d\"col-sm-12\"\u003e"},{"line_number":8,"context_line":"  \u003cp class\u003d\"text-left\"\u003e"},{"line_number":9,"context_line":"    \u003cb\u003e{% trans \"Shares in total\" %}: {{ shares_count }}\u003c/b\u003e"},{"line_number":10,"context_line":"   \u003c/p\u003e"},{"line_number":11,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"37811ee3_e9a15ef4","line":8,"in_reply_to":"8fa41845_bed9f661","updated":"2021-02-17 19:05:16.000000000","message":"Done","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"}],"manila_ui/dashboards/project/shares/views.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"4d45490d9b2058a2e4efc7565d9d785da00f3716","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    page_title \u003d _(\"Shares\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @memoized.memoized_method"},{"line_number":55,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":56,"context_line":"        context \u003d super(SharesView, self).get_context_data(**kwargs)"},{"line_number":57,"context_line":"        shares \u003d manila.share_list("},{"line_number":58,"context_line":"            self.request,"}],"source_content_type":"text/x-python","patch_set":5,"id":"562279c4_5a2d8043","line":55,"updated":"2021-02-17 14:53:55.000000000","message":"Remove this function here","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"db659d826562ab57b1d09ae805744917f4bc2d60","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    page_title \u003d _(\"Shares\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @memoized.memoized_method"},{"line_number":55,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":56,"context_line":"        context \u003d super(SharesView, self).get_context_data(**kwargs)"},{"line_number":57,"context_line":"        shares \u003d manila.share_list("},{"line_number":58,"context_line":"            self.request,"}],"source_content_type":"text/x-python","patch_set":5,"id":"09650b0a_1c40b3be","line":55,"in_reply_to":"067572b2_912f6715","updated":"2021-02-23 21:54:45.000000000","message":"Agree. We will need to add this when we work on the pagination feature. Right now if we leave this here we will have an extra call to share_list without actually needing it (because we don\u0027t have pagination yet).","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"730e80c0b710cb17533e90897b8ce5d1c43a6586","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    page_title \u003d _(\"Shares\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @memoized.memoized_method"},{"line_number":55,"context_line":"    def get_context_data(self, **kwargs):"},{"line_number":56,"context_line":"        context \u003d super(SharesView, self).get_context_data(**kwargs)"},{"line_number":57,"context_line":"        shares \u003d manila.share_list("},{"line_number":58,"context_line":"            self.request,"}],"source_content_type":"text/x-python","patch_set":5,"id":"067572b2_912f6715","line":55,"in_reply_to":"562279c4_5a2d8043","updated":"2021-02-17 19:05:16.000000000","message":"This function passes \"shares_count\" variable to HTML template. If \"shares_count\" will be used in future for pagination, I think this function needs to stay.","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"4d45490d9b2058a2e4efc7565d9d785da00f3716","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        for share_net in share_nets:"},{"line_number":69,"context_line":"            share_nets_names[share_net.id] \u003d share_net.name"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            shares \u003d manila.share_list(self.request)"},{"line_number":72,"context_line":"            for share in shares:"},{"line_number":73,"context_line":"                share.share_network \u003d ("},{"line_number":74,"context_line":"                    share_nets_names.get(share.share_network_id) or"}],"source_content_type":"text/x-python","patch_set":5,"id":"e3fd3e3f_dd579f18","line":71,"updated":"2021-02-17 14:53:55.000000000","message":"Add the search_opts with the with_count param set to true here","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"db659d826562ab57b1d09ae805744917f4bc2d60","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        for share_net in share_nets:"},{"line_number":69,"context_line":"            share_nets_names[share_net.id] \u003d share_net.name"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            shares \u003d manila.share_list(self.request)"},{"line_number":72,"context_line":"            for share in shares:"},{"line_number":73,"context_line":"                share.share_network \u003d ("},{"line_number":74,"context_line":"                    share_nets_names.get(share.share_network_id) or"}],"source_content_type":"text/x-python","patch_set":5,"id":"b712d9bf_2a270065","line":71,"in_reply_to":"751a8439_a32583d0","updated":"2021-02-23 21:54:45.000000000","message":"This is correct yes","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"730e80c0b710cb17533e90897b8ce5d1c43a6586","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        for share_net in share_nets:"},{"line_number":69,"context_line":"            share_nets_names[share_net.id] \u003d share_net.name"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            shares \u003d manila.share_list(self.request)"},{"line_number":72,"context_line":"            for share in shares:"},{"line_number":73,"context_line":"                share.share_network \u003d ("},{"line_number":74,"context_line":"                    share_nets_names.get(share.share_network_id) or"}],"source_content_type":"text/x-python","patch_set":5,"id":"751a8439_a32583d0","line":71,"in_reply_to":"e3fd3e3f_dd579f18","updated":"2021-02-17 19:05:16.000000000","message":"get_shares_data function return shares_data table. I might be wrong but I think it is not possible to extract \"shares_count\" from this function to the view.","commit_id":"91d35a317334a8f6599d20f2670bf8d1e089e5f2"}]}