)]}'
{"manila_ui/local/local_settings.d/_90_manila_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d4d46ebc00096bfe317c0522ffb192b0298ae735","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"settings.POLICY_FILES.update({"},{"line_number":18,"context_line":"    \u0027share\u0027: \u0027manila_policy.json\u0027,"},{"line_number":19,"context_line":"})"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# The OPENSTACK_MANILA_FEATURES settings can be used to enable or disable"}],"source_content_type":"text/x-python","patch_set":1,"id":"6b25c977_063cb705","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":32},"updated":"2021-02-15 16:55:44.000000000","message":"yaml?","commit_id":"7b3267b2bae436e0580e2a229a64bd8d6a04bc1f"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"0cc792c14043951afe03136542a639fc35f1b615","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"settings.POLICY_FILES.update({"},{"line_number":18,"context_line":"    \u0027share\u0027: \u0027manila_policy.json\u0027,"},{"line_number":19,"context_line":"})"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# The OPENSTACK_MANILA_FEATURES settings can be used to enable or disable"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2cccff3_039bb610","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":32},"in_reply_to":"4b419ca6_6a3af059","updated":"2021-03-15 07:10:17.000000000","message":"yeah we have to manually update policy.json file to sync polices change with manila.\nJFYI: we recently change format of the policy files from json-\u003eyaml [1] so if you\nare planning to add it please use new format.\n\n[1] https://review.opendev.org/c/openstack/horizon/+/750134","commit_id":"7b3267b2bae436e0580e2a229a64bd8d6a04bc1f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7f36ffbcbaf2be903cbf1340d98954b3dcf0b0dc","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"settings.POLICY_FILES.update({"},{"line_number":18,"context_line":"    \u0027share\u0027: \u0027manila_policy.json\u0027,"},{"line_number":19,"context_line":"})"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# The OPENSTACK_MANILA_FEATURES settings can be used to enable or disable"}],"source_content_type":"text/x-python","patch_set":1,"id":"73fae89a_b4de01f2","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":32},"in_reply_to":"6b25c977_063cb705","updated":"2021-02-15 22:57:01.000000000","message":"In Horizon, json is still used by default in current master. There is a patch to replace json with yaml but it is not yet merged\n https://review.opendev.org/c/openstack/horizon/+/750134\n\nI was thinking to merge this change with json first just in case we would need to backport this to older stable branches and then replace json with yaml once the above patch is merged.","commit_id":"7b3267b2bae436e0580e2a229a64bd8d6a04bc1f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa84fe0e1355805f6c010ae3653e970a3f6f42ee","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"settings.POLICY_FILES.update({"},{"line_number":18,"context_line":"    \u0027share\u0027: \u0027manila_policy.json\u0027,"},{"line_number":19,"context_line":"})"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# The OPENSTACK_MANILA_FEATURES settings can be used to enable or disable"}],"source_content_type":"text/x-python","patch_set":1,"id":"a021bbef_67f4fcba","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":32},"in_reply_to":"6b4ee1ab_2aebe40d","updated":"2021-02-17 03:05:25.000000000","message":"Agreed, this makes sense for backports. However, i am a little unfamiliar with how the policy file is used at all by this horizon plugin. \nIf i refer to the RBAC doc here: https://docs.openstack.org/horizon/latest/contributor/topics/policy.html - it appears that we need manila-ui\u0027s panels to declare some policies per\nhttps://docs.openstack.org/horizon/latest/contributor/topics/policy.html#django-policy-check-function\n\nWe don\u0027t do any of that currently. Our dashboards have a \"admin\" and \"member\" view of things. Is this unique to manila-ui?","commit_id":"7b3267b2bae436e0580e2a229a64bd8d6a04bc1f"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"d20e3cccea1bd1ea9b5cefe9f5cc6ba4aa72bda7","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"settings.POLICY_FILES.update({"},{"line_number":18,"context_line":"    \u0027share\u0027: \u0027manila_policy.json\u0027,"},{"line_number":19,"context_line":"})"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# The OPENSTACK_MANILA_FEATURES settings can be used to enable or disable"}],"source_content_type":"text/x-python","patch_set":1,"id":"6b4ee1ab_2aebe40d","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":32},"in_reply_to":"73fae89a_b4de01f2","updated":"2021-02-16 05:00:15.000000000","message":"+1. It make sense form backport POV.","commit_id":"7b3267b2bae436e0580e2a229a64bd8d6a04bc1f"},{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"f867ea967ac6d99b77b618c029577989ef742bbd","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"settings.POLICY_FILES.update({"},{"line_number":18,"context_line":"    \u0027share\u0027: \u0027manila_policy.json\u0027,"},{"line_number":19,"context_line":"})"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# The OPENSTACK_MANILA_FEATURES settings can be used to enable or disable"}],"source_content_type":"text/x-python","patch_set":1,"id":"a9556986_ab66669e","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":32},"in_reply_to":"a021bbef_67f4fcba","updated":"2021-02-17 04:31:58.000000000","message":"yes you are right. In horizon we generally adds policy checks(policy_rules attribute) in table action which check that a operation create/delete/view is allowed or not.\nSo IMO this patch is not complete, We have to first generate \u0027manila_policy.json\u0027 using oslo-generator tool and add it. I was checking how to add policy support in any horizon plugin and\nI found this [1] maybe it can help although I am not agreed at some points how it is implemented in murano-dashboard.\n[1] https://review.opendev.org/q/topic:%22bp%252Fmurano-dashboard-rbac%22+(status:open%20OR%20status:merged)","commit_id":"7b3267b2bae436e0580e2a229a64bd8d6a04bc1f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a576ff745512a9376586bce668da38bf368b8b30","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"settings.POLICY_FILES.update({"},{"line_number":18,"context_line":"    \u0027share\u0027: \u0027manila_policy.json\u0027,"},{"line_number":19,"context_line":"})"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# The OPENSTACK_MANILA_FEATURES settings can be used to enable or disable"}],"source_content_type":"text/x-python","patch_set":1,"id":"4b419ca6_6a3af059","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":32},"in_reply_to":"a9556986_ab66669e","updated":"2021-03-12 11:27:12.000000000","message":"I see there already exists implementations to enforce policy rules like https://github.com/openstack/manila-ui/blob/master/manila_ui/dashboards/project/shares/tables.py#L87 , so I believe manila-ui already requires policy rules defined in policy.json.\n\nI agree that it would be better to provide a default policy.json file. I confirmed that heat-dashboard also provides the default policy file. One concern would be that we need to update the file manually everytime we make changes in manila itself but I think it\u0027s still doable thing.","commit_id":"7b3267b2bae436e0580e2a229a64bd8d6a04bc1f"}]}