)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"826bf75da4135358192dda2d975b488b022bb926","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixes  availability zone issue when creating from snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug #1915706 in Manila UI, availability zone"},{"line_number":10,"context_line":"not being picked up correctly. Issue is invaild input"},{"line_number":11,"context_line":"error being raised, even when availability_zone provided"},{"line_number":12,"context_line":"is the same, as parent share\u0027s. Removed availability_zone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8dc37708_bf1bd4e6","line":9,"updated":"2021-04-27 19:51:12.000000000","message":"NIT The the commit message should be self contained to be helpful in the future. A better commit message would be like:\n\nSet parent share az when creating a share from snapshot\n\nThis patch-set modifies how we manage user input when creating a share from snapshot. Since we use the same form for the basic create share workflow and for the create share from snapshot workflow, we need to add a check to distinguish both cases: when creating a share from snapshot, then the parent share availability zone is picked by default. Otherwise, if it\u0027s a regular share create, the user can pick up the availability zone they need.\n\nCloses-Bug: #1915706","commit_id":"6eb1f979d8eb8cd23a90bfbccede1f8143bcee4e"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"565e4146e0d170e662cebd0fbf2a2eb73b886003","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixes  availability zone issue when creating from snapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug #1915706 in Manila UI, availability zone"},{"line_number":10,"context_line":"not being picked up correctly. Issue is invaild input"},{"line_number":11,"context_line":"error being raised, even when availability_zone provided"},{"line_number":12,"context_line":"is the same, as parent share\u0027s. Removed availability_zone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b05425bd_d99e7804","line":9,"in_reply_to":"8dc37708_bf1bd4e6","updated":"2021-04-28 14:32:38.000000000","message":"Done","commit_id":"6eb1f979d8eb8cd23a90bfbccede1f8143bcee4e"}],"manila_ui/dashboards/project/shares/forms.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"579008b1f85ce93b923ee773cfa518c16993984f","unresolved":true,"context_lines":[{"line_number":118,"context_line":"                                              self.enabled_share_protocols]"},{"line_number":119,"context_line":"        if (\"snapshot_id\" in request.GET or"},{"line_number":120,"context_line":"                kwargs.get(\"data\", {}).get(\"snapshot\")):"},{"line_number":121,"context_line":"            del self.fields[\u0027availability_zone\u0027]"},{"line_number":122,"context_line":"            try:"},{"line_number":123,"context_line":"                snapshot \u003d self.get_snapshot("},{"line_number":124,"context_line":"                    request,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae440fe5_31ad7455","line":121,"range":{"start_line":121,"start_character":12,"end_line":121,"end_character":48},"updated":"2021-04-03 07:57:57.000000000","message":"i don\u0027t think we need to delete this parameter, manila client also support create share from snapshot, and specify this parameter. the error you describe just need to fix manila. not manila-ui.","commit_id":"6eb1f979d8eb8cd23a90bfbccede1f8143bcee4e"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"a41c6c5e0a15c0950b646459a28a55347e72cd62","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                              self.enabled_share_protocols]"},{"line_number":119,"context_line":"        if (\"snapshot_id\" in request.GET or"},{"line_number":120,"context_line":"                kwargs.get(\"data\", {}).get(\"snapshot\")):"},{"line_number":121,"context_line":"            del self.fields[\u0027availability_zone\u0027]"},{"line_number":122,"context_line":"            try:"},{"line_number":123,"context_line":"                snapshot \u003d self.get_snapshot("},{"line_number":124,"context_line":"                    request,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0e29e098_abbfe151","line":121,"range":{"start_line":121,"start_character":12,"end_line":121,"end_character":48},"in_reply_to":"ae440fe5_31ad7455","updated":"2021-04-26 06:32:29.000000000","message":"Ack, i made this field default and disabled.","commit_id":"6eb1f979d8eb8cd23a90bfbccede1f8143bcee4e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"826bf75da4135358192dda2d975b488b022bb926","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                self.fields[\u0027size\u0027].initial \u003d snapshot.size"},{"line_number":128,"context_line":"                self.fields[\u0027snapshot\u0027].choices \u003d ((snapshot.id, snapshot),)"},{"line_number":129,"context_line":"                try:"},{"line_number":130,"context_line":"                    # Set the share type  and az from the original share"},{"line_number":131,"context_line":"                    orig_share \u003d manila.share_get(request, snapshot.share_id)"},{"line_number":132,"context_line":"                    # NOTE(vponomaryov): we should use share type name, not ID,"},{"line_number":133,"context_line":"                    # because we use names in our choices above."}],"source_content_type":"text/x-python","patch_set":2,"id":"c049d60f_48182c9c","line":130,"updated":"2021-04-27 19:51:12.000000000","message":"NIT remove extra space","commit_id":"74a92f59548ad68eb07b230e5f6b2ac21e3109ec"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"565e4146e0d170e662cebd0fbf2a2eb73b886003","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                self.fields[\u0027size\u0027].initial \u003d snapshot.size"},{"line_number":128,"context_line":"                self.fields[\u0027snapshot\u0027].choices \u003d ((snapshot.id, snapshot),)"},{"line_number":129,"context_line":"                try:"},{"line_number":130,"context_line":"                    # Set the share type  and az from the original share"},{"line_number":131,"context_line":"                    orig_share \u003d manila.share_get(request, snapshot.share_id)"},{"line_number":132,"context_line":"                    # NOTE(vponomaryov): we should use share type name, not ID,"},{"line_number":133,"context_line":"                    # because we use names in our choices above."}],"source_content_type":"text/x-python","patch_set":2,"id":"e885e31c_265eebc0","line":130,"in_reply_to":"c049d60f_48182c9c","updated":"2021-04-28 14:32:38.000000000","message":"Done","commit_id":"74a92f59548ad68eb07b230e5f6b2ac21e3109ec"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"826bf75da4135358192dda2d975b488b022bb926","unresolved":true,"context_lines":[{"line_number":129,"context_line":"                try:"},{"line_number":130,"context_line":"                    # Set the share type  and az from the original share"},{"line_number":131,"context_line":"                    orig_share \u003d manila.share_get(request, snapshot.share_id)"},{"line_number":132,"context_line":"                    # NOTE(vponomaryov): we should use share type name, not ID,"},{"line_number":133,"context_line":"                    # because we use names in our choices above."},{"line_number":134,"context_line":"                    self.fields[\u0027share_type\u0027].initial \u003d ("},{"line_number":135,"context_line":"                        orig_share.share_type_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e1a78d1e_54efdfa4","line":132,"updated":"2021-04-27 19:51:12.000000000","message":"NIT Not related to this patch, but, seems we can remove this comment here since we don\u0027t add more information than the one we have in the code","commit_id":"74a92f59548ad68eb07b230e5f6b2ac21e3109ec"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"565e4146e0d170e662cebd0fbf2a2eb73b886003","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                try:"},{"line_number":130,"context_line":"                    # Set the share type  and az from the original share"},{"line_number":131,"context_line":"                    orig_share \u003d manila.share_get(request, snapshot.share_id)"},{"line_number":132,"context_line":"                    # NOTE(vponomaryov): we should use share type name, not ID,"},{"line_number":133,"context_line":"                    # because we use names in our choices above."},{"line_number":134,"context_line":"                    self.fields[\u0027share_type\u0027].initial \u003d ("},{"line_number":135,"context_line":"                        orig_share.share_type_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa14b5b8_f979cca2","line":132,"in_reply_to":"e1a78d1e_54efdfa4","updated":"2021-04-28 14:32:38.000000000","message":"Done","commit_id":"74a92f59548ad68eb07b230e5f6b2ac21e3109ec"}]}