)]}'
{"manila_ui/dashboards/project/shares/forms.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dfabb30bb4ff0a0b318ad1ca49035fe192ec50d8","unresolved":true,"context_lines":[{"line_number":412,"context_line":"            time_elapsed +\u003d interval"},{"line_number":413,"context_line":"            share \u003d manila.share_get(request, share_id)"},{"line_number":414,"context_line":"            if time_elapsed \u003e timeout:"},{"line_number":415,"context_line":"                raise Exception"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        if share.size \u003d\u003d new_size:"},{"line_number":418,"context_line":"            message \u003d _(\u0027Resized share \"%s\"\u0027) % share.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"a581b139_2f14ac4d","line":415,"range":{"start_line":415,"start_character":22,"end_line":415,"end_character":31},"updated":"2021-03-14 21:30:28.000000000","message":"on this and line 421; please raise a specific exception - raising an Exception without a message isn\u0027t good practice and makes handling different kinds of errors in the future hard: https://opendev.org/openstack/horizon/src/commit/0d39a5c33a65e7b477138e0e5aabc5ffa422efbf/horizon/exceptions.py#L157","commit_id":"4ae2d26784cd0a51318b46dc94e07a9c5694c78c"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"17d9b38ec3180faf5493ef3246904ba47831f2fd","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            time_elapsed +\u003d interval"},{"line_number":413,"context_line":"            share \u003d manila.share_get(request, share_id)"},{"line_number":414,"context_line":"            if time_elapsed \u003e timeout:"},{"line_number":415,"context_line":"                raise Exception"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        if share.size \u003d\u003d new_size:"},{"line_number":418,"context_line":"            message \u003d _(\u0027Resized share \"%s\"\u0027) % share.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"c1ef0c81_6f2f170c","line":415,"range":{"start_line":415,"start_character":22,"end_line":415,"end_character":31},"in_reply_to":"a581b139_2f14ac4d","updated":"2021-03-16 14:03:33.000000000","message":"Done","commit_id":"4ae2d26784cd0a51318b46dc94e07a9c5694c78c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2939b67426fd628382fd1fb2c7cabf737a51f0f8","unresolved":true,"context_lines":[{"line_number":420,"context_line":"            message \u003d _(\u0027Resized share \"%s\"\u0027) % share.name"},{"line_number":421,"context_line":"            messages.success(request, message)"},{"line_number":422,"context_line":"            return True"},{"line_number":423,"context_line":"        raise Exception"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"class RevertForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f921d42_25450138","line":423,"range":{"start_line":423,"start_character":14,"end_line":423,"end_character":23},"updated":"2021-03-16 15:41:31.000000000","message":"WorkflowError here too?","commit_id":"279067151512cb7586927c740a0acf383dfb34a8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3b4f6f5cc75f193714fc507a13ff85e8a98fc4f8","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            message \u003d _(\u0027Resized share \"%s\"\u0027) % share.name"},{"line_number":421,"context_line":"            messages.success(request, message)"},{"line_number":422,"context_line":"            return True"},{"line_number":423,"context_line":"        raise Exception"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"class RevertForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":2,"id":"d588b6fd_266770c0","line":423,"range":{"start_line":423,"start_character":14,"end_line":423,"end_character":23},"in_reply_to":"1fd7b2b0_cfce2c04","updated":"2021-03-17 17:10:25.000000000","message":"Hi Dina, WorkflowError is a subclass of Exception, and you\u0027re handling the base class on line 400. I understand the message raised on lines 415-417 is lost. Perhaps we should log these on line 401?","commit_id":"279067151512cb7586927c740a0acf383dfb34a8"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"56b3054a9a526b21c9ee7c651d6a40eec859efba","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            message \u003d _(\u0027Resized share \"%s\"\u0027) % share.name"},{"line_number":421,"context_line":"            messages.success(request, message)"},{"line_number":422,"context_line":"            return True"},{"line_number":423,"context_line":"        raise Exception"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"class RevertForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1fd7b2b0_cfce2c04","line":423,"range":{"start_line":423,"start_character":14,"end_line":423,"end_character":23},"in_reply_to":"7f921d42_25450138","updated":"2021-03-17 14:23:22.000000000","message":"Hi Goutham, this exception is handled on line #400 in try/except block. WorkflowError will override the message there. I think it is not necessary here. thanks.","commit_id":"279067151512cb7586927c740a0acf383dfb34a8"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"f3873e1bd3ba7a61a6b90c230276cb3e84b3feaa","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            message \u003d _(\u0027Resized share \"%s\"\u0027) % share.name"},{"line_number":421,"context_line":"            messages.success(request, message)"},{"line_number":422,"context_line":"            return True"},{"line_number":423,"context_line":"        raise Exception"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"class RevertForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dd813667_466efbe8","line":423,"range":{"start_line":423,"start_character":14,"end_line":423,"end_character":23},"in_reply_to":"d588b6fd_266770c0","updated":"2021-03-17 18:31:46.000000000","message":"Done","commit_id":"279067151512cb7586927c740a0acf383dfb34a8"}]}