)]}'
{"manila_ui/dashboards/project/shares/forms.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"456255a449c7964d6c15a7a9b2c3e295e8e8fe28","unresolved":true,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def handle(self, request, data):"},{"line_number":382,"context_line":"        rule_id \u003d self.initial[\u0027rule_id\u0027]"},{"line_number":383,"context_line":"        try:"},{"line_number":384,"context_line":"            rule \u003d manila.share_rule_get(self.request, rule_id)"},{"line_number":385,"context_line":"            set_dict, unset_list \u003d utils.parse_str_meta(data[\u0027metadata\u0027])"},{"line_number":386,"context_line":"            if set_dict:"},{"line_number":387,"context_line":"                manila.share_rule_set_metadata(request, rule, set_dict)"},{"line_number":388,"context_line":"            if unset_list:"},{"line_number":389,"context_line":"                manila.share_rule_unset_metadata(request, rule, unset_list)"},{"line_number":390,"context_line":"            message \u003d _(\u0027Updating share access rule metadata \u0027)"},{"line_number":391,"context_line":"            messages.success(request, message)"},{"line_number":392,"context_line":"            return True"},{"line_number":393,"context_line":"        except ValidationError as e:"},{"line_number":394,"context_line":"            self.api_error(e.messages[0])"},{"line_number":395,"context_line":"            return False"},{"line_number":396,"context_line":"        except Exception:"},{"line_number":397,"context_line":"            redirect \u003d reverse(\"horizon:project:shares:manage_rules\")"},{"line_number":398,"context_line":"            exceptions.handle(request,"},{"line_number":399,"context_line":"                              _(\u0027Unable to update rule metadata.\u0027),"},{"line_number":400,"context_line":"                              redirect\u003dredirect)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"class ResizeForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7c16651a_d7cc2cb1","line":400,"range":{"start_line":383,"start_character":8,"end_line":400,"end_character":48},"updated":"2021-09-02 17:04:54.000000000","message":"When unsetting metadata that doesn\u0027t exist, the form fails; because there\u0027s no \n\n  args\u003d[self.initial[\u0027share_id\u0027]] in the reverse() call here. \n\nNot much of a harm done though because i get a \"Danger\" pop up with \"Unable to update rule metadata.\" error. \n\nDina, is it possible to fix this in a follow up patch? \n\n\n\n2021-09-02 16:54:19.616388 RESP BODY: {\"itemNotFound\": {\"code\": 404, \"message\": \"Share access rule metadata does not exist.\"}}\n2021-09-02 16:54:19.616392\n2021-09-02 16:54:19.658393 ERROR django.request Internal Server Error: /dashboard/project/shares/rules/e8cb793d-65a9-46cf-80ca-b7c3d7e861f9/update_rule_metadata/\n2021-09-02 16:54:19.658448 Traceback (most recent call last):\n2021-09-02 16:54:19.658454   File \"/opt/stack/manila-ui/manila_ui/dashboards/project/shares/forms.py\", line 389, in handle\n2021-09-02 16:54:19.658458     manila.share_rule_unset_metadata(request, rule, unset_list)\n2021-09-02 16:54:19.658461   File \"/opt/stack/manila-ui/manila_ui/api/manila.py\", line 141, in share_rule_unset_metadata\n2021-09-02 16:54:19.658465     return manilaclient(request).share_access_rules.unset_metadata(\n2021-09-02 16:54:19.658468   File \"/opt/stack/python-manilaclient/manilaclient/api_versions.py\", line 399, in substitution\n2021-09-02 16:54:19.658489     return method.func(obj, *args, **kwargs)\n2021-09-02 16:54:19.658493   File \"/opt/stack/python-manilaclient/manilaclient/v2/share_access_rules.py\", line 82, in unset_metadata\n2021-09-02 16:54:19.658497     self._delete(url)\n2021-09-02 16:54:19.658502   File \"/opt/stack/python-manilaclient/manilaclient/base.py\", line 173, in _delete\n2021-09-02 16:54:19.658506     resp, body \u003d self.api.client.delete(url)\n2021-09-02 16:54:19.658509   File \"/opt/stack/python-manilaclient/manilaclient/common/httpclient.py\", line 193, in delete\n2021-09-02 16:54:19.658514     return self._cs_request(url, \u0027DELETE\u0027, **kwargs)\n2021-09-02 16:54:19.658518   File \"/opt/stack/python-manilaclient/manilaclient/common/httpclient.py\", line 143, in _cs_request\n2021-09-02 16:54:19.658521     return self._cs_request_with_retries(\n2021-09-02 16:54:19.658525   File \"/opt/stack/python-manilaclient/manilaclient/common/httpclient.py\", line 160, in _cs_request_with_retries\n2021-09-02 16:54:19.658528     resp, body \u003d self.request(url, method, **kwargs)\n2021-09-02 16:54:19.658532   File \"/opt/stack/python-manilaclient/manilaclient/common/httpclient.py\", line 138, in request\n2021-09-02 16:54:19.658535     raise exceptions.from_response(resp, method, url)\n2021-09-02 16:54:19.658544 manilaclient.common.apiclient.exceptions.NotFound: Share access rule metadata does not exist. (HTTP 404) (Request-ID: req-00ee6aba-d854-4fd7-92c6-44852e606114)\n2021-09-02 16:54:19.658548\n2021-09-02 16:54:19.658560 During handling of the above exception, another exception occurred:\n2021-09-02 16:54:19.658564\n2021-09-02 16:54:19.658567 Traceback (most recent call last):\n2021-09-02 16:54:19.658570   File \"/usr/local/lib/python3.8/dist-packages/django/core/handlers/exception.py\", line 34, in inner\n2021-09-02 16:54:19.658574     response \u003d get_response(request)\n2021-09-02 16:54:19.658577   File \"/usr/local/lib/python3.8/dist-packages/django/core/handlers/base.py\", line 115, in _get_response\n2021-09-02 16:54:19.658581     response \u003d self.process_exception_by_middleware(e, request)\n2021-09-02 16:54:19.658585   File \"/usr/local/lib/python3.8/dist-packages/django/core/handlers/base.py\", line 113, in _get_response\n2021-09-02 16:54:19.658588     response \u003d wrapped_callback(request, *callback_args, **callback_kwargs)\n2021-09-02 16:54:19.658591   File \"/opt/stack/horizon/horizon/decorators.py\", line 52, in dec\n2021-09-02 16:54:19.658595     return view_func(request, *args, **kwargs)\n2021-09-02 16:54:19.658598   File \"/opt/stack/horizon/horizon/decorators.py\", line 36, in dec\n2021-09-02 16:54:19.658601     return view_func(request, *args, **kwargs)\n2021-09-02 16:54:19.658605   File \"/opt/stack/horizon/horizon/decorators.py\", line 36, in dec\n2021-09-02 16:54:19.658608     return view_func(request, *args, **kwargs)\n2021-09-02 16:54:19.658611   File \"/opt/stack/horizon/horizon/decorators.py\", line 112, in dec\n2021-09-02 16:54:19.658615     return view_func(request, *args, **kwargs)\n2021-09-02 16:54:19.658618   File \"/opt/stack/horizon/horizon/decorators.py\", line 84, in dec\n2021-09-02 16:54:19.658621     return view_func(request, *args, **kwargs)\n2021-09-02 16:54:19.658624   File \"/usr/local/lib/python3.8/dist-packages/django/views/generic/base.py\", line 71, in view\n2021-09-02 16:54:19.658628     return self.dispatch(request, *args, **kwargs)\n2021-09-02 16:54:19.658631   File \"/usr/local/lib/python3.8/dist-packages/django/views/generic/base.py\", line 97, in dispatch\n2021-09-02 16:54:19.658635     return handler(request, *args, **kwargs)\n2021-09-02 16:54:19.658638   File \"/usr/local/lib/python3.8/dist-packages/django/views/generic/edit.py\", line 142, in post\n2021-09-02 16:54:19.658642     return self.form_valid(form)\n2021-09-02 16:54:19.658645   File \"/opt/stack/horizon/horizon/forms/views.py\", line 190, in form_valid\n2021-09-02 16:54:19.658649     exceptions.handle(self.request)\n2021-09-02 16:54:19.658652   File \"/opt/stack/horizon/horizon/forms/views.py\", line 187, in form_valid\n2021-09-02 16:54:19.658656     handled \u003d form.handle(self.request, form.cleaned_data)\n2021-09-02 16:54:19.658676   File \"/opt/stack/manila-ui/manila_ui/dashboards/project/shares/forms.py\", line 397, in handle\n2021-09-02 16:54:19.658680     redirect \u003d reverse(\"horizon:project:shares:manage_rules\")\n2021-09-02 16:54:19.658684   File \"/usr/local/lib/python3.8/dist-packages/django/urls/base.py\", line 90, in reverse\n2021-09-02 16:54:19.658687     return iri_to_uri(resolver._reverse_with_prefix(view, prefix, *args, **kwargs))\n2021-09-02 16:54:19.658691   File \"/usr/local/lib/python3.8/dist-packages/django/urls/resolvers.py\", line 673, in _reverse_with_prefix\n2021-09-02 16:54:19.658694     raise NoReverseMatch(msg)\n2021-09-02 16:54:19.658698 django.urls.exceptions.NoReverseMatch: Reverse for \u0027manage_rules\u0027 with no arguments not found. 1 pattern(s) tried: [\u0027project/shares/(?P\u003cshare_id\u003e[^/]+)/rules/$\u0027]","commit_id":"8b5b9cb83be616bdcfd4fb3b9d62fc41a9bcbca4"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"9aede478a0cccb663ec61675b82fcc3bc9e72ef6","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def handle(self, request, data):"},{"line_number":382,"context_line":"        rule_id \u003d self.initial[\u0027rule_id\u0027]"},{"line_number":383,"context_line":"        try:"},{"line_number":384,"context_line":"            rule \u003d manila.share_rule_get(self.request, rule_id)"},{"line_number":385,"context_line":"            set_dict, unset_list \u003d utils.parse_str_meta(data[\u0027metadata\u0027])"},{"line_number":386,"context_line":"            if set_dict:"},{"line_number":387,"context_line":"                manila.share_rule_set_metadata(request, rule, set_dict)"},{"line_number":388,"context_line":"            if unset_list:"},{"line_number":389,"context_line":"                manila.share_rule_unset_metadata(request, rule, unset_list)"},{"line_number":390,"context_line":"            message \u003d _(\u0027Updating share access rule metadata \u0027)"},{"line_number":391,"context_line":"            messages.success(request, message)"},{"line_number":392,"context_line":"            return True"},{"line_number":393,"context_line":"        except ValidationError as e:"},{"line_number":394,"context_line":"            self.api_error(e.messages[0])"},{"line_number":395,"context_line":"            return False"},{"line_number":396,"context_line":"        except Exception:"},{"line_number":397,"context_line":"            redirect \u003d reverse(\"horizon:project:shares:manage_rules\")"},{"line_number":398,"context_line":"            exceptions.handle(request,"},{"line_number":399,"context_line":"                              _(\u0027Unable to update rule metadata.\u0027),"},{"line_number":400,"context_line":"                              redirect\u003dredirect)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"class ResizeForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":14,"id":"1dbe724e_52a1e16b","line":400,"range":{"start_line":383,"start_character":8,"end_line":400,"end_character":48},"in_reply_to":"7c16651a_d7cc2cb1","updated":"2021-09-02 18:43:52.000000000","message":"Hi, Goutham! Thanks for reviewing, will submit follow up patch soon.","commit_id":"8b5b9cb83be616bdcfd4fb3b9d62fc41a9bcbca4"}],"manila_ui/dashboards/project/shares/views.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7276cfcada3dc34f4bfd763fa91164da2493861d","unresolved":true,"context_lines":[{"line_number":267,"context_line":"                self._object \u003d manila.share_rule_get(self.request, rule_id)"},{"line_number":268,"context_line":"            except Exception:"},{"line_number":269,"context_line":"                msg \u003d _(\u0027Unable to retrieve share access rule.\u0027)"},{"line_number":270,"context_line":"                url \u003d reverse(\u0027horizon:project:shares:index\u0027)"},{"line_number":271,"context_line":"                exceptions.handle(self.request, msg, redirect\u003durl)"},{"line_number":272,"context_line":"        return self._object"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"0130623a_5675edfa","line":270,"range":{"start_line":270,"start_character":31,"end_line":270,"end_character":59},"updated":"2021-08-20 02:23:12.000000000","message":"i think here should be: horizon:project:shares:manage_rules\nbecause the page is here when user click edit rule metadata.","commit_id":"4676a0687a79ddefa57de936ea2b59ec04f1ba89"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"74f1dd0500cb0d1cd6b433050ad8b4b3fb623f25","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                self._object \u003d manila.share_rule_get(self.request, rule_id)"},{"line_number":268,"context_line":"            except Exception:"},{"line_number":269,"context_line":"                msg \u003d _(\u0027Unable to retrieve share access rule.\u0027)"},{"line_number":270,"context_line":"                url \u003d reverse(\u0027horizon:project:shares:index\u0027)"},{"line_number":271,"context_line":"                exceptions.handle(self.request, msg, redirect\u003durl)"},{"line_number":272,"context_line":"        return self._object"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3da90c62_1b890a8c","line":270,"range":{"start_line":270,"start_character":31,"end_line":270,"end_character":59},"in_reply_to":"0130623a_5675edfa","updated":"2021-08-20 11:23:16.000000000","message":"thanks haixin, fixed.","commit_id":"4676a0687a79ddefa57de936ea2b59ec04f1ba89"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"456255a449c7964d6c15a7a9b2c3e295e8e8fe28","unresolved":true,"context_lines":[{"line_number":267,"context_line":"                self._object \u003d manila.share_rule_get(self.request, rule_id)"},{"line_number":268,"context_line":"            except Exception:"},{"line_number":269,"context_line":"                msg \u003d _(\u0027Unable to retrieve share access rule.\u0027)"},{"line_number":270,"context_line":"                url \u003d reverse(\u0027horizon:project:shares:manage_rules\u0027)"},{"line_number":271,"context_line":"                exceptions.handle(self.request, msg, redirect\u003durl)"},{"line_number":272,"context_line":"        return self._object"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"d1b1a0dd_33a7434d","line":270,"range":{"start_line":270,"start_character":67,"end_line":270,"end_character":68},"updated":"2021-09-02 17:04:54.000000000","message":"should you add a share.id arg here as well?","commit_id":"8b5b9cb83be616bdcfd4fb3b9d62fc41a9bcbca4"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"9aede478a0cccb663ec61675b82fcc3bc9e72ef6","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                self._object \u003d manila.share_rule_get(self.request, rule_id)"},{"line_number":268,"context_line":"            except Exception:"},{"line_number":269,"context_line":"                msg \u003d _(\u0027Unable to retrieve share access rule.\u0027)"},{"line_number":270,"context_line":"                url \u003d reverse(\u0027horizon:project:shares:manage_rules\u0027)"},{"line_number":271,"context_line":"                exceptions.handle(self.request, msg, redirect\u003durl)"},{"line_number":272,"context_line":"        return self._object"},{"line_number":273,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"139749bd_e173b772","line":270,"range":{"start_line":270,"start_character":67,"end_line":270,"end_character":68},"in_reply_to":"d1b1a0dd_33a7434d","updated":"2021-09-02 18:43:52.000000000","message":"Ack","commit_id":"8b5b9cb83be616bdcfd4fb3b9d62fc41a9bcbca4"}]}