)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"7371b56cba0338b27bc5f5f56620ea06b2fc4e0a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     kafilat-adeleke \u003cadelekekafilatadenike@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-05-01 09:29:21 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API version 2.46, adds default to share share_type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial-Bug: #1920688"},{"line_number":10,"context_line":"Change-Id: Ic0ffc853e0549ff4ae788d3c3969dd469f9dac48"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"80013c83_b99141d8","line":7,"updated":"2021-05-06 15:42:21.000000000","message":"please remove extra word \"share\" here.\nAnd more info, about what is in the change.","commit_id":"c90fcd21d8d82c94725b74e06fd85f2638bfebe6"}],"manila_ui/api/manila.py":[{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"7371b56cba0338b27bc5f5f56620ea06b2fc4e0a","unresolved":true,"context_lines":[{"line_number":404,"context_line":""},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"def share_type_create(request, name, spec_driver_handles_share_servers,"},{"line_number":407,"context_line":"                      is_default\u003dTrue, description\u003dNone, is_public\u003dTrue):"},{"line_number":408,"context_line":"    return manilaclient(request).share_types.create("},{"line_number":409,"context_line":"        name\u003dname,"},{"line_number":410,"context_line":"        description\u003ddescription,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9e1dcac4_fbf2bc9a","line":407,"updated":"2021-05-06 15:42:21.000000000","message":"I think it is more appropriate to set default of \"is_default\" field to False, other defult types might exist. Better not to change the state of is_default if value is not provided.","commit_id":"c90fcd21d8d82c94725b74e06fd85f2638bfebe6"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"96010233d791ae8e1377ac924801aa24ecafe772","unresolved":true,"context_lines":[{"line_number":404,"context_line":""},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"def share_type_create(request, name, spec_driver_handles_share_servers,"},{"line_number":407,"context_line":"                      is_default\u003dFalse, description\u003dNone, is_public\u003dTrue):"},{"line_number":408,"context_line":"    return manilaclient(request).share_types.create("},{"line_number":409,"context_line":"        name\u003dname,"},{"line_number":410,"context_line":"        description\u003ddescription,"}],"source_content_type":"text/x-python","patch_set":4,"id":"6db45793_7254cbe6","line":407,"range":{"start_line":407,"start_character":22,"end_line":407,"end_character":38},"updated":"2021-05-26 01:40:46.000000000","message":"manila client and manila do not support is_default parameter when create share type.\nif you want to set default share type, you should set default_share_type in manila.conf\nand create a share type ,which name is same to the name in configure file.","commit_id":"e914154842b609ac234bc722b4269eeba0963946"}],"manila_ui/dashboards/admin/share_types/forms.py":[{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"7371b56cba0338b27bc5f5f56620ea06b2fc4e0a","unresolved":true,"context_lines":[{"line_number":48,"context_line":"                   \"separately.\"))"},{"line_number":49,"context_line":"    is_default \u003d forms.BooleanField("},{"line_number":50,"context_line":"        label\u003d_(\"Is default\"), required\u003dFalse, initial\u003dFalse,"},{"line_number":51,"context_line":"        help_text\u003d(\"Defines whether this share type is the default.\"))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":54,"context_line":"        super(CreateShareType, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f31ebe3_a3300863","line":51,"updated":"2021-05-06 15:42:21.000000000","message":"please add the translation:_(\"Defines whether this share type is the default.\"))\nAnd maybe wordings should be changed to something like:\n\"Defines whether it should be the default share type.\" What do you think?","commit_id":"c90fcd21d8d82c94725b74e06fd85f2638bfebe6"}],"manila_ui/tests/api/test_manila.py":[{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"7371b56cba0338b27bc5f5f56620ea06b2fc4e0a","unresolved":true,"context_lines":[{"line_number":673,"context_line":"            description\u003dNone,"},{"line_number":674,"context_line":"            is_public\u003dTrue, is_default\u003dTrue)"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    @ddt.data(True, False)"},{"line_number":677,"context_line":"    def test_share_type_create_with_custom_values("},{"line_number":678,"context_line":"            self, dhss):"},{"line_number":679,"context_line":"        name \u003d \u0027fake_share_type_name\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"10f2d19c_08eff8e3","line":676,"updated":"2021-05-06 15:42:21.000000000","message":"here test value for is_default needs to be added to existing test data.","commit_id":"c90fcd21d8d82c94725b74e06fd85f2638bfebe6"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"7371b56cba0338b27bc5f5f56620ea06b2fc4e0a","unresolved":true,"context_lines":[{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    @ddt.data(True, False)"},{"line_number":677,"context_line":"    def test_share_type_create_with_custom_values("},{"line_number":678,"context_line":"            self, dhss):"},{"line_number":679,"context_line":"        name \u003d \u0027fake_share_type_name\u0027"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        api.share_type_create("}],"source_content_type":"text/x-python","patch_set":1,"id":"9c4b0341_3b8be22e","line":678,"updated":"2021-05-06 15:42:21.000000000","message":"please add is_default param here without deleting other existing params.","commit_id":"c90fcd21d8d82c94725b74e06fd85f2638bfebe6"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"7371b56cba0338b27bc5f5f56620ea06b2fc4e0a","unresolved":true,"context_lines":[{"line_number":683,"context_line":""},{"line_number":684,"context_line":"        self.manilaclient.share_types.create.assert_called_once_with("},{"line_number":685,"context_line":"            name\u003dname,"},{"line_number":686,"context_line":"            description\u003dNone,"},{"line_number":687,"context_line":"            spec_driver_handles_share_servers\u003ddhss,"},{"line_number":688,"context_line":"            is_public\u003dTrue, is_default\u003dTrue)"},{"line_number":689,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4acc701f_ab83ac24","line":686,"updated":"2021-05-06 15:42:21.000000000","message":"same, description also needs to tested.","commit_id":"c90fcd21d8d82c94725b74e06fd85f2638bfebe6"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"7371b56cba0338b27bc5f5f56620ea06b2fc4e0a","unresolved":true,"context_lines":[{"line_number":685,"context_line":"            name\u003dname,"},{"line_number":686,"context_line":"            description\u003dNone,"},{"line_number":687,"context_line":"            spec_driver_handles_share_servers\u003ddhss,"},{"line_number":688,"context_line":"            is_public\u003dTrue, is_default\u003dTrue)"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"    def test_share_type_delete(self):"},{"line_number":691,"context_line":"        share_type_id \u003d \"fake_share_type_id\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ee4ddca9_eb0d65c7","line":688,"updated":"2021-05-06 15:42:21.000000000","message":"same","commit_id":"c90fcd21d8d82c94725b74e06fd85f2638bfebe6"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"5a0908d9b05ce9b071d2f95ec0d50761c62d1a29","unresolved":true,"context_lines":[{"line_number":671,"context_line":"            name\u003dname,"},{"line_number":672,"context_line":"            spec_driver_handles_share_servers\u003ddhss,"},{"line_number":673,"context_line":"            description\u003dNone,"},{"line_number":674,"context_line":"            is_public\u003dTrue, is_default\u003dTrue)"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    @ddt.data("},{"line_number":677,"context_line":"        (True, False, \"fake_description\", True),"}],"source_content_type":"text/x-python","patch_set":3,"id":"f7609df9_96edc683","line":674,"updated":"2021-05-18 14:47:10.000000000","message":"Here is the test for default value. Default for is_public field is False in api/manila.py. That is the reason test fails. You should change test to False as you testing here the default value.","commit_id":"7ea3f91b4cb07a075f0aae854ccde14d7e046ce9"}],"manila_ui/tests/dashboards/admin/share_types/test_forms.py":[{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"5a0908d9b05ce9b071d2f95ec0d50761c62d1a29","unresolved":true,"context_lines":[{"line_number":181,"context_line":"            \u0027spec_driver_handles_share_servers\u0027: \u0027True\u0027,"},{"line_number":182,"context_line":"            \u0027name\u0027: \u0027share\u0027,"},{"line_number":183,"context_line":"            \u0027description\u0027: \u0027\u0027,"},{"line_number":184,"context_line":"            \u0027is_default\u0027: False"},{"line_number":185,"context_line":"        }"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        result \u003d form.handle(self.request, data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0de63210_a73dfdbb","line":184,"updated":"2021-05-18 14:47:10.000000000","message":"Put comma at the end of dictionary\nhttps://docs.openstack.org/charm-guide/latest/coding-guidelines.html#ensure-there-s-a-comma-on-the-last-item-of-a-dictionary","commit_id":"7ea3f91b4cb07a075f0aae854ccde14d7e046ce9"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"5a0908d9b05ce9b071d2f95ec0d50761c62d1a29","unresolved":true,"context_lines":[{"line_number":204,"context_line":"                \u0027is_default\u0027: False,"},{"line_number":205,"context_line":"                \u0027spec_driver_handles_share_servers\u0027: \u0027True\u0027,"},{"line_number":206,"context_line":"                \u0027description\u0027: \u0027st_description\u0027,"},{"line_number":207,"context_line":"                \u0027name\u0027: \u0027share\u0027}"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        result \u003d form.handle(self.request, data)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"16918a1b_855d4d62","line":207,"updated":"2021-05-18 14:47:10.000000000","message":"Comma","commit_id":"7ea3f91b4cb07a075f0aae854ccde14d7e046ce9"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"5a0908d9b05ce9b071d2f95ec0d50761c62d1a29","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                \u0027spec_driver_handles_share_servers\u0027: \u0027True\u0027,"},{"line_number":238,"context_line":"                \u0027name\u0027: \u0027share\u0027,"},{"line_number":239,"context_line":"                \u0027description\u0027: \u0027\u0027,"},{"line_number":240,"context_line":"                \u0027is_default\u0027: True"},{"line_number":241,"context_line":"            }"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"            result \u003d form.handle(self.request, data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"66b31a52_fa376713","line":240,"updated":"2021-05-18 14:47:10.000000000","message":"Comma","commit_id":"7ea3f91b4cb07a075f0aae854ccde14d7e046ce9"}],"manila_ui/tests/dashboards/admin/share_types/tests.py":[{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"5a0908d9b05ce9b071d2f95ec0d50761c62d1a29","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            \u0027name\u0027: \u0027my_share_type\u0027,"},{"line_number":53,"context_line":"            \u0027description\u0027: \u0027share_type_description\u0027,"},{"line_number":54,"context_line":"            \u0027spec_driver_handles_share_servers\u0027: \u0027False\u0027,"},{"line_number":55,"context_line":"            \u0027is_default\u0027: True"},{"line_number":56,"context_line":"        }"},{"line_number":57,"context_line":"        form_data \u003d data.copy()"},{"line_number":58,"context_line":"        form_data[\u0027spec_driver_handles_share_servers\u0027] \u003d \u0027false\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"d4aa6795_4c22913b","line":55,"updated":"2021-05-18 14:47:10.000000000","message":"Also comma","commit_id":"7ea3f91b4cb07a075f0aae854ccde14d7e046ce9"}]}