)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9a516fd2a6cd6dac1b806e6d38c2976f933b7e6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaix09@chinatelecom.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-20 17:41:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Api 2.65, Add Share Affinity/Anti-Affinity Scheduler Filters when create share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7bfcc1b94a4a8a709f26080cfcc192d5d7834700"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"593e11aa_295455c8","line":7,"range":{"start_line":7,"start_character":53,"end_line":7,"end_character":60},"updated":"2021-10-25 23:54:45.000000000","message":"hints","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5990e0b8a0f6bd4d8855c15bdd1104261adf1709","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaix09@chinatelecom.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-10-20 17:41:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Api 2.65, Add Share Affinity/Anti-Affinity Scheduler Filters when create share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7bfcc1b94a4a8a709f26080cfcc192d5d7834700"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"eb2fb28f_5e03a979","line":7,"range":{"start_line":7,"start_character":53,"end_line":7,"end_character":60},"in_reply_to":"593e11aa_295455c8","updated":"2021-10-26 01:37:15.000000000","message":"Done","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9a516fd2a6cd6dac1b806e6d38c2976f933b7e6","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-20 17:41:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Api 2.65, Add Share Affinity/Anti-Affinity Scheduler Filters when create share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7bfcc1b94a4a8a709f26080cfcc192d5d7834700"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"0dee8462_4c05b1b2","line":8,"updated":"2021-10-25 23:54:45.000000000","message":"Implements: bp/affinity-antiaffinity-filter","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5990e0b8a0f6bd4d8855c15bdd1104261adf1709","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-20 17:41:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Api 2.65, Add Share Affinity/Anti-Affinity Scheduler Filters when create share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7bfcc1b94a4a8a709f26080cfcc192d5d7834700"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5b29e0bf_35250d2a","line":8,"in_reply_to":"0dee8462_4c05b1b2","updated":"2021-10-26 01:37:15.000000000","message":"Done","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b8f0ac63274a161a2e28205b5b3be48858b9c19","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     haixin \u003chaix09@chinatelecom.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-01 14:52:27 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Api 2.65, Add Share Affinity/Anti-Affinity Scheduler hints when create share"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: bp/affinity-antiaffinity-filter"},{"line_number":10,"context_line":"Change-Id: I7bfcc1b94a4a8a709f26080cfcc192d5d7834700"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"f6270232_e058829b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":76},"updated":"2022-01-14 03:32:21.000000000","message":"nit: keep under 50 chars","commit_id":"e6e02ffbfc885cbd2bcef5025578744ea1c328f7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9a516fd2a6cd6dac1b806e6d38c2976f933b7e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e13f3179_16725583","updated":"2021-10-25 23:54:45.000000000","message":"Thank you for working on this haixin! Please see a design question inline?","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5fb4f53654d2968613a9686b94d37d1ecf25c8e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"83b0980a_9ddc7160","updated":"2021-10-24 02:05:13.000000000","message":"hi, Kiran Pawar.\nthanks for your review.","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5990e0b8a0f6bd4d8855c15bdd1104261adf1709","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c27e202c_0f3df979","updated":"2021-10-26 01:37:15.000000000","message":"hi, Goutham Pacha Ravi.\nthanks for your review.","commit_id":"afa172fa26a48ac956fda8b298cd94831d866a96"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"98eafc74316710228a33a63fcaeb9d05c1947906","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"76cbcf6e_0ceafefa","updated":"2021-10-26 08:08:32.000000000","message":"recheck","commit_id":"afa172fa26a48ac956fda8b298cd94831d866a96"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b6c142c63777a79fd22de776c1d27f9c5ad73eed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1ae0b364_9ec1303c","updated":"2022-07-07 12:38:19.000000000","message":"Nothing more to add more than already has been pointed.","commit_id":"e6e02ffbfc885cbd2bcef5025578744ea1c328f7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b8f0ac63274a161a2e28205b5b3be48858b9c19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"57e532db_002f09df","updated":"2022-01-14 03:32:21.000000000","message":"This looks good and works well, Haixin. I\u0027ve a couple of questions for you inline.. ","commit_id":"e6e02ffbfc885cbd2bcef5025578744ea1c328f7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ff1ba423cb3c63ba7d6ef0594133ea6202951b5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d71545ba_1a4ad144","updated":"2021-12-15 19:19:37.000000000","message":"recheck\n\n","commit_id":"e6e02ffbfc885cbd2bcef5025578744ea1c328f7"}],"manila_ui/api/manila.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b8f0ac63274a161a2e28205b5b3be48858b9c19","unresolved":true,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MANILA_UI_USER_AGENT_REPR \u003d \"manila_ui_plugin_for_horizon\""},{"line_number":31,"context_line":"MANILA_VERSION \u003d \"2.65\""},{"line_number":32,"context_line":"MANILA_SERVICE_TYPE \u003d \"sharev2\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# API static values"}],"source_content_type":"text/x-python","patch_set":12,"id":"b0b15f51_fe091575","line":31,"range":{"start_line":31,"start_character":17,"end_line":31,"end_character":23},"updated":"2022-01-14 03:32:21.000000000","message":"we\u0027d have to bump the minimum version of python-manilaclient to support this microversion: https://opendev.org/openstack/manila-ui/src/branch/master/requirements.txt#L11","commit_id":"e6e02ffbfc885cbd2bcef5025578744ea1c328f7"}],"manila_ui/dashboards/project/shares/forms.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9a516fd2a6cd6dac1b806e6d38c2976f933b7e6","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.fields[\u0027scheduler_hints_same_host\u0027] \u003d forms.CharField("},{"line_number":121,"context_line":"            label\u003d_(\"Scheduler Hints Same Host\"), required\u003dFalse,"},{"line_number":122,"context_line":"            widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 3}))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.fields[\u0027scheduler_hints_different_host\u0027] \u003d forms.CharField("},{"line_number":125,"context_line":"            label\u003d_(\"Scheduler Hints Different Host\"), required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":6,"id":"448d6f54_6120e9a1","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":53},"updated":"2021-10-25 23:54:45.000000000","message":"Since we know what shares exist, it might be easier if we allowed users to pick from a set of share name/share IDs rather than provide a text area input. What do you think?\n\nis it too cumbersome to have a multi-select field with something like the ThemableCheckboxSelectMultiple widget perhaps?","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"55bc5bfc085051ac97e1bb492c83269dab77eb8e","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.fields[\u0027scheduler_hints_same_host\u0027] \u003d forms.CharField("},{"line_number":121,"context_line":"            label\u003d_(\"Scheduler Hints Same Host\"), required\u003dFalse,"},{"line_number":122,"context_line":"            widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 3}))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.fields[\u0027scheduler_hints_different_host\u0027] \u003d forms.CharField("},{"line_number":125,"context_line":"            label\u003d_(\"Scheduler Hints Different Host\"), required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":6,"id":"918456a8_03807b04","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":53},"in_reply_to":"3b32e0a9_7478a3a9","updated":"2021-10-27 20:01:32.000000000","message":"yes, MultipleChoiceField also will work I think, as it takes choices argument as well and takes any SelectMultiple widget. So multiple shares can be selected. https://docs.djangoproject.com/en/3.2/ref/forms/fields/#multiplechoicefield","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5990e0b8a0f6bd4d8855c15bdd1104261adf1709","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.fields[\u0027scheduler_hints_same_host\u0027] \u003d forms.CharField("},{"line_number":121,"context_line":"            label\u003d_(\"Scheduler Hints Same Host\"), required\u003dFalse,"},{"line_number":122,"context_line":"            widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 3}))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.fields[\u0027scheduler_hints_different_host\u0027] \u003d forms.CharField("},{"line_number":125,"context_line":"            label\u003d_(\"Scheduler Hints Different Host\"), required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d153b3d5_b07c125c","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":53},"in_reply_to":"448d6f54_6120e9a1","updated":"2021-10-26 01:37:15.000000000","message":"I thought about it during development, However, first of all, it would be complicated and I have no experience. Secondly, in the use of this function, users usually only write two or three shares, which are a small amount. The current design can also meet the needs, and it is not troublesome.","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6b17ea1791fec174d7a7c380f5a57f8ede558a5","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.fields[\u0027scheduler_hints_same_host\u0027] \u003d forms.CharField("},{"line_number":121,"context_line":"            label\u003d_(\"Scheduler Hints Same Host\"), required\u003dFalse,"},{"line_number":122,"context_line":"            widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 3}))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.fields[\u0027scheduler_hints_different_host\u0027] \u003d forms.CharField("},{"line_number":125,"context_line":"            label\u003d_(\"Scheduler Hints Different Host\"), required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3b32e0a9_7478a3a9","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":53},"in_reply_to":"4979841f_c9e633e5","updated":"2021-10-27 19:42:22.000000000","message":"Thank you Dina! \n\nWe want to allow selecting multiple shares, would \"MultipleChoiceField\" be usable here? or can ChoiceField do the job?\n\nhttps://docs.djangoproject.com/en/dev/ref/forms/fields/#multiplechoicefield","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"7a57630e994956b2a7d74e717dd2d00d19d57768","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.fields[\u0027scheduler_hints_same_host\u0027] \u003d forms.CharField("},{"line_number":121,"context_line":"            label\u003d_(\"Scheduler Hints Same Host\"), required\u003dFalse,"},{"line_number":122,"context_line":"            widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 3}))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.fields[\u0027scheduler_hints_different_host\u0027] \u003d forms.CharField("},{"line_number":125,"context_line":"            label\u003d_(\"Scheduler Hints Different Host\"), required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":6,"id":"14d99fc0_a8cf8b7f","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":53},"in_reply_to":"918456a8_03807b04","updated":"2021-10-28 01:15:08.000000000","message":"thanks,Goutham and Dina, i will try to use it.","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":32531,"name":"Dina Saparbaeva","email":"dinas27@outlook.com","username":"disap"},"change_message_id":"662bab69f03565ea2b23d19ccdd634419a8fd167","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.fields[\u0027scheduler_hints_same_host\u0027] \u003d forms.CharField("},{"line_number":121,"context_line":"            label\u003d_(\"Scheduler Hints Same Host\"), required\u003dFalse,"},{"line_number":122,"context_line":"            widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 3}))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.fields[\u0027scheduler_hints_different_host\u0027] \u003d forms.CharField("},{"line_number":125,"context_line":"            label\u003d_(\"Scheduler Hints Different Host\"), required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":6,"id":"4979841f_c9e633e5","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":53},"in_reply_to":"bf29981b_ffd7fe23","updated":"2021-10-27 18:25:59.000000000","message":"Hi,I understand you want to get here list of shares.You can do here something like below:\nshare_list \u003d manila.share_list(request)\nself.fields[\u0027scheduler_hints_same_host\u0027] \u003d forms.ChoiceField(\n        label\u003d_(\"Share\"),#or some other label\n        choices \u003d [(\"\", \"\")] + [(share.name, share.id) for share in share_list],\n        required\u003dTrue)\n\nThen here you will display share names as dropdown list and send the share id to your function.\nhttps://docs.djangoproject.com/en/3.2/ref/forms/fields/#choicefield","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6b359a953edc392aca378aeb5907504f15b1a9b0","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.fields[\u0027scheduler_hints_same_host\u0027] \u003d forms.CharField("},{"line_number":121,"context_line":"            label\u003d_(\"Scheduler Hints Same Host\"), required\u003dFalse,"},{"line_number":122,"context_line":"            widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 3}))"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        self.fields[\u0027scheduler_hints_different_host\u0027] \u003d forms.CharField("},{"line_number":125,"context_line":"            label\u003d_(\"Scheduler Hints Different Host\"), required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf29981b_ffd7fe23","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":53},"in_reply_to":"d153b3d5_b07c125c","updated":"2021-10-26 21:01:16.000000000","message":"Ack - agreed - thank you for explaining the issue; lets check with Victoria/Dina if they have any suggestions. My concern would be about the user having to remember (or copy-paste) the names or IDs of the shares they want to use as hints; and having seen the validation you\u0027re doing in https://review.opendev.org/c/openstack/manila-ui/+/814694/6/manila_ui/dashboards/utils.py , it could be easier for users if we can present the curated list instead of the validation.","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b8f0ac63274a161a2e28205b5b3be48858b9c19","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            label\u003d_(\"Metadata\"), required\u003dFalse,"},{"line_number":119,"context_line":"            widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 4}))"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        self.fields[\"scheduler_hints_same_host\"] \u003d forms.MultipleChoiceField("},{"line_number":122,"context_line":"            label\u003d_(\"Scheduler Hints Same Host\"), required\u003dFalse,"},{"line_number":123,"context_line":"            widget\u003dforms.ThemableCheckboxSelectMultiple())"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.fields[\"scheduler_hints_different_host\"] \u003d ("},{"line_number":126,"context_line":"            forms.MultipleChoiceField("},{"line_number":127,"context_line":"                label\u003d_(\"Scheduler Hints Different Host\"), required\u003dFalse,"},{"line_number":128,"context_line":"                widget\u003dforms.ThemableCheckboxSelectMultiple()))"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        search_opts \u003d {\u0027all_tenants\u0027: 1}"},{"line_number":131,"context_line":"        all_shares \u003d manila.share_list(request, search_opts\u003dsearch_opts)"}],"source_content_type":"text/x-python","patch_set":12,"id":"43276325_26af9d10","line":128,"range":{"start_line":121,"start_character":8,"end_line":128,"end_character":63},"updated":"2022-01-14 03:32:21.000000000","message":"is it possible to hide these fields if there are no shares? it looks a bit confusing to see these when there\u0027s nothing to populate","commit_id":"e6e02ffbfc885cbd2bcef5025578744ea1c328f7"}],"manila_ui/dashboards/project/shares/templates/shares/_limits.html":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b8f0ac63274a161a2e28205b5b3be48858b9c19","unresolved":true,"context_lines":[{"line_number":14,"context_line":"\u003ch3\u003e{% trans \"Scheduler Hints Same/Different Host\" %}:\u003c/h3\u003e"},{"line_number":15,"context_line":"  \u003cp\u003e"},{"line_number":16,"context_line":"    {% trans \"Chose one or more shares to apply \" %}\u003cbr /\u003e"},{"line_number":17,"context_line":"    {% trans \"Affinity/Anti-Affinity Filters:\" %}"},{"line_number":18,"context_line":"  \u003c/p\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\u003ch3\u003e{% trans \"Share Limits\" %}\u003c/h3\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"5146d56c_391b0807","line":17,"range":{"start_line":17,"start_character":44,"end_line":17,"end_character":45},"updated":"2022-01-14 03:32:21.000000000","message":"no need for this \":\", there\u0027s nothing more to add here","commit_id":"e6e02ffbfc885cbd2bcef5025578744ea1c328f7"}],"manila_ui/dashboards/utils.py":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d7c5bb8d1b53e1a7480aaf8bd22b9d442e0d08fb","unresolved":true,"context_lines":[{"line_number":147,"context_line":"                share \u003d manila.share_get(request, tmp_id)"},{"line_number":148,"context_line":"                sh_uuid_list.append(share.id)"},{"line_number":149,"context_line":"            else:"},{"line_number":150,"context_line":"                search_opts \u003d {\u0027all_tenants\u0027: 1}"},{"line_number":151,"context_line":"                shares \u003d manila.share_list(request, search_opts\u003dsearch_opts)"},{"line_number":152,"context_line":"                for sh in shares:"},{"line_number":153,"context_line":"                    if sh.name \u003d\u003d tmp_id:"}],"source_content_type":"text/x-python","patch_set":6,"id":"af9ee4e8_0d1c53fc","line":150,"updated":"2021-10-23 18:36:15.000000000","message":"Do you need to initialize matches \u003d [] at this point ?","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5fb4f53654d2968613a9686b94d37d1ecf25c8e5","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                share \u003d manila.share_get(request, tmp_id)"},{"line_number":148,"context_line":"                sh_uuid_list.append(share.id)"},{"line_number":149,"context_line":"            else:"},{"line_number":150,"context_line":"                search_opts \u003d {\u0027all_tenants\u0027: 1}"},{"line_number":151,"context_line":"                shares \u003d manila.share_list(request, search_opts\u003dsearch_opts)"},{"line_number":152,"context_line":"                for sh in shares:"},{"line_number":153,"context_line":"                    if sh.name \u003d\u003d tmp_id:"}],"source_content_type":"text/x-python","patch_set":6,"id":"b9a007e8_fa10edcb","line":150,"in_reply_to":"af9ee4e8_0d1c53fc","updated":"2021-10-24 02:05:13.000000000","message":"matches \u003d [] has been initialized in line 142.\nso i do not think we need initialize here again.","commit_id":"fb8d751496b6e8051697ac12865e29437788026c"}],"releasenotes/notes/add-share-affinity-antiaffinity-scheduler-filters-a58b9b7b37828498.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6b294f4a925eae61696d78ba60f1c70e71c59cb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The Scheduler Hints can be used for create share with API version ``2.65``"},{"line_number":5,"context_line":"    and beyond."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"aaeea157_ecf71efe","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":15},"updated":"2022-01-14 03:33:51.000000000","message":"there\u0027s no way for manila ui deployers or users to set API microversions, we hard code it. So perhaps say:\n\n\"Scheduler hints to specify affinity/anti-affinity are now supported while creating shares.\"","commit_id":"e6e02ffbfc885cbd2bcef5025578744ea1c328f7"}]}