)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34524,"name":"Shkoh Hamasoor","email":"shkoh.hamasoor@ndus.edu","username":"shkohy"},"change_message_id":"dac3b725d304b4d21c19be5c16452f407bb0ffc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7091746_f580cfd2","updated":"2022-04-27 14:36:33.000000000","message":"Hello Carlos,\nThank you for reviewing the code and going through it. I have changed each file you have recommended. \nThank you,\nShkoh Hamasoor","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a043c057db3e039472d27621bf1d7c62cba3d0de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7cd21d55_6954b5c7","updated":"2022-04-25 16:11:42.000000000","message":"Thank you for working on this change :)\nFew comments inline for you, please take a look at them","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"ece7ec37f5ee507fbd6ab4065ea03bb05144fb91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6318ded8_4fdec1ce","updated":"2022-04-27 19:26:16.000000000","message":"Thanks for the contribution Shkoh. I\u0027d suggest we follow this example [0] to create tabs within the Detailed view for the Share Network in which we show an Overview (current info) and a Subnets table (the info that wants to be added). For that we need to change the class of the view (it has to be TabbedTableView). In order to the changes to be visible, we need to update views.py and _detail.html. That should be enough. It\u0027s recommended you try an iterative approach in which you add changes little by little and test the outcome. I will follow up with more reviews.\n\n[0] https://github.com/openstack/horizon/tree/master/openstack_dashboard/dashboards/project/networks/templates/networks","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2e89d45e1548836c45a45b4f01c6f259de839a7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"449d3c2c_07031f21","in_reply_to":"30e954bc_17707a65","updated":"2022-04-28 08:06:07.000000000","message":"Oh no, I just mentioned we can follow the example of how information is displayed in the networks detail panel (that is for neutron) and apply that idea to what we are doing in share networks detail panel. I\u0027ll try to submit a sample to follow and we can work over that.","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":34524,"name":"Shkoh Hamasoor","email":"shkoh.hamasoor@ndus.edu","username":"shkohy"},"change_message_id":"94e57e42847234a1aa161ba9f4ec4541a7ef39da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"30e954bc_17707a65","in_reply_to":"6318ded8_4fdec1ce","updated":"2022-04-27 23:06:59.000000000","message":"Hi Victoria,\nI have been working on the code for a while now with your suggestions in mind, and I seem to be stuck on a few things. First inside _detail.html file. I created this code here:\n\n\u003c!added\u003e\n{% if share_network.ShareNetworkSubnetsView %}\n   \u003cdiv class \u003d\"detail\"\u003e\n     \u003ch4\u003e{% trans \"Subnet Table\" %}\u003c/h4\u003e\n     \u003chr class\u003d\"header_rule\"\u003e\n     \u003cdl class\u003d\"dl-horizontal\"\u003e\n       \u003cdiv class\u003d\"row\"\u003e\n           \u003cdiv class\u003d\"col-sm-12\"\u003e\n     {% for ShareNetworkSubnetView in ShareNetworkSubnetsView %}\n           {% url \u0027horizon:project:networks_subnets:_detail_overview\u0027 \n           ShareNetworkSubnetsView.id as ShareNetworkSubnetsView_url %}\n     {% endfor %}\n           \u003c/div\u003e\n       \u003c/div\u003e \n     \u003c/dl\u003e  \n   \u003c/div\u003e\n{% endif %}\n\n\nWhat I am understood from your message is that the information we want to show is already there in Horizon/networks. So would it be correct to try and get that information with this for loop and get the URL from the networks page? Or did I misunderstand your message. Second question is. I have changed the class ShareNetworkSubnetsView and added (tabs.TabbedTableView) is that what you wanted me to do? Or would you want me to change the ShareNetworkView? Because when I try to change ShareNetworkView I need to add an __init__ and I think a self.table_classes. I\u0027m not too sure why, but when I added that HTML code, I stopped getting that __init__ error. Also, nothing is currently being shown on the page.","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"}],"manila_ui/dashboards/project/share_networks/tables.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a043c057db3e039472d27621bf1d7c62cba3d0de","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        \"network_type\", verbose_name\u003d_(\"Network Type\"))"},{"line_number":103,"context_line":"    segmentation_id \u003d tables.Column("},{"line_number":104,"context_line":"        \"segmentation_id\", verbose_name\u003d_(\"Segmentation Id\"))"},{"line_number":105,"context_line":"    availability_id \u003d tables.Column(\"availability_zone_id\", verbose_name\u003d_(\"AZ\")) "},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def get_object_display(self, share_network_subnet):"},{"line_number":108,"context_line":"        return str(share_network_subnet.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9618bbca_7f799b2a","line":105,"range":{"start_line":105,"start_character":60,"end_line":105,"end_character":82},"updated":"2022-04-25 16:11:42.000000000","message":"Please break the line here due to the 79 characters limit.\nAlso, please remove the trailing white space at the end of the line\n[1] https://docs.openstack.org/doc-contrib-guide/rst-conv/general-guidelines.html","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":34524,"name":"Shkoh Hamasoor","email":"shkoh.hamasoor@ndus.edu","username":"shkohy"},"change_message_id":"dac3b725d304b4d21c19be5c16452f407bb0ffc6","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \"network_type\", verbose_name\u003d_(\"Network Type\"))"},{"line_number":103,"context_line":"    segmentation_id \u003d tables.Column("},{"line_number":104,"context_line":"        \"segmentation_id\", verbose_name\u003d_(\"Segmentation Id\"))"},{"line_number":105,"context_line":"    availability_id \u003d tables.Column(\"availability_zone_id\", verbose_name\u003d_(\"AZ\")) "},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def get_object_display(self, share_network_subnet):"},{"line_number":108,"context_line":"        return str(share_network_subnet.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"838ce355_66ff82c8","line":105,"range":{"start_line":105,"start_character":60,"end_line":105,"end_character":82},"in_reply_to":"9618bbca_7f799b2a","updated":"2022-04-27 14:36:33.000000000","message":"Done","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a043c057db3e039472d27621bf1d7c62cba3d0de","unresolved":true,"context_lines":[{"line_number":113,"context_line":"    class Meta(object):"},{"line_number":114,"context_line":"        name \u003d \"share_network_subnets\""},{"line_number":115,"context_line":"        verbose_name \u003d _(\"Share Networks subnets\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class ShareNetworksTable(tables.DataTable):"},{"line_number":119,"context_line":"    STATUS_CHOICES \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa98d80_cab46dc0","line":116,"updated":"2022-04-25 16:11:42.000000000","message":"Missing the similar to row_class \u003d UpdateRow field here... You\u0027ll possibly need to implement a method to get data for it as well","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":34524,"name":"Shkoh Hamasoor","email":"shkoh.hamasoor@ndus.edu","username":"shkohy"},"change_message_id":"dac3b725d304b4d21c19be5c16452f407bb0ffc6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    class Meta(object):"},{"line_number":114,"context_line":"        name \u003d \"share_network_subnets\""},{"line_number":115,"context_line":"        verbose_name \u003d _(\"Share Networks subnets\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class ShareNetworksTable(tables.DataTable):"},{"line_number":119,"context_line":"    STATUS_CHOICES \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3803286e_6aaf62cd","line":116,"in_reply_to":"1fa98d80_cab46dc0","updated":"2022-04-27 14:36:33.000000000","message":"Done","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":34524,"name":"Shkoh Hamasoor","email":"shkoh.hamasoor@ndus.edu","username":"shkohy"},"change_message_id":"115262de1259ee8c943157c0fd4fc0b45565964c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    class Meta(object):"},{"line_number":114,"context_line":"        name \u003d \"share_network_subnets\""},{"line_number":115,"context_line":"        verbose_name \u003d _(\"Share Networks subnets\")"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class ShareNetworksTable(tables.DataTable):"},{"line_number":119,"context_line":"    STATUS_CHOICES \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"a34a2110_fbdf5661","line":116,"in_reply_to":"3803286e_6aaf62cd","updated":"2022-04-27 14:38:22.000000000","message":"class Meta(object):\n        row_class \u003d sn_tables.UpdateRow\n        row_actions \u003d (\n            sn_tables.EditShareNetwork,\n            sn_tables.Delete,\n        ) #added to get data from table to delete table row.\n        name \u003d \"share_network_subnets\"\n        verbose_name \u003d _(\"Share Networks subnets\")\n\nWould this work for the mentioned patchset?","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a043c057db3e039472d27621bf1d7c62cba3d0de","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    name \u003d tables.WrappingColumn("},{"line_number":132,"context_line":"        \"name\", verbose_name\u003d_(\"Name\"),"},{"line_number":133,"context_line":"        link\u003d\"horizon:project:share_networks:share_network_detail\")"},{"line_number":134,"context_line":"    #neutron_net \u003d tables.Column(\"neutron_net\", verbose_name\u003d_(\"Neutron Net\"))"},{"line_number":135,"context_line":"    #neutron_subnet \u003d tables.Column("},{"line_number":136,"context_line":"    #    \"neutron_subnet\", verbose_name\u003d_(\"Neutron Subnet\"))"},{"line_number":137,"context_line":"    #ip_version \u003d tables.Column(\"ip_version\", verbose_name\u003d_(\"IP Version\"))"},{"line_number":138,"context_line":"    #network_type \u003d tables.Column("},{"line_number":139,"context_line":"    #    \"network_type\", verbose_name\u003d_(\"Network Type\"))"},{"line_number":140,"context_line":"    #segmentation_id \u003d tables.Column("},{"line_number":141,"context_line":"    #    \"segmentation_id\", verbose_name\u003d_(\"Segmentation Id\"))"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def get_object_display(self, share_network):"},{"line_number":144,"context_line":"        return share_network.name or str(share_network.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"36ed2162_4e96522c","line":141,"range":{"start_line":134,"start_character":4,"end_line":141,"end_character":62},"updated":"2022-04-25 16:11:42.000000000","message":"you can remove this code block, since it\u0027s going to belong to share network subnets now","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":34524,"name":"Shkoh Hamasoor","email":"shkoh.hamasoor@ndus.edu","username":"shkohy"},"change_message_id":"dac3b725d304b4d21c19be5c16452f407bb0ffc6","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    name \u003d tables.WrappingColumn("},{"line_number":132,"context_line":"        \"name\", verbose_name\u003d_(\"Name\"),"},{"line_number":133,"context_line":"        link\u003d\"horizon:project:share_networks:share_network_detail\")"},{"line_number":134,"context_line":"    #neutron_net \u003d tables.Column(\"neutron_net\", verbose_name\u003d_(\"Neutron Net\"))"},{"line_number":135,"context_line":"    #neutron_subnet \u003d tables.Column("},{"line_number":136,"context_line":"    #    \"neutron_subnet\", verbose_name\u003d_(\"Neutron Subnet\"))"},{"line_number":137,"context_line":"    #ip_version \u003d tables.Column(\"ip_version\", verbose_name\u003d_(\"IP Version\"))"},{"line_number":138,"context_line":"    #network_type \u003d tables.Column("},{"line_number":139,"context_line":"    #    \"network_type\", verbose_name\u003d_(\"Network Type\"))"},{"line_number":140,"context_line":"    #segmentation_id \u003d tables.Column("},{"line_number":141,"context_line":"    #    \"segmentation_id\", verbose_name\u003d_(\"Segmentation Id\"))"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def get_object_display(self, share_network):"},{"line_number":144,"context_line":"        return share_network.name or str(share_network.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"807c018c_0bf2f11b","line":141,"range":{"start_line":134,"start_character":4,"end_line":141,"end_character":62},"in_reply_to":"36ed2162_4e96522c","updated":"2022-04-27 14:36:33.000000000","message":"Done","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"}],"manila_ui/dashboards/project/share_networks/templates/share_networks/_detail.html":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a043c057db3e039472d27621bf1d7c62cba3d0de","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    \u003c/div\u003e"},{"line_number":76,"context_line":"{% endif %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":80,"context_line":"  \u003cdiv class\u003d\"col-sm-12\"\u003e"},{"line_number":81,"context_line":"  {{ share_network_subnets_table.render}}"},{"line_number":82,"context_line":"  \u003c/div\u003e"},{"line_number":83,"context_line":"\u003c/div\u003e"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/html","patch_set":1,"id":"638a4cd4_6ff2b76f","line":84,"range":{"start_line":78,"start_character":0,"end_line":84,"end_character":0},"updated":"2022-04-25 16:11:42.000000000","message":"this is being repeated to the one above...","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":34524,"name":"Shkoh Hamasoor","email":"shkoh.hamasoor@ndus.edu","username":"shkohy"},"change_message_id":"dac3b725d304b4d21c19be5c16452f407bb0ffc6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    \u003c/div\u003e"},{"line_number":76,"context_line":"{% endif %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":80,"context_line":"  \u003cdiv class\u003d\"col-sm-12\"\u003e"},{"line_number":81,"context_line":"  {{ share_network_subnets_table.render}}"},{"line_number":82,"context_line":"  \u003c/div\u003e"},{"line_number":83,"context_line":"\u003c/div\u003e"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/html","patch_set":1,"id":"0332830c_bacd9f4f","line":84,"range":{"start_line":78,"start_character":0,"end_line":84,"end_character":0},"in_reply_to":"638a4cd4_6ff2b76f","updated":"2022-04-27 14:36:33.000000000","message":"Done","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"}],"manila_ui/dashboards/project/share_networks/templates/share_networks/index.html":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a043c057db3e039472d27621bf1d7c62cba3d0de","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"tests\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"\u003cdiv class\u003d\"row\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"a1c09aa6_99922b22","line":3,"range":{"start_line":3,"start_character":27,"end_line":3,"end_character":32},"updated":"2022-04-25 16:11:42.000000000","message":"Please switch it back to Share Networks","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":34524,"name":"Shkoh Hamasoor","email":"shkoh.hamasoor@ndus.edu","username":"shkohy"},"change_message_id":"dac3b725d304b4d21c19be5c16452f407bb0ffc6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"tests\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block main %}"},{"line_number":6,"context_line":"\u003cdiv class\u003d\"row\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"4c384127_cf0f8218","line":3,"range":{"start_line":3,"start_character":27,"end_line":3,"end_character":32},"in_reply_to":"a1c09aa6_99922b22","updated":"2022-04-27 14:36:33.000000000","message":"Done","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"}],"manila_ui/dashboards/project/share_networks/views.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a043c057db3e039472d27621bf1d7c62cba3d0de","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        sn_tables.ShareNetworksTable,"},{"line_number":37,"context_line":"    )"},{"line_number":38,"context_line":"    template_name \u003d \"admin/share_networks/index.html\""},{"line_number":39,"context_line":"    page_title \u003d _(\"tests\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @memoized.memoized_method"},{"line_number":42,"context_line":"    def get_share_networks_data(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4824a3ae_9be1b84b","line":39,"range":{"start_line":39,"start_character":20,"end_line":39,"end_character":25},"updated":"2022-04-25 16:11:42.000000000","message":"Please undo this change","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":34524,"name":"Shkoh Hamasoor","email":"shkoh.hamasoor@ndus.edu","username":"shkohy"},"change_message_id":"dac3b725d304b4d21c19be5c16452f407bb0ffc6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        sn_tables.ShareNetworksTable,"},{"line_number":37,"context_line":"    )"},{"line_number":38,"context_line":"    template_name \u003d \"admin/share_networks/index.html\""},{"line_number":39,"context_line":"    page_title \u003d _(\"tests\")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @memoized.memoized_method"},{"line_number":42,"context_line":"    def get_share_networks_data(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"61447a66_7fdea2de","line":39,"range":{"start_line":39,"start_character":20,"end_line":39,"end_character":25},"in_reply_to":"4824a3ae_9be1b84b","updated":"2022-04-27 14:36:33.000000000","message":"Done","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a043c057db3e039472d27621bf1d7c62cba3d0de","unresolved":true,"context_lines":[{"line_number":155,"context_line":"        share_network_id \u003d self.kwargs[\u0027share_network_id\u0027]"},{"line_number":156,"context_line":"        return manila.share_network_subnet_list("},{"line_number":157,"context_line":"            self.request, share_network_id)"},{"line_number":158,"context_line":"        "},{"line_number":159,"context_line":"    "}],"source_content_type":"text/x-python","patch_set":1,"id":"f9daa593_b66a56a9","line":159,"range":{"start_line":158,"start_character":0,"end_line":159,"end_character":4},"updated":"2022-04-25 16:11:42.000000000","message":"please remove this trailing whitespaces","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"},{"author":{"_account_id":34524,"name":"Shkoh Hamasoor","email":"shkoh.hamasoor@ndus.edu","username":"shkohy"},"change_message_id":"dac3b725d304b4d21c19be5c16452f407bb0ffc6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        share_network_id \u003d self.kwargs[\u0027share_network_id\u0027]"},{"line_number":156,"context_line":"        return manila.share_network_subnet_list("},{"line_number":157,"context_line":"            self.request, share_network_id)"},{"line_number":158,"context_line":"        "},{"line_number":159,"context_line":"    "}],"source_content_type":"text/x-python","patch_set":1,"id":"b146dd0d_9f0f4fed","line":159,"range":{"start_line":158,"start_character":0,"end_line":159,"end_character":4},"in_reply_to":"f9daa593_b66a56a9","updated":"2022-04-27 14:36:33.000000000","message":"Done","commit_id":"d1a2968002f9e2d132797fb1ba884a6c1eb6e2fa"}]}