)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b6971fdd6a4ebc29f2aadc97e19b8e4d8c23ebe6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     sehun.jeong \u003cpermesilo@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-11-27 10:00:47 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add UnicodeDecodeError exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update manila-ui/dashboards/utils.py for add UnicodeDecodeError"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-bug: #2043572"},{"line_number":12,"context_line":"Change-Id: I5d978e8eb3931a218b1946625baa28aa23890cd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"192f20fc_f5c20426","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":1},"updated":"2023-11-27 10:08:47.000000000","message":"Similarly to release note, this may need to describe the problem, rather than the code change.\n\n```\nAvoid server error caused by UnicodeDecodeError\n\nSometimes b32decode may generate data which can\u0027t be decoded.\nIgnore UnicodeDecodeError so that a few other formats can be tried.\n```","commit_id":"3df4415defd3df22e236da1ac7a8b375d834b6d8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"159746212a1aef2a31d02a351c32e44e1093a1db","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sehun.jeong \u003cpermesilo@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-11-27 10:00:47 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add UnicodeDecodeError exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update manila-ui/dashboards/utils.py for add UnicodeDecodeError"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-bug: #2043572"},{"line_number":12,"context_line":"Change-Id: I5d978e8eb3931a218b1946625baa28aa23890cd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"abe42ed1_65e367d6","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":1},"in_reply_to":"192f20fc_f5c20426","updated":"2023-11-29 08:12:36.000000000","message":"Done","commit_id":"3df4415defd3df22e236da1ac7a8b375d834b6d8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fd0deee92bd55ff5c298eb84dca5b72dae3798a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0756a888_3c6928a8","updated":"2023-11-21 11:07:39.000000000","message":"Could you please add a release note to this change?","commit_id":"4de9dfbc1fc388eb54666e5026e40b116515fb1e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2f0713e1f07d9c7afe67c12dd5a190852534fd9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84d30532_3930e019","updated":"2023-11-21 11:07:01.000000000","message":"LGTM, thanks for the change","commit_id":"4de9dfbc1fc388eb54666e5026e40b116515fb1e"},{"author":{"_account_id":35658,"name":"sehun Jeong","display_name":"sehun.jeong","email":"permesilo@gmail.com","username":"sehun.jeong"},"change_message_id":"b0a3d790f138bf407bf22593e0714327634ceb48","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa460e8c_46883ac8","in_reply_to":"0756a888_3c6928a8","updated":"2023-11-24 00:48:13.000000000","message":"can you tell me how to add release note? because this is the first time to contribution to manila-ui. I do not know what hash value is attached after releasenote.","commit_id":"4de9dfbc1fc388eb54666e5026e40b116515fb1e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"63c3a5c97b37ccf3cdf17d00b3df69abe8a95a46","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af2b7bd6_91c93e95","in_reply_to":"aa460e8c_46883ac8","updated":"2023-11-24 12:21:24.000000000","message":"ah, apologies for not sharing a link in advance, but here goes our release notes doc: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html\n\nThe part that specifically singles out how to create release notes: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#how-do-i-add-a-release-note","commit_id":"4de9dfbc1fc388eb54666e5026e40b116515fb1e"},{"author":{"_account_id":35658,"name":"sehun Jeong","display_name":"sehun.jeong","email":"permesilo@gmail.com","username":"sehun.jeong"},"change_message_id":"827b849f1d2e6fdfc0dbd5ad57aa0e19fd345818","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7304e4f1_a200ac12","in_reply_to":"af2b7bd6_91c93e95","updated":"2023-11-27 01:05:51.000000000","message":"I added a release note thx!","commit_id":"4de9dfbc1fc388eb54666e5026e40b116515fb1e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b6971fdd6a4ebc29f2aadc97e19b8e4d8c23ebe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7275c276_cbdb6099","updated":"2023-11-27 10:08:47.000000000","message":"I agree with the proposed change itself but have a few suggestions about the documentation.","commit_id":"3df4415defd3df22e236da1ac7a8b375d834b6d8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b9fe405c7d364b1d5d297061577a25154985f289","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7356b5ea_11210c1d","updated":"2023-12-06 11:44:39.000000000","message":"LGTM, thanks!","commit_id":"e1b7aceff9f59333b2da6ad8933f50f11f16b086"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"981e509ae630e1214a613b98282086a7517ff779","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad113d0c_c251d80c","updated":"2023-12-05 12:12:29.000000000","message":"Thank you; LGTM","commit_id":"e1b7aceff9f59333b2da6ad8933f50f11f16b086"}],"manila_ui/dashboards/utils.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"159746212a1aef2a31d02a351c32e44e1093a1db","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    if not name:"},{"line_number":123,"context_line":"        return"},{"line_number":124,"context_line":"    try:"},{"line_number":125,"context_line":"        return base64.b32decode("},{"line_number":126,"context_line":"            name.replace(\u0027_\u0027, \u0027\u003d\u0027).upper().encode()).decode()"},{"line_number":127,"context_line":"    except (binascii.Error, UnicodeDecodeError):"},{"line_number":128,"context_line":"        if re.search(r\u0027^[a-z_\\d]+$\u0027, name):"},{"line_number":129,"context_line":"            return name  # leave as-is names without dashes and capitals"}],"source_content_type":"text/x-python","patch_set":3,"id":"9c6bd3c8_2a1d3b7d","line":126,"range":{"start_line":125,"start_character":8,"end_line":126,"end_character":61},"updated":"2023-11-29 08:12:36.000000000","message":"side note:\nI\u0027ve not yet looked into this in detail but I feel like the current logic is \"unsafe\", because result of b32decode is not always decodable, and using the logic at L131 may make a better sense.","commit_id":"e1b7aceff9f59333b2da6ad8933f50f11f16b086"}],"releasenotes/notes/bug-2043572-fix-transform-dashed-name-3212571da9b0bd43.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b6971fdd6a4ebc29f2aadc97e19b8e4d8c23ebe6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A UnicodeDecodeError is added to the exception in the transform_dashed_name"},{"line_number":5,"context_line":"    to solve the problem that the create share button does not work "},{"line_number":6,"context_line":"    in a specific share type."},{"line_number":7,"context_line":"    `Launchpad bug \u003chttps://bugs.launchpad.net/manila-ui/+bug/2043572\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5c985930_b546fd74","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":29},"updated":"2023-11-27 10:08:47.000000000","message":"I\u0027d recommend describing the problem and not explaining the code change, because release notes are for users, not for developers.\n\n```\nFixed error in share creation caused by internal UnicodeDecodeError.\n```","commit_id":"3df4415defd3df22e236da1ac7a8b375d834b6d8"},{"author":{"_account_id":35658,"name":"sehun Jeong","display_name":"sehun.jeong","email":"permesilo@gmail.com","username":"sehun.jeong"},"change_message_id":"70289775ff830ab99666064d38d9ad42d009f605","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A UnicodeDecodeError is added to the exception in the transform_dashed_name"},{"line_number":5,"context_line":"    to solve the problem that the create share button does not work "},{"line_number":6,"context_line":"    in a specific share type."},{"line_number":7,"context_line":"    `Launchpad bug \u003chttps://bugs.launchpad.net/manila-ui/+bug/2043572\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"70a6c343_58cc69ea","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":29},"in_reply_to":"5c985930_b546fd74","updated":"2023-11-28 00:35:05.000000000","message":"Thank you for your advice.","commit_id":"3df4415defd3df22e236da1ac7a8b375d834b6d8"}]}