)]}'
{".zuul.yaml":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"2fcbbfa13090f43c3f02242886e2e31152d460b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a8d3216_66dd4f7b","line":107,"updated":"2024-03-06 07:12:59.000000000","message":"you can also add \u0027setup.cfg\u0027 here.","commit_id":"c63a50ba1b4d5d93a8541dde78c31bbbfcf3f2e4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3a82cbb93c76b2845ba56179046a2dea18845c7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1f82f115_0959749d","line":107,"in_reply_to":"3a8d3216_66dd4f7b","updated":"2024-04-02 22:53:18.000000000","message":"+1","commit_id":"c63a50ba1b4d5d93a8541dde78c31bbbfcf3f2e4"},{"author":{"_account_id":36758,"name":"Elvis Kobi Acheampong","email":"kobi.elvis790@yahoo.com","username":"acheampongelvis"},"change_message_id":"26b73640e2273e2d95f73ded5847a7c01283c6f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0022be74_b3c8c550","line":107,"in_reply_to":"3a8d3216_66dd4f7b","updated":"2024-04-23 17:43:36.000000000","message":"Done","commit_id":"c63a50ba1b4d5d93a8541dde78c31bbbfcf3f2e4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3a82cbb93c76b2845ba56179046a2dea18845c7","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        - manila-ui-integration-tests:"},{"line_number":14,"context_line":"            voting: false"},{"line_number":15,"context_line":"        - manila-ui-tox-bandit:"},{"line_number":16,"context_line":"            voting: false"},{"line_number":17,"context_line":"    gate:"},{"line_number":18,"context_line":"      jobs:"},{"line_number":19,"context_line":"        - manila-ui-integration-tests:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fdd3aeea_222928ae","line":16,"updated":"2024-04-02 22:53:18.000000000","message":"I think you can remove this; you\u0027re resolving the current issues in the code.. so lets keep this voting so we prevent any further issues.","commit_id":"a6604b6b4ce37e83cc5547d8dff5692d66b1e514"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4163aed9131b5db7e24f05e0e3184ebee4fad2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        - manila-ui-integration-tests:"},{"line_number":14,"context_line":"            voting: false"},{"line_number":15,"context_line":"        - manila-ui-tox-bandit:"},{"line_number":16,"context_line":"            voting: false"},{"line_number":17,"context_line":"    gate:"},{"line_number":18,"context_line":"      jobs:"},{"line_number":19,"context_line":"        - manila-ui-integration-tests:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"81528ae5_2d673906","line":16,"in_reply_to":"878be91b_838f3b57","updated":"2024-04-25 23:07:56.000000000","message":"Done","commit_id":"a6604b6b4ce37e83cc5547d8dff5692d66b1e514"},{"author":{"_account_id":36758,"name":"Elvis Kobi Acheampong","email":"kobi.elvis790@yahoo.com","username":"acheampongelvis"},"change_message_id":"2dae3fa98212234adab078d4f9b6558763e3e486","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        - manila-ui-integration-tests:"},{"line_number":14,"context_line":"            voting: false"},{"line_number":15,"context_line":"        - manila-ui-tox-bandit:"},{"line_number":16,"context_line":"            voting: false"},{"line_number":17,"context_line":"    gate:"},{"line_number":18,"context_line":"      jobs:"},{"line_number":19,"context_line":"        - manila-ui-integration-tests:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fddfd96b_f124d247","line":16,"in_reply_to":"878be91b_838f3b57","updated":"2024-04-30 17:12:52.000000000","message":"Should I remove the line 15?","commit_id":"a6604b6b4ce37e83cc5547d8dff5692d66b1e514"},{"author":{"_account_id":36758,"name":"Elvis Kobi Acheampong","email":"kobi.elvis790@yahoo.com","username":"acheampongelvis"},"change_message_id":"26b73640e2273e2d95f73ded5847a7c01283c6f5","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        - manila-ui-integration-tests:"},{"line_number":14,"context_line":"            voting: false"},{"line_number":15,"context_line":"        - manila-ui-tox-bandit:"},{"line_number":16,"context_line":"            voting: false"},{"line_number":17,"context_line":"    gate:"},{"line_number":18,"context_line":"      jobs:"},{"line_number":19,"context_line":"        - manila-ui-integration-tests:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"878be91b_838f3b57","line":16,"in_reply_to":"fdd3aeea_222928ae","updated":"2024-04-23 17:43:36.000000000","message":"Alright. I have omitted line 16 from the code.","commit_id":"a6604b6b4ce37e83cc5547d8dff5692d66b1e514"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6257b9e7ff067fee0ba5799722baafe94db034e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        - manila-ui-integration-tests:"},{"line_number":14,"context_line":"            voting: false"},{"line_number":15,"context_line":"        - manila-ui-tox-bandit:"},{"line_number":16,"context_line":"            voting: false"},{"line_number":17,"context_line":"    gate:"},{"line_number":18,"context_line":"      jobs:"},{"line_number":19,"context_line":"        - manila-ui-integration-tests:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"8ca426df_5fc0bb4e","line":16,"in_reply_to":"fddfd96b_f124d247","updated":"2024-05-01 00:26:20.000000000","message":"Nope; everything looks good now","commit_id":"a6604b6b4ce37e83cc5547d8dff5692d66b1e514"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4163aed9131b5db7e24f05e0e3184ebee4fad2","unresolved":true,"context_lines":[{"line_number":12,"context_line":"            voting: false"},{"line_number":13,"context_line":"        - manila-ui-integration-tests:"},{"line_number":14,"context_line":"            voting: false"},{"line_number":15,"context_line":"        - manila-ui-tox-bandit:"},{"line_number":16,"context_line":"    gate:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - manila-ui-integration-tests:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f1f491e_8c75cdee","line":15,"range":{"start_line":15,"start_character":30,"end_line":15,"end_character":31},"updated":"2024-04-25 23:07:56.000000000","message":"you must remove the \":\"","commit_id":"f6070fe3d4efe0db52dc0d46ea44866d643f62f2"},{"author":{"_account_id":36758,"name":"Elvis Kobi Acheampong","email":"kobi.elvis790@yahoo.com","username":"acheampongelvis"},"change_message_id":"2dae3fa98212234adab078d4f9b6558763e3e486","unresolved":false,"context_lines":[{"line_number":12,"context_line":"            voting: false"},{"line_number":13,"context_line":"        - manila-ui-integration-tests:"},{"line_number":14,"context_line":"            voting: false"},{"line_number":15,"context_line":"        - manila-ui-tox-bandit:"},{"line_number":16,"context_line":"    gate:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"        - manila-ui-integration-tests:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1b5391ba_4e52a068","line":15,"range":{"start_line":15,"start_character":30,"end_line":15,"end_character":31},"in_reply_to":"9f1f491e_8c75cdee","updated":"2024-04-30 17:12:52.000000000","message":"Alright","commit_id":"f6070fe3d4efe0db52dc0d46ea44866d643f62f2"}],"/COMMIT_MSG":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"2fcbbfa13090f43c3f02242886e2e31152d460b8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Elvis Acheampong \u003ckobi.elvis790@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-20 18:48:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Bandit testing environment to tox.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable the bandit test env in manila-ui"},{"line_number":10,"context_line":"Execute tox -e bandit to run it and also include zuul continous integration"},{"line_number":11,"context_line":"Chage manila-ui to manila_ui"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id75cbd8ce7e33ab4d920bdf389ac66f8d93f19dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"135ebf8d_a71a933a","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":28},"updated":"2024-03-06 07:12:59.000000000","message":"commit-msg can be improved.\nwhat about:\n\nAdd non-voting Bandit test job for manila-ui\n\nThis patch adds a non-voting job in the CI for bandit testing.\nWe can change it to voting in the future once it passes in CI job.\n\nIt also adds the bandit env. in ``tox.ini`` file so can run it locally using the \u0027tox -e bandit\u0027 command.","commit_id":"c63a50ba1b4d5d93a8541dde78c31bbbfcf3f2e4"},{"author":{"_account_id":36758,"name":"Elvis Kobi Acheampong","email":"kobi.elvis790@yahoo.com","username":"acheampongelvis"},"change_message_id":"26b73640e2273e2d95f73ded5847a7c01283c6f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Elvis Acheampong \u003ckobi.elvis790@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-02-20 18:48:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Bandit testing environment to tox.ini"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Enable the bandit test env in manila-ui"},{"line_number":10,"context_line":"Execute tox -e bandit to run it and also include zuul continous integration"},{"line_number":11,"context_line":"Chage manila-ui to manila_ui"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id75cbd8ce7e33ab4d920bdf389ac66f8d93f19dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d6f9b3b2_e77a87e7","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":28},"in_reply_to":"135ebf8d_a71a933a","updated":"2024-04-23 17:43:36.000000000","message":"Done","commit_id":"c63a50ba1b4d5d93a8541dde78c31bbbfcf3f2e4"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"b7b2e19750657c3256190e08a85821d79aeb5346","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Elvis Kobi Acheampong \u003ckobi.elvis790@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-19 16:14:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding a Bandit test environment in tox.ini, allowing for local execution with tox -e bandit."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implementing a non-voting Bandit test job in the continuous integration setup."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fd31d49c_4bc7ca08","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":93},"updated":"2024-03-26 15:40:36.000000000","message":"the title is too long. details should be added in the body instead. \nLeave this at \"Adding a Bandit test environment\"","commit_id":"75938b1a817bddfd34e9783019650ee3dd51d81f"},{"author":{"_account_id":36758,"name":"Elvis Kobi Acheampong","email":"kobi.elvis790@yahoo.com","username":"acheampongelvis"},"change_message_id":"26b73640e2273e2d95f73ded5847a7c01283c6f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Elvis Kobi Acheampong \u003ckobi.elvis790@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-03-19 16:14:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding a Bandit test environment in tox.ini, allowing for local execution with tox -e bandit."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implementing a non-voting Bandit test job in the continuous integration setup."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"55290982_487a6648","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":93},"in_reply_to":"fd31d49c_4bc7ca08","updated":"2024-04-23 17:43:36.000000000","message":"Done","commit_id":"75938b1a817bddfd34e9783019650ee3dd51d81f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29313,"name":"Vishal Manchanda","email":"manchandavishal143@gmail.com","username":"vishalmanchanda"},"change_message_id":"2fcbbfa13090f43c3f02242886e2e31152d460b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a2a2860b_92359e66","updated":"2024-03-06 07:12:59.000000000","message":"Thanks for the patch, Please find some comments inline.","commit_id":"c63a50ba1b4d5d93a8541dde78c31bbbfcf3f2e4"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"b7b2e19750657c3256190e08a85821d79aeb5346","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9ca5acce_ce484bf2","updated":"2024-03-26 15:40:36.000000000","message":"roll back changes made to utils.py. I see you were using https://docs.djangoproject.com/en/5.0/ref/utils/ as a reference to replace the current usage of mark_safe, but your implementation is not quite right.\n\ntry instead of \"return mark_safe(meta_str)\" on line 104:\n\nreturn format_html(\"{} \u003cb\u003e\", mark_safe(meta_str))","commit_id":"75938b1a817bddfd34e9783019650ee3dd51d81f"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"3ddc2908e6f579725b8c60a0270665c06a682a60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c65d498f_cfbb23d8","updated":"2024-04-02 17:22:49.000000000","message":"remove this line","commit_id":"39ea332cf74709eca912d8222ba0753e67d899e4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3a82cbb93c76b2845ba56179046a2dea18845c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1afd2a98_4e122b1c","updated":"2024-04-02 22:53:18.000000000","message":"Hi Elvis, thank you for working on this. please see comments inline","commit_id":"a6604b6b4ce37e83cc5547d8dff5692d66b1e514"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4163aed9131b5db7e24f05e0e3184ebee4fad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"43bac85c_fa83dbda","updated":"2024-04-25 23:07:56.000000000","message":"Ashley is fixing up what I called out in my last comment here: https://review.opendev.org/c/openstack/manila-ui/+/917066\n\nSo, this patch needs just a couple of other fixes","commit_id":"f6070fe3d4efe0db52dc0d46ea44866d643f62f2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3c7e3bd8d3086387f0d7b8066e88372a130c2109","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"e55b15b0_0a46c726","updated":"2024-05-02 19:24:41.000000000","message":"LGTM, thank you Elvis!","commit_id":"119c906ba6931ca6e8d2683aa0aa6ad42b78518c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"73c557888e37b8d077c18459387d1b73be99ddf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0dfef2dc_f5688c3f","updated":"2024-05-01 01:59:18.000000000","message":"The integration test failure is unrelated; I\u0027d love to get this in alongside https://review.opendev.org/c/openstack/manila-ui/+/917066 to close this out. Thanks for your work on this, Elvis!","commit_id":"119c906ba6931ca6e8d2683aa0aa6ad42b78518c"}],"manila_ui/dashboards/utils.py":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"3ddc2908e6f579725b8c60a0270665c06a682a60","unresolved":true,"context_lines":[{"line_number":16,"context_line":"import re"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from django.forms import ValidationError"},{"line_number":19,"context_line":"from django.utils.safestring import mark_safe"},{"line_number":20,"context_line":"from django.utils.translation import gettext_lazy as _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"c378ceb3_6143e95e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":45},"updated":"2024-04-02 17:22:49.000000000","message":"remove this line","commit_id":"39ea332cf74709eca912d8222ba0753e67d899e4"},{"author":{"_account_id":36758,"name":"Elvis Kobi Acheampong","email":"kobi.elvis790@yahoo.com","username":"acheampongelvis"},"change_message_id":"26b73640e2273e2d95f73ded5847a7c01283c6f5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import re"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from django.forms import ValidationError"},{"line_number":19,"context_line":"from django.utils.safestring import mark_safe"},{"line_number":20,"context_line":"from django.utils.translation import gettext_lazy as _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3033c323_7bb54ffc","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":45},"in_reply_to":"c378ceb3_6143e95e","updated":"2024-04-23 17:43:36.000000000","message":"Done","commit_id":"39ea332cf74709eca912d8222ba0753e67d899e4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3a82cbb93c76b2845ba56179046a2dea18845c7","unresolved":true,"context_lines":[{"line_number":95,"context_line":"    meta_str \u003d \"\u003cbr/\u003e\".join(meta)"},{"line_number":96,"context_line":"    if len(metadata.keys()) \u003e meta_visible_limit and meta_str[-3:] !\u003d \"...\":"},{"line_number":97,"context_line":"        meta_str +\u003d \u0027...\u0027"},{"line_number":98,"context_line":"    return meta_str"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def get_nice_security_service_type(security_service):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5cfc312e_0ec839be","line":98,"updated":"2024-04-02 22:53:18.000000000","message":"I\u0027m a little concerned with how this change will work. \n\nFrom what I understand, when you have HTML escaped characters (e.g.: the \u003c\u003e used for HTML elements, like in line 95)  in an output, you\u0027ll want to prevent Django from messing it up. \n\nI do see a concerning use of this though; this method (\"metadata_to_str(..)\") must only be used by view builders and must not be used in any user input forms. Why? because we\u0027re parsing metadata strings and \"prettifying\" their display on the UI... so, we know that the string that we\u0027re formatting is safe and not susceptible to XSS attacks. \n\nI do see one instance of using this method in a user input form: https://opendev.org/openstack/manila-ui/src/branch/master/manila_ui/dashboards/project/shares/forms.py#L374-L377\n\nMaybe we should #noqa this occurrence with a comment, and avoid using this method in the forms.. It\u0027s pretty easy to get the right behavior without using this.. we do this for metadata elsewhere: https://github.com/openstack/manila-ui/blob/db7fc5d15068d9163ed9c1c0f7bb18dfd34e712d/manila_ui/dashboards/project/shares/forms.py#L298-L301","commit_id":"a6604b6b4ce37e83cc5547d8dff5692d66b1e514"},{"author":{"_account_id":36758,"name":"Elvis Kobi Acheampong","email":"kobi.elvis790@yahoo.com","username":"acheampongelvis"},"change_message_id":"174874a137a08429bdc169a0fad480e809a853d4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    meta_str \u003d \"\u003cbr/\u003e\".join(meta)"},{"line_number":96,"context_line":"    if len(metadata.keys()) \u003e meta_visible_limit and meta_str[-3:] !\u003d \"...\":"},{"line_number":97,"context_line":"        meta_str +\u003d \u0027...\u0027"},{"line_number":98,"context_line":"    return meta_str"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"def get_nice_security_service_type(security_service):"}],"source_content_type":"text/x-python","patch_set":13,"id":"32f94163_fd97c115","line":98,"in_reply_to":"5cfc312e_0ec839be","updated":"2024-04-23 19:12:54.000000000","message":"I do see your point. I think includinng the mark_safe and mark it as \"no sec\" is better the appoarch.","commit_id":"a6604b6b4ce37e83cc5547d8dff5692d66b1e514"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ee4163aed9131b5db7e24f05e0e3184ebee4fad2","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    meta_str \u003d \"\u003cbr/\u003e\".join(meta)"},{"line_number":97,"context_line":"    if len(metadata.keys()) \u003e meta_visible_limit and meta_str[-3:] !\u003d \"...\":"},{"line_number":98,"context_line":"        meta_str +\u003d \u0027...\u0027"},{"line_number":99,"context_line":"    return mark_safe(meta_str)  #no sec"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def get_nice_security_service_type(security_service):"}],"source_content_type":"text/x-python","patch_set":17,"id":"4a13bcf2_89135438","line":99,"range":{"start_line":99,"start_character":32,"end_line":99,"end_character":39},"updated":"2024-04-25 23:07:56.000000000","message":"isn\u0027t this:\n\n```\nreturn mark_safe(meta_str)  # nosec B703\n\n```","commit_id":"f6070fe3d4efe0db52dc0d46ea44866d643f62f2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f6257b9e7ff067fee0ba5799722baafe94db034e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    meta_str \u003d \"\u003cbr/\u003e\".join(meta)"},{"line_number":97,"context_line":"    if len(metadata.keys()) \u003e meta_visible_limit and meta_str[-3:] !\u003d \"...\":"},{"line_number":98,"context_line":"        meta_str +\u003d \u0027...\u0027"},{"line_number":99,"context_line":"    return mark_safe(meta_str)  #no sec"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def get_nice_security_service_type(security_service):"}],"source_content_type":"text/x-python","patch_set":17,"id":"8411178a_d2084ed6","line":99,"range":{"start_line":99,"start_character":32,"end_line":99,"end_character":39},"in_reply_to":"4a13bcf2_89135438","updated":"2024-05-01 00:26:20.000000000","message":"Looks like it is B308","commit_id":"f6070fe3d4efe0db52dc0d46ea44866d643f62f2"}],"tox.ini":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"18ae38f7b829ffc23f6530386e33b21d4844c21b","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[testenv:bandit]"},{"line_number":35,"context_line":"deps \u003d bandit~\u003d1.6.0"},{"line_number":36,"context_line":"commands \u003d bandit -r manila-ui -x manila-ui/tests/* -n5 -ll"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[testenv:integration]"},{"line_number":39,"context_line":"# Run integration tests only"}],"source_content_type":"text/x-properties","patch_set":5,"id":"b70eb652_665f7d15","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":30},"updated":"2024-02-20 18:12:30.000000000","message":"manila_ui","commit_id":"cb09fc9e66e6d8b50d77c56d90c7480385053dd7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3a82cbb93c76b2845ba56179046a2dea18845c7","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[testenv:bandit]"},{"line_number":35,"context_line":"deps \u003d bandit~\u003d1.6.0"},{"line_number":36,"context_line":"commands \u003d bandit -r manila-ui -x manila-ui/tests/* -n5 -ll"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[testenv:integration]"},{"line_number":39,"context_line":"# Run integration tests only"}],"source_content_type":"text/x-properties","patch_set":5,"id":"714955fb_8f9c1d38","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":30},"in_reply_to":"b70eb652_665f7d15","updated":"2024-04-02 22:53:18.000000000","message":"Done\n\n\n@Elvis; for future reference; please respond to review comments and \"resolve\" them. When you see a comment like this, your follow up should be:\n\n1) Ask questions or act on the suggestion in the comment\n2) Acting on a suggestion could be either: state your disagreement (with reason) or acknowledgement (\"Done\", \"Ack\", \"Thank you, I have fixed this\" etc are fine comments), and leave the comment as \"Resolved\" (click the check-box that shows up on the comment response form) or not \"Resolved\" (leave the check-box empty) \n3) When you\u0027re done responding to all the individual comments, you will need to click on \"Reply\" and post your comments - without this, your responses are left in a \"Draft\" state.","commit_id":"cb09fc9e66e6d8b50d77c56d90c7480385053dd7"},{"author":{"_account_id":36758,"name":"Elvis Kobi Acheampong","email":"kobi.elvis790@yahoo.com","username":"acheampongelvis"},"change_message_id":"26b73640e2273e2d95f73ded5847a7c01283c6f5","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[testenv:bandit]"},{"line_number":35,"context_line":"deps \u003d bandit~\u003d1.6.0"},{"line_number":36,"context_line":"commands \u003d bandit -r manila-ui -x manila-ui/tests/* -n5 -ll"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[testenv:integration]"},{"line_number":39,"context_line":"# Run integration tests only"}],"source_content_type":"text/x-properties","patch_set":5,"id":"9e39de31_416b2e99","line":36,"range":{"start_line":36,"start_character":21,"end_line":36,"end_character":30},"in_reply_to":"b70eb652_665f7d15","updated":"2024-04-23 17:43:36.000000000","message":"Thank you. I will do it right from now going.","commit_id":"cb09fc9e66e6d8b50d77c56d90c7480385053dd7"}]}