)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a39bfce84c363088435dbea4bcff11de76454532","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     tspyderboy \u003ctspyderboy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-24 18:41:32 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Share Network Subnet create UI option added"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic3a5e63e34ca7c8eb4ce41d93e9558e04a08e6a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"08349286_27101482","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"updated":"2024-07-24 19:01:04.000000000","message":"nit:\n\nAdd workflow to create share network subnets","commit_id":"ca406d8e2dd171ad514f57826bebd5e3d8cd5406"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"9563b39240646097661da801e7316c5380c4091a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     tspyderboy \u003ctspyderboy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-24 18:41:32 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Share Network Subnet create UI option added"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic3a5e63e34ca7c8eb4ce41d93e9558e04a08e6a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa25cc8e_b8a1517b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"in_reply_to":"08349286_27101482","updated":"2024-07-28 17:32:10.000000000","message":"Acknowledged","commit_id":"ca406d8e2dd171ad514f57826bebd5e3d8cd5406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91c27581c108d256bec121fe746ef634d64333ba","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-07-28 17:30:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add workflow to create share network subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic3a5e63e34ca7c8eb4ce41d93e9558e04a08e6a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"86ad5041_2d9cf293","line":8,"updated":"2024-07-29 23:18:50.000000000","message":"I see that we\u0027ve a blueprint!\n\nhttps://blueprints.launchpad.net/manila-ui/+spec/share-network-subnets\n\nPlease add:\n\n```\nPartially-implements: bp share-network-subnets\n```\n\nabove the \"Change-Id\" line..","commit_id":"3a799e7fd15eb88eb04c6d262d40adf1d61abf52"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a575cd16e5737abc9964991697ad62e6ff3d3b7c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-07-28 17:30:26 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add workflow to create share network subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic3a5e63e34ca7c8eb4ce41d93e9558e04a08e6a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dd0f8d4c_76778b9d","line":8,"in_reply_to":"86ad5041_2d9cf293","updated":"2024-07-30 11:51:12.000000000","message":"Acknowledged","commit_id":"3a799e7fd15eb88eb04c6d262d40adf1d61abf52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2e4ee7607fc3142bdcb30c00f70cc3c2d75acde4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     tspyderboy \u003ctspyderboy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-30 11:49:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add workflow to create share network subnets"},{"line_number":8,"context_line":"Partially-implements: bp share-network-subnets"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ic3a5e63e34ca7c8eb4ce41d93e9558e04a08e6a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1f56d306_5c974c2f","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":46},"updated":"2024-07-30 15:13:06.000000000","message":"a blank line between these two lines please.\ntypically, we use commit message tags just above \"Change-Id\"\n\nWithout a blank line, git treats this entire paragraph as a title:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Executive_Summary","commit_id":"721637c4435c260a8dcd4894c4195d7b7b6abd04"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"fb8ebe0975cd340e019ce646173acf349796d0d5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     tspyderboy \u003ctspyderboy@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-30 11:49:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add workflow to create share network subnets"},{"line_number":8,"context_line":"Partially-implements: bp share-network-subnets"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ic3a5e63e34ca7c8eb4ce41d93e9558e04a08e6a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1f44b65e_a80ef2d2","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":46},"in_reply_to":"1f56d306_5c974c2f","updated":"2024-07-30 17:08:09.000000000","message":"Acknowledged","commit_id":"721637c4435c260a8dcd4894c4195d7b7b6abd04"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c0e3f6df6c0385184d6006d329c3501aec974741","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"85a6a9c5_bb7d1e98","updated":"2024-07-17 18:06:33.000000000","message":"Thanks Ariq! This looks good for the most part; some minor comments inline; can you look at increasing the unit test coverage for the new tables/forms/panels added?","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a2c0c62838b1ad64bc736c9221ddadc669b47db7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e5604629_cd9ba7b8","updated":"2024-07-23 18:08:17.000000000","message":"Addressed req changes, working on adding pending tests","commit_id":"b2187d40e5f315050bd21243663aff45dc3470ae"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a39bfce84c363088435dbea4bcff11de76454532","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7b60d5bb_18c4e3bf","updated":"2024-07-24 19:01:04.000000000","message":"Thank you @tspyderboy@gmail.com; a few minor comments inline; could you also address @eceokekechima@gmail.com\u0027s comment?","commit_id":"ca406d8e2dd171ad514f57826bebd5e3d8cd5406"},{"author":{"_account_id":36853,"name":"christian okeke","email":"eceokekechima@gmail.com","username":"ccokeke"},"change_message_id":"7d45c4617974577e9708c0869487b81ebcfc4c51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e5031a41_25b1d38a","updated":"2024-07-24 16:10:29.000000000","message":"Thanks Ariq: Adding comments on the line `res \u003d self.client.post(url, formData)` will definitely enhance the readability of the test.","commit_id":"ca406d8e2dd171ad514f57826bebd5e3d8cd5406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91c27581c108d256bec121fe746ef634d64333ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0b6ea104_1e88ded0","updated":"2024-07-29 23:18:50.000000000","message":"@tspyderboy@gmail.com - one final comment inline","commit_id":"3a799e7fd15eb88eb04c6d262d40adf1d61abf52"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"9563b39240646097661da801e7316c5380c4091a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3b9f5257_031440d5","updated":"2024-07-28 17:32:10.000000000","message":"Thank You Goutham and Christian, for the suggestions. \nHave iterated on the requested changes.","commit_id":"3a799e7fd15eb88eb04c6d262d40adf1d61abf52"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a575cd16e5737abc9964991697ad62e6ff3d3b7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"13ae7c84_9c51de3e","updated":"2024-07-30 11:51:12.000000000","message":"Thank you Goutham for the blueprint reference.\nAdded partial tag.","commit_id":"721637c4435c260a8dcd4894c4195d7b7b6abd04"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cf6f1c52c10c73d769196cd0eaab1ddc08b2059","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"afa1ad46_f5022932","updated":"2024-07-30 22:42:23.000000000","message":"Good stuff, thanks tspyderboy!","commit_id":"3f3ed6a4537dce6b1340460a139be737c1555134"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"a3a1a3a4c49a9229897550d697d73ca297eac2b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"392469a9_42b48e6b","updated":"2024-07-31 17:50:04.000000000","message":"Let\u0027s further refine the error messages that pop up. When purposefully triggering an error I get two banners:\nFirst: “Error: Unable to create share network subnet \"Create Share Network Subnet\".”\nSecond: “Error: Unable to create share network subnet. Details”\n\nThe first error message is vague, and unnecessary as the second has the appropriate details.","commit_id":"3f3ed6a4537dce6b1340460a139be737c1555134"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"d1ca8290b8c5dff0e999ada7356e1c627334a748","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3f0cf6bb_1d71049d","updated":"2024-07-30 17:07:49.000000000","message":"Thanks Goutham, fix the git commit message","commit_id":"3f3ed6a4537dce6b1340460a139be737c1555134"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"ab03312557d1b8ce9573145e5ce84827252c7ac2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"37f4c5df_d9fd1df0","updated":"2024-08-05 12:09:16.000000000","message":"Hi, refined the error message.\n\nOnly a single error message pops-up like below:\n\nError: Unable to create share network subnet. Details\n\nAnother share network subnet was found in the specified availability zone. Only one share network subnet is allowed per availability zone for share network 4f516555-ca13-4d96-8952-6c2609241534. (HTTP 409) (Request-ID: req-84bc71e7-c90b-41c3-9d66-813fd873006c)","commit_id":"0d5a1484c5713562d51e591a15abd0c97f08ef64"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a798a369bf90c7a42bc1257d41ce044cb682f2c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5f392d04_70570d90","updated":"2024-08-06 13:12:31.000000000","message":"Hi Goutham, please check the reason in the inline comments for not removing those lines completely.\nThanks","commit_id":"cc3985c2678afc28ca10b087eb9d2a016b62c67a"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"237f5cfc27287530b4849a63fc2fce9b1984a8ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"db35696d_61ab122f","updated":"2024-08-06 13:13:07.000000000","message":"If we remove it comepletely, default messages are printed from here: https://github.com/openstack/horizon/blob/d171cee3836fdd7fcf0661af31fad9043db24b53/horizon/workflows/base.py#L625","commit_id":"cc3985c2678afc28ca10b087eb9d2a016b62c67a"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"30f6081d6e86690b8508d3f326c60691f23df6ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0b332cb4_a1f52421","updated":"2024-08-09 19:19:45.000000000","message":"LGTM, thanks for addressing the duplicate error issue. \n@gouthampravi@gmail.com should we leave this open and propose delete subnet work and chain the patches? Or go ahead and merge this then work on the delete workflow?","commit_id":"cc3985c2678afc28ca10b087eb9d2a016b62c67a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5347212cefaf3464880b9eccac151e7ee527a7c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e21c4747_9f686a41","updated":"2024-08-06 17:54:05.000000000","message":"LGTM; thanks @tspyderboy@gmail.com","commit_id":"cc3985c2678afc28ca10b087eb9d2a016b62c67a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b85b8655178576e32ae1352e5b6d99df727dcb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9e0d3509_b85dba23","updated":"2024-08-09 22:29:04.000000000","message":"Let\u0027s get this in, thanks and good work @tspyderboy@gmail.com!","commit_id":"cc3985c2678afc28ca10b087eb9d2a016b62c67a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1b85b8655178576e32ae1352e5b6d99df727dcb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b30e2962_d1c04c41","in_reply_to":"0b332cb4_a1f52421","updated":"2024-08-09 22:29:04.000000000","message":"Probably not; this is quite useful for now; even without allowing deletion of subnets.. lets get it in.. \n\ni think @tspyderboy@gmail.com wanted to add a subnets table view where deletion and further updates (adding/altering subnet metadata) can be done..","commit_id":"cc3985c2678afc28ca10b087eb9d2a016b62c67a"}],"manila_ui/dashboards/project/share_networks/share_network_subnets/tables.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c0e3f6df6c0385184d6006d329c3501aec974741","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from django.utils.translation import gettext_lazy as _"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from horizon import tables"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f389a636_e20d74f8","line":14,"updated":"2024-07-17 18:06:33.000000000","message":"both of these are \"third party\" libraries; please group them together:\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a2c0c62838b1ad64bc736c9221ddadc669b47db7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from django.utils.translation import gettext_lazy as _"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from horizon import tables"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ece88e2c_623c3b4a","line":14,"in_reply_to":"f389a636_e20d74f8","updated":"2024-07-23 18:08:17.000000000","message":"Acknowledged","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c0e3f6df6c0385184d6006d329c3501aec974741","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    verbose_name \u003d _(\"Create Share Network Subnets\")"},{"line_number":21,"context_line":"    url \u003d \"horizon:project:share_networks:share_network_subnet_create\""},{"line_number":22,"context_line":"    classes \u003d (\"ajax-modal\", \"btn-create\")"},{"line_number":23,"context_line":"    policy_rules \u003d ((\"share\", \"share_network:subnet\"),)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def allowed(self, request, obj_id):"},{"line_number":26,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"8334f0cf_7f2969f6","line":23,"range":{"start_line":23,"start_character":21,"end_line":23,"end_character":53},"updated":"2024-07-17 18:06:33.000000000","message":"the policy seems incorrect; \n\n\"share_network_subnet:create\"","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a2c0c62838b1ad64bc736c9221ddadc669b47db7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    verbose_name \u003d _(\"Create Share Network Subnets\")"},{"line_number":21,"context_line":"    url \u003d \"horizon:project:share_networks:share_network_subnet_create\""},{"line_number":22,"context_line":"    classes \u003d (\"ajax-modal\", \"btn-create\")"},{"line_number":23,"context_line":"    policy_rules \u003d ((\"share\", \"share_network:subnet\"),)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def allowed(self, request, obj_id):"},{"line_number":26,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"c1adca4a_54915a7a","line":23,"range":{"start_line":23,"start_character":21,"end_line":23,"end_character":53},"in_reply_to":"8334f0cf_7f2969f6","updated":"2024-07-23 18:08:17.000000000","message":"Acknowledged","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a39bfce84c363088435dbea4bcff11de76454532","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class CreateShareNetworkSubnet(tables.LinkAction):"},{"line_number":18,"context_line":"    name \u003d \"subnet\""},{"line_number":19,"context_line":"    verbose_name \u003d _(\"Create Share Network Subnets\")"},{"line_number":20,"context_line":"    url \u003d \"horizon:project:share_networks:share_network_subnet_create\""},{"line_number":21,"context_line":"    classes \u003d (\"ajax-modal\", \"btn-create\")"},{"line_number":22,"context_line":"    policy_rules \u003d ((\"share\", \"share_network_subnet:create\"),)"}],"source_content_type":"text/x-python","patch_set":5,"id":"6dcdeb9c_e882ac22","line":19,"range":{"start_line":19,"start_character":29,"end_line":19,"end_character":50},"updated":"2024-07-24 19:01:04.000000000","message":"```suggestion\n    verbose_name \u003d _(\"Create Subnet\")\n```\n\nwould suffice","commit_id":"ca406d8e2dd171ad514f57826bebd5e3d8cd5406"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"9563b39240646097661da801e7316c5380c4091a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class CreateShareNetworkSubnet(tables.LinkAction):"},{"line_number":18,"context_line":"    name \u003d \"subnet\""},{"line_number":19,"context_line":"    verbose_name \u003d _(\"Create Share Network Subnets\")"},{"line_number":20,"context_line":"    url \u003d \"horizon:project:share_networks:share_network_subnet_create\""},{"line_number":21,"context_line":"    classes \u003d (\"ajax-modal\", \"btn-create\")"},{"line_number":22,"context_line":"    policy_rules \u003d ((\"share\", \"share_network_subnet:create\"),)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0d304664_8684e826","line":19,"range":{"start_line":19,"start_character":29,"end_line":19,"end_character":50},"in_reply_to":"6dcdeb9c_e882ac22","updated":"2024-07-28 17:32:10.000000000","message":"Acknowledged","commit_id":"ca406d8e2dd171ad514f57826bebd5e3d8cd5406"}],"manila_ui/dashboards/project/share_networks/share_network_subnets/views.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0a281b68e6da27b41d393be338cb939c7c77502c","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from django.utils.translation import gettext_lazy as _"},{"line_number":14,"context_line":"from horizon import workflows"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import manila_ui.dashboards.project.share_networks.share_network_subnets. \\"},{"line_number":17,"context_line":"    workflows"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class CreateSubnet(workflows.WorkflowView):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c972b293_0ed6c70f","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":13},"updated":"2024-07-17 22:57:39.000000000","message":"```\nfrom manila_ui.dashboards.project.share_networks.share_network_subnets import workflows\n```","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a2c0c62838b1ad64bc736c9221ddadc669b47db7","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from django.utils.translation import gettext_lazy as _"},{"line_number":14,"context_line":"from horizon import workflows"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import manila_ui.dashboards.project.share_networks.share_network_subnets. \\"},{"line_number":17,"context_line":"    workflows"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class CreateSubnet(workflows.WorkflowView):"}],"source_content_type":"text/x-python","patch_set":2,"id":"981d419b_81d20db8","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":13},"in_reply_to":"c972b293_0ed6c70f","updated":"2024-07-23 18:08:17.000000000","message":"Acknowledged","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0a281b68e6da27b41d393be338cb939c7c77502c","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class CreateSubnet(workflows.WorkflowView):"},{"line_number":21,"context_line":"    workflow_class \u003d (manila_ui.dashboards.project.share_networks"},{"line_number":22,"context_line":"                      .share_network_subnets.workflows"},{"line_number":23,"context_line":"                      .CreateShareNetworkSubnetsWorkflow)"},{"line_number":24,"context_line":"    success_url \u003d \u0027horizon:project:share_networks:index\u0027"},{"line_number":25,"context_line":"    page_title \u003d _(\u0027Create Share Network Subnet\u0027)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3d812132_385a6f88","line":23,"range":{"start_line":21,"start_character":22,"end_line":23,"end_character":22},"updated":"2024-07-17 22:57:39.000000000","message":"workflows","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a2c0c62838b1ad64bc736c9221ddadc669b47db7","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class CreateSubnet(workflows.WorkflowView):"},{"line_number":21,"context_line":"    workflow_class \u003d (manila_ui.dashboards.project.share_networks"},{"line_number":22,"context_line":"                      .share_network_subnets.workflows"},{"line_number":23,"context_line":"                      .CreateShareNetworkSubnetsWorkflow)"},{"line_number":24,"context_line":"    success_url \u003d \u0027horizon:project:share_networks:index\u0027"},{"line_number":25,"context_line":"    page_title \u003d _(\u0027Create Share Network Subnet\u0027)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ca7a493_6ee751cc","line":23,"range":{"start_line":21,"start_character":22,"end_line":23,"end_character":22},"in_reply_to":"3d812132_385a6f88","updated":"2024-07-23 18:08:17.000000000","message":"Acknowledged","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"}],"manila_ui/dashboards/project/share_networks/share_network_subnets/workflows.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0a281b68e6da27b41d393be338cb939c7c77502c","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from horizon import workflows"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila_ui.api import manila"},{"line_number":19,"context_line":"from manila_ui.dashboards.project.share_networks.workflows \\"},{"line_number":20,"context_line":"    import AddShareNetworkSubnetAction"},{"line_number":21,"context_line":"from manila_ui.dashboards import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bd45bdd0_59cbfee6","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":38},"updated":"2024-07-17 22:57:39.000000000","message":"don\u0027t import the class directly; import the module and reference the class:\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#imports\n\n```\nfrom manila_ui.dashboards.project.share_networks import workflows\n...\n\nworkflows.AddShareNetworkSubnetAction\n```","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a2c0c62838b1ad64bc736c9221ddadc669b47db7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from horizon import workflows"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila_ui.api import manila"},{"line_number":19,"context_line":"from manila_ui.dashboards.project.share_networks.workflows \\"},{"line_number":20,"context_line":"    import AddShareNetworkSubnetAction"},{"line_number":21,"context_line":"from manila_ui.dashboards import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2cef3bff_2d79349a","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":38},"in_reply_to":"bd45bdd0_59cbfee6","updated":"2024-07-23 18:08:17.000000000","message":"Acknowledged","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c0e3f6df6c0385184d6006d329c3501aec974741","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    def handle(self, request, context):"},{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            data \u003d request.POST"},{"line_number":42,"context_line":"            share_network_id \u003d self.context_seed[\u0027share_network_id\u0027]"},{"line_number":43,"context_line":"            share_network_name \u003d manila.share_network_get("},{"line_number":44,"context_line":"                request, share_network_id).name"},{"line_number":45,"context_line":"            send_data \u003d {\u0027share_network_id\u0027: share_network_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"78ef7a48_f2915c14","line":42,"range":{"start_line":42,"start_character":31,"end_line":42,"end_character":68},"updated":"2024-07-17 18:06:33.000000000","message":"context[\u0027share_network_id\u0027]","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a2c0c62838b1ad64bc736c9221ddadc669b47db7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def handle(self, request, context):"},{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            data \u003d request.POST"},{"line_number":42,"context_line":"            share_network_id \u003d self.context_seed[\u0027share_network_id\u0027]"},{"line_number":43,"context_line":"            share_network_name \u003d manila.share_network_get("},{"line_number":44,"context_line":"                request, share_network_id).name"},{"line_number":45,"context_line":"            send_data \u003d {\u0027share_network_id\u0027: share_network_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1bd73864_53d89589","line":42,"range":{"start_line":42,"start_character":31,"end_line":42,"end_character":68},"in_reply_to":"78ef7a48_f2915c14","updated":"2024-07-23 18:08:17.000000000","message":"Acknowledged","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"385e5f7fd278864af756ca92459a72bedc92df42","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    slug \u003d \"create_share_network_subnet\""},{"line_number":32,"context_line":"    name \u003d _(\"Create Share Network Subnet\")"},{"line_number":33,"context_line":"    finalize_button_name \u003d _(\"Create Share Network Subnet\")"},{"line_number":34,"context_line":"    success_message \u003d _(\u0027Created share network subnet \"%s\".\u0027)"},{"line_number":35,"context_line":"    failure_message \u003d _(\u0027\u0027)"},{"line_number":36,"context_line":"    success_url \u003d \u0027horizon:project:share_networks:index\u0027"},{"line_number":37,"context_line":"    default_steps \u003d (AddShareNetworkSubnetStep,)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"87469d91_d1533238","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":27},"updated":"2024-08-05 19:59:34.000000000","message":"You can remove both of these. I think the default messages added on line 62-68 suffice","commit_id":"0d5a1484c5713562d51e591a15abd0c97f08ef64"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5347212cefaf3464880b9eccac151e7ee527a7c9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    slug \u003d \"create_share_network_subnet\""},{"line_number":32,"context_line":"    name \u003d _(\"Create Share Network Subnet\")"},{"line_number":33,"context_line":"    finalize_button_name \u003d _(\"Create Share Network Subnet\")"},{"line_number":34,"context_line":"    success_message \u003d _(\u0027Created share network subnet \"%s\".\u0027)"},{"line_number":35,"context_line":"    failure_message \u003d _(\u0027\u0027)"},{"line_number":36,"context_line":"    success_url \u003d \u0027horizon:project:share_networks:index\u0027"},{"line_number":37,"context_line":"    default_steps \u003d (AddShareNetworkSubnetStep,)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"2b74d938_ec34a3e4","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":27},"in_reply_to":"436d04f7_b83cea68","updated":"2024-08-06 17:54:05.000000000","message":"Perfect; thank you","commit_id":"0d5a1484c5713562d51e591a15abd0c97f08ef64"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"237f5cfc27287530b4849a63fc2fce9b1984a8ee","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    slug \u003d \"create_share_network_subnet\""},{"line_number":32,"context_line":"    name \u003d _(\"Create Share Network Subnet\")"},{"line_number":33,"context_line":"    finalize_button_name \u003d _(\"Create Share Network Subnet\")"},{"line_number":34,"context_line":"    success_message \u003d _(\u0027Created share network subnet \"%s\".\u0027)"},{"line_number":35,"context_line":"    failure_message \u003d _(\u0027\u0027)"},{"line_number":36,"context_line":"    success_url \u003d \u0027horizon:project:share_networks:index\u0027"},{"line_number":37,"context_line":"    default_steps \u003d (AddShareNetworkSubnetStep,)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"436d04f7_b83cea68","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":27},"in_reply_to":"5963bb91_a3ec664a","updated":"2024-08-06 13:13:07.000000000","message":"Acknowledged","commit_id":"0d5a1484c5713562d51e591a15abd0c97f08ef64"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a798a369bf90c7a42bc1257d41ce044cb682f2c1","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    slug \u003d \"create_share_network_subnet\""},{"line_number":32,"context_line":"    name \u003d _(\"Create Share Network Subnet\")"},{"line_number":33,"context_line":"    finalize_button_name \u003d _(\"Create Share Network Subnet\")"},{"line_number":34,"context_line":"    success_message \u003d _(\u0027Created share network subnet \"%s\".\u0027)"},{"line_number":35,"context_line":"    failure_message \u003d _(\u0027\u0027)"},{"line_number":36,"context_line":"    success_url \u003d \u0027horizon:project:share_networks:index\u0027"},{"line_number":37,"context_line":"    default_steps \u003d (AddShareNetworkSubnetStep,)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5963bb91_a3ec664a","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":27},"in_reply_to":"87469d91_d1533238","updated":"2024-08-06 13:12:31.000000000","message":"If we remove it comepletely, default messages are printed from here: https://github.com/openstack/horizon/blob/d171cee3836fdd7fcf0661af31fad9043db24b53/horizon/workflows/base.py#L625","commit_id":"0d5a1484c5713562d51e591a15abd0c97f08ef64"}],"manila_ui/dashboards/project/share_networks/tables.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0a281b68e6da27b41d393be338cb939c7c77502c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from openstack_dashboard.api import neutron"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila_ui.api import manila"},{"line_number":23,"context_line":"from manila_ui.dashboards.project.share_networks.share_network_subnets. \\"},{"line_number":24,"context_line":"    tables import CreateShareNetworkSubnet"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DELETABLE_STATES \u003d (\"INACTIVE\", \"ERROR\")"},{"line_number":27,"context_line":"EDITABLE_STATES \u003d (\"INACTIVE\", )"}],"source_content_type":"text/x-python","patch_set":2,"id":"fd9020dc_95cc4c76","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":42},"updated":"2024-07-17 22:57:39.000000000","message":"same import issue here","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a2c0c62838b1ad64bc736c9221ddadc669b47db7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from openstack_dashboard.api import neutron"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila_ui.api import manila"},{"line_number":23,"context_line":"from manila_ui.dashboards.project.share_networks.share_network_subnets. \\"},{"line_number":24,"context_line":"    tables import CreateShareNetworkSubnet"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DELETABLE_STATES \u003d (\"INACTIVE\", \"ERROR\")"},{"line_number":27,"context_line":"EDITABLE_STATES \u003d (\"INACTIVE\", )"}],"source_content_type":"text/x-python","patch_set":2,"id":"c15b9fc6_e2e4903c","line":24,"range":{"start_line":23,"start_character":0,"end_line":24,"end_character":42},"in_reply_to":"fd9020dc_95cc4c76","updated":"2024-07-23 18:08:17.000000000","message":"Acknowledged","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a39bfce84c363088435dbea4bcff11de76454532","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        row_actions \u003d ("},{"line_number":132,"context_line":"            EditShareNetwork,"},{"line_number":133,"context_line":"            Delete,"},{"line_number":134,"context_line":"            subnet_tables.CreateShareNetworkSubnet"},{"line_number":135,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"02539c34_ebb690b2","line":134,"range":{"start_line":134,"start_character":49,"end_line":134,"end_character":50},"updated":"2024-07-24 19:01:04.000000000","message":"add a trailing comma","commit_id":"ca406d8e2dd171ad514f57826bebd5e3d8cd5406"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"9563b39240646097661da801e7316c5380c4091a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        row_actions \u003d ("},{"line_number":132,"context_line":"            EditShareNetwork,"},{"line_number":133,"context_line":"            Delete,"},{"line_number":134,"context_line":"            subnet_tables.CreateShareNetworkSubnet"},{"line_number":135,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"c9771c43_d2d3f13d","line":134,"range":{"start_line":134,"start_character":49,"end_line":134,"end_character":50},"in_reply_to":"02539c34_ebb690b2","updated":"2024-07-28 17:32:10.000000000","message":"Acknowledged","commit_id":"ca406d8e2dd171ad514f57826bebd5e3d8cd5406"}],"manila_ui/tests/dashboards/project/share_networks/share_network_subnets/tests.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a39bfce84c363088435dbea4bcff11de76454532","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 NetApp, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"0bda0122_a6cd3b1d","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":33},"updated":"2024-07-24 19:01:04.000000000","message":"please remove this","commit_id":"ca406d8e2dd171ad514f57826bebd5e3d8cd5406"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"9563b39240646097661da801e7316c5380c4091a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 NetApp, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"ada723d7_ac3da592","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":33},"in_reply_to":"0bda0122_a6cd3b1d","updated":"2024-07-28 17:32:10.000000000","message":"Acknowledged","commit_id":"ca406d8e2dd171ad514f57826bebd5e3d8cd5406"}],"releasenotes/notes/add-share-network-subnet-create-option-a8f8a8e6305cc94d.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c0e3f6df6c0385184d6006d329c3501aec974741","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add share network subnet create option under share network actions."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e92bc565_23b57285","line":4,"range":{"start_line":4,"start_character":70,"end_line":4,"end_character":71},"updated":"2024-07-17 18:06:33.000000000","message":"please add a blank line at the end of the file","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"},{"author":{"_account_id":36889,"name":"tspyderboy","display_name":"tspyderboy","email":"tspyderboy@gmail.com","username":"tspyderboy"},"change_message_id":"a2c0c62838b1ad64bc736c9221ddadc669b47db7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add share network subnet create option under share network actions."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d42f13e2_c20c12c3","line":4,"range":{"start_line":4,"start_character":70,"end_line":4,"end_character":71},"in_reply_to":"e92bc565_23b57285","updated":"2024-07-23 18:08:17.000000000","message":"Acknowledged","commit_id":"0ca39814c75617b21f60eaa1e7b6b7ad0468e917"}]}