)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1fea2d671a2bd5d835102db274ec62bb301e43c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c25663b3_07ac5773","updated":"2025-06-11 16:00:52.000000000","message":"Hey, Logan! Thanks for working on this change. I have realized that most of the issues are related to the imports. I have also realized that you ended up submitting a second change [1] to address the issues with pep8, however, those updates need to be a part of this change, so here are some instructions for you to merge the other change and this one and proceed fixing the instructions:\n\n1. On the second change\u0027s page [1], please find the download button and click on the checkout option, and copy it to your clipboard.\n2. In your manila-ui repository locally, where you are pushing code from, please paste the command for the checkout.\n3. Reset the additional commit with this command: `git reset --soft HEAD~1`\n4. Run the command: `git add .`\n5. Run the command: `git commit --amend`\n6. Run the command: `git review`\n\nWhat this will do: it will check out to the commit tree, undo the commit that is at the top and amend the changes to this commit and push the changes to gerrit. Gerrit and git work differently, so please remember that every time that you have already pushed one change to gerrit and you are only updating it because of comments, you should not run git commit, as it will create a new change on gerrit, instead you should run git commit --amend, so that you amend the changes you are making into the change that is already proposed. \n\n[1] https://review.opendev.org/c/openstack/manila-ui/+/948897/2","commit_id":"8922452e487c704e820bc6154900c130c66dd6c0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"efdd2e45_c3551c7d","updated":"2025-06-27 20:09:11.000000000","message":"Hey, Logan! Thanks for working on the changes. PLease take a look at the comments inline","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"1f413d66c01bf5ea7e4bbaa95e6bc5800468c36c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"a4732cc1_c83ca422","updated":"2025-07-04 17:41:42.000000000","message":"@loganhas@yahoo.com Hello Logan, please add release notes in this MR.","commit_id":"63c2674828a88ba05c71e33031b03effe07bb764"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"943e2b166c614191e6bbe4e7e5ce126116a246ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"a126e6a2_5d806f36","updated":"2025-07-15 16:35:05.000000000","message":"Thanks for working on this change, Logan. Please take a look at the pep8 comments inline. Could you also please add the share server id field to the share manage page?","commit_id":"4aee6d2a95d5d959e1005c66061d092aef180ccf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"25796cae00eb41b483aabcf68bc3f7e96d5f4842","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"398d7c60_2068796b","updated":"2025-07-31 10:31:41.000000000","message":"Hey, Logan. Please take a look at the comments inline. I have two other requests:\n\nCould you please add the share server field while managing shares as well?\nCould you please mark the comments you resolved as done and resolved?","commit_id":"a18f7cb5e3f97af351a95422766282c959175a44"}],"manila_ui/dashboards/admin/share_servers/forms.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1fea2d671a2bd5d835102db274ec62bb301e43c9","unresolved":true,"context_lines":[{"line_number":1,"context_line":"class ManageShareServer(forms.SelfHandlingForm):"},{"line_number":2,"context_line":"    name \u003d forms.CharField("},{"line_number":3,"context_line":"        max_length\u003d255, label\u003d_(\"Share Server Name\"), required\u003dFalse,"},{"line_number":4,"context_line":"        help_text\u003d_(\"Share Sever name to be assigned\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"25cbdf60_8354a84a","line":1,"updated":"2025-06-11 16:00:52.000000000","message":"so, you\u0027re missing some imports here, that\u0027s why you see this undefined name \u0027forms\u0027 message. You\u0027ll need to do some imports as in [1]\n\n[1] https://github.com/openstack/manila-ui/blob/master/manila_ui/dashboards/project/share_group_snapshots/forms.py#L16-L22","commit_id":"99603dfa62d10b2660a21b4b992eae03f3aa9c7d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":28,"context_line":"class ManageShareServer(forms.SelfHandlingForm):"},{"line_number":29,"context_line":"    name \u003d forms.CharField("},{"line_number":30,"context_line":"        max_length\u003d255, label\u003d_(\"Share Server Name\"),"},{"line_number":31,"context_line":"                                            required\u003dFalse,"},{"line_number":32,"context_line":"        help_text\u003d_(\"Share Sever name to be assigned\"))"},{"line_number":33,"context_line":"    description \u003d forms.CharField("},{"line_number":34,"context_line":"        max_length\u003d255, label\u003d_(\"Description\"), required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":31,"id":"f8160e06_00d0d166","line":31,"in_reply_to":"a56b6bc2_39e5681f","updated":"2025-06-27 20:09:11.000000000","message":"\u003e pep8: E131 continuation line unaligned for hanging indent\n\nPlease fix.","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ManageShareServer(forms.SelfHandlingForm):"},{"line_number":29,"context_line":"    name \u003d forms.CharField("},{"line_number":30,"context_line":"        max_length\u003d255, label\u003d_(\"Share Server Name\"),"},{"line_number":31,"context_line":"                                            required\u003dFalse,"},{"line_number":32,"context_line":"        help_text\u003d_(\"Share Sever name to be assigned\"))"},{"line_number":33,"context_line":"    description \u003d forms.CharField("},{"line_number":34,"context_line":"        max_length\u003d255, label\u003d_(\"Description\"), required\u003dFalse,"},{"line_number":35,"context_line":"        widget\u003dforms.Textarea("},{"line_number":36,"context_line":"            attrs\u003d{\u0027class\u0027: \u0027modal-body-fixed-width\u0027, \u0027rows\u0027: 4}))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    host \u003d forms.CharField("},{"line_number":39,"context_line":"        max_length\u003d255, label\u003d_(\"Host of share server\"), required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":31,"id":"978244af_64159626","line":36,"range":{"start_line":29,"start_character":3,"end_line":36,"end_character":66},"updated":"2025-06-27 20:09:11.000000000","message":"Please remove these, they are not part of the share server adopt parameters. You can find all of them here: https://paste.opendev.org/show/bj2mUUlZkHeCaov3HaSN/","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":36,"context_line":"            attrs\u003d{\u0027class\u0027: \u0027modal-body-fixed-width\u0027, \u0027rows\u0027: 4}))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    host \u003d forms.CharField("},{"line_number":39,"context_line":"        max_length\u003d255, label\u003d_(\"Host of share server\"), required\u003dFalse,"},{"line_number":40,"context_line":"        help_text\u003d_("},{"line_number":41,"context_line":"            \"Host where share server is located,\" +"},{"line_number":42,"context_line":"                                      \"example: some.host@driver[#pool]\"))"}],"source_content_type":"text/x-python","patch_set":31,"id":"22ccf2e1_3f14e95a","line":39,"range":{"start_line":39,"start_character":66,"end_line":39,"end_character":71},"updated":"2025-06-27 20:09:11.000000000","message":"True","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        max_length\u003d255, label\u003d_(\"Host of share server\"), required\u003dFalse,"},{"line_number":40,"context_line":"        help_text\u003d_("},{"line_number":41,"context_line":"            \"Host where share server is located,\" +"},{"line_number":42,"context_line":"                                      \"example: some.host@driver[#pool]\"))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    protocol \u003d forms.ChoiceField(label\u003d_(\"Share Server Network\"),"},{"line_number":45,"context_line":"                                    required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa27c21b_3795d50b","line":42,"range":{"start_line":42,"start_character":48,"end_line":42,"end_character":72},"updated":"2025-06-27 20:09:11.000000000","message":"some.host@driver\n\nthe pool cannot be specified","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        max_length\u003d255, label\u003d_(\"Host of share server\"), required\u003dFalse,"},{"line_number":40,"context_line":"        help_text\u003d_("},{"line_number":41,"context_line":"            \"Host where share server is located,\" +"},{"line_number":42,"context_line":"                                      \"example: some.host@driver[#pool]\"))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    protocol \u003d forms.ChoiceField(label\u003d_(\"Share Server Network\"),"},{"line_number":45,"context_line":"                                    required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":31,"id":"f2dee30c_bbed08f4","line":42,"in_reply_to":"e20a2d09_1dcdd4ce","updated":"2025-06-27 20:09:11.000000000","message":"\u003e pep8: E131 continuation line unaligned for hanging indent\n\nPlease fix.","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            \"Host where share server is located,\" +"},{"line_number":42,"context_line":"                                      \"example: some.host@driver[#pool]\"))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    protocol \u003d forms.ChoiceField(label\u003d_(\"Share Server Network\"),"},{"line_number":45,"context_line":"                                    required\u003dFalse)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    driver_options \u003d forms.CharField("}],"source_content_type":"text/x-python","patch_set":31,"id":"96267071_3e97aeee","line":44,"range":{"start_line":44,"start_character":42,"end_line":44,"end_character":62},"updated":"2025-06-27 20:09:11.000000000","message":"Share network","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            \"Host where share server is located,\" +"},{"line_number":42,"context_line":"                                      \"example: some.host@driver[#pool]\"))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    protocol \u003d forms.ChoiceField(label\u003d_(\"Share Server Network\"),"},{"line_number":45,"context_line":"                                    required\u003dFalse)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    driver_options \u003d forms.CharField("}],"source_content_type":"text/x-python","patch_set":31,"id":"cf4bfab3_599b0b66","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":12},"updated":"2025-06-27 20:09:11.000000000","message":"share_network","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":42,"context_line":"                                      \"example: some.host@driver[#pool]\"))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    protocol \u003d forms.ChoiceField(label\u003d_(\"Share Server Network\"),"},{"line_number":45,"context_line":"                                    required\u003dFalse)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    driver_options \u003d forms.CharField("},{"line_number":48,"context_line":"        max_length\u003d255, required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":31,"id":"683a66fd_8e88153b","line":45,"in_reply_to":"433b4d46_6e566862","updated":"2025-06-27 20:09:11.000000000","message":"\u003e pep8: E127 continuation line over-indented for visual indent\n\nPlease fix.","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":45,"context_line":"                                    required\u003dFalse)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    driver_options \u003d forms.CharField("},{"line_number":48,"context_line":"        max_length\u003d255, required\u003dTrue,"},{"line_number":49,"context_line":"        label\u003d_(\"Driver options (\u0027volume_id\u0027 for Generic driver, etc...)\"),"},{"line_number":50,"context_line":"        help_text\u003d_(\"key\u003dvalue pairs per line can be set\"),"},{"line_number":51,"context_line":"        widget\u003dforms.Textarea("}],"source_content_type":"text/x-python","patch_set":31,"id":"b7ee8d7a_3fe9c782","line":48,"range":{"start_line":48,"start_character":33,"end_line":48,"end_character":37},"updated":"2025-06-27 20:09:11.000000000","message":"False\ndirever_options are optional","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        label\u003d_(\"Public\"), required\u003dFalse, initial\u003dFalse,"},{"line_number":55,"context_line":"        help_text\u003d(\"Defines whether this share server is available\" +"},{"line_number":56,"context_line":"                   \" for all or not.\"))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    share_server_type \u003d forms.ChoiceField("},{"line_number":59,"context_line":"        label\u003d_(\"Share_Servers_Network_Subnet_ID\"), required\u003dTrue)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"e9e1e461_bb08b3fc","line":57,"updated":"2025-06-27 20:09:11.000000000","message":"please add share network subnet to this list","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        help_text\u003d(\"Defines whether this share server is available\" +"},{"line_number":56,"context_line":"                   \" for all or not.\"))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    share_server_type \u003d forms.ChoiceField("},{"line_number":59,"context_line":"        label\u003d_(\"Share_Servers_Network_Subnet_ID\"), required\u003dTrue)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":62,"context_line":"        super(ManageShareServer, self).__init__(request, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":31,"id":"3ee88817_750dd484","line":59,"range":{"start_line":58,"start_character":1,"end_line":59,"end_character":66},"updated":"2025-06-27 20:09:11.000000000","message":"please remove this, as only shares are tied to share types","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":139,"context_line":"    def handle(self, request, data):"},{"line_number":140,"context_line":"        try:"},{"line_number":141,"context_line":"            manila.share_server_unmanage(request,"},{"line_number":142,"context_line":"                                        self.initial[\u0027share_server_id\u0027])"},{"line_number":143,"context_line":"            messages.success("},{"line_number":144,"context_line":"                request,"},{"line_number":145,"context_line":"                _(\u0027Successfully sent the request to unmanage share server: %s\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"6c36e060_c9dc887a","line":142,"in_reply_to":"9fccdea4_dae99dbb","updated":"2025-06-27 20:09:11.000000000","message":"\u003e pep8: E128 continuation line under-indented for visual indent\n\nPlease fix.","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"943e2b166c614191e6bbe4e7e5ce126116a246ee","unresolved":true,"context_lines":[{"line_number":27,"context_line":"class ManageShareServer(forms.SelfHandlingForm):"},{"line_number":28,"context_line":"    name \u003d forms.CharField("},{"line_number":29,"context_line":"        max_length\u003d255, label\u003d_(\"Share Server Name\"),"},{"line_number":30,"context_line":"                        required\u003dFalse,"},{"line_number":31,"context_line":"        )"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    host \u003d forms.CharField("}],"source_content_type":"text/x-python","patch_set":47,"id":"380b86a3_b52592c9","line":30,"in_reply_to":"bd8ebd8d_968e85bc","updated":"2025-07-15 16:35:05.000000000","message":"\u003e pep8: E131 continuation line unaligned for hanging indent\n\nPlease fix.","commit_id":"4aee6d2a95d5d959e1005c66061d092aef180ccf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"943e2b166c614191e6bbe4e7e5ce126116a246ee","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        max_length\u003d255, label\u003d_(\"Host of share server\"), required\u003dTrue,"},{"line_number":35,"context_line":"        help_text\u003d_("},{"line_number":36,"context_line":"            \"Host where share server is located,\" +"},{"line_number":37,"context_line":"                        \"example: some.host@driver\"))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    protocol \u003d forms.ChoiceField(label\u003d_(\"share_network\"),"},{"line_number":40,"context_line":"                                 required\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":47,"id":"dcb798b4_0e86f59f","line":37,"in_reply_to":"0883dcae_a0fe15cf","updated":"2025-07-15 16:35:05.000000000","message":"\u003e pep8: E131 continuation line unaligned for hanging indent\n\nPlease fix.","commit_id":"4aee6d2a95d5d959e1005c66061d092aef180ccf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"25796cae00eb41b483aabcf68bc3f7e96d5f4842","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 NetApp, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":55,"id":"12183b52_87a37971","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":2},"updated":"2025-07-31 10:31:41.000000000","message":"please remove this line","commit_id":"a18f7cb5e3f97af351a95422766282c959175a44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"25796cae00eb41b483aabcf68bc3f7e96d5f4842","unresolved":true,"context_lines":[{"line_number":36,"context_line":"            \"Host where share server is located,\" +"},{"line_number":37,"context_line":"            \"example: some.host@driver\"))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    protocol \u003d forms.ChoiceField(label\u003d_(\"share_network\"),"},{"line_number":40,"context_line":"                                 required\u003dFalse)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    driver_options \u003d forms.CharField("}],"source_content_type":"text/x-python","patch_set":55,"id":"ac4135d0_021c2d97","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":12},"updated":"2025-07-31 10:31:41.000000000","message":"share_network","commit_id":"a18f7cb5e3f97af351a95422766282c959175a44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"25796cae00eb41b483aabcf68bc3f7e96d5f4842","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    driver_options \u003d forms.CharField("},{"line_number":43,"context_line":"        max_length\u003d255, required\u003dFalse,"},{"line_number":44,"context_line":"        label\u003d_(\"Driver options (\u0027volume_id\u0027 for Generic driver, etc...)\"),"},{"line_number":45,"context_line":"        help_text\u003d_(\"key\u003dvalue pairs per line can be set\"),"},{"line_number":46,"context_line":"        widget\u003dforms.Textarea("},{"line_number":47,"context_line":"            attrs\u003d{\u0027class\u0027: \u0027modal-body-fixed-width\u0027, \u0027rows\u0027: 2}))"}],"source_content_type":"text/x-python","patch_set":55,"id":"211c925a_77a10eae","line":44,"range":{"start_line":44,"start_character":17,"end_line":44,"end_character":72},"updated":"2025-07-31 10:31:41.000000000","message":"please replace this... this is related to shares management, you\u0027ll need a text that asks for the driver options of the share server","commit_id":"a18f7cb5e3f97af351a95422766282c959175a44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"25796cae00eb41b483aabcf68bc3f7e96d5f4842","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        widget\u003dforms.Textarea("},{"line_number":47,"context_line":"            attrs\u003d{\u0027class\u0027: \u0027modal-body-fixed-width\u0027, \u0027rows\u0027: 2}))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    share_network_subnet \u003d forms.ChoiceField(label\u003d(\"share_network_subnet\"),"},{"line_number":50,"context_line":"                                             required\u003dFalse)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    share_server_id \u003d forms.ChoiceField(label\u003d(\"share_server_id\"),"},{"line_number":53,"context_line":"                                        required\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":55,"id":"09cbac01_c5f482db","line":50,"range":{"start_line":49,"start_character":27,"end_line":50,"end_character":60},"updated":"2025-07-31 10:31:41.000000000","message":"this choicefield has to be populated","commit_id":"a18f7cb5e3f97af351a95422766282c959175a44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"25796cae00eb41b483aabcf68bc3f7e96d5f4842","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":56,"context_line":"        super(ManageShareServer, self).__init__(request, *args, **kwargs)"},{"line_number":57,"context_line":"        manila_features \u003d getattr(settings, \u0027OPENSTACK_MANILA_FEATURES\u0027, {})"},{"line_number":58,"context_line":"        self.enabled_share_server_protocols \u003d manila_features.get("},{"line_number":59,"context_line":"            \u0027enabled_share_server_protocols\u0027,"},{"line_number":60,"context_line":"            [\u0027NFS\u0027, \u0027CIFS\u0027, \u0027GlusterFS\u0027, \u0027HDFS\u0027, \u0027CephFS\u0027, \u0027MapRFS\u0027])"},{"line_number":61,"context_line":"        self.fields[\u0027protocol\u0027].choices \u003d ([(\u0027 \u0027, \u0027 \u0027)] +"},{"line_number":62,"context_line":"                                           [(enabled_proto, enabled_proto)"},{"line_number":63,"context_line":"                                           for enabled_proto in"},{"line_number":64,"context_line":"                                           self.enabled_share_server_protocols]"},{"line_number":65,"context_line":"                                           )"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def handle(self, request, data):"},{"line_number":68,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":55,"id":"0b4c538a_7db7ae16","line":65,"range":{"start_line":58,"start_character":8,"end_line":65,"end_character":44},"updated":"2025-07-31 10:31:41.000000000","message":"we don\u0027t need protocols while managing share servers, only shares need that","commit_id":"a18f7cb5e3f97af351a95422766282c959175a44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"25796cae00eb41b483aabcf68bc3f7e96d5f4842","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            manila.share_server_manage("},{"line_number":87,"context_line":"                request,"},{"line_number":88,"context_line":"                service_host\u003ddata[\u0027host\u0027],"},{"line_number":89,"context_line":"                protocol\u003ddata[\u0027protocol\u0027],"},{"line_number":90,"context_line":"                share_network_subnet\u003ddata[\"share_network_subnet\"],"},{"line_number":91,"context_line":"                name\u003ddata[\u0027name\u0027],"},{"line_number":92,"context_line":"                share_server_id\u003ddata[\u0027share_server_id\u0027],"}],"source_content_type":"text/x-python","patch_set":55,"id":"aa77ff9b_4c170fc7","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":42},"updated":"2025-07-31 10:31:41.000000000","message":"no need for the protocol and you might need share network instead","commit_id":"a18f7cb5e3f97af351a95422766282c959175a44"}],"manila_ui/dashboards/admin/share_servers/views.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        try:"},{"line_number":133,"context_line":"            share_server_id \u003d self.kwargs[\u0027share_server_id\u0027]"},{"line_number":134,"context_line":"            share_server \u003d manila.share_server_get(self.request,"},{"line_number":135,"context_line":"                                        share_server_id)"},{"line_number":136,"context_line":"        except Exception:"},{"line_number":137,"context_line":"            exceptions.handle("},{"line_number":138,"context_line":"                self.request, _(\u0027Unable to retrieve volume details.\u0027),"}],"source_content_type":"text/x-python","patch_set":31,"id":"df6527cd_3a61ca18","line":135,"in_reply_to":"a8fb6301_0546d604","updated":"2025-06-27 20:09:11.000000000","message":"\u003e pep8: E128 continuation line under-indented for visual indent\n\nPlease fix.","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ee28e3f96155f11e3b140e865aea70493676ed9f","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                                        share_server_id)"},{"line_number":136,"context_line":"        except Exception:"},{"line_number":137,"context_line":"            exceptions.handle("},{"line_number":138,"context_line":"                self.request, _(\u0027Unable to retrieve volume details.\u0027),"},{"line_number":139,"context_line":"                redirect\u003dself.success_url)"},{"line_number":140,"context_line":"        return share_server"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"307dcd01_fe7ace3f","line":138,"range":{"start_line":138,"start_character":52,"end_line":138,"end_character":58},"updated":"2025-06-27 20:09:11.000000000","message":"share server","commit_id":"b4ca1c0d7ecbdbb03008c76af42cfe9a3b51c8f7"}]}