)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"8fb23a1275fbbc6c3ccfad3ef2e44ea693b0bd8d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jan Jasek \u003cjjasek@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-02 10:38:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pytest-based selenium tests add shares tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"test_edit_share_description_demo"},{"line_number":10,"context_line":"test_resize_share_demo"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a4629629_d726d584","line":7,"updated":"2025-09-10 18:47:00.000000000","message":"Please specify the share types, protocols tested","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"5b346dd4d5a199dee41c3cbbcef91161f95bca0a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jan Jasek \u003cjjasek@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-02 10:38:33 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"pytest-based selenium tests add shares tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"test_edit_share_description_demo"},{"line_number":10,"context_line":"test_resize_share_demo"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4f3f174b_553ea4de","line":7,"in_reply_to":"a4629629_d726d584","updated":"2025-09-11 12:27:44.000000000","message":"Done","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"8fb23a1275fbbc6c3ccfad3ef2e44ea693b0bd8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a359d6a7_3ac34521","updated":"2025-09-10 18:47:00.000000000","message":"Thanks for the test coverage Jan. Some questions and code optimization comments inline.","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"c578da76a02419b02f80ba28ff0810dc0775e307","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2e2231bf_b57242b2","updated":"2025-09-22 16:30:03.000000000","message":"@ces.eduardo98@gmail.com @gouthampravi@gmail.com, Hi guys, could you please review this?\nAll the tests are still running as non-voting and there may be some small changes during implementation of other tests (snapshots, rules, groups, etc). There will be several upcoming patches that I am already working on.\nBut I need some cooperation from your side to speed it up a bit and move it forward.\nThanks!","commit_id":"62db1b17c64eec018dbe206ea74acc73b0bac7bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f104eb1296befacc8a76855b7830ff73cf45c0c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"454f95b4_3038ec3a","updated":"2025-10-01 16:10:04.000000000","message":"LGTM, thank you Jan!","commit_id":"62db1b17c64eec018dbe206ea74acc73b0bac7bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"93a5749af0fe0fe294290a1cc65e59531a6b7cda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3654be4c_3299aad6","updated":"2025-10-02 02:30:30.000000000","message":"Very nice; ty for adding these tests @jjasek@redhat.com","commit_id":"62db1b17c64eec018dbe206ea74acc73b0bac7bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d1d6bf92467742fdae130bad90016e20b0a9e2bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"40788aa7_1c956706","in_reply_to":"454f95b4_3038ec3a","updated":"2025-10-01 16:10:37.000000000","message":".... and apologies for the delay on the review!","commit_id":"62db1b17c64eec018dbe206ea74acc73b0bac7bf"}],"manila_ui/tests/selenium/integration/test_shares.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"8fb23a1275fbbc6c3ccfad3ef2e44ea693b0bd8d","unresolved":true,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@pytest.fixture"},{"line_number":28,"context_line":"def new_share_demo(share_name, openstack_demo):"},{"line_number":29,"context_line":"    share \u003d openstack_demo.shared_file_system.create_share("},{"line_number":30,"context_line":"        name\u003dshare_name,"},{"line_number":31,"context_line":"        size\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d7957b3d_b16e41b8","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":47},"updated":"2025-09-10 18:47:00.000000000","message":"Can new_share_demo \u0026 new_share_admin be combined into a single pytest fixture for improved code reuse. The new fixture could pass a new param to specify the user role such as demo or admin","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"5b346dd4d5a199dee41c3cbbcef91161f95bca0a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@pytest.fixture"},{"line_number":28,"context_line":"def new_share_demo(share_name, openstack_demo):"},{"line_number":29,"context_line":"    share \u003d openstack_demo.shared_file_system.create_share("},{"line_number":30,"context_line":"        name\u003dshare_name,"},{"line_number":31,"context_line":"        size\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"26cb5d71_8e37f39d","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":47},"in_reply_to":"d7957b3d_b16e41b8","updated":"2025-09-11 12:27:44.000000000","message":"Done","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"8fb23a1275fbbc6c3ccfad3ef2e44ea693b0bd8d","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"@pytest.fixture"},{"line_number":41,"context_line":"def new_share_admin(share_name, openstack_admin):"},{"line_number":42,"context_line":"    share \u003d openstack_admin.shared_file_system.create_share("},{"line_number":43,"context_line":"        name\u003dshare_name,"},{"line_number":44,"context_line":"        size\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6e6f17c3_045a77eb","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":49},"updated":"2025-09-10 18:47:00.000000000","message":"See ^^","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"5b346dd4d5a199dee41c3cbbcef91161f95bca0a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"@pytest.fixture"},{"line_number":41,"context_line":"def new_share_admin(share_name, openstack_admin):"},{"line_number":42,"context_line":"    share \u003d openstack_admin.shared_file_system.create_share("},{"line_number":43,"context_line":"        name\u003dshare_name,"},{"line_number":44,"context_line":"        size\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8e5ed2fb_7dbc1b92","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":49},"in_reply_to":"6e6f17c3_045a77eb","updated":"2025-09-11 12:27:44.000000000","message":"Done","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"8fb23a1275fbbc6c3ccfad3ef2e44ea693b0bd8d","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                [\"available\", \"error\", \"inactive\"]):"},{"line_number":75,"context_line":"            break"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            time.sleep(3)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def wait_for_share_is_deleted(openstack, share_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"203cad88_332fe765","line":77,"range":{"start_line":77,"start_character":11,"end_line":77,"end_character":25},"updated":"2025-09-10 18:47:00.000000000","message":"Is this time random/optimal?","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"5b346dd4d5a199dee41c3cbbcef91161f95bca0a","unresolved":true,"context_lines":[{"line_number":74,"context_line":"                [\"available\", \"error\", \"inactive\"]):"},{"line_number":75,"context_line":"            break"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            time.sleep(3)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def wait_for_share_is_deleted(openstack, share_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"f9194b66_49595022","line":77,"range":{"start_line":77,"start_character":11,"end_line":77,"end_character":25},"in_reply_to":"203cad88_332fe765","updated":"2025-09-11 12:27:44.000000000","message":"3s - random, 3x120\u003d360s optimal deadline from experience with Cinder (Upstream Zuul).\n\nYou can put anything you want there.\nToo low number - polling too frequently -  unnecessary load, can cause you to exceed the limit. But maybe you will save second on the test run.\nToo high number - your tests can take second more.\n\nSo no big deal.","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"8fb23a1275fbbc6c3ccfad3ef2e44ea693b0bd8d","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        if openstack.shared_file_system.find_share(share_name) is None:"},{"line_number":83,"context_line":"            break"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            time.sleep(3)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def test_create_share_demo(login, driver, share_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d1658d71_6eab46a1","line":85,"range":{"start_line":85,"start_character":11,"end_line":85,"end_character":25},"updated":"2025-09-10 18:47:00.000000000","message":"Same ^^","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"5b346dd4d5a199dee41c3cbbcef91161f95bca0a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if openstack.shared_file_system.find_share(share_name) is None:"},{"line_number":83,"context_line":"            break"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            time.sleep(3)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"def test_create_share_demo(login, driver, share_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"179c31f7_d6432bf5","line":85,"range":{"start_line":85,"start_character":11,"end_line":85,"end_character":25},"in_reply_to":"d1658d71_6eab46a1","updated":"2025-09-11 12:27:44.000000000","message":"Done","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"8fb23a1275fbbc6c3ccfad3ef2e44ea693b0bd8d","unresolved":true,"context_lines":[{"line_number":157,"context_line":"        f\"EDITED_Description for: {new_share_demo.name}\")"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def test_resize_share_demo(login, driver, openstack_demo,"},{"line_number":161,"context_line":"                           config, new_share_demo):"},{"line_number":162,"context_line":"    login(\u0027user\u0027)"},{"line_number":163,"context_line":"    url \u003d \u0027/\u0027.join(("}],"source_content_type":"text/x-python","patch_set":2,"id":"8ab31a0b_13489558","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":57},"updated":"2025-09-10 18:47:00.000000000","message":"Please see code reuse comment above. The remaining function pairs for demo/admin user can likely be optimized by adding a new parameter for user role.\nEx: below function pairs can be integrated into a single pytest with role passed in \ntest_resize_share_demo \u0026 test_resize_share_admin\ntest_edit_share_metadata_demo \u0026 test_edit_share_metadata_admin","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"5b346dd4d5a199dee41c3cbbcef91161f95bca0a","unresolved":true,"context_lines":[{"line_number":157,"context_line":"        f\"EDITED_Description for: {new_share_demo.name}\")"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def test_resize_share_demo(login, driver, openstack_demo,"},{"line_number":161,"context_line":"                           config, new_share_demo):"},{"line_number":162,"context_line":"    login(\u0027user\u0027)"},{"line_number":163,"context_line":"    url \u003d \u0027/\u0027.join(("}],"source_content_type":"text/x-python","patch_set":2,"id":"f5c1f533_8691d45a","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":57},"in_reply_to":"8ab31a0b_13489558","updated":"2025-09-11 12:27:44.000000000","message":"I tried to find a way like this when I started with reimplementation of the tests for Horizon - without success.\nNow when your comment pushed me to try it again with all the new knowledge I have and with the experience from countless issues that I was facing during reimplementation of the Horizon tests, it seems possible. Although it includes significantly more changes than just using a different parameter for the function because it is not a standard function - as it is decorated with pytest.fixtures it becomes a dependency injection.\nAnyway - the new implementation with combined fixtures works.\nAs it is a little different approach than we use in Horizon, I am not 100% sure that it will not bring some other issues/bottlenecks in the next implementation.\nThe tests execution will also take a little more time for execution (especially in the downstream in high load jobs or when the upstream server will be overloaded) because as it is running alternately (admin/demo) then we lose the advantage of session scope of the login fixture and every test will log in separately. I am not sure from the top of my head if it has some elegant solution.\nAnd of course we lose the possibility to manipulate with single tests but it is the price for having less code.\n\nIt is significantly less code without doubt, it looks good and I will be more than happy to test it (if it has some bottlenecks or brings some complication and how time significant will be login and login again) somewhere else than directly in Horizon integration tests :-D.","commit_id":"eeb4f72123aff7f95771ab7d26fb738c3d1bb13d"}]}