)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"81a840a7259cf9e6df4f8df6a79257388bff0c84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"df1c3d33_c9b57bff","updated":"2025-09-10 16:24:32.000000000","message":"I have to double check this to be sure","commit_id":"077fa32eb7d187d0cf345952b76336b36e79bad5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b49c7c1c56bfb4da58b9c48d90bc66bee40b8347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7b8c4d23_1c00426b","updated":"2025-10-09 23:05:44.000000000","message":"Please see: https://review.opendev.org/c/openstack/manila-ui/+/963640","commit_id":"73b9ee4c3412c03f4efafdc0c1d08b2fe8dca97b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7d43681ea7e39b56d4050c78186aff20a01897f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7eee958d_6ba83360","updated":"2025-10-09 23:04:14.000000000","message":"https://opendev.org/openstack/manila-ui/src/commit/9f62587916e2fe313378b5f8ddb9b57139cddfba/manila_ui/dashboards/project/share_networks/views.py#L128-L130\n\nWe can\u0027t just remove testing without addressing the SDK usage itself.\n\nWill follow up with a change","commit_id":"73b9ee4c3412c03f4efafdc0c1d08b2fe8dca97b"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a28ffe9fcb7ff8d64133a9e47d0e57e3f163b562","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da970a55_86704225","in_reply_to":"7b8c4d23_1c00426b","updated":"2025-10-10 08:36:46.000000000","message":"+1, I check it","commit_id":"73b9ee4c3412c03f4efafdc0c1d08b2fe8dca97b"}],"manila_ui/tests/dashboards/admin/share_networks/tests.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e54428558c78f7b7c8e0552418aa5e24994ec59c","unresolved":true,"context_lines":[{"line_number":132,"context_line":"            mock.Mock(return_value\u003d[sec_service]))"},{"line_number":133,"context_line":"        self.mock_object("},{"line_number":134,"context_line":"            api_neutron, \"network_get\", mock.Mock("},{"line_number":135,"context_line":"                side_effect\u003dexceptions.NeutronClientException(\u0027fake\u0027, 500)))"},{"line_number":136,"context_line":"        self.mock_object("},{"line_number":137,"context_line":"            api_neutron, \"subnet_get\", mock.Mock("},{"line_number":138,"context_line":"                side_effect\u003dexceptions.NeutronClientException(\u0027fake\u0027, 500)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"e12d5545_40f07a36","side":"PARENT","line":135,"range":{"start_line":135,"start_character":28,"end_line":135,"end_character":75},"updated":"2025-09-10 16:27:05.000000000","message":"In horizon if NotFound is back from the client (now it is SDK) than we just return (see with neutronclient: https://opendev.org/openstack/horizon/src/branch/stable/2024.1/openstack_dashboard/api/neutron.py#L1578 , and with SDK: https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/api/neutron.py#L1676 )\nSo I would say this is the correct mock, but I have to check exactly what happens here (true for the other occurance in project/share_network... )","commit_id":"40a8a1075c3bd0315c5b25b8a5caf6bdb1ef3c30"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7d43681ea7e39b56d4050c78186aff20a01897f5","unresolved":true,"context_lines":[{"line_number":132,"context_line":"            mock.Mock(return_value\u003d[sec_service]))"},{"line_number":133,"context_line":"        self.mock_object("},{"line_number":134,"context_line":"            api_neutron, \"network_get\", mock.Mock("},{"line_number":135,"context_line":"                side_effect\u003dexceptions.NeutronClientException(\u0027fake\u0027, 500)))"},{"line_number":136,"context_line":"        self.mock_object("},{"line_number":137,"context_line":"            api_neutron, \"subnet_get\", mock.Mock("},{"line_number":138,"context_line":"                side_effect\u003dexceptions.NeutronClientException(\u0027fake\u0027, 500)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"f61b9b7d_8a0cf582","side":"PARENT","line":135,"range":{"start_line":135,"start_character":28,"end_line":135,"end_character":75},"in_reply_to":"6f72a502_12e133e4","updated":"2025-10-09 23:04:14.000000000","message":"as i read it, with the SDK, \"network_get\" doesn\u0027t ignore a sdk_exceptions.ResourceNotFound error. The code ignores inaccessible subnets, but if a network isnt found, this error will be raised to the caller and would break the exception handling here: https://opendev.org/openstack/manila-ui/src/commit/9f62587916e2fe313378b5f8ddb9b57139cddfba/manila_ui/dashboards/project/share_networks/views.py#L124-L140\n\nI\u0027ll upload a change for this.","commit_id":"40a8a1075c3bd0315c5b25b8a5caf6bdb1ef3c30"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"02320affa99effcd108f864f20d28fae37c0a3c0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            mock.Mock(return_value\u003d[sec_service]))"},{"line_number":133,"context_line":"        self.mock_object("},{"line_number":134,"context_line":"            api_neutron, \"network_get\", mock.Mock("},{"line_number":135,"context_line":"                side_effect\u003dexceptions.NeutronClientException(\u0027fake\u0027, 500)))"},{"line_number":136,"context_line":"        self.mock_object("},{"line_number":137,"context_line":"            api_neutron, \"subnet_get\", mock.Mock("},{"line_number":138,"context_line":"                side_effect\u003dexceptions.NeutronClientException(\u0027fake\u0027, 500)))"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f72a502_12e133e4","side":"PARENT","line":135,"range":{"start_line":135,"start_character":28,"end_line":135,"end_character":75},"in_reply_to":"e12d5545_40f07a36","updated":"2025-10-02 12:14:30.000000000","message":"As I see this new mock is correct.","commit_id":"40a8a1075c3bd0315c5b25b8a5caf6bdb1ef3c30"}]}