)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"ccfa5c14192870e893eb1ece285721133a8b431f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba85de7f_f7552666","updated":"2025-12-11 17:09:13.000000000","message":"Hello @gouthampravi@gmail.com, I know that you are super busy, but if you have some time, could you please review this patch?","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b694952bc9aae9eca289980fe2bc6a992c385db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d117ed2_4cb79fc7","updated":"2025-11-13 13:21:15.000000000","message":"LGTM, thanks for working on this change, Jan","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"},{"author":{"_account_id":38469,"name":"Rose Kimondo","display_name":"Rose Kimondo","email":"rosewairimu1@gmail.com","username":"rosekimondo"},"change_message_id":"4b55d17ce6de5fc052feb5926b531a697413b7e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2ee8c1ee_07a1b906","updated":"2026-01-16 11:40:00.000000000","message":"Looks good to me","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"baf890762e11973d4701ecc610691b931f321f65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7c17b2ec_3abe4684","updated":"2026-01-15 14:50:56.000000000","message":"Looks good, thanks Jan.","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"394125fef898400f2305b16bdb328db4436b421e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"42d4b575_c7975b8a","updated":"2026-01-16 18:47:38.000000000","message":"Thanks for your patience with the reviews here; i\u0027ve some minor comments that you can address in a follow up patch if you\u0027d like, or respond to at your leisure","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"}],"manila_ui/tests/selenium/integration/conftest.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"394125fef898400f2305b16bdb328db4436b421e","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        share_id\u003dnew_share.id,"},{"line_number":57,"context_line":"        access_type\u003d\"ip\","},{"line_number":58,"context_line":"        access_level\u003d\"rw\","},{"line_number":59,"context_line":"        access_to\u003d\"10.0.10.10\""},{"line_number":60,"context_line":"    )"},{"line_number":61,"context_line":"    yield share_access_rule"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ae025f01_64185809","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":30},"updated":"2026-01-16 18:47:38.000000000","message":"https://datatracker.ietf.org/doc/html/rfc5737#section-3","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"f6e9e7f8502e46d28e08c74e7f5103a2932536da","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        share_id\u003dnew_share.id,"},{"line_number":57,"context_line":"        access_type\u003d\"ip\","},{"line_number":58,"context_line":"        access_level\u003d\"rw\","},{"line_number":59,"context_line":"        access_to\u003d\"10.0.10.10\""},{"line_number":60,"context_line":"    )"},{"line_number":61,"context_line":"    yield share_access_rule"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9423868e_ce1988a7","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":30},"in_reply_to":"ae025f01_64185809","updated":"2026-01-19 09:31:06.000000000","message":"Acknowledged","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"394125fef898400f2305b16bdb328db4436b421e","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        access_type\u003d\"ip\","},{"line_number":58,"context_line":"        access_level\u003d\"rw\","},{"line_number":59,"context_line":"        access_to\u003d\"10.0.10.10\""},{"line_number":60,"context_line":"    )"},{"line_number":61,"context_line":"    yield share_access_rule"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c812b59e_b352d27f","line":60,"updated":"2026-01-16 18:47:38.000000000","message":"a cleanup wasn\u0027t added here - just for parity/correctness.. \nmanila will still cleanup access rules when the share is deleted","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"f6e9e7f8502e46d28e08c74e7f5103a2932536da","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        access_type\u003d\"ip\","},{"line_number":58,"context_line":"        access_level\u003d\"rw\","},{"line_number":59,"context_line":"        access_to\u003d\"10.0.10.10\""},{"line_number":60,"context_line":"    )"},{"line_number":61,"context_line":"    yield share_access_rule"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ddee9ca4_0bd50fb0","line":60,"in_reply_to":"c812b59e_b352d27f","updated":"2026-01-19 09:31:06.000000000","message":"Hello, good point but I did not add there the cleanup on purpose. As you said, access rules are cleanup when share is deleted and share is deleted every time (as it is connected fixture - dependency).\nIt would make a sense to add the cleanup there in case the \"new_access_rule_for_share\" is independent fixture. But in the way how it is implemented and how we use it, add cleanup would just made the tests slower and code bigger. So I would prefer to not to use it there.","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9d9e5adbe345868fcd4c54296f0b1bd67f3f1372","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        access_type\u003d\"ip\","},{"line_number":58,"context_line":"        access_level\u003d\"rw\","},{"line_number":59,"context_line":"        access_to\u003d\"10.0.10.10\""},{"line_number":60,"context_line":"    )"},{"line_number":61,"context_line":"    yield share_access_rule"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"18a4896b_264ba177","line":60,"in_reply_to":"ddee9ca4_0bd50fb0","updated":"2026-01-19 17:33:24.000000000","message":"Acknowledged","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"}],"manila_ui/tests/selenium/integration/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"394125fef898400f2305b16bdb328db4436b421e","unresolved":true,"context_lines":[{"line_number":208,"context_line":"    ], indirect\u003d[\"new_share\", \"openstack_client\"])"},{"line_number":209,"context_line":"def test_create_share_access_rule(login, driver, config, new_share,"},{"line_number":210,"context_line":"                                  openstack_client, user_type):"},{"line_number":211,"context_line":"    test_rule_ip_address \u003d \"10.10.0.10\""},{"line_number":212,"context_line":"    login(user_type)"},{"line_number":213,"context_line":"    url \u003d \u0027/\u0027.join(("},{"line_number":214,"context_line":"        config.dashboard.dashboard_url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"54a3d492_d3c396e8","line":211,"range":{"start_line":211,"start_character":28,"end_line":211,"end_character":38},"updated":"2026-01-16 18:47:38.000000000","message":"Prefer test data to use IP addresses set aside for documentation: https://datatracker.ietf.org/doc/html/rfc5737#section-3","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"},{"author":{"_account_id":35133,"name":"Jan Jasek","email":"jjasek@redhat.com","username":"janjasek"},"change_message_id":"f6e9e7f8502e46d28e08c74e7f5103a2932536da","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    ], indirect\u003d[\"new_share\", \"openstack_client\"])"},{"line_number":209,"context_line":"def test_create_share_access_rule(login, driver, config, new_share,"},{"line_number":210,"context_line":"                                  openstack_client, user_type):"},{"line_number":211,"context_line":"    test_rule_ip_address \u003d \"10.10.0.10\""},{"line_number":212,"context_line":"    login(user_type)"},{"line_number":213,"context_line":"    url \u003d \u0027/\u0027.join(("},{"line_number":214,"context_line":"        config.dashboard.dashboard_url,"}],"source_content_type":"text/x-python","patch_set":2,"id":"674fe4b7_5e156e93","line":211,"range":{"start_line":211,"start_character":28,"end_line":211,"end_character":38},"in_reply_to":"54a3d492_d3c396e8","updated":"2026-01-19 09:31:06.000000000","message":"Oh, okay, I missed it. I will change it in upcoming patches.","commit_id":"e1abf9aa43c16c71cfc72e032c397bc6d9d84274"}]}