)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"092dc0bdd1d31ef868b59d0b668fd5f5c7602215","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Srinesh A R \u003csrinesh.a-r@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-08-11 16:38:35 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement new snapshot_inherit_share_access_support share capability"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Includes a new share capability snapshot_inherit_share_access_support."},{"line_number":10,"context_line":"Setting this will block mountable snapshot access rule modification for the share."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"35e630c2_4b516f0b","line":7,"updated":"2026-08-17 06:04:50.000000000","message":"I think we can add below points to the commit message:\n- Microversion 2.99\n- New DB column and API field\n- Snapshot access API blocking behavior\n- Relationship to mountable snapshot / inherit-only backends","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"79aa7b478e8fe947eb8f8a94a115792f84af6e16","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Srinesh A R \u003csrinesh.a-r@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-08-11 16:38:35 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement new snapshot_inherit_share_access_support share capability"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Includes a new share capability snapshot_inherit_share_access_support."},{"line_number":10,"context_line":"Setting this will block mountable snapshot access rule modification for the share."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"baacf8b7_c6d52233","line":7,"in_reply_to":"35e630c2_4b516f0b","updated":"2026-08-18 15:37:01.000000000","message":"Done","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"092dc0bdd1d31ef868b59d0b668fd5f5c7602215","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3d950200_0163408a","updated":"2026-08-17 06:04:50.000000000","message":"Code looks good to me. Some minor comments apart from Carlos\u0027s comments. Overall looks good. Will wait for the resolve of comments.","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85a3d1fda610328ae31de0885b00c9f7d9e6a6b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2c76e99e_b67c5698","updated":"2026-08-14 17:59:44.000000000","message":"Looks good for the most part. Please take a look at the comments inline.","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"79aa7b478e8fe947eb8f8a94a115792f84af6e16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b2f0f518_a1358860","updated":"2026-08-18 15:37:01.000000000","message":"Thanks for reviewing the changes @anoop.shukla@netapp.com. I have addressed your comments. Please take a look and let me know.","commit_id":"11828f75af5d3713b129430d958c7ca997d70076"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"1b7f8f304719aa2e81bcbf5cfcf4eb1d70cc8f33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e5d74f76_de887f3e","updated":"2026-08-18 15:35:55.000000000","message":"Thanks for reviewing the changes @ces.eduardo98@gmail.com. I have addressed the comments. Please take a look and let me know.","commit_id":"11828f75af5d3713b129430d958c7ca997d70076"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b71841d9faef71152bafd3d24bb6bbd0d7954f1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4f811198_a3e88501","updated":"2026-08-19 18:16:14.000000000","message":"LGTM, thank you Srinesh!","commit_id":"bbc61d432013dd73543c38c7af02a07c2041b749"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"86a7beb1e139d1f8d841ea1631dd2ff498f336de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3c49bd12_4a2df57f","updated":"2026-08-26 06:59:09.000000000","message":"@srinesh.a-r@hpe.com -- Looks like this change is causing manila tempest failure when ran with max_api_microversion\u003d2.99. Can you please take a look at this.\n\n\n--------------------------------------------------------------------------------------\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFailed 1 tests - output below:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nmanila_tempest_tests.tests.api.admin.test_share_types_extra_specs_negative.ExtraSpecsAdminNegativeTest.test_try_read_extra_specs_on_share_type_with_user[api,id-36c5ada4-9efd-4f6a-b58d-24f08a2433ce,negative]\n--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n\n      File \"/opt/stack/manila-tempest-plugin/manila_tempest_tests/tests/api/admin/test_share_types_extra_specs_negative.py\", line 90, in test_try_read_extra_specs_on_share_type_with_user\n    self.assertEqual(sorted(expected_keys), sorted(actual_keys),\n\n      File \"/opt/stack/tempest/.tox/venv/lib/python3.12/site-packages/testtools/testcase.py\", line 513, in assertEqual\n    self.assertThat(observed, matcher, message)\n\n      File \"/opt/stack/tempest/.tox/venv/lib/python3.12/site-packages/testtools/testcase.py\", line 704, in assertThat\n    raise mismatch_error\n\n    testtools.matchers._impl.MismatchError: !\u003d:\nreference \u003d [\u0027create_share_from_snapshot_support\u0027,\n \u0027driver_handles_share_servers\u0027,\n \u0027mount_snapshot_support\u0027,\n \u0027revert_to_snapshot_support\u0027,\n \u0027snapshot_support\u0027]\nactual    \u003d [\u0027create_share_from_snapshot_support\u0027,\n \u0027driver_handles_share_servers\u0027,\n \u0027mount_snapshot_support\u0027,\n \u0027revert_to_snapshot_support\u0027,\n \u0027snapshot_inherit_share_access_support\u0027,\n \u0027snapshot_support\u0027]\n: Incorrect extra specs visible to non-admin user; expected [\u0027driver_handles_share_servers\u0027, \u0027snapshot_support\u0027, \u0027create_share_from_snapshot_support\u0027, \u0027revert_to_snapshot_support\u0027, \u0027mount_snapshot_support\u0027], got dict_keys([\u0027driver_handles_share_servers\u0027, \u0027snapshot_support\u0027, \u0027create_share_from_snapshot_support\u0027, \u0027revert_to_snapshot_support\u0027, \u0027mount_snapshot_support\u0027, \u0027snapshot_inherit_share_access_support\u0027])","commit_id":"4838c5ec822edf0b2e60d2f20d5552dd01863ac3"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"65118bdb30dd2b61fb4cd6ccfbceff9771cfd49f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"098c41fb_68e6afd8","updated":"2026-08-20 15:29:46.000000000","message":"LGTM.","commit_id":"4838c5ec822edf0b2e60d2f20d5552dd01863ac3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"79672b95b944c1a28ce0acdacf7ffad3280be890","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8b467939_c72fefe5","updated":"2026-08-20 15:21:40.000000000","message":"Thanks for rebasing!","commit_id":"4838c5ec822edf0b2e60d2f20d5552dd01863ac3"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"c17e7d1d7c838d1a308a3ed046eb4680f3c0fa2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"56b5b850_66c92b2c","in_reply_to":"3c49bd12_4a2df57f","updated":"2026-08-26 07:08:54.000000000","message":"Hi @manideep.openstack@gmail.com\n\nYes, as part of my tempest test PR I have added this parameter in the expected list. \n\nSince the tempest PR is not merged yet you are seeing the issue.\nhttps://review.opendev.org/c/openstack/manila-tempest-plugin/+/994878","commit_id":"4838c5ec822edf0b2e60d2f20d5552dd01863ac3"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85a3d1fda610328ae31de0885b00c9f7d9e6a6b6","unresolved":true,"context_lines":[{"line_number":4047,"context_line":"  in: body"},{"line_number":4048,"context_line":"  required: true"},{"line_number":4049,"context_line":"  type: boolean"},{"line_number":4050,"context_line":"  min_version: 2.98"},{"line_number":4051,"context_line":"snapshot_instance_id:"},{"line_number":4052,"context_line":"  description: |"},{"line_number":4053,"context_line":"    The UUID of the share snapshot instance."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"238aae57_5135fd02","line":4050,"range":{"start_line":4050,"start_character":15,"end_line":4050,"end_character":19},"updated":"2026-08-14 17:59:44.000000000","message":"please update here and in other places. This change will be 2.99","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"1b7f8f304719aa2e81bcbf5cfcf4eb1d70cc8f33","unresolved":false,"context_lines":[{"line_number":4047,"context_line":"  in: body"},{"line_number":4048,"context_line":"  required: true"},{"line_number":4049,"context_line":"  type: boolean"},{"line_number":4050,"context_line":"  min_version: 2.98"},{"line_number":4051,"context_line":"snapshot_instance_id:"},{"line_number":4052,"context_line":"  description: |"},{"line_number":4053,"context_line":"    The UUID of the share snapshot instance."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fd969417_c44c991a","line":4050,"range":{"start_line":4050,"start_character":15,"end_line":4050,"end_character":19},"in_reply_to":"238aae57_5135fd02","updated":"2026-08-18 15:35:55.000000000","message":"Done","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85a3d1fda610328ae31de0885b00c9f7d9e6a6b6","unresolved":true,"context_lines":[{"line_number":216,"context_line":"    * 2.95 - Added Share Replica Metadata to Metadata API"},{"line_number":217,"context_line":"    * 2.96 - Share migration APIs are no longer considered experimental."},{"line_number":218,"context_line":"    * 2.97 - Added availability_zone filter to share list API."},{"line_number":219,"context_line":"    * 2.98 - Added ``snapshot_inherit_share_access_support`` to share details"},{"line_number":220,"context_line":"             and share type API."},{"line_number":221,"context_line":"\"\"\""},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"42b73dfd_19cb3e4f","line":219,"range":{"start_line":219,"start_character":6,"end_line":219,"end_character":10},"updated":"2026-08-14 17:59:44.000000000","message":"2.99 here and in the other places of this change :)","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"1b7f8f304719aa2e81bcbf5cfcf4eb1d70cc8f33","unresolved":false,"context_lines":[{"line_number":216,"context_line":"    * 2.95 - Added Share Replica Metadata to Metadata API"},{"line_number":217,"context_line":"    * 2.96 - Share migration APIs are no longer considered experimental."},{"line_number":218,"context_line":"    * 2.97 - Added availability_zone filter to share list API."},{"line_number":219,"context_line":"    * 2.98 - Added ``snapshot_inherit_share_access_support`` to share details"},{"line_number":220,"context_line":"             and share type API."},{"line_number":221,"context_line":"\"\"\""},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"d62312c8_d5d5fd2e","line":219,"range":{"start_line":219,"start_character":6,"end_line":219,"end_character":10},"in_reply_to":"42b73dfd_19cb3e4f","updated":"2026-08-18 15:35:55.000000000","message":"Done","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"}],"manila/db/migrations/alembic/versions/afc3b5e1f406_add_snapshot_inherit_share_access_support.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85a3d1fda610328ae31de0885b00c9f7d9e6a6b6","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def upgrade():"},{"line_number":30,"context_line":"    op.add_column(\u0027shares\u0027,"},{"line_number":31,"context_line":"                  sa.Column(\u0027snapshot_inherit_share_access_support\u0027,"},{"line_number":32,"context_line":"                            sa.Boolean, nullable\u003dFalse,"},{"line_number":33,"context_line":"                            server_default\u003dsa.sql.false()))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":7,"id":"1de90421_b053d53f","line":33,"range":{"start_line":30,"start_character":4,"end_line":33,"end_character":59},"updated":"2026-08-14 17:59:44.000000000","message":"please wrap this with a try/catch block... same for downgrade\nAlso, I have a feeling we\u0027ll need to update all non-deleted and soft deleted (with share delete --soft) share records to make this defaulting to False","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"092dc0bdd1d31ef868b59d0b668fd5f5c7602215","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def upgrade():"},{"line_number":30,"context_line":"    op.add_column(\u0027shares\u0027,"},{"line_number":31,"context_line":"                  sa.Column(\u0027snapshot_inherit_share_access_support\u0027,"},{"line_number":32,"context_line":"                            sa.Boolean, nullable\u003dFalse,"},{"line_number":33,"context_line":"                            server_default\u003dsa.sql.false()))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":7,"id":"a851dac2_b025e81b","line":33,"range":{"start_line":30,"start_character":4,"end_line":33,"end_character":59},"in_reply_to":"1de90421_b053d53f","updated":"2026-08-17 06:04:50.000000000","message":"+1 This should be addressed.","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"446dac140507a68a3c5bddbf340da511d308e7c6","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def upgrade():"},{"line_number":30,"context_line":"    op.add_column(\u0027shares\u0027,"},{"line_number":31,"context_line":"                  sa.Column(\u0027snapshot_inherit_share_access_support\u0027,"},{"line_number":32,"context_line":"                            sa.Boolean, nullable\u003dFalse,"},{"line_number":33,"context_line":"                            server_default\u003dsa.sql.false()))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":7,"id":"4956949a_c78cc119","line":33,"range":{"start_line":30,"start_character":4,"end_line":33,"end_character":59},"in_reply_to":"8583591d_701ce652","updated":"2026-08-19 18:15:44.000000000","message":"Sure. Thank you for updating this","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"1b7f8f304719aa2e81bcbf5cfcf4eb1d70cc8f33","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def upgrade():"},{"line_number":30,"context_line":"    op.add_column(\u0027shares\u0027,"},{"line_number":31,"context_line":"                  sa.Column(\u0027snapshot_inherit_share_access_support\u0027,"},{"line_number":32,"context_line":"                            sa.Boolean, nullable\u003dFalse,"},{"line_number":33,"context_line":"                            server_default\u003dsa.sql.false()))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def downgrade():"}],"source_content_type":"text/x-python","patch_set":7,"id":"8583591d_701ce652","line":33,"range":{"start_line":30,"start_character":4,"end_line":33,"end_character":59},"in_reply_to":"a851dac2_b025e81b","updated":"2026-08-18 15:35:55.000000000","message":"Done, have updated with try/catch block.\nSince we are using server_default\u003dsa.sql.false() it should update the values for non-deleted and soft-deleted values","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"}],"releasenotes/notes/snapshot-inherit-share-access-support-3f5c1d0a9e47b2c8.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85a3d1fda610328ae31de0885b00c9f7d9e6a6b6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"55648923_6dc4c8bc","line":10,"updated":"2026-08-14 17:59:44.000000000","message":"great release note","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"1b7f8f304719aa2e81bcbf5cfcf4eb1d70cc8f33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bd83ea32_7549f2dc","line":10,"in_reply_to":"55648923_6dc4c8bc","updated":"2026-08-18 15:35:55.000000000","message":"Acknowledged","commit_id":"4ea62c25c2d135b68ec9617970e4c4dc96b170a7"}]}