)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"f6b2a167fc6e9f18514704fd62fa4d81990c4112","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60629bd5_c5def71d","updated":"2026-08-12 12:12:51.000000000","message":"LGTM. @saikumar1016@gmail.com we should test this once and validate it.","commit_id":"8aabd01b35e8c22c234a48d2ea9675d0aa195482"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"2b0c311fb5def9d64dd70d733bcab4fa286c7e6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f954848_e8e7cc73","updated":"2026-08-13 13:31:55.000000000","message":"Thanks for working on this Carlos! Appreciate it. \n\nI have cherry picked the patch changes on latest master code. Injected a temporary failure at “_create_barbican_kms_config_for_specified_vserver()”. \n\nThe share server show now gets below details as per your patch changes which were not present earlier. \n| details:vserver_name              | os_c86365d8-7a4f-4b42-b92c-41342ce5b2f7                                                                            |\n| details:ports                     | {\"85c03675-7f8f-407b-ad47-51acd57e4638\": \"10.192.96.157\", \"b1d6ecea-ecbd-4260-b408-1ac5638f4567\": \"10.192.96.156\"} |\n| details:nfs_config                | {\"tcp-max-xfer-size\": \"65536\", \"udp-max-xfer-size\": \"32768\"}                                                       |\n\nI have executed the below workflow, the SVM got deleted from ONTAP as well. I think we are good with the patch changes. \n\n1. Created an encrypted share [I temporarily injected a forced failure at the exact point described in the bug:https://bugs.launchpad.net/manila/+bug/2163166, here “_create_barbican_kms_config_for_specified_vserver]\n2. Share and share server creation failed - errored out as injected\n3. Deleted failed share - the share got delete from OpenStack\n4. Deleted failed share server - the share server got deleted from OpenStack and the respective SVM got deleted from ONTAP.\n \nComplete testing details: https://paste.opendev.org/show/bD74sWDMMtl4p95isfQt/\n\n+1 but looks like Zuul is failing. Please take a look.","commit_id":"8aabd01b35e8c22c234a48d2ea9675d0aa195482"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b41531dfbba7702ac669196065b355bf28d330a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6045430_cff13f5b","updated":"2026-08-13 14:10:19.000000000","message":"Thanks Carlos for the fix. The code and tests look good to me.","commit_id":"93b437f345ef15b0305091765db62c75f2e21635"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c49e3013668a81cf74806835c64e7f4359c76e54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36ae48b9_705ca176","updated":"2026-08-13 19:01:11.000000000","message":"recheck\n\noffending release has been withdrawn","commit_id":"93b437f345ef15b0305091765db62c75f2e21635"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"fc0fb17df8c2f83619cae391e3010f0a9ec4fb0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"655232e9_9f046adb","updated":"2026-08-14 17:23:53.000000000","message":"recheck\nFlaky test on LVM driver job failed","commit_id":"93b437f345ef15b0305091765db62c75f2e21635"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"f6b2a167fc6e9f18514704fd62fa4d81990c4112","unresolved":true,"context_lines":[{"line_number":479,"context_line":"                raise"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"            if metadata.get(\u0027encryption_key_ref\u0027):"},{"line_number":482,"context_line":"                try:"},{"line_number":483,"context_line":"                    self._create_barbican_kms_config_for_specified_vserver("},{"line_number":484,"context_line":"                        vserver_name, metadata)"},{"line_number":485,"context_line":"                except Exception as e:"},{"line_number":486,"context_line":"                    e.detail_data \u003d {\u0027server_details\u0027: server_details}"},{"line_number":487,"context_line":"                    raise"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"            return server_details"},{"line_number":490,"context_line":"        return setup_server_with_lock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"624cecc5_d8799e0b","line":487,"range":{"start_line":482,"start_character":11,"end_line":487,"end_character":25},"updated":"2026-08-12 12:12:51.000000000","message":"Can we cover this in a UT?","commit_id":"8aabd01b35e8c22c234a48d2ea9675d0aa195482"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"98eb6d34d5d9b077b50b780f0d078971dea57497","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                raise"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"            if metadata.get(\u0027encryption_key_ref\u0027):"},{"line_number":482,"context_line":"                try:"},{"line_number":483,"context_line":"                    self._create_barbican_kms_config_for_specified_vserver("},{"line_number":484,"context_line":"                        vserver_name, metadata)"},{"line_number":485,"context_line":"                except Exception as e:"},{"line_number":486,"context_line":"                    e.detail_data \u003d {\u0027server_details\u0027: server_details}"},{"line_number":487,"context_line":"                    raise"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"            return server_details"},{"line_number":490,"context_line":"        return setup_server_with_lock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9b5a100_4e2febbd","line":487,"range":{"start_line":482,"start_character":11,"end_line":487,"end_character":25},"in_reply_to":"624cecc5_d8799e0b","updated":"2026-08-13 12:38:23.000000000","message":"Done","commit_id":"8aabd01b35e8c22c234a48d2ea9675d0aa195482"}]}
