)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ee5c5b77c0c2260ab484c7a267aba4a0151bba2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fdf6fad9_743ffaab","updated":"2026-08-25 11:11:27.000000000","message":"Fixed to change from replica promotion to revert to snapshot","commit_id":"85cdf0a7ecb787b5a6cd3b44869119a5bbf2fa15"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"265fbd795211aae2ef94e77421e3cb530210048a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b319f2a6_58de2e23","updated":"2026-08-31 19:01:32.000000000","message":"LGTM, thank you Kiran","commit_id":"9aacb4ebda439c8bd4bf6df537f3e255a06e1d6e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"81c0dcd426c05eca2ebf10528c98495262b60ef6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5134db72_02e09be8","updated":"2026-09-01 12:56:09.000000000","message":"Thanks for handling the comments. LGTM.","commit_id":"9aacb4ebda439c8bd4bf6df537f3e255a06e1d6e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3e2a2efff1b25df662f0c919e34da63326b65875","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"127ef8ed_edc1636f","updated":"2026-08-26 06:07:35.000000000","message":"Zuul as well as CI is passing.","commit_id":"9aacb4ebda439c8bd4bf6df537f3e255a06e1d6e"}],"releasenotes/notes/netapp-purge-snapmirror-snapshots-after-promote-b2163507.yaml":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"8fb58532dab99e5f2396076b9fa5accdd35be804","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `NetApp Driver bug #2163507"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/2163507\u003e`_: Fixed SnapMirror"},{"line_number":6,"context_line":"    snapshots not being cleaned up after DR replica promotion. ONTAP does"},{"line_number":7,"context_line":"    not remove snapshots with SnapMirror dependency automatically after a"},{"line_number":8,"context_line":"    SnapMirror break, leaving them orphaned on the promoted volume and"},{"line_number":9,"context_line":"    blocking subsequent snapshot restores."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5d8e337a_3749cdde","line":9,"range":{"start_line":6,"start_character":63,"end_line":9,"end_character":42},"updated":"2026-08-20 14:24:25.000000000","message":"The reason ONTAP does not remove snapshots is because irrespective of which site is primary, the snapshots hold the golden copy and point in time snapshots to recover the Share to its prior state. Even after promote, there can be chances of corruption to the data. To recover from the corruption, snapshots are needed to be retained. Moreover, you would want Shares from the snapshots to be created for backup workflow. I do not see this as an \"issue\". May be I am missing something.","commit_id":"85cdf0a7ecb787b5a6cd3b44869119a5bbf2fa15"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"eda7023a8375a7e9e6bddde077686e260cf7911f","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `NetApp Driver bug #2163507"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/2163507\u003e`_: Fixed SnapMirror"},{"line_number":6,"context_line":"    snapshots not being cleaned up after DR replica promotion. ONTAP does"},{"line_number":7,"context_line":"    not remove snapshots with SnapMirror dependency automatically after a"},{"line_number":8,"context_line":"    SnapMirror break, leaving them orphaned on the promoted volume and"},{"line_number":9,"context_line":"    blocking subsequent snapshot restores."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a644da7f_f9279d50","line":9,"range":{"start_line":6,"start_character":63,"end_line":9,"end_character":42},"in_reply_to":"5d8e337a_3749cdde","updated":"2026-08-25 08:44:06.000000000","message":"Those snapshots are not visible to manila, so you cannot use them for the backup workflow.\nI see the point with the corruption recovery, this would have to happen directly on the back end, not through manila.\nTo keep this possibility, I suggest to move the cleanup code to revert_to_snapshot() to only do this when the user really asks for a revert and not unconditionally on promote. The other benefit of moving this away from promote is to not increase the complexity of the promote flow.","commit_id":"85cdf0a7ecb787b5a6cd3b44869119a5bbf2fa15"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ee5c5b77c0c2260ab484c7a267aba4a0151bba2e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `NetApp Driver bug #2163507"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/manila/+bug/2163507\u003e`_: Fixed SnapMirror"},{"line_number":6,"context_line":"    snapshots not being cleaned up after DR replica promotion. ONTAP does"},{"line_number":7,"context_line":"    not remove snapshots with SnapMirror dependency automatically after a"},{"line_number":8,"context_line":"    SnapMirror break, leaving them orphaned on the promoted volume and"},{"line_number":9,"context_line":"    blocking subsequent snapshot restores."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c7d825fb_b9aaadf5","line":9,"range":{"start_line":6,"start_character":63,"end_line":9,"end_character":42},"in_reply_to":"a644da7f_f9279d50","updated":"2026-08-25 11:11:27.000000000","message":"Acknowledged","commit_id":"85cdf0a7ecb787b5a6cd3b44869119a5bbf2fa15"}]}