)]}'
{"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a0e125c07a8c4d69512d7895a93ef47fa6c6fc6","unresolved":true,"context_lines":[{"line_number":787,"context_line":"            az_request_multiple_subnet_support_map\u003dNone,"},{"line_number":788,"context_line":"            mount_point_name\u003dNone, encryption_key_ref\u003dNone,"},{"line_number":789,"context_line":"            qos_type_id\u003dNone, share_instance_metadata\u003dNone,"},{"line_number":790,"context_line":"            is_replica\u003dFalse):"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        availability_zone_id \u003d None"},{"line_number":793,"context_line":"        if availability_zone:"}],"source_content_type":"text/x-python","patch_set":1,"id":"212baf7b_d5dae110","line":790,"range":{"start_line":790,"start_character":12,"end_line":790,"end_character":30},"updated":"2026-09-17 16:05:24.000000000","message":"isn\u0027t it better if we used the \"replica_state\" to judge this within the scheduler where the capacity reservation logic is kicking in?","commit_id":"66b1e63775492e508b9e8a95d6d7cdc7be43be99"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"61d5824cd4f13eb3dc52dfbfdb29417e35468182","unresolved":true,"context_lines":[{"line_number":787,"context_line":"            az_request_multiple_subnet_support_map\u003dNone,"},{"line_number":788,"context_line":"            mount_point_name\u003dNone, encryption_key_ref\u003dNone,"},{"line_number":789,"context_line":"            qos_type_id\u003dNone, share_instance_metadata\u003dNone,"},{"line_number":790,"context_line":"            is_replica\u003dFalse):"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        availability_zone_id \u003d None"},{"line_number":793,"context_line":"        if availability_zone:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2af1732d_ce9993cf","line":790,"range":{"start_line":790,"start_character":12,"end_line":790,"end_character":30},"in_reply_to":"212baf7b_d5dae110","updated":"2026-09-18 06:39:34.000000000","message":"I wanted to avoid adding yet another parameter, when we anyhow have no use-case for sending the snapshot_id for replicas.","commit_id":"66b1e63775492e508b9e8a95d6d7cdc7be43be99"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"2297c2c132220a07aee3a53880cf64a8ef9d520c","unresolved":true,"context_lines":[{"line_number":787,"context_line":"            az_request_multiple_subnet_support_map\u003dNone,"},{"line_number":788,"context_line":"            mount_point_name\u003dNone, encryption_key_ref\u003dNone,"},{"line_number":789,"context_line":"            qos_type_id\u003dNone, share_instance_metadata\u003dNone,"},{"line_number":790,"context_line":"            is_replica\u003dFalse):"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        availability_zone_id \u003d None"},{"line_number":793,"context_line":"        if availability_zone:"}],"source_content_type":"text/x-python","patch_set":1,"id":"65e0d806_44af37d6","line":790,"range":{"start_line":790,"start_character":12,"end_line":790,"end_character":30},"in_reply_to":"2332e2b1_8762c624","updated":"2026-09-18 06:57:21.000000000","message":"I see, we could use the instance properties from request spec.\nI agree, solving in the scheduler makes is more explicit, which is easier to read.","commit_id":"66b1e63775492e508b9e8a95d6d7cdc7be43be99"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb9a9ed07e7609529eded16a02faef66e28d5ea3","unresolved":true,"context_lines":[{"line_number":787,"context_line":"            az_request_multiple_subnet_support_map\u003dNone,"},{"line_number":788,"context_line":"            mount_point_name\u003dNone, encryption_key_ref\u003dNone,"},{"line_number":789,"context_line":"            qos_type_id\u003dNone, share_instance_metadata\u003dNone,"},{"line_number":790,"context_line":"            is_replica\u003dFalse):"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        availability_zone_id \u003d None"},{"line_number":793,"context_line":"        if availability_zone:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2332e2b1_8762c624","line":790,"range":{"start_line":790,"start_character":12,"end_line":790,"end_character":30},"in_reply_to":"2af1732d_ce9993cf","updated":"2026-09-18 06:42:21.000000000","message":"The \"replica_state\" should already be there; it\u0027s being set on line 846 below. My concern is that this logic may not be apparent until you see the reservation code.","commit_id":"66b1e63775492e508b9e8a95d6d7cdc7be43be99"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6319b04cbc3e18cabcae7b89b0823cb6d448688f","unresolved":false,"context_lines":[{"line_number":787,"context_line":"            az_request_multiple_subnet_support_map\u003dNone,"},{"line_number":788,"context_line":"            mount_point_name\u003dNone, encryption_key_ref\u003dNone,"},{"line_number":789,"context_line":"            qos_type_id\u003dNone, share_instance_metadata\u003dNone,"},{"line_number":790,"context_line":"            is_replica\u003dFalse):"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"        availability_zone_id \u003d None"},{"line_number":793,"context_line":"        if availability_zone:"}],"source_content_type":"text/x-python","patch_set":1,"id":"cb0dabf5_71092992","line":790,"range":{"start_line":790,"start_character":12,"end_line":790,"end_character":30},"in_reply_to":"65e0d806_44af37d6","updated":"2026-09-18 11:31:26.000000000","message":"ok, filled in replica_state explicitly OUT_OF_SYNC for replica.","commit_id":"66b1e63775492e508b9e8a95d6d7cdc7be43be99"}]}