)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2dc7ea4634f89b564a8c1a3e196e49a266d468c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc55a462_7ee766f0","updated":"2026-10-08 10:02:17.000000000","message":"recheck","commit_id":"f26b01e3f91998766aeee2d97a341c847ee54106"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"db28b007bf0ac557dcff20ab4c7a1e4edb121b1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ea32ef22_0f130766","updated":"2026-10-15 16:53:33.000000000","message":"Thanks for working on this. Got a couple of questions inline","commit_id":"6c33a3361484b3c1635f4a3af827a96e3fa0fc88"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"58ac0f28db60cdb18bfd1714b083c5ae66d18ef3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a459b727_3f71b351","updated":"2026-10-15 16:54:35.000000000","message":"This needs a corresponding tempest patch as well so we can test this against the backends that support this","commit_id":"6c33a3361484b3c1635f4a3af827a96e3fa0fc88"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"c12202add67bf4fae522aac776425d1634365129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fab4b1c0_feaa0b97","in_reply_to":"a459b727_3f71b351","updated":"2026-10-19 08:40:59.000000000","message":"https://review.opendev.org/c/openstack/manila-tempest-plugin/+/1011230","commit_id":"6c33a3361484b3c1635f4a3af827a96e3fa0fc88"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"18a7a6d3b6edc6c70d36d5160d6acaca7bbc221f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63181ff5_b7ad745a","updated":"2026-10-19 06:37:39.000000000","message":"created anothr PR for driver work https://review.opendev.org/c/openstack/manila/+/1011225 after PTG discussion.","commit_id":"146a33de57ce2c3bed1890958c79513c09e3e3d2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"4acfd57958b00563f43f3d2fe0da775e10634cd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6f9ea50f_e8dd90e7","updated":"2026-10-20 05:38:39.000000000","message":"recheck","commit_id":"146a33de57ce2c3bed1890958c79513c09e3e3d2"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0deb5a040ab365d8b68521ac3df6fc4b19a8bbfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ab8334c5_8daf7b24","updated":"2026-10-28 16:29:49.000000000","message":"recheck","commit_id":"146a33de57ce2c3bed1890958c79513c09e3e3d2"}],"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"db28b007bf0ac557dcff20ab4c7a1e4edb121b1e","unresolved":true,"context_lines":[{"line_number":2012,"context_line":"                LOG.warning(msg)"},{"line_number":2013,"context_line":"                raise exception.Conflict(err\u003dmsg)"},{"line_number":2014,"context_line":""},{"line_number":2015,"context_line":"            if force_host_assisted_migration or not nondisruptive:"},{"line_number":2016,"context_line":"                msg \u003d _(\u0027Share %s has replicas. Only a nondisruptive, \u0027"},{"line_number":2017,"context_line":"                        \u0027driver-assisted migration is supported for \u0027"},{"line_number":2018,"context_line":"                        \u0027replicated shares.\u0027) % share[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"f77ddca2_2912dbc2","line":2015,"range":{"start_line":2015,"start_character":45,"end_line":2015,"end_character":65},"updated":"2026-10-15 16:53:33.000000000","message":"\"force_host_assisted_migration\" feels like the only infeasible thing unless we add support to move replication over generically (which is hard to do). \n\nis \"nondisruptive\" required as well?","commit_id":"6c33a3361484b3c1635f4a3af827a96e3fa0fc88"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"18a7a6d3b6edc6c70d36d5160d6acaca7bbc221f","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"                LOG.warning(msg)"},{"line_number":2013,"context_line":"                raise exception.Conflict(err\u003dmsg)"},{"line_number":2014,"context_line":""},{"line_number":2015,"context_line":"            if force_host_assisted_migration or not nondisruptive:"},{"line_number":2016,"context_line":"                msg \u003d _(\u0027Share %s has replicas. Only a nondisruptive, \u0027"},{"line_number":2017,"context_line":"                        \u0027driver-assisted migration is supported for \u0027"},{"line_number":2018,"context_line":"                        \u0027replicated shares.\u0027) % share[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"efa62d91_98ba0350","line":2015,"range":{"start_line":2015,"start_character":45,"end_line":2015,"end_character":65},"in_reply_to":"f77ddca2_2912dbc2","updated":"2026-10-19 06:37:39.000000000","message":"Agreed — removed the nondisruptive check. force_host_assisted_migration is the only hard block at the API layer; whether the migration is nondisruptive is a capability the driver/scheduler negotiates.","commit_id":"6c33a3361484b3c1635f4a3af827a96e3fa0fc88"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"db28b007bf0ac557dcff20ab4c7a1e4edb121b1e","unresolved":true,"context_lines":[{"line_number":2019,"context_line":"                LOG.warning(msg)"},{"line_number":2020,"context_line":"                raise exception.Conflict(err\u003dmsg)"},{"line_number":2021,"context_line":""},{"line_number":2022,"context_line":"            src_backend \u003d share_utils.extract_host("},{"line_number":2023,"context_line":"                share_instance[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"},{"line_number":2024,"context_line":"            dest_backend \u003d share_utils.extract_host("},{"line_number":2025,"context_line":"                dest_host, level\u003d\u0027backend_name\u0027)"},{"line_number":2026,"context_line":"            if src_backend !\u003d dest_backend:"},{"line_number":2027,"context_line":"                msg \u003d _(\u0027Share %s has replicas. Migrating a replicated \u0027"},{"line_number":2028,"context_line":"                        \u0027share is only supported within the same \u0027"},{"line_number":2029,"context_line":"                        \u0027backend.\u0027) % share[\u0027id\u0027]"},{"line_number":2030,"context_line":"                LOG.warning(msg)"},{"line_number":2031,"context_line":"                raise exception.Conflict(err\u003dmsg)"},{"line_number":2032,"context_line":""},{"line_number":2033,"context_line":"            if new_share_type or new_share_network:"},{"line_number":2034,"context_line":"                msg \u003d _(\u0027Share %s has replicas. Changing the share type or \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"6b53a238_e5408944","line":2031,"range":{"start_line":2022,"start_character":0,"end_line":2031,"end_character":49},"updated":"2026-10-15 16:53:33.000000000","message":"can this check move to the scheduler? i.e., the driver reports the capability, so you should validate it against the capability - not have an API block.","commit_id":"6c33a3361484b3c1635f4a3af827a96e3fa0fc88"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"18a7a6d3b6edc6c70d36d5160d6acaca7bbc221f","unresolved":false,"context_lines":[{"line_number":2019,"context_line":"                LOG.warning(msg)"},{"line_number":2020,"context_line":"                raise exception.Conflict(err\u003dmsg)"},{"line_number":2021,"context_line":""},{"line_number":2022,"context_line":"            src_backend \u003d share_utils.extract_host("},{"line_number":2023,"context_line":"                share_instance[\u0027host\u0027], level\u003d\u0027backend_name\u0027)"},{"line_number":2024,"context_line":"            dest_backend \u003d share_utils.extract_host("},{"line_number":2025,"context_line":"                dest_host, level\u003d\u0027backend_name\u0027)"},{"line_number":2026,"context_line":"            if src_backend !\u003d dest_backend:"},{"line_number":2027,"context_line":"                msg \u003d _(\u0027Share %s has replicas. Migrating a replicated \u0027"},{"line_number":2028,"context_line":"                        \u0027share is only supported within the same \u0027"},{"line_number":2029,"context_line":"                        \u0027backend.\u0027) % share[\u0027id\u0027]"},{"line_number":2030,"context_line":"                LOG.warning(msg)"},{"line_number":2031,"context_line":"                raise exception.Conflict(err\u003dmsg)"},{"line_number":2032,"context_line":""},{"line_number":2033,"context_line":"            if new_share_type or new_share_network:"},{"line_number":2034,"context_line":"                msg \u003d _(\u0027Share %s has replicas. Changing the share type or \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d141fe1_33fd8f0d","line":2031,"range":{"start_line":2022,"start_character":0,"end_line":2031,"end_character":49},"in_reply_to":"6b53a238_e5408944","updated":"2026-10-19 06:37:39.000000000","message":"moved to scheduler.","commit_id":"6c33a3361484b3c1635f4a3af827a96e3fa0fc88"}]}
