)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"6e063ac8ce9ce0849ebc65533f77a59665ba2bdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6cee64bd_bc8a1f7b","updated":"2026-10-07 10:40:04.000000000","message":"Thanks for the patch. I left some comments, please take a look.","commit_id":"11c587307f06dac1963ad7d4ead17a6093590961"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b9a1467d7318a6e581235d7122587d0a6f01b060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b78499a_be110541","updated":"2026-10-07 08:27:42.000000000","message":"run-DellEMC PowerScale CI","commit_id":"11c587307f06dac1963ad7d4ead17a6093590961"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1a7548beeea51ab1b60f0f8c68394ee8fbb0cc35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c7f86336_aa8f3f9d","updated":"2026-10-07 11:31:43.000000000","message":"run-DellEMC PowerScale CI","commit_id":"11c587307f06dac1963ad7d4ead17a6093590961"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"96e1cd182f3614c363cadbf37dea1a534bda285a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d0dcc885_7d83cefc","updated":"2026-10-07 09:47:41.000000000","message":"run-DellEMC PowerScale CI","commit_id":"11c587307f06dac1963ad7d4ead17a6093590961"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"ca4714ac0213e0d5de3c5bded0c3fb58ddb232cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"72af7646_4649b800","updated":"2026-10-28 11:10:30.000000000","message":"@ces.eduardo98@gmail.com \nPlease help review this patch","commit_id":"16a4ce7fe6a23812ac4020ba201de0b2ad3361f4"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"e64ce9e968e113da66630afed26cb5ebdced56ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cafc0816_2154e838","updated":"2026-10-28 02:33:18.000000000","message":"@siddharth.kumar1@dell.com thanks for the explanation and for addressing my comments. LGTM","commit_id":"16a4ce7fe6a23812ac4020ba201de0b2ad3361f4"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"6aadb4afc8b12a93d3d8d7c72801fef650778632","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0e281b5_07134934","updated":"2026-10-29 09:02:53.000000000","message":"I gave +1 before, but I have another concern, so I\u0027m changing my vote to -1. Please take a look.","commit_id":"16a4ce7fe6a23812ac4020ba201de0b2ad3361f4"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4b6d1c49083b28c0fe600cdb2bf5ef66abd27961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d32a860_fc6e3059","updated":"2026-10-16 11:38:20.000000000","message":"run-DellEMC PowerScale CI","commit_id":"16a4ce7fe6a23812ac4020ba201de0b2ad3361f4"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"48f8ee0dfb23775f1627b90f7003d06b8dbab454","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3d9428f7_3dc44a63","updated":"2026-10-16 14:48:50.000000000","message":"run-DellEMC PowerScale CI","commit_id":"16a4ce7fe6a23812ac4020ba201de0b2ad3361f4"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"e186479ccb6c69f6bb5bd1d298c9663aef08f56c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8e738406_3cef381c","updated":"2026-10-16 13:56:40.000000000","message":"run-DellEMC PowerScale CI","commit_id":"16a4ce7fe6a23812ac4020ba201de0b2ad3361f4"}],"manila/share/drivers/dell_emc/plugins/powerscale/powerscale.py":[{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"6e063ac8ce9ce0849ebc65533f77a59665ba2bdb","unresolved":true,"context_lines":[{"line_number":816,"context_line":"                                     read_only)"},{"line_number":817,"context_line":"        user_permissions \u003d self._get_cifs_user_permissions("},{"line_number":818,"context_line":"            user_access_rules, rule_state_map)"},{"line_number":819,"context_line":"        if not ips and not user_permissions:"},{"line_number":820,"context_line":"            ips \u003d [powerscale_api.SMB_NO_ACCESS_HOST]"},{"line_number":821,"context_line":"        share_updated \u003d self._powerscale_api.modify_smb_share_access("},{"line_number":822,"context_line":"            share_name,"},{"line_number":823,"context_line":"            host_acl\u003dips,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f5a0ad2c_935207f8","line":820,"range":{"start_line":819,"start_character":6,"end_line":820,"end_character":51},"updated":"2026-10-07 10:40:04.000000000","message":"Shouldn\u0027t deny:ALL apply whenever ips is empty? With only user rules, the host ACL stays open, so access looks like ip OR user rather than ip AND user. Is OR the intended semantics for CIFS here? Please correct me if I\u0027m wrong. Also, with only ip rules, permissions\u003d[] is sent. What does OneFS do with share-level access in that case?","commit_id":"11c587307f06dac1963ad7d4ead17a6093590961"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"6405f37862cb08b001aec2a0d1fd82b7b5fa320d","unresolved":false,"context_lines":[{"line_number":816,"context_line":"                                     read_only)"},{"line_number":817,"context_line":"        user_permissions \u003d self._get_cifs_user_permissions("},{"line_number":818,"context_line":"            user_access_rules, rule_state_map)"},{"line_number":819,"context_line":"        if not ips and not user_permissions:"},{"line_number":820,"context_line":"            ips \u003d [powerscale_api.SMB_NO_ACCESS_HOST]"},{"line_number":821,"context_line":"        share_updated \u003d self._powerscale_api.modify_smb_share_access("},{"line_number":822,"context_line":"            share_name,"},{"line_number":823,"context_line":"            host_acl\u003dips,"}],"source_content_type":"text/x-python","patch_set":1,"id":"247c44a0_d512c5b0","line":820,"range":{"start_line":819,"start_character":6,"end_line":820,"end_character":51},"in_reply_to":"f5a0ad2c_935207f8","updated":"2026-10-16 09:46:15.000000000","message":"Thanks for raising this. OneFS enforces the SMB host ACL and share permissions as separate authorization layers. An empty layer is intentionally unrestricted:\n\nFor user-only rules, host_acl\u003d[] allows the user check to control access from any host.\nFor IP-only rules, permissions\u003d[] leaves share-level user permissions unrestricted while host_acl restricts the source host.\nWhen both layers are populated, both OneFS checks apply.\ndeny:ALL is used only when both the host ACL and user permissions are empty, meaning no Manila access rules exist.\n\nThis preserves valid user-only and IP-only access while ensuring that a share with no access rules is denied by default. The behavior is covered by the existing Manila user-rule test, the added IP-only unit test, and the real PowerScale CIFS Tempest workflow.","commit_id":"11c587307f06dac1963ad7d4ead17a6093590961"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"6e063ac8ce9ce0849ebc65533f77a59665ba2bdb","unresolved":true,"context_lines":[{"line_number":851,"context_line":"            cifs_ips.append(\u0027allow:\u0027 + rule[\u0027access_to\u0027])"},{"line_number":852,"context_line":"            rule_state_map.update({rule[\u0027access_id\u0027]: {\u0027state\u0027: \u0027active\u0027}})"},{"line_number":853,"context_line":"        if len(cifs_ips) \u003e 0:"},{"line_number":854,"context_line":"            cifs_ips.append(\u0027deny:ALL\u0027)"},{"line_number":855,"context_line":"        return cifs_ips"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"    def _get_cifs_user_permissions(self, access_rules, rule_state_map):"}],"source_content_type":"text/x-python","patch_set":1,"id":"88fc015c_6bc17286","line":854,"updated":"2026-10-07 10:40:04.000000000","message":"How about using the `SMB_NO_ACCESS_HOST` constant variable added in this patch instead of `deny:ALL`?","commit_id":"11c587307f06dac1963ad7d4ead17a6093590961"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"6405f37862cb08b001aec2a0d1fd82b7b5fa320d","unresolved":false,"context_lines":[{"line_number":851,"context_line":"            cifs_ips.append(\u0027allow:\u0027 + rule[\u0027access_to\u0027])"},{"line_number":852,"context_line":"            rule_state_map.update({rule[\u0027access_id\u0027]: {\u0027state\u0027: \u0027active\u0027}})"},{"line_number":853,"context_line":"        if len(cifs_ips) \u003e 0:"},{"line_number":854,"context_line":"            cifs_ips.append(\u0027deny:ALL\u0027)"},{"line_number":855,"context_line":"        return cifs_ips"},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"    def _get_cifs_user_permissions(self, access_rules, rule_state_map):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d19663d_fff2a5a0","line":854,"in_reply_to":"88fc015c_6bc17286","updated":"2026-10-16 09:46:15.000000000","message":"Done","commit_id":"11c587307f06dac1963ad7d4ead17a6093590961"}],"manila/share/drivers/dell_emc/plugins/powerscale/powerscale_api.py":[{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"6aadb4afc8b12a93d3d8d7c72801fef650778632","unresolved":true,"context_lines":[{"line_number":33,"context_line":"PAPI_VERSION_SNAPSHOT_NFS_EXPORT \u003d \u002722\u0027"},{"line_number":34,"context_line":"PAPI_VERSION_CLUSTER \u003d \u002712\u0027"},{"line_number":35,"context_line":"PAPI_VERSION_QOS \u003d \u002719\u0027"},{"line_number":36,"context_line":"NFS_NO_ACCESS_CLIENT \u003d \u0027192.0.2.1/32\u0027"},{"line_number":37,"context_line":"SMB_NO_ACCESS_HOST \u003d \u0027deny:ALL\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2c1e135e_dc0f2406","line":36,"updated":"2026-10-29 09:02:53.000000000","message":"192.0.2.1 still gives read-write access to any host that uses this IP. Could we use 127.0.0.1 instead, like the Hitachi HNAS driver does? \nhttps://opendev.org/openstack/manila/src/branch/master/manila/share/drivers/hitachi/hnas/ssh.py#L78","commit_id":"16a4ce7fe6a23812ac4020ba201de0b2ad3361f4"}]}