)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38762,"name":"Sahil Kumbhar","display_name":"sakumbha","email":"sakumbha@redhat.com","username":"sakumbha"},"change_message_id":"7dc1b3437cd727febeb3bc34a77a5ceb0ce893dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"51451397_fe29f708","updated":"2026-10-13 10:22:26.000000000","message":"Please check PEP8 is failing.\n`manila/api/v2/share_groups.py:27:1: H306: imports not in alphabetical order (manila.api.validation, manila.api.schemas.share_groups)`","commit_id":"819ae5fc6d684a83065f1227358df7f9081a3ec6"},{"author":{"_account_id":38982,"name":"Meer Hashaam Khan","display_name":"hashaaam","email":"hashaamkhan975@gmail.com","username":"hashaaam"},"change_message_id":"bbdd326516590c3eb5dd86105a847a60a0076199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"acde2a79_4a77150d","updated":"2026-10-14 00:06:18.000000000","message":"Thank you for the review Sahil! I have fixed the pep8 failures \nin the latest patchset. Please take another look when available.","commit_id":"5c74941f31d6c4a2f9d2456840fa33338afbf2f0"},{"author":{"_account_id":38762,"name":"Sahil Kumbhar","display_name":"sakumbha","email":"sakumbha@redhat.com","username":"sakumbha"},"change_message_id":"9e3e44c51851f6b2b110b1bb1ba2a2c97dbf2a4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"05c211b5_47509909","updated":"2026-10-16 06:24:20.000000000","message":"This test case are failing:\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_6c3/openstack/6c358eda752b4ef4a7b4b35acea30fad/testr_results.html","commit_id":"c29923472bd3d159b361f482da46b057e066722c"}],"manila/api/schemas/share_groups.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8594e3027d2952e3c2b1cd45b380b8de0650588d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from manila.api.validation import parameter_types"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"create_request_body \u003d {"},{"line_number":16,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"33a08955_92f17a70","line":13,"updated":"2026-10-12 23:23:13.000000000","message":"pep8: F401 \u0027manila.api.validation.parameter_types\u0027 imported but unused","commit_id":"a554e990987a7fc047a407052a54df325b466e72"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8594e3027d2952e3c2b1cd45b380b8de0650588d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    },"},{"line_number":83,"context_line":"    \u0027required\u0027: [\u0027share_group\u0027],"},{"line_number":84,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":85,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"18d96eef_94611aa9","line":85,"updated":"2026-10-12 23:23:13.000000000","message":"pep8: W292 no newline at end of file","commit_id":"a554e990987a7fc047a407052a54df325b466e72"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"073f5571e73373b6afd8fdbf50cfc5b2f0b0aa8e","unresolved":true,"context_lines":[{"line_number":19,"context_line":"            \u0027properties\u0027: {"},{"line_number":20,"context_line":"                \u0027name\u0027: {"},{"line_number":21,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":22,"context_line":"                    \u0027minLength\u0027: 0,"},{"line_number":23,"context_line":"                    \u0027maxLength\u0027: 255,"},{"line_number":24,"context_line":"                },"},{"line_number":25,"context_line":"                \u0027description\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"75bc741d_85ae6ea7","line":22,"updated":"2026-10-24 06:54:24.000000000","message":"I know this field is optional, but if one wants to add a name, should we allow them pass an empty string? If no please update the \u0027minLength\u0027 to 1","commit_id":"2fe926040508a1077fff3d42529bac30ff7a6d02"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"073f5571e73373b6afd8fdbf50cfc5b2f0b0aa8e","unresolved":true,"context_lines":[{"line_number":24,"context_line":"                },"},{"line_number":25,"context_line":"                \u0027description\u0027: {"},{"line_number":26,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":27,"context_line":"                    \u0027minLength\u0027: 0,"},{"line_number":28,"context_line":"                    \u0027maxLength\u0027: 255,"},{"line_number":29,"context_line":"                },"},{"line_number":30,"context_line":"                \u0027share_types\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae7be47_93d5e03a","line":27,"updated":"2026-10-24 06:54:24.000000000","message":"same as above","commit_id":"2fe926040508a1077fff3d42529bac30ff7a6d02"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"073f5571e73373b6afd8fdbf50cfc5b2f0b0aa8e","unresolved":true,"context_lines":[{"line_number":34,"context_line":"                        \u0027format\u0027: \u0027uuid\u0027,"},{"line_number":35,"context_line":"                    },"},{"line_number":36,"context_line":"                },"},{"line_number":37,"context_line":"                \u0027share_group_type_id\u0027: {"},{"line_number":38,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":39,"context_line":"                    \u0027format\u0027: \u0027uuid\u0027,"},{"line_number":40,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":8,"id":"2c1451d5_10153cf8","line":37,"updated":"2026-10-24 06:54:24.000000000","message":"I noticed this is listed in the request examples in the doc, but it is written as share_group_type in the request table. The table should reference it as \u0027share_group_type_id\u0027 as well.\nThis is a discrepancy worth looking into","commit_id":"2fe926040508a1077fff3d42529bac30ff7a6d02"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"073f5571e73373b6afd8fdbf50cfc5b2f0b0aa8e","unresolved":true,"context_lines":[{"line_number":38,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":39,"context_line":"                    \u0027format\u0027: \u0027uuid\u0027,"},{"line_number":40,"context_line":"                },"},{"line_number":41,"context_line":"                \u0027source_share_group_snapshot_id\u0027: {"},{"line_number":42,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":43,"context_line":"                    \u0027format\u0027: \u0027uuid\u0027,"},{"line_number":44,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":8,"id":"e8924e35_ce28eea9","line":41,"updated":"2026-10-24 06:54:24.000000000","message":"same as above","commit_id":"2fe926040508a1077fff3d42529bac30ff7a6d02"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"073f5571e73373b6afd8fdbf50cfc5b2f0b0aa8e","unresolved":true,"context_lines":[{"line_number":42,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":43,"context_line":"                    \u0027format\u0027: \u0027uuid\u0027,"},{"line_number":44,"context_line":"                },"},{"line_number":45,"context_line":"                \u0027share_network_id\u0027: {"},{"line_number":46,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":47,"context_line":"                    \u0027format\u0027: \u0027uuid\u0027,"},{"line_number":48,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":8,"id":"8600769a_f08ff740","line":45,"updated":"2026-10-24 06:54:24.000000000","message":"same as above","commit_id":"2fe926040508a1077fff3d42529bac30ff7a6d02"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"073f5571e73373b6afd8fdbf50cfc5b2f0b0aa8e","unresolved":true,"context_lines":[{"line_number":46,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":47,"context_line":"                    \u0027format\u0027: \u0027uuid\u0027,"},{"line_number":48,"context_line":"                },"},{"line_number":49,"context_line":"                \u0027availability_zone\u0027: {"},{"line_number":50,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":51,"context_line":"                    \u0027minLength\u0027: 0,"},{"line_number":52,"context_line":"                    \u0027maxLength\u0027: 255,"}],"source_content_type":"text/x-python","patch_set":8,"id":"cd2ec37b_22651cb6","line":49,"updated":"2026-10-24 06:54:24.000000000","message":"The \u0027availability_zone\u0027 is introduced in a new version so we would want to microversion it","commit_id":"2fe926040508a1077fff3d42529bac30ff7a6d02"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"073f5571e73373b6afd8fdbf50cfc5b2f0b0aa8e","unresolved":true,"context_lines":[{"line_number":48,"context_line":"                },"},{"line_number":49,"context_line":"                \u0027availability_zone\u0027: {"},{"line_number":50,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":51,"context_line":"                    \u0027minLength\u0027: 0,"},{"line_number":52,"context_line":"                    \u0027maxLength\u0027: 255,"},{"line_number":53,"context_line":"                },"},{"line_number":54,"context_line":"            },"},{"line_number":55,"context_line":"            \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":8,"id":"b5378d3c_9481e5a7","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":37},"updated":"2026-10-24 06:54:24.000000000","message":"why are we giving it limits? The doc doesn\u0027t state this","commit_id":"2fe926040508a1077fff3d42529bac30ff7a6d02"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"073f5571e73373b6afd8fdbf50cfc5b2f0b0aa8e","unresolved":true,"context_lines":[{"line_number":67,"context_line":"            \u0027properties\u0027: {"},{"line_number":68,"context_line":"                \u0027name\u0027: {"},{"line_number":69,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":70,"context_line":"                    \u0027minLength\u0027: 0,"},{"line_number":71,"context_line":"                    \u0027maxLength\u0027: 255,"},{"line_number":72,"context_line":"                },"},{"line_number":73,"context_line":"                \u0027description\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"819b2580_66faeb70","line":70,"updated":"2026-10-24 06:54:24.000000000","message":"I know this field is optional, but if one wants to add a name, should we allow them pass an empty string? If no please update the \u0027minLength\u0027 to 1","commit_id":"2fe926040508a1077fff3d42529bac30ff7a6d02"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"073f5571e73373b6afd8fdbf50cfc5b2f0b0aa8e","unresolved":true,"context_lines":[{"line_number":72,"context_line":"                },"},{"line_number":73,"context_line":"                \u0027description\u0027: {"},{"line_number":74,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":75,"context_line":"                    \u0027minLength\u0027: 0,"},{"line_number":76,"context_line":"                    \u0027maxLength\u0027: 255,"},{"line_number":77,"context_line":"                },"},{"line_number":78,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":8,"id":"e89b49c7_8a5b707e","line":75,"updated":"2026-10-24 06:54:24.000000000","message":"same as above","commit_id":"2fe926040508a1077fff3d42529bac30ff7a6d02"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"073f5571e73373b6afd8fdbf50cfc5b2f0b0aa8e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b807589f_cd0fb409","line":85,"updated":"2026-10-24 06:54:24.000000000","message":"Nice work, Hashaaam. It would have been good practice to have the endpoints in different patches, but nevertheless, Both endpoints require a response schema\n\nSecondly, I do not see the file containing your schema decorators attached to the endpoint","commit_id":"2fe926040508a1077fff3d42529bac30ff7a6d02"}],"manila/api/v2/share_groups.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8594e3027d2952e3c2b1cd45b380b8de0650588d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.api.openstack import api_version_request as api_version"},{"line_number":25,"context_line":"from manila.api.openstack import wsgi"},{"line_number":26,"context_line":"from manila.api.views import share_groups as share_group_views"},{"line_number":27,"context_line":"from manila.api import validation"},{"line_number":28,"context_line":"from manila.api.schemas import share_groups as share_groups_schema"},{"line_number":29,"context_line":"from manila import db"},{"line_number":30,"context_line":"from manila import exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"e12b6a7f_d39df335","line":27,"updated":"2026-10-12 23:23:13.000000000","message":"pep8: H306: imports not in alphabetical order (manila.api.views.share_groups, manila.api.validation)","commit_id":"a554e990987a7fc047a407052a54df325b466e72"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8594e3027d2952e3c2b1cd45b380b8de0650588d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from manila.api.openstack import wsgi"},{"line_number":26,"context_line":"from manila.api.views import share_groups as share_group_views"},{"line_number":27,"context_line":"from manila.api import validation"},{"line_number":28,"context_line":"from manila.api.schemas import share_groups as share_groups_schema"},{"line_number":29,"context_line":"from manila import db"},{"line_number":30,"context_line":"from manila import exception"},{"line_number":31,"context_line":"from manila.i18n import _"}],"source_content_type":"text/x-python","patch_set":1,"id":"84663d22_28e24f9c","line":28,"updated":"2026-10-12 23:23:13.000000000","message":"pep8: H306: imports not in alphabetical order (manila.api.validation, manila.api.schemas.share_groups)","commit_id":"a554e990987a7fc047a407052a54df325b466e72"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"48acb83e5271f9cb3c26b42957aed85cfd89be23","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.api.openstack import api_version_request as api_version"},{"line_number":25,"context_line":"from manila.api.openstack import wsgi"},{"line_number":26,"context_line":"from manila.api import validation"},{"line_number":27,"context_line":"from manila.api.schemas import share_groups as share_groups_schema"},{"line_number":28,"context_line":"from manila.api.views import share_groups as share_group_views"},{"line_number":29,"context_line":"from manila import db"},{"line_number":30,"context_line":"from manila import exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"6143fe0b_1e6bec76","line":27,"updated":"2026-10-13 00:27:06.000000000","message":"pep8: H306: imports not in alphabetical order (manila.api.validation, manila.api.schemas.share_groups)","commit_id":"819ae5fc6d684a83065f1227358df7f9081a3ec6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e874575391c4e99d4b8b80acb18b38b9fcf9553f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.api.openstack import api_version_request as api_version"},{"line_number":25,"context_line":"from manila.api.openstack import wsgi"},{"line_number":26,"context_line":"from manila.api import validation"},{"line_number":27,"context_line":"from manila.api.schemas import share_groups as share_groups_schema"},{"line_number":28,"context_line":"from manila.api.views import share_groups as share_group_views"},{"line_number":29,"context_line":"from manila import db"},{"line_number":30,"context_line":"from manila import exception"}],"source_content_type":"text/x-python","patch_set":4,"id":"a1843122_33c001b6","line":27,"updated":"2026-10-14 01:11:00.000000000","message":"pep8: H306: imports not in alphabetical order (manila.api.validation, manila.api.schemas.share_groups)","commit_id":"67cd916b34d86a5efc40640f2786cb2a93c4bd65"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"eb2c125736b7504b61941475e55e37aac31bd798","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from manila.api import common"},{"line_number":24,"context_line":"from manila.api import validation"},{"line_number":25,"context_line":"from manila.api.openstack import api_version_request as api_version"},{"line_number":26,"context_line":"from manila.api.openstack import wsgi"},{"line_number":27,"context_line":"from manila.api.schemas import share_groups as share_groups_schema"},{"line_number":28,"context_line":"from manila.api.views import share_groups as share_group_views"}],"source_content_type":"text/x-python","patch_set":5,"id":"150e5a91_8756f00b","line":25,"updated":"2026-10-14 02:29:47.000000000","message":"pep8: H306: imports not in alphabetical order (manila.api.validation, manila.api.openstack.api_version_request)","commit_id":"2e437ac0a05d510b7368d0d5038e8ba9de34d743"}]}