)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38762,"name":"Sahil Kumbhar","display_name":"sakumbha","email":"sakumbha@redhat.com","username":"sakumbha"},"change_message_id":"db7168b4cc6a47f732519fd2142f78d51969ca7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3155da9d_4e515080","updated":"2026-10-13 10:18:18.000000000","message":"fix this \n`manila/api/v2/share_instances.py:19:1: F401 \u0027manila.api.validation\u0027 imported but unused\nmanila/api/v2/share_instances.py:20:1: F401 \u0027manila.api.schemas.share_instances as share_instances_schema\u0027 imported but unused\nmanila/api/v2/share_instances.py:20:1: H306: imports not in alphabetical order (manila.api.validation, manila.api.schemas.share_instances)\nmanila/api/v2/share_instances.py:21:1: H306: imports not in alphabetical order (manila.api.schemas.share_instances, manila.api.openstack.wsgi`","commit_id":"8d8c50824cdf76703e0954e078ddf3e73acfb723"},{"author":{"_account_id":38762,"name":"Sahil Kumbhar","display_name":"sakumbha","email":"sakumbha@redhat.com","username":"sakumbha"},"change_message_id":"526d9570dcb7ed0bf00adc16f3f40e88f0440c2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a6bdcdbe_fd524e1d","updated":"2026-10-13 10:18:57.000000000","message":"please check the pep8 is failing.","commit_id":"8d8c50824cdf76703e0954e078ddf3e73acfb723"},{"author":{"_account_id":38982,"name":"Meer Hashaam Khan","display_name":"hashaaam","email":"hashaamkhan975@gmail.com","username":"hashaaam"},"change_message_id":"8a61b6ca41eb49e766cd3e62ce680170f08d9ac7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"113582a7_ccb3d01d","updated":"2026-10-14 00:06:40.000000000","message":"Thank you for the review Sahil! I have fixed the pep8 failures \nin the latest patchset. Please take another look when available.","commit_id":"d61840ff76962584af01662a8a9624b75f718b73"},{"author":{"_account_id":38982,"name":"Meer Hashaam Khan","display_name":"hashaaam","email":"hashaamkhan975@gmail.com","username":"hashaaam"},"change_message_id":"c68a92a3f24d0907e600ee94cb41a0be32d473a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"964edfd9_f0c6c2d0","updated":"2026-10-28 23:26:41.000000000","message":"Thanks Olamide. The latest patchset attaches the schemas to index and show and adds the response schemas, in the microversion ranges of the view builder. The export_location_id and export_location_path filters now start at 2.35, where the controller starts using them (it ignores them before that), and is_soft_deleted at 2.69. I did not use format uuid for the export location id because the API accepts any string and returns an empty list for unknown ids, so uuid would reject requests that work today. additionalProperties also stays True for the same reason. The unused show query schema you flagged is removed. The reset status and force delete actions are not changed in this patch. Carlos said multiple endpoints in one patch are fine as they are. I\u0027ll resolve these once Zuul passes.","commit_id":"06357d8ac9def59f02e99b6d129bfd97ef0a3ad0"}],"manila/api/schemas/share_instances.py":[{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"a93e5d55c4c11a89838fc9f8012128342b7e2845","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"index_request_query \u003d {"},{"line_number":14,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":15,"context_line":"    \u0027properties\u0027: {"},{"line_number":16,"context_line":"        \u0027export_location_id\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ae98257_7a494e7d","line":13,"updated":"2026-10-24 12:50:10.000000000","message":"A response body is also required for this endpoint","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":38982,"name":"Meer Hashaam Khan","display_name":"hashaaam","email":"hashaamkhan975@gmail.com","username":"hashaaam"},"change_message_id":"48e8e560260fc86d35daa48e48089b0a5b7d455d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"index_request_query \u003d {"},{"line_number":14,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":15,"context_line":"    \u0027properties\u0027: {"},{"line_number":16,"context_line":"        \u0027export_location_id\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff9378e2_5caf0efe","line":13,"in_reply_to":"0ae98257_7a494e7d","updated":"2026-10-28 23:26:51.000000000","message":"Done","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"a93e5d55c4c11a89838fc9f8012128342b7e2845","unresolved":true,"context_lines":[{"line_number":13,"context_line":"index_request_query \u003d {"},{"line_number":14,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":15,"context_line":"    \u0027properties\u0027: {"},{"line_number":16,"context_line":"        \u0027export_location_id\u0027: {"},{"line_number":17,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":18,"context_line":"        },"},{"line_number":19,"context_line":"        \u0027export_location_path\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"58850848_e83036aa","line":16,"updated":"2026-10-24 12:50:10.000000000","message":"The \u0027export_location_id\u0027 is introduced in a new version so we would want to microversion it and also its format should be specified as a UUID","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":38982,"name":"Meer Hashaam Khan","display_name":"hashaaam","email":"hashaamkhan975@gmail.com","username":"hashaaam"},"change_message_id":"48e8e560260fc86d35daa48e48089b0a5b7d455d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"index_request_query \u003d {"},{"line_number":14,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":15,"context_line":"    \u0027properties\u0027: {"},{"line_number":16,"context_line":"        \u0027export_location_id\u0027: {"},{"line_number":17,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":18,"context_line":"        },"},{"line_number":19,"context_line":"        \u0027export_location_path\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"af46a5ca_14fb2c47","line":16,"in_reply_to":"58850848_e83036aa","updated":"2026-10-28 23:26:51.000000000","message":"Done","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"a93e5d55c4c11a89838fc9f8012128342b7e2845","unresolved":true,"context_lines":[{"line_number":16,"context_line":"        \u0027export_location_id\u0027: {"},{"line_number":17,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":18,"context_line":"        },"},{"line_number":19,"context_line":"        \u0027export_location_path\u0027: {"},{"line_number":20,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":21,"context_line":"        },"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":4,"id":"312aab5b_e74c1165","line":19,"updated":"2026-10-24 12:50:10.000000000","message":"The \u0027export_location_path\u0027 is introduced in a new version so we would want to microversion it","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":38982,"name":"Meer Hashaam Khan","display_name":"hashaaam","email":"hashaamkhan975@gmail.com","username":"hashaaam"},"change_message_id":"48e8e560260fc86d35daa48e48089b0a5b7d455d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        \u0027export_location_id\u0027: {"},{"line_number":17,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":18,"context_line":"        },"},{"line_number":19,"context_line":"        \u0027export_location_path\u0027: {"},{"line_number":20,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":21,"context_line":"        },"},{"line_number":22,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":4,"id":"84c61688_c1d4d19b","line":19,"in_reply_to":"312aab5b_e74c1165","updated":"2026-10-28 23:26:51.000000000","message":"Done","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"a93e5d55c4c11a89838fc9f8012128342b7e2845","unresolved":true,"context_lines":[{"line_number":20,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":21,"context_line":"        },"},{"line_number":22,"context_line":"    },"},{"line_number":23,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"show_request_query \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"d91b8600_986dff97","line":23,"updated":"2026-10-24 12:50:10.000000000","message":"additionalProperties should be False","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":38982,"name":"Meer Hashaam Khan","display_name":"hashaaam","email":"hashaamkhan975@gmail.com","username":"hashaaam"},"change_message_id":"48e8e560260fc86d35daa48e48089b0a5b7d455d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":21,"context_line":"        },"},{"line_number":22,"context_line":"    },"},{"line_number":23,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"show_request_query \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"71e64e8a_c8a4ab77","line":23,"in_reply_to":"d91b8600_986dff97","updated":"2026-10-28 23:26:51.000000000","message":"Done","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"a93e5d55c4c11a89838fc9f8012128342b7e2845","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"show_request_query \u003d {"},{"line_number":27,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":28,"context_line":"    \u0027properties\u0027: {},"},{"line_number":29,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"reset_status_request_body \u003d {"},{"line_number":33,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"6870de3b_3e5aa5b3","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":1},"updated":"2026-10-24 12:50:10.000000000","message":"Does this reference the show share instance details? if so please this is wrong","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":38982,"name":"Meer Hashaam Khan","display_name":"hashaaam","email":"hashaamkhan975@gmail.com","username":"hashaaam"},"change_message_id":"48e8e560260fc86d35daa48e48089b0a5b7d455d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"show_request_query \u003d {"},{"line_number":27,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":28,"context_line":"    \u0027properties\u0027: {},"},{"line_number":29,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"reset_status_request_body \u003d {"},{"line_number":33,"context_line":"    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df344a53_19a2618a","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":1},"in_reply_to":"6870de3b_3e5aa5b3","updated":"2026-10-28 23:26:51.000000000","message":"Done","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"a93e5d55c4c11a89838fc9f8012128342b7e2845","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"reset_status_request_body \u003d {"},{"line_number":33,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":34,"context_line":"    \u0027properties\u0027: {"},{"line_number":35,"context_line":"        \u0027reset_status\u0027: {"},{"line_number":36,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":37,"context_line":"            \u0027properties\u0027: {"},{"line_number":38,"context_line":"                \u0027status\u0027: {"},{"line_number":39,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":40,"context_line":"                },"},{"line_number":41,"context_line":"            },"},{"line_number":42,"context_line":"            \u0027required\u0027: [\u0027status\u0027],"},{"line_number":43,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":44,"context_line":"        },"},{"line_number":45,"context_line":"    },"},{"line_number":46,"context_line":"    \u0027required\u0027: [\u0027reset_status\u0027],"},{"line_number":47,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":48,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"ea2ff35b_e17aeeb5","line":48,"range":{"start_line":32,"start_character":0,"end_line":48,"end_character":1},"updated":"2026-10-24 12:50:10.000000000","message":"LGTM for the reset share instance state","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":38982,"name":"Meer Hashaam Khan","display_name":"hashaaam","email":"hashaamkhan975@gmail.com","username":"hashaaam"},"change_message_id":"48e8e560260fc86d35daa48e48089b0a5b7d455d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"reset_status_request_body \u003d {"},{"line_number":33,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":34,"context_line":"    \u0027properties\u0027: {"},{"line_number":35,"context_line":"        \u0027reset_status\u0027: {"},{"line_number":36,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":37,"context_line":"            \u0027properties\u0027: {"},{"line_number":38,"context_line":"                \u0027status\u0027: {"},{"line_number":39,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":40,"context_line":"                },"},{"line_number":41,"context_line":"            },"},{"line_number":42,"context_line":"            \u0027required\u0027: [\u0027status\u0027],"},{"line_number":43,"context_line":"            \u0027additionalProperties\u0027: False,"},{"line_number":44,"context_line":"        },"},{"line_number":45,"context_line":"    },"},{"line_number":46,"context_line":"    \u0027required\u0027: [\u0027reset_status\u0027],"},{"line_number":47,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":48,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"245f206e_8e4d9d03","line":48,"range":{"start_line":32,"start_character":0,"end_line":48,"end_character":1},"in_reply_to":"ea2ff35b_e17aeeb5","updated":"2026-10-28 23:26:51.000000000","message":"Done","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"a93e5d55c4c11a89838fc9f8012128342b7e2845","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e2dc0d7c_26350979","line":49,"updated":"2026-10-24 12:50:10.000000000","message":"Thank you, Hashaaam. It would have been good practice to have the endpoints in different patches.\n\nSecondly, I do not see the file containing your schema decorators attached to the endpoint","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"},{"author":{"_account_id":38982,"name":"Meer Hashaam Khan","display_name":"hashaaam","email":"hashaamkhan975@gmail.com","username":"hashaaam"},"change_message_id":"48e8e560260fc86d35daa48e48089b0a5b7d455d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c88aef48_6608e00e","line":49,"in_reply_to":"e2dc0d7c_26350979","updated":"2026-10-28 23:26:51.000000000","message":"Done","commit_id":"18af757ab22dccc3675b390ae7df5c9736b2b7a4"}],"manila/api/v2/share_instances.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"35fd22b4afa23375a44c5e4f32c460f5bbcff2f7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from webob import exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila.api import common"},{"line_number":19,"context_line":"from manila.api import validation"},{"line_number":20,"context_line":"from manila.api.schemas import share_instances as share_instances_schema"},{"line_number":21,"context_line":"from manila.api.openstack import wsgi"},{"line_number":22,"context_line":"from manila.api.views import share_instance as instance_view"}],"source_content_type":"text/x-python","patch_set":2,"id":"47fcf01d_81224c1f","line":19,"updated":"2026-10-13 01:31:00.000000000","message":"pep8: F401 \u0027manila.api.validation\u0027 imported but unused","commit_id":"8d8c50824cdf76703e0954e078ddf3e73acfb723"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"35fd22b4afa23375a44c5e4f32c460f5bbcff2f7","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila.api import common"},{"line_number":19,"context_line":"from manila.api import validation"},{"line_number":20,"context_line":"from manila.api.schemas import share_instances as share_instances_schema"},{"line_number":21,"context_line":"from manila.api.openstack import wsgi"},{"line_number":22,"context_line":"from manila.api.views import share_instance as instance_view"},{"line_number":23,"context_line":"from manila import db"}],"source_content_type":"text/x-python","patch_set":2,"id":"c07b2749_01acc330","line":20,"updated":"2026-10-13 01:31:00.000000000","message":"pep8: F401 \u0027manila.api.schemas.share_instances as share_instances_schema\u0027 imported but unused","commit_id":"8d8c50824cdf76703e0954e078ddf3e73acfb723"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"35fd22b4afa23375a44c5e4f32c460f5bbcff2f7","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from manila.api import common"},{"line_number":19,"context_line":"from manila.api import validation"},{"line_number":20,"context_line":"from manila.api.schemas import share_instances as share_instances_schema"},{"line_number":21,"context_line":"from manila.api.openstack import wsgi"},{"line_number":22,"context_line":"from manila.api.views import share_instance as instance_view"},{"line_number":23,"context_line":"from manila import db"}],"source_content_type":"text/x-python","patch_set":2,"id":"92cd82f8_c87d1893","line":20,"updated":"2026-10-13 01:31:00.000000000","message":"pep8: H306: imports not in alphabetical order (manila.api.validation, manila.api.schemas.share_instances)","commit_id":"8d8c50824cdf76703e0954e078ddf3e73acfb723"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"35fd22b4afa23375a44c5e4f32c460f5bbcff2f7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from manila.api import common"},{"line_number":19,"context_line":"from manila.api import validation"},{"line_number":20,"context_line":"from manila.api.schemas import share_instances as share_instances_schema"},{"line_number":21,"context_line":"from manila.api.openstack import wsgi"},{"line_number":22,"context_line":"from manila.api.views import share_instance as instance_view"},{"line_number":23,"context_line":"from manila import db"},{"line_number":24,"context_line":"from manila import exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"154771a9_f47b92b7","line":21,"updated":"2026-10-13 01:31:00.000000000","message":"pep8: H306: imports not in alphabetical order (manila.api.schemas.share_instances, manila.api.openstack.wsgi)","commit_id":"8d8c50824cdf76703e0954e078ddf3e73acfb723"}]}
