)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"9a708b9038bbef4fe814d2c3c448df5026c70ee2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c06316a5_070c0f7b","updated":"2026-10-19 14:51:29.000000000","message":"Hello comfort, this is good work. I just have two comments to add","commit_id":"4c3e269641d6228b09f50eb4a83390e004aab541"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"773674433fe509362c11fbc3478a63ab71f83029","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f8a36596_8ccfd6fd","in_reply_to":"c06316a5_070c0f7b","updated":"2026-10-19 19:22:34.000000000","message":"I am also willing to collaborate with you on this, i.e build on top of what you currently have but that\u0027s if it\u0027s okay by you","commit_id":"4c3e269641d6228b09f50eb4a83390e004aab541"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"34f86e95e8c52227f0cf9be036c8b9645b3167f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cb1e76bf_081e401c","in_reply_to":"f8a36596_8ccfd6fd","updated":"2026-10-19 19:55:28.000000000","message":"Sure, when I\u0027m done updating this patchset.","commit_id":"4c3e269641d6228b09f50eb4a83390e004aab541"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1c6ac3a6e17bd01ace1f6254cfda690a6ff61684","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"231683b9_6359e4a7","updated":"2026-10-21 20:18:15.000000000","message":"Thank you for working on this change. Please take a look at the comments inline","commit_id":"0c2b17e21c13a665d188414568553678d0af6ed3"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"7da8cc9518318acc1fc1a68ebd9b797088c8d141","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"04dd14cc_749348c7","updated":"2026-11-02 09:55:26.000000000","message":"Recheck","commit_id":"757fd94d99e18a051cb83d332639276e65cc2928"}],"manila/api/schemas/shares.py":[{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"773674433fe509362c11fbc3478a63ab71f83029","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"update_request_body \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: [\u0027object\u0027, \u0027null\u0027],"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027share\u0027: {"},{"line_number":24,"context_line":"            \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"10c0c5b9_75d05e50","line":21,"updated":"2026-10-19 19:22:34.000000000","message":"I noticed the request schema allows null via \u0027type\u0027: [\u0027object\u0027, \u0027null\u0027]. Does the API intend to accept a null request body here?","commit_id":"4c3e269641d6228b09f50eb4a83390e004aab541"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"34f86e95e8c52227f0cf9be036c8b9645b3167f7","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"update_request_body \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: [\u0027object\u0027, \u0027null\u0027],"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027share\u0027: {"},{"line_number":24,"context_line":"            \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"4354922e_caef277c","line":21,"in_reply_to":"10c0c5b9_75d05e50","updated":"2026-10-19 19:55:28.000000000","message":"This already been addressed in patchset 3.","commit_id":"4c3e269641d6228b09f50eb4a83390e004aab541"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"773674433fe509362c11fbc3478a63ab71f83029","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"_status \u003d {"},{"line_number":46,"context_line":"    \u0027type\u0027: \u0027string\u0027,"},{"line_number":47,"context_line":"    \u0027enum\u0027: list(constants.SHARE_STATUSES),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fe36a69e_f8d29df0","line":44,"updated":"2026-10-19 19:22:34.000000000","message":"Ideally, we would want to include a response body as well for this endpoint","commit_id":"4c3e269641d6228b09f50eb4a83390e004aab541"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"34f86e95e8c52227f0cf9be036c8b9645b3167f7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"_status \u003d {"},{"line_number":46,"context_line":"    \u0027type\u0027: \u0027string\u0027,"},{"line_number":47,"context_line":"    \u0027enum\u0027: list(constants.SHARE_STATUSES),"}],"source_content_type":"text/x-python","patch_set":2,"id":"e4a81c08_18f68c52","line":44,"in_reply_to":"fe36a69e_f8d29df0","updated":"2026-10-19 19:55:28.000000000","message":"I will submit a ptach that addresses that. My goal was to keep this patchset scoped to request validation.","commit_id":"4c3e269641d6228b09f50eb4a83390e004aab541"}],"manila/api/v2/shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1c6ac3a6e17bd01ace1f6254cfda690a6ff61684","unresolved":true,"context_lines":[{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        return self._view_builder.detail(req, share)"},{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"    @wsgi.Controller.api_version(\"2.0\")"},{"line_number":1425,"context_line":"    @validation.request_body_schema(schema.update_request_body)"},{"line_number":1426,"context_line":"    @wsgi.Controller.authorize"},{"line_number":1427,"context_line":"    def update(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a37608f3_83b3f144","line":1424,"range":{"start_line":1424,"start_character":4,"end_line":1424,"end_character":39},"updated":"2026-10-21 20:18:15.000000000","message":"why was the new annotation necessary?","commit_id":"0c2b17e21c13a665d188414568553678d0af6ed3"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"cfe07660659f5865b27f40785463b5a45dd9f6c4","unresolved":false,"context_lines":[{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        return self._view_builder.detail(req, share)"},{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"    @wsgi.Controller.api_version(\"2.0\")"},{"line_number":1425,"context_line":"    @validation.request_body_schema(schema.update_request_body)"},{"line_number":1426,"context_line":"    @wsgi.Controller.authorize"},{"line_number":1427,"context_line":"    def update(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":4,"id":"2df12253_bfee3cc5","line":1424,"range":{"start_line":1424,"start_character":4,"end_line":1424,"end_character":39},"in_reply_to":"6c04ccc6_91ca4880","updated":"2026-10-25 20:17:25.000000000","message":"I’ve read through the microversion docs and I see the annotation is added for version-gated changes. So I’m removing it as it doesn’t affect the method I added.","commit_id":"0c2b17e21c13a665d188414568553678d0af6ed3"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"d94694db7702e322ed5b1d04378b053809b3d814","unresolved":true,"context_lines":[{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"        return self._view_builder.detail(req, share)"},{"line_number":1423,"context_line":""},{"line_number":1424,"context_line":"    @wsgi.Controller.api_version(\"2.0\")"},{"line_number":1425,"context_line":"    @validation.request_body_schema(schema.update_request_body)"},{"line_number":1426,"context_line":"    @wsgi.Controller.authorize"},{"line_number":1427,"context_line":"    def update(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":4,"id":"6c04ccc6_91ca4880","line":1424,"range":{"start_line":1424,"start_character":4,"end_line":1424,"end_character":39},"in_reply_to":"a37608f3_83b3f144","updated":"2026-10-21 22:12:59.000000000","message":"I added it to keep it consistent with the other methods in this file, since they also have explicit declarations. I thought that would be the right thing to do.","commit_id":"0c2b17e21c13a665d188414568553678d0af6ed3"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e4a675e265df444470769d29c2d6364c7be3bdac","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            \u0027share_type_name\u0027: None,"},{"line_number":197,"context_line":"            \u0027links\u0027: ["},{"line_number":198,"context_line":"                {"},{"line_number":199,"context_line":"                    \u0027href\u0027: f\u0027http://localhost/share/v2/fake/shares/{stubs.FAKE_UUID}\u0027,"},{"line_number":200,"context_line":"                    \u0027rel\u0027: \u0027self\u0027"},{"line_number":201,"context_line":"                },"},{"line_number":202,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":7,"id":"68da0c0c_d65b8614","line":199,"updated":"2026-10-30 14:19:34.000000000","message":"pep8: E501 line too long (87 \u003e 79 characters)","commit_id":"6c58b387f797a276cec579923738d6025cb944c4"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"420cb9c9789787c1cb35a8b8161baf3ec6ef470b","unresolved":true,"context_lines":[{"line_number":196,"context_line":"            \u0027share_type_name\u0027: None,"},{"line_number":197,"context_line":"            \u0027links\u0027: ["},{"line_number":198,"context_line":"                {"},{"line_number":199,"context_line":"                    \u0027href\u0027: f\u0027http://localhost/share/v2/fake/shares/{stubs.FAKE_UUID}\u0027,"},{"line_number":200,"context_line":"                    \u0027rel\u0027: \u0027self\u0027"},{"line_number":201,"context_line":"                },"},{"line_number":202,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":7,"id":"69beda73_67762c22","line":199,"in_reply_to":"68da0c0c_d65b8614","updated":"2026-10-30 14:23:57.000000000","message":"Hey comfort. To solve this you\u0027d just have to run tox -e pep8 then fix the necessary failures as listed by zuul then run tox -e pep8 again after to ensure your files are properly linted","commit_id":"6c58b387f797a276cec579923738d6025cb944c4"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"f5c0a943f6d69f1ee585cde066d0317820f1c6d3","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            \u0027share_type_name\u0027: None,"},{"line_number":197,"context_line":"            \u0027links\u0027: ["},{"line_number":198,"context_line":"                {"},{"line_number":199,"context_line":"                    \u0027href\u0027: f\u0027http://localhost/share/v2/fake/shares/{stubs.FAKE_UUID}\u0027,"},{"line_number":200,"context_line":"                    \u0027rel\u0027: \u0027self\u0027"},{"line_number":201,"context_line":"                },"},{"line_number":202,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":7,"id":"bce37470_3d81fde9","line":199,"in_reply_to":"69beda73_67762c22","updated":"2026-10-30 14:39:49.000000000","message":"Acknowledged","commit_id":"6c58b387f797a276cec579923738d6025cb944c4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e4a675e265df444470769d29c2d6364c7be3bdac","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                    \u0027rel\u0027: \u0027self\u0027"},{"line_number":201,"context_line":"                },"},{"line_number":202,"context_line":"                {"},{"line_number":203,"context_line":"                    \u0027href\u0027: f\u0027http://localhost/share/fake/shares/{stubs.FAKE_UUID}\u0027,"},{"line_number":204,"context_line":"                    \u0027rel\u0027: \u0027bookmark\u0027"},{"line_number":205,"context_line":"                }"},{"line_number":206,"context_line":"            ],"}],"source_content_type":"text/x-python","patch_set":7,"id":"cd6cb78f_4fc252f9","line":203,"updated":"2026-10-30 14:19:34.000000000","message":"pep8: E501 line too long (84 \u003e 79 characters)","commit_id":"6c58b387f797a276cec579923738d6025cb944c4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e4a675e265df444470769d29c2d6364c7be3bdac","unresolved":false,"context_lines":[{"line_number":2658,"context_line":"        search_opts \u003d {\u0027a\u0027: \u0027a\u0027, \u0027b\u0027: \u0027b\u0027, \u0027c\u0027: \u0027c\u0027, \u0027d\u0027: \u0027d\u0027}"},{"line_number":2659,"context_line":"        expected_opts \u003d {\u0027a\u0027: \u0027a\u0027, \u0027c\u0027: \u0027c\u0027}"},{"line_number":2660,"context_line":"        allowed_opts \u003d [\u0027a\u0027, \u0027c\u0027]"},{"line_number":2661,"context_line":"        common.remove_invalid_options(ctx, search_opts, allowed_opts)"},{"line_number":2662,"context_line":"        self.assertEqual(expected_opts, search_opts)"},{"line_number":2663,"context_line":""},{"line_number":2664,"context_line":"    def test_remove_invalid_options_admin(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bcd12955_f11df100","line":2661,"updated":"2026-10-30 14:19:34.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"6c58b387f797a276cec579923738d6025cb944c4"}]}
