)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"b5cf8928a393609005a58cd0bf1eb84d89cc6e97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"46791a2b_90034e04","updated":"2026-10-25 00:37:10.000000000","message":"Thanks for working on this! The voting tempest failures come from the schema rejecting unknown query parameters (see inline): test_delete_locked_resource sends ?force\u003dTrue to delete and gets a 400 instead of the expected 403. Keeping additionalProperties: True should fix it, and it matches the guidance that existing requests must keep working.","commit_id":"550b6af1bc0b04949e39a10717ee837e3ccae4df"},{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"ae1d2c15d6d2ace7cdf87e5ceeb58d12c9741d99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f589e910_a3564082","updated":"2026-10-25 00:37:58.000000000","message":"You can recheck and fix","commit_id":"550b6af1bc0b04949e39a10717ee837e3ccae4df"},{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"d255af162f9f629ffd456eaf4dcc5a7d9aa3e307","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7e9c2095_6e6c57d2","updated":"2026-10-26 23:10:04.000000000","message":"Thanks for the update! Patchset 6 fixes the tempest failure: I checked locally that DELETE /v2/shares/\u003cid\u003e?force\u003dTrue now returns 202 as on master, and that a repeated share_group_id is rejected by single_param with a ValidationError.","commit_id":"7d6e48ffae5aa407ca2a96a9ef49ce37c9e8575c"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"fd423482dc8904847f4b802b6a3d26dce3cbb2ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8e61474e_62ccdf6b","in_reply_to":"7e9c2095_6e6c57d2","updated":"2026-10-30 12:57:29.000000000","message":"Thanks Delight","commit_id":"7d6e48ffae5aa407ca2a96a9ef49ce37c9e8575c"}],"manila/api/schemas/shares.py":[{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"b1df2a4776d6d027ec652ca8cef0788974fc6c78","unresolved":true,"context_lines":[{"line_number":20,"context_line":"delete_request_query \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027share_group_id\u0027: parameter_types.single_param({"},{"line_number":24,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":25,"context_line":"        }),"},{"line_number":26,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":2,"id":"da564981_4606d7b8","line":23,"updated":"2026-10-19 19:21:31.000000000","message":"Hello Comfort, I would get back to you once I get a solid knowledge of how to handle the delete endpoint, but I\u0027m sure currently the endpoint accepts only path parameters, so having a request query doesn\u0027t solve the problem.\n\nNB: the path parameter is share_id not share_group_id","commit_id":"d8920824cdf78ff97cc800bc9a1cd732d0d5017a"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"9783f51ced23b69e2df6c76aa78a1187eaf73c65","unresolved":false,"context_lines":[{"line_number":20,"context_line":"delete_request_query \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027share_group_id\u0027: parameter_types.single_param({"},{"line_number":24,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":25,"context_line":"        }),"},{"line_number":26,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf3b5065_19cd8753","line":23,"in_reply_to":"2cb6b45b_9f3e81a0","updated":"2026-10-22 09:08:06.000000000","message":"Hi Olamide, thanks for the feedback!\nAbout the path parameter (share_id), there\u0027s currently no validator to validate path parameters, so I could only validate the query parameter (share_group_id). Regarding the `share_group_id`, I wrote the validation for it as it is required by the deletion logic when the share being deleted is in a share group.","commit_id":"d8920824cdf78ff97cc800bc9a1cd732d0d5017a"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"6b214c3db0557ed89be7e48c3dfa6259b4efd14b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"delete_request_query \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027share_group_id\u0027: parameter_types.single_param({"},{"line_number":24,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":25,"context_line":"        }),"},{"line_number":26,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef2b1f8a_6da01087","line":23,"in_reply_to":"bf3b5065_19cd8753","updated":"2026-10-22 09:41:05.000000000","message":"I don\u0027t think this is right. Could you point me to the direction of the `share_group_id` requiring a query param? Cause from what I see,the shares.delete endpoint does not take a query.","commit_id":"d8920824cdf78ff97cc800bc9a1cd732d0d5017a"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"a4dcb92d3f1ad91175824b6c4016d69d63b6f2f5","unresolved":true,"context_lines":[{"line_number":20,"context_line":"delete_request_query \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027share_group_id\u0027: parameter_types.single_param({"},{"line_number":24,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":25,"context_line":"        }),"},{"line_number":26,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":2,"id":"2cb6b45b_9f3e81a0","line":23,"in_reply_to":"da564981_4606d7b8","updated":"2026-10-20 18:46:31.000000000","message":"Hey comfort, it\u0027s me again 😀, but this time I\u0027m back with a proposed solution.\nIn response to my previous comment, after doing some digging, my proposed solution is delete_response \u003d {\u0027type\u0027 : \u0027null\u0027}.","commit_id":"d8920824cdf78ff97cc800bc9a1cd732d0d5017a"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"4733b98d6adccb68093c387b9b89f4a81cf80c0c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"delete_request_query \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027share_group_id\u0027: parameter_types.single_param({"},{"line_number":24,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":25,"context_line":"        }),"},{"line_number":26,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":2,"id":"ebfa2ad3_5523d0cb","line":23,"in_reply_to":"ef2b1f8a_6da01087","updated":"2026-10-22 09:48:08.000000000","message":"Please read lines 1475 - 1488 of the `manila/api/v2/shares.py`. It clearly states there what query parameter is expected to be provided by the user when the share being deleted is in a share group.\n\nAlso, if you check the unit test cases that were written for the delete method, you will find cases testing the `share_group_id` query param.","commit_id":"d8920824cdf78ff97cc800bc9a1cd732d0d5017a"},{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"b5cf8928a393609005a58cd0bf1eb84d89cc6e97","unresolved":true,"context_lines":[{"line_number":316,"context_line":"        }),"},{"line_number":317,"context_line":"    },"},{"line_number":318,"context_line":"    \u0027required\u0027: [],"},{"line_number":319,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":320,"context_line":"}"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"delete_response_body \u003d {\u0027type\u0027: \u0027null\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"0cbdf9a4_5e784129","line":319,"updated":"2026-10-25 00:37:10.000000000","message":"This is what fails the voting tempest jobs. In manila-tempest-plugin-dummy-no-dhss, test_delete_locked_resource (manila_tempest_tests/tests/api/test_resource_locks.py:274) deletes a locked share with params\u003d{\u0027force\u0027: True}, i.e. DELETE /v2/shares/\u003cid\u003e?force\u003dTrue, and expects a 403. The log shows the two deletes without parameters get the expected 403 from the lock, but this one gets a 400: \"Additional properties are not allowed (\u0027force\u0027 was unexpected)\". delete ignores unknown query parameters today, so the schema now rejects a request that used to work. I reproduced it locally by calling the controller with ?force\u003dTrue: on this patchset it raises that ValidationError and never reaches share_api.delete, while on master it returns 202. Patchset 2 had additionalProperties: True and passed. To keep existing requests working, this should stay True.","commit_id":"550b6af1bc0b04949e39a10717ee837e3ccae4df"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"2f4ff227038034e6c3dd94d6af296c4127f85289","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        }),"},{"line_number":317,"context_line":"    },"},{"line_number":318,"context_line":"    \u0027required\u0027: [],"},{"line_number":319,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":320,"context_line":"}"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"delete_response_body \u003d {\u0027type\u0027: \u0027null\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"86c15933_223122d6","line":319,"in_reply_to":"0cbdf9a4_5e784129","updated":"2026-10-25 20:46:03.000000000","message":"Acknowledged","commit_id":"550b6af1bc0b04949e39a10717ee837e3ccae4df"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"b5cf8928a393609005a58cd0bf1eb84d89cc6e97","unresolved":true,"context_lines":[{"line_number":2137,"context_line":"                          req,"},{"line_number":2138,"context_line":"                          1)"},{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"    def test_share_delete_in_share_group_with_additional_property(self):"},{"line_number":2141,"context_line":"        fake_share \u003d stubs.stub_share(\u0027fake_share\u0027,"},{"line_number":2142,"context_line":"                                      share_group_id\u003d\u0027fake_group_id\u0027)"},{"line_number":2143,"context_line":"        self.mock_object(share_api.API, \u0027get\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"de52bf8f_7c6cf3e2","line":2140,"updated":"2026-10-25 00:37:10.000000000","message":"This asserts that an unknown query parameter is rejected, which is the behavior change above. With additionalProperties: True, it could instead check that an unknown parameter is still accepted. Also, patchset 5 removed test_share_delete_in_share_group_multiple_ids, but the schema still uses single_param for share_group_id, so that test still seems worth keeping.","commit_id":"550b6af1bc0b04949e39a10717ee837e3ccae4df"},{"author":{"_account_id":38945,"name":"Comfort Oyewole","display_name":"Comfort Oyewole","email":"Coyewole7@gmail.com","username":"coyewole","status":"Outreachy Intern"},"change_message_id":"2f4ff227038034e6c3dd94d6af296c4127f85289","unresolved":false,"context_lines":[{"line_number":2137,"context_line":"                          req,"},{"line_number":2138,"context_line":"                          1)"},{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"    def test_share_delete_in_share_group_with_additional_property(self):"},{"line_number":2141,"context_line":"        fake_share \u003d stubs.stub_share(\u0027fake_share\u0027,"},{"line_number":2142,"context_line":"                                      share_group_id\u003d\u0027fake_group_id\u0027)"},{"line_number":2143,"context_line":"        self.mock_object(share_api.API, \u0027get\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"a734277c_2f8e7db9","line":2140,"in_reply_to":"de52bf8f_7c6cf3e2","updated":"2026-10-25 20:46:03.000000000","message":"Acknowledged","commit_id":"550b6af1bc0b04949e39a10717ee837e3ccae4df"}]}
