)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"199241ac4b70208fe9bcd9b358d294cdbcafcfff","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add JSON schema validation for share network delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a response body schema for the share network delete API and apply it using the response_body_schema decorator. Since the API doesn\u0027t take a request body and returns an empty 202 response, only the response schema is needed. The existing checks for shares, share groups and subnets are unchanged."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If328f3a327c797820de0d7242040a2c7c213bdfa"},{"line_number":12,"context_line":"Signed-off-by: Namrata Thakur \u003ctnamrata137@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"eb91d268_6e379a2e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":299},"updated":"2026-10-21 19:45:05.000000000","message":"please check the guidance for commit messages. they should not go over 70 characters: https://docs.openstack.org/project-team-guide/open-development.html#reviews-guidelines","commit_id":"084e4dd3c9a8931443565dd537ff4a685f062c3f"},{"author":{"_account_id":39526,"name":"Namrata Thakur","display_name":"Namrata","email":"tnamrata137@gmail.com","username":"Namrata","status":"Interested in the JSON Schema Validation project for Manila REST APIs."},"change_message_id":"27d066810f92911c67d124460df8fd20fb388ca7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add JSON schema validation for share network delete"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a response body schema for the share network delete API and apply it using the response_body_schema decorator. Since the API doesn\u0027t take a request body and returns an empty 202 response, only the response schema is needed. The existing checks for shares, share groups and subnets are unchanged."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If328f3a327c797820de0d7242040a2c7c213bdfa"},{"line_number":12,"context_line":"Signed-off-by: Namrata Thakur \u003ctnamrata137@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"36b56286_71e293e4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":299},"in_reply_to":"eb91d268_6e379a2e","updated":"2026-10-22 03:07:12.000000000","message":"Done","commit_id":"084e4dd3c9a8931443565dd537ff4a685f062c3f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"199241ac4b70208fe9bcd9b358d294cdbcafcfff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"434e8b37_fa59a99c","updated":"2026-10-21 19:45:05.000000000","message":"Looks good for the most part, please check the comment regarding the commit message","commit_id":"084e4dd3c9a8931443565dd537ff4a685f062c3f"},{"author":{"_account_id":39526,"name":"Namrata Thakur","display_name":"Namrata","email":"tnamrata137@gmail.com","username":"Namrata","status":"Interested in the JSON Schema Validation project for Manila REST APIs."},"change_message_id":"27d066810f92911c67d124460df8fd20fb388ca7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de8f2886_71d9d245","updated":"2026-10-22 03:07:12.000000000","message":"Fixed the commit message (title under 50 characters, lines wrapped at 70). Thanks!","commit_id":"8351a198943961a89a51ad9a78c268835786a05c"},{"author":{"_account_id":39526,"name":"Namrata Thakur","display_name":"Namrata","email":"tnamrata137@gmail.com","username":"Namrata","status":"Interested in the JSON Schema Validation project for Manila REST APIs."},"change_message_id":"15c45748f26c3b6177c7353d19c22a1b3382ac22","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7d9ff440_d59ec406","updated":"2026-10-22 03:23:11.000000000","message":"Hi Carlos, thanks for the review and for the guide link! I’ve fixed the commit message on this change (title under 50 characters, lines wrapped at 70). Two questions from the doc : \n1. shares.create_metadata (1011055) and shares.update_all_metadata (1011525) reject unknown top-level keys in the request body, which is slightly stricter than before. Should those two carry an APIImpact flag, or is that expected for the schema work and not needed? This change only adds a response schema, so I don’t think it needs one.\n2. Is there a blueprint or bug I should reference (Implements-blueprint) for the JSON-schema effort, or should I leave that out?","commit_id":"8351a198943961a89a51ad9a78c268835786a05c"}]}