)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d16c30b3ce5e7ddf35ddf13e0f9b635d27e909c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4432700_2d0b9b84","updated":"2026-10-21 19:22:59.000000000","message":"Thank you for working on this change. Looks good for the most part, just have a small question inline.","commit_id":"2a5f3a002209395b3d157bd2fb1f4ebc425becb5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a65003480d3335626f99fc2d2512299b23bc7e9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e4e66573_f2dd2bca","updated":"2026-10-21 19:20:00.000000000","message":"recheck\nMaybe a CI glitch","commit_id":"2a5f3a002209395b3d157bd2fb1f4ebc425becb5"},{"author":{"_account_id":39505,"name":"Ragini Sharma","display_name":"Ragini","email":"raginisharma.r07@gmail.com","username":"Ragini"},"change_message_id":"13be55a7a67a395c8ce094ee5b91c6a15affd947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"48839abe_a214dffb","updated":"2026-11-12 07:44:19.000000000","message":"Hello @gouthampravi@gmail.com @ces.eduardo98@gmail.com, I have resolved the comments, It would be really helpful, if you do the final review:)","commit_id":"f5a61be90fa93a4f5883f05cf1155a379409a163"}],"manila/tests/api/v2/test_share_snapshots.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d16c30b3ce5e7ddf35ddf13e0f9b635d27e909c5","unresolved":true,"context_lines":[{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":786,"context_line":"                          self.controller.deny_access, req, snapshot[\u0027id\u0027],"},{"line_number":787,"context_line":"                          body\u003dbody)"},{"line_number":788,"context_line":"        get.assert_called_with(utils.IsAMatcher(context.RequestContext),"},{"line_number":789,"context_line":"                               share[\u0027id\u0027])"},{"line_number":790,"context_line":"        get_snapshot.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"7eb8a2f3_54dafe36","line":787,"range":{"start_line":787,"start_character":26,"end_line":787,"end_character":35},"updated":"2026-10-21 19:22:59.000000000","message":"what motivated the kwargs modification in all modified places? Not sure it\u0027s part of the new changes. If not, we should not make changes like this to upset the git history.","commit_id":"2a5f3a002209395b3d157bd2fb1f4ebc425becb5"},{"author":{"_account_id":39505,"name":"Ragini Sharma","display_name":"Ragini","email":"raginisharma.r07@gmail.com","username":"Ragini"},"change_message_id":"f1c07b6e7960bfaacae6cde5204afd5c231deced","unresolved":false,"context_lines":[{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":786,"context_line":"                          self.controller.deny_access, req, snapshot[\u0027id\u0027],"},{"line_number":787,"context_line":"                          body\u003dbody)"},{"line_number":788,"context_line":"        get.assert_called_with(utils.IsAMatcher(context.RequestContext),"},{"line_number":789,"context_line":"                               share[\u0027id\u0027])"},{"line_number":790,"context_line":"        get_snapshot.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"f60e4493_305a347f","line":787,"range":{"start_line":787,"start_character":26,"end_line":787,"end_character":35},"in_reply_to":"7eb8a2f3_54dafe36","updated":"2026-10-24 19:27:48.000000000","message":"Hey i added body\u003dbody, because @validation.request_body_schema decorator reads request body from kwargs[\u0027body\u0027], so only body gave keyError:\u0027body\u0027, and the api behaviour is unchanged because requests already pass body as a keyword.\n\n\nso body\u003dbody is required , as without that we would face keyError:\u0027body\u0027","commit_id":"2a5f3a002209395b3d157bd2fb1f4ebc425becb5"},{"author":{"_account_id":39505,"name":"Ragini Sharma","display_name":"Ragini","email":"raginisharma.r07@gmail.com","username":"Ragini"},"change_message_id":"04e94683c46b1e58179a947ee6ed4fbcefb21e19","unresolved":false,"context_lines":[{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":786,"context_line":"                          self.controller.deny_access, req, snapshot[\u0027id\u0027],"},{"line_number":787,"context_line":"                          body\u003dbody)"},{"line_number":788,"context_line":"        get.assert_called_with(utils.IsAMatcher(context.RequestContext),"},{"line_number":789,"context_line":"                               share[\u0027id\u0027])"},{"line_number":790,"context_line":"        get_snapshot.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"f4b860da_73f1e4d9","line":787,"range":{"start_line":787,"start_character":26,"end_line":787,"end_character":35},"in_reply_to":"f60e4493_305a347f","updated":"2026-11-12 07:45:12.000000000","message":"done","commit_id":"2a5f3a002209395b3d157bd2fb1f4ebc425becb5"}]}
