)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18df57fd5c345e581e230daa3286c7e11c0c05e8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds request and response body schema validation for the"},{"line_number":10,"context_line":"shares.manage() endpoint"},{"line_number":11,"context_line":"While writing tests for invalid request bodies, the"},{"line_number":12,"context_line":"tests failed because the request body was passed"},{"line_number":13,"context_line":"positionally instead of as a keyword argument so I"},{"line_number":14,"context_line":"updated the test calls to pass the body as a keyword argument."},{"line_number":15,"context_line":"Also to verify the response schema validation"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic341bb026b56b6e8757b28f1be1bc68fe81c210f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8f02d902_c3c3efa5","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":62},"updated":"2026-10-21 19:59:03.000000000","message":"I appreciate the details, just would like for it to not be phrased in the first person :)","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"6298d30fa81d807daa41b99f51de19b4b58398ea","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds request and response body schema validation for the"},{"line_number":10,"context_line":"shares.manage() endpoint"},{"line_number":11,"context_line":"While writing tests for invalid request bodies, the"},{"line_number":12,"context_line":"tests failed because the request body was passed"},{"line_number":13,"context_line":"positionally instead of as a keyword argument so I"},{"line_number":14,"context_line":"updated the test calls to pass the body as a keyword argument."},{"line_number":15,"context_line":"Also to verify the response schema validation"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic341bb026b56b6e8757b28f1be1bc68fe81c210f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"247db1c2_2c7e77e5","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":62},"in_reply_to":"8f02d902_c3c3efa5","updated":"2026-10-22 17:26:43.000000000","message":"Got that(:","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18df57fd5c345e581e230daa3286c7e11c0c05e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed7c8f7f_696be657","updated":"2026-10-21 19:59:03.000000000","message":"Thank you for working on this change, Olamide. Please take a look a the comments inline","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"22beb71e7e67ebb74b8fb9f71bd760109d0ee59b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"051892bb_5537b83a","updated":"2026-11-05 14:52:08.000000000","message":"Now that I have my schemas implemented, I’ll be checking to see if my endpoint has any manual validations and if so, I’ll cross check to make sure my schema covers the existing legacy manual validation then I\u0027ll remove it as it would become redundant\n\nI can’t yet remove shared legacy validation helper functions because other endpoints most likely depend on it…this would be a last patch change and a new patch entirely after confirming all endpoints making use of the shared legacy validation helper function have been Schema validated.\n\nThe patch would most likely have a commit of “remove shared legacy validation helper functions as it had become redundant because all endpoints depending on it have been validated by a schema”\n\nThe above is my thought process.","commit_id":"67fb1cb5a8c5ee13eba307261cb76fef94b20942"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"90e6a74bb9d6bdcfc4192854be67ade07ea72357","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a93e32dd_39561855","in_reply_to":"051892bb_5537b83a","updated":"2026-11-06 11:49:29.000000000","message":"Done","commit_id":"67fb1cb5a8c5ee13eba307261cb76fef94b20942"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"2ed1b4972054fd23aae40d751e6123b450770c34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3f382e6d_6fb1d734","updated":"2026-11-06 16:37:03.000000000","message":"recheck","commit_id":"13edb04e1fbd84e74dba5527364604cf1b6551b9"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"e4edf34e39e97a985dbe8adffb0342131894ffe4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9de80979_831bdb57","updated":"2026-11-10 06:56:34.000000000","message":"recheck manila-tempest-plugin-dummy-no-dhss-old-rbac","commit_id":"06d866a4c7ae591f214bceda9a7f8e578ba3073f"}],"manila/api/schemas/shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18df57fd5c345e581e230daa3286c7e11c0c05e8","unresolved":true,"context_lines":[{"line_number":291,"context_line":"                \u0027is_public\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":292,"context_line":"                \u0027driver_options\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":293,"context_line":"                \u0027share_server_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":294,"context_line":"                \u0027mount_point_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":295,"context_line":"            },"},{"line_number":296,"context_line":"            \u0027required\u0027: [\u0027export_path\u0027, \u0027service_host\u0027, \u0027protocol\u0027],"},{"line_number":297,"context_line":"            \u0027additionalProperties\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a754a1ac_ae38630a","line":294,"range":{"start_line":294,"start_character":0,"end_line":294,"end_character":65},"updated":"2026-10-21 19:59:03.000000000","message":"mount point name is microversioned, so please only add it in the correct microversion. As this is only for 2.7, this and other parameters must be dropped. For more accuracy, please check the \"New in version \u003c\u003e\" from the API ref","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18df57fd5c345e581e230daa3286c7e11c0c05e8","unresolved":true,"context_lines":[{"line_number":281,"context_line":"                        },"},{"line_number":282,"context_line":"                    ],"},{"line_number":283,"context_line":"                },"},{"line_number":284,"context_line":"                \u0027service_host\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":285,"context_line":"                \u0027protocol\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":286,"context_line":"                \u0027share_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":287,"context_line":"                \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":288,"context_line":"                \u0027description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":289,"context_line":"                \u0027display_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":290,"context_line":"                \u0027display_description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":291,"context_line":"                \u0027is_public\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":292,"context_line":"                \u0027driver_options\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":293,"context_line":"                \u0027share_server_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":294,"context_line":"                \u0027mount_point_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":295,"context_line":"            },"},{"line_number":296,"context_line":"            \u0027required\u0027: [\u0027export_path\u0027, \u0027service_host\u0027, \u0027protocol\u0027],"},{"line_number":297,"context_line":"            \u0027additionalProperties\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1e961d2e_3006872f","line":294,"range":{"start_line":284,"start_character":15,"end_line":294,"end_character":65},"updated":"2026-10-21 19:59:03.000000000","message":"should these be also between shares\u0027s properties? alongside export_path?","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"6298d30fa81d807daa41b99f51de19b4b58398ea","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                        },"},{"line_number":282,"context_line":"                    ],"},{"line_number":283,"context_line":"                },"},{"line_number":284,"context_line":"                \u0027service_host\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":285,"context_line":"                \u0027protocol\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":286,"context_line":"                \u0027share_type\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":287,"context_line":"                \u0027name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":288,"context_line":"                \u0027description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":289,"context_line":"                \u0027display_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":290,"context_line":"                \u0027display_description\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":291,"context_line":"                \u0027is_public\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":292,"context_line":"                \u0027driver_options\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":293,"context_line":"                \u0027share_server_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":294,"context_line":"                \u0027mount_point_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":295,"context_line":"            },"},{"line_number":296,"context_line":"            \u0027required\u0027: [\u0027export_path\u0027, \u0027service_host\u0027, \u0027protocol\u0027],"},{"line_number":297,"context_line":"            \u0027additionalProperties\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fe6be4c_44d2534e","line":294,"range":{"start_line":284,"start_character":15,"end_line":294,"end_character":65},"in_reply_to":"1e961d2e_3006872f","updated":"2026-10-22 17:26:43.000000000","message":"Hey Carlos, thanks for taking out time to review my work. \nSo yes, I believe they should be between the shares\u0027s properties, including the export_path since they\u0027re all properties of the share object in the request body.\nThe example from the api doc also shows that these are the fields the share object can contain.","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"6298d30fa81d807daa41b99f51de19b4b58398ea","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                \u0027is_public\u0027: {\u0027type\u0027: \u0027boolean\u0027},"},{"line_number":292,"context_line":"                \u0027driver_options\u0027: {\u0027type\u0027: \u0027object\u0027},"},{"line_number":293,"context_line":"                \u0027share_server_id\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":294,"context_line":"                \u0027mount_point_name\u0027: {\u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]},"},{"line_number":295,"context_line":"            },"},{"line_number":296,"context_line":"            \u0027required\u0027: [\u0027export_path\u0027, \u0027service_host\u0027, \u0027protocol\u0027],"},{"line_number":297,"context_line":"            \u0027additionalProperties\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0ddd702d_b82f094d","line":294,"range":{"start_line":294,"start_character":0,"end_line":294,"end_character":65},"in_reply_to":"a754a1ac_ae38630a","updated":"2026-10-22 17:26:43.000000000","message":"Okay I got that. Would implement as instructed","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18df57fd5c345e581e230daa3286c7e11c0c05e8","unresolved":true,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"revert_response_body \u003d {\u0027type\u0027: \u0027null\u0027}"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"manage_response_body \u003d {"},{"line_number":350,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":351,"context_line":"    \u0027properties\u0027: {"},{"line_number":352,"context_line":"        \u0027share\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3cd28bbb_8b2629b5","line":349,"updated":"2026-10-21 19:59:03.000000000","message":"this should be almost the same as https://review.opendev.org/c/openstack/manila/+/974649/12/manila/api/schemas/shares.py, as both return a \"newly\" created share","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"b161af241ad67d60f6d69fcf7ec5ef66567aac8e","unresolved":true,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"revert_response_body \u003d {\u0027type\u0027: \u0027null\u0027}"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"manage_response_body \u003d {"},{"line_number":350,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":351,"context_line":"    \u0027properties\u0027: {"},{"line_number":352,"context_line":"        \u0027share\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"04aba7d7_e0b75069","line":349,"in_reply_to":"0ca373a1_d87546ed","updated":"2026-11-09 21:32:31.000000000","message":"haha, okay I see...So you\u0027d want my schema to reference this microversion, then make the api-ref fix a different patch?\n\nAlso, please see the second issue concerning export_location","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"6298d30fa81d807daa41b99f51de19b4b58398ea","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"revert_response_body \u003d {\u0027type\u0027: \u0027null\u0027}"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"manage_response_body \u003d {"},{"line_number":350,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":351,"context_line":"    \u0027properties\u0027: {"},{"line_number":352,"context_line":"        \u0027share\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a58e7a8_4c3b1e08","line":349,"in_reply_to":"3cd28bbb_8b2629b5","updated":"2026-10-22 17:26:43.000000000","message":"Thanks for the reference, done as instructed.","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"a903434fd86f233a4933f941365e19fe40171818","unresolved":true,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"revert_response_body \u003d {\u0027type\u0027: \u0027null\u0027}"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"manage_response_body \u003d {"},{"line_number":350,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":351,"context_line":"    \u0027properties\u0027: {"},{"line_number":352,"context_line":"        \u0027share\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"dce9f1e2_e23dcb3f","line":349,"in_reply_to":"5a58e7a8_4c3b1e08","updated":"2026-11-09 21:00:58.000000000","message":"Hello @ces.eduardo98@gmail.com been reviewing my patches from the beginning and I noticed something.\n\nIn shares.create(the link you sent me), I noticed encryption_key_ref is introduced in version 2.90, but in the shares.manage API doc, it doesn\u0027t state it was introduced in a new version, and that confused me at first, making me include it in my base properties.\n\nBut going through the implementation again, I see the viewbuilder only exposes encryption_key_ref at v2.90, and I guess it only makes sense for my schema to do the same, right? Then I update the api doc accordingly.\n\n\nThe same goes for export_location and export_locations,it is required until v2.8, but the schema you shared with me for shares.create doesn\u0027t reference this, and also it\u0027s not stated in the api doc for shares.manage, I was thinking of updating that as well and updating my schema to show this","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c5c058c092458a5f5575ae54033c5a6e1e5daea0","unresolved":true,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"revert_response_body \u003d {\u0027type\u0027: \u0027null\u0027}"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"manage_response_body \u003d {"},{"line_number":350,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":351,"context_line":"    \u0027properties\u0027: {"},{"line_number":352,"context_line":"        \u0027share\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"0ca373a1_d87546ed","line":349,"in_reply_to":"dce9f1e2_e23dcb3f","updated":"2026-11-09 21:23:29.000000000","message":"Hey, Ola! Thank you for investigating this. So there is a small difference: in share create, encryption key ref (containing the minimum version) only shows up in the requests, not the response. That happens because we did not add the min version to the response [1]. It is a pattern, yes, so it would be nice if we can fix this in a different patch and make it similar. We\u0027ve not been so consistent in the responses apparently :)\n\n[1] https://github.com/openstack/manila/blob/master/api-ref/source/parameters.yaml#L1475","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18df57fd5c345e581e230daa3286c7e11c0c05e8","unresolved":true,"context_lines":[{"line_number":4015,"context_line":"        body \u003d get_fake_manage_body()"},{"line_number":4016,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":4017,"context_line":"            \u0027/v2/shares/manage\u0027, use_admin_context\u003dTrue, version\u003d\u00272.49\u0027)"},{"line_number":4018,"context_line":"        mock_manage \u003d self.mock_object(self.controller, \u0027_manage\u0027,)"},{"line_number":4019,"context_line":"        mock_manage.return_value \u003d {"},{"line_number":4020,"context_line":"            \u0027share\u0027: {"},{"line_number":4021,"context_line":"                \u0027id\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"cb9fdda3_d4b7fee5","line":4018,"updated":"2026-10-21 19:59:03.000000000","message":"not sure we should be mocking the _manage - this test targets it specifically.","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"6298d30fa81d807daa41b99f51de19b4b58398ea","unresolved":false,"context_lines":[{"line_number":4015,"context_line":"        body \u003d get_fake_manage_body()"},{"line_number":4016,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":4017,"context_line":"            \u0027/v2/shares/manage\u0027, use_admin_context\u003dTrue, version\u003d\u00272.49\u0027)"},{"line_number":4018,"context_line":"        mock_manage \u003d self.mock_object(self.controller, \u0027_manage\u0027,)"},{"line_number":4019,"context_line":"        mock_manage.return_value \u003d {"},{"line_number":4020,"context_line":"            \u0027share\u0027: {"},{"line_number":4021,"context_line":"                \u0027id\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fe2ecc3d_4b0c405b","line":4018,"in_reply_to":"cb9fdda3_d4b7fee5","updated":"2026-10-22 17:26:43.000000000","message":"Okay,noted","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"18df57fd5c345e581e230daa3286c7e11c0c05e8","unresolved":true,"context_lines":[{"line_number":4041,"context_line":"            req, body, allow_dhss_true\u003dTrue"},{"line_number":4042,"context_line":"        )"},{"line_number":4043,"context_line":""},{"line_number":4044,"context_line":"    def test_manage_response_body_schema_valid(self):"},{"line_number":4045,"context_line":"        response_body \u003d {"},{"line_number":4046,"context_line":"            \u0027share\u0027: {"},{"line_number":4047,"context_line":"                \u0027id\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b567d4b_4d5a8281","line":4044,"updated":"2026-10-21 19:59:03.000000000","message":"if we introduce new tests, they should be calling the controller method and let it do the validation, instead of calling jsonschema.validate","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"6298d30fa81d807daa41b99f51de19b4b58398ea","unresolved":false,"context_lines":[{"line_number":4041,"context_line":"            req, body, allow_dhss_true\u003dTrue"},{"line_number":4042,"context_line":"        )"},{"line_number":4043,"context_line":""},{"line_number":4044,"context_line":"    def test_manage_response_body_schema_valid(self):"},{"line_number":4045,"context_line":"        response_body \u003d {"},{"line_number":4046,"context_line":"            \u0027share\u0027: {"},{"line_number":4047,"context_line":"                \u0027id\u0027: \u0027fake\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d29603b0_04075f27","line":4044,"in_reply_to":"8b567d4b_4d5a8281","updated":"2026-10-22 17:26:43.000000000","message":"Okay,noted","commit_id":"caa15f881e160b0e7faf6fca9b108daa99792523"}]}
