)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d09850a0aad1bec0e77bbcd23a1e55af5d77296b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3417b646_f7885c4e","updated":"2026-10-21 19:34:57.000000000","message":"Thank you for working on this change. Please take a look at the comments inline","commit_id":"2c1c3f248dc1fb7938ac593b7b89f5acb10e6716"},{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"89fbb7f0c8791e1ad2eae606d1e8251258b2b543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8fe7819b_278a6126","updated":"2026-10-27 00:50:16.000000000","message":"Great work, Faiqa! I tested this patchset against master with different request bodies. Most of it behaves the same as today: names and descriptions over 255 characters were already rejected with 400, and so were non-string names like 5. The schema just gives a clearer error now.\n\nI found two problems, explained in my inline comments:\n1. A request without a \"snapshot\" key would get 400 instead of today\u0027s 422.\n2. A request with no body would crash with a 500, unless this depends on Folasade\u0027s fix (1012052).\n\nSmall note: display_name: 0 works today but would be rejected here. It\u0027s a rare case, but worth knowing.","commit_id":"fa324a4ce3ec38a3aeeb95f8c6d23c4ef8c3709e"}],"manila/api/schemas/share_snapshots.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d09850a0aad1bec0e77bbcd23a1e55af5d77296b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a752367_2f641451","line":292,"updated":"2026-10-21 19:34:57.000000000","message":"update also has a response, please also add it as part of this change","commit_id":"2c1c3f248dc1fb7938ac593b7b89f5acb10e6716"},{"author":{"_account_id":39533,"name":"Faiqa Iqbal","display_name":"Faiqa Iqbal","email":"faiqaiqbalc7@gmail.com","username":"faiqa"},"change_message_id":"0cd47866afde634812a184970846623ef6d7d2e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1c957da6_30a85aba","line":292,"in_reply_to":"7a752367_2f641451","updated":"2026-10-22 14:16:52.000000000","message":"Done. Added the response schema for update, reusing the show response schemas for each microversion range.","commit_id":"2c1c3f248dc1fb7938ac593b7b89f5acb10e6716"},{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"89fbb7f0c8791e1ad2eae606d1e8251258b2b543","unresolved":true,"context_lines":[{"line_number":286,"context_line":"            \u0027additionalProperties\u0027: True,"},{"line_number":287,"context_line":"        },"},{"line_number":288,"context_line":"    },"},{"line_number":289,"context_line":"    \u0027required\u0027: [\u0027snapshot\u0027],"},{"line_number":290,"context_line":"    \u0027additionalProperties\u0027: True,"},{"line_number":291,"context_line":"}"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9c83e39a_3af8921e","line":289,"updated":"2026-10-27 00:50:16.000000000","message":"This line changes the error code users get. Today, if the request has no \"snapshot\" key (for example {}), the API returns 422. With this line, the schema rejects it first and returns 400 instead. I tested both on master and on this patchset. Changing an error code needs a microversion, so I\u0027d suggest removing this line and letting the existing check keep returning 422. The test test_snapshot_update_missing_snapshot_key would then expect a 422 (HTTPUnprocessableEntity).","commit_id":"fa324a4ce3ec38a3aeeb95f8c6d23c4ef8c3709e"}],"manila/api/v2/share_snapshots.py":[{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"89fbb7f0c8791e1ad2eae606d1e8251258b2b543","unresolved":true,"context_lines":[{"line_number":81,"context_line":"            raise exc.HTTPNotFound()"},{"line_number":82,"context_line":"        return webob.Response(status_int\u003dhttp_client.ACCEPTED)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @validation.request_body_schema(schema.update_request_body)"},{"line_number":85,"context_line":"    @validation.response_body_schema(schema.update_response, \"2.0\", \"2.11\")"},{"line_number":86,"context_line":"    @validation.response_body_schema("},{"line_number":87,"context_line":"        schema.update_response_v212, \"2.12\", \"2.16\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"dc6af8be_e5055c42","line":84,"updated":"2026-10-27 00:50:16.000000000","message":"If someone sends this request with no body at all, the decorator now crashes (500). Today it returns 400. Folasade\u0027s change https://review.opendev.org/c/openstack/manila/+/1012052 fixes this, so please add \"Depends-On: (you can this reference for more info) https://review.opendev.org/c/openstack/manila/+/1012052\" to the commit message.","commit_id":"fa324a4ce3ec38a3aeeb95f8c6d23c4ef8c3709e"}],"manila/tests/api/v2/test_share_snapshots.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d09850a0aad1bec0e77bbcd23a1e55af5d77296b","unresolved":true,"context_lines":[{"line_number":514,"context_line":"        body \u003d {\"snapshot\": snp}"},{"line_number":515,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshot/1\u0027, version\u003dversion)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        res_dict \u003d self.controller.update(req, 1, body\u003dbody)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        self.assertEqual(snp[\"display_name\"], res_dict[\u0027snapshot\u0027][\"name\"])"},{"line_number":520,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"96682004_84142e8d","line":517,"range":{"start_line":517,"start_character":50,"end_line":517,"end_character":60},"updated":"2026-10-21 19:34:57.000000000","message":"is the kwarg change necessary to this change? what changed to force it? if not necessary, please roll back. Updating it without actually needing will upset the git history.","commit_id":"2c1c3f248dc1fb7938ac593b7b89f5acb10e6716"},{"author":{"_account_id":39533,"name":"Faiqa Iqbal","display_name":"Faiqa Iqbal","email":"faiqaiqbalc7@gmail.com","username":"faiqa"},"change_message_id":"0cd47866afde634812a184970846623ef6d7d2e0","unresolved":true,"context_lines":[{"line_number":514,"context_line":"        body \u003d {\"snapshot\": snp}"},{"line_number":515,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshot/1\u0027, version\u003dversion)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        res_dict \u003d self.controller.update(req, 1, body\u003dbody)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        self.assertEqual(snp[\"display_name\"], res_dict[\u0027snapshot\u0027][\"name\"])"},{"line_number":520,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a46c95c0_420b1ecd","line":517,"range":{"start_line":517,"start_character":50,"end_line":517,"end_character":60},"in_reply_to":"96682004_84142e8d","updated":"2026-10-22 14:16:52.000000000","message":"The validator reads the body from kwargs[‘body’], so without body\u003dbody these tests fail with KeyError: ‘body’ once the decorator is applied. I only changed the calls that needed it.","commit_id":"2c1c3f248dc1fb7938ac593b7b89f5acb10e6716"},{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"1493bc8a2f95715171889ef2da1d7aa835b73c59","unresolved":true,"context_lines":[{"line_number":514,"context_line":"        body \u003d {\"snapshot\": snp}"},{"line_number":515,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshot/1\u0027, version\u003dversion)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        res_dict \u003d self.controller.update(req, 1, body\u003dbody)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        self.assertEqual(snp[\"display_name\"], res_dict[\u0027snapshot\u0027][\"name\"])"},{"line_number":520,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dbbded8a_be7b21fc","line":517,"range":{"start_line":517,"start_character":50,"end_line":517,"end_character":60},"in_reply_to":"a46c95c0_420b1ecd","updated":"2026-10-27 00:55:37.000000000","message":"I had the same problem on my share transfer create change (1011575). Once the request_body_schema decorator is added, the tests must pass the body as body\u003dbody, otherwise they fail with KeyError: \u0027body\u0027. So I think this change is needed.","commit_id":"2c1c3f248dc1fb7938ac593b7b89f5acb10e6716"}]}
