)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ae6c9ce78226cea2f05e3e54e08cd7326afca466","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ef63e0f_7a7f70df","updated":"2026-11-04 23:15:46.000000000","message":"Hey @falodunfolasade@gmail.com: good job finding this issue, and fixing this up.. I do think a short release note would be appropriate.. \n\nsomething along these lines:\n\n```\n---\nfixes:\n  - |\n    Fixed an issue where listing share snapshots with an older\n    microversion could return ``400 Bad Request`` if a parameter\n    introduced in a newer microversion (e.g. ``with_count``) was\n    supplied with an invalid value. Unsupported parameters are now\n    ignored as intended. Refer to `bug 2171025\n    \u003chttps://bugs.launchpad.net/manila/+bug/2171025\u003e`_ for more\n    details.\n```","commit_id":"c3d032dc463863612c10b2784b0de34578f792a0"},{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"2cd46b12e99f547eb24a26c82a630ebc810c130a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6757cf8_d9c6c3e7","updated":"2026-10-17 11:33:06.000000000","message":"I searched all merged schema files and share_snapshots.py is the only one using copy.copy, so the fix is complete; and I confirmed the new test fails without the fix and passes with it.","commit_id":"c3d032dc463863612c10b2784b0de34578f792a0"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"12d6c268aa7ce63101d9bb48a0d43595046a7968","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6df9422a_a5c7dde3","in_reply_to":"5ef63e0f_7a7f70df","updated":"2026-11-05 07:04:58.000000000","message":"Thanks Gouthamr! I’ve added the release note you suggested, and the Assisted-By trailer.","commit_id":"c3d032dc463863612c10b2784b0de34578f792a0"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"27a10b50aab14170e31b8cc89a4d0a64574b5b7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3bea3c51_4af43367","in_reply_to":"f6757cf8_d9c6c3e7","updated":"2026-10-31 17:32:37.000000000","message":"Thanks for verifying!","commit_id":"c3d032dc463863612c10b2784b0de34578f792a0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d647f57a3545d2b89a1581c1785045e94c5d0d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e13c357_84515d1e","updated":"2026-11-05 11:26:12.000000000","message":"LLMs *love* writing tests, even when they\u0027re not needed 😉","commit_id":"1675e71b730dbd07724b50cb05b022b01406015c"},{"author":{"_account_id":38943,"name":"Ubah Delight Godson Okechukwu","display_name":"delightubah","email":"delight.verse01@gmail.com","username":"delightubah"},"change_message_id":"2eadce39222333a1c3482ee399915fef0dc52e74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"61874a77_3eb8e0b4","updated":"2026-11-17 20:43:54.000000000","message":"Re-checked patchset 3: all copies in the file are now deepcopy, and printing the four index query schemas shows each version adding only its own parameters (name~/description~ at 2.36, metadata at 2.73, with_count at 2.79), while without the fix all four show the full list.","commit_id":"99b8d8401c58cd24c9e4a9d64ae5ccb8502f29d5"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"042baae580e31e2509e7b32b8a67a55e8465c438","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e677a8f_ec4698de","updated":"2026-11-06 13:20:32.000000000","message":"Thanks stephenfin! I’ve pushed the hacking check here: https://review.opendev.org/c/openstack/manila/+/1014516","commit_id":"99b8d8401c58cd24c9e4a9d64ae5ccb8502f29d5"}],"manila/tests/api/v2/test_share_snapshots.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0d647f57a3545d2b89a1581c1785045e94c5d0d8","unresolved":true,"context_lines":[{"line_number":227,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"},{"line_number":228,"context_line":"                          self.controller.show,"},{"line_number":229,"context_line":"                          req, \u0027200\u0027)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_snapshot_query_schema_isolation(self):"},{"line_number":232,"context_line":"        base \u003d snapshot_schemas.index_request_query[\u0027properties\u0027]"},{"line_number":233,"context_line":"        v236 \u003d snapshot_schemas.index_request_query_v236[\u0027properties\u0027]"},{"line_number":234,"context_line":"        v273 \u003d snapshot_schemas.index_request_query_v273[\u0027properties\u0027]"},{"line_number":235,"context_line":"        v279 \u003d snapshot_schemas.index_request_query_v279[\u0027properties\u0027]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Prove the dictionaries are completely separate objects"},{"line_number":238,"context_line":"        self.assertIsNot(base, v236)"},{"line_number":239,"context_line":"        self.assertIsNot(v236, v273)"},{"line_number":240,"context_line":"        self.assertIsNot(v273, v279)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        # Prove the base schema is clean"},{"line_number":243,"context_line":"        self.assertNotIn(\u0027name~\u0027, base)"},{"line_number":244,"context_line":"        self.assertNotIn(\u0027description~\u0027, base)"},{"line_number":245,"context_line":"        self.assertNotIn(\u0027metadata\u0027, base)"},{"line_number":246,"context_line":"        self.assertNotIn(\u0027with_count\u0027, base)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # Prove v2.36 only has its specific additions"},{"line_number":249,"context_line":"        self.assertIn(\u0027name~\u0027, v236)"},{"line_number":250,"context_line":"        self.assertIn(\u0027description~\u0027, v236)"},{"line_number":251,"context_line":"        self.assertNotIn(\u0027metadata\u0027, v236)"},{"line_number":252,"context_line":"        self.assertNotIn(\u0027with_count\u0027, v236)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        # Prove v2.73 only has its specific additions"},{"line_number":255,"context_line":"        self.assertIn(\u0027metadata\u0027, v273)"},{"line_number":256,"context_line":"        self.assertNotIn(\u0027with_count\u0027, v273)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        # Prove v2.79 has the final addition"},{"line_number":259,"context_line":"        self.assertIn(\u0027with_count\u0027, v279)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def test_snapshot_list_with_count_validation_v20(self):"},{"line_number":262,"context_line":"        # with_count is not in the 2.0 schema, so additionalProperties lets it"},{"line_number":263,"context_line":"        # through and the controller drops it"},{"line_number":264,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshots?with_count\u003dbanana\u0027,"},{"line_number":265,"context_line":"                                      version\u003d\u00272.0\u0027)"},{"line_number":266,"context_line":"        self.mock_object(self.controller.share_api, \u0027get_all_snapshots\u0027,"},{"line_number":267,"context_line":"                         mock.Mock(return_value\u003d[]))"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        result \u003d self.controller.index(req)"},{"line_number":270,"context_line":"        self.assertIn(\u0027snapshots\u0027, result)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_snapshot_list_with_count_validation_v279(self):"},{"line_number":273,"context_line":"        # At 2.79+, with_count must be a boolean, so \u0027banana\u0027 raises an error"},{"line_number":274,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshots?with_count\u003dbanana\u0027,"},{"line_number":275,"context_line":"                                      version\u003d\u00272.79\u0027)"},{"line_number":276,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":277,"context_line":"                          self.controller.index, req)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def test_snapshot_list_summary(self):"},{"line_number":280,"context_line":"        self.mock_object(share_api.API, \u0027get_all_snapshots\u0027,"},{"line_number":281,"context_line":"                         stubs.stub_snapshot_get_all_by_project)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d61f96c4_8e0b544d","line":278,"range":{"start_line":230,"start_character":1,"end_line":278,"end_character":1},"updated":"2026-11-05 11:26:12.000000000","message":"I don\u0027t think these are useful, personally. What we\u0027re fixing here is a programmer error. This tests serves to prove that the programmer error is addressed, but doesn\u0027t serve any real purpose going forward because it is extremely unlikely that anyone will ever revert the change and go back to `copy.copy`.\n\nIf you wanted to test something, I would try to write a hacking check (likely AST-based) that prevented us using direct assignment or `copy.copy` to create new variables. That is, the following code should fail:\n\n```\nfoo \u003d {\u0027a\u0027: \u0027thing\u0027}\nbar \u003d foo\n```\n\nbut this should pass:\n\n```\nfoo \u003d {\u0027a\u0027: \u0027thing\u0027}\nbar \u003d copy.deepcopy(foo)\n```\n\nI would do this change separately, as a follow-up. It will likely highlight a few other places where this issue exists, and it would prevent us adding new occurrences of same in the future.","commit_id":"1675e71b730dbd07724b50cb05b022b01406015c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9fc4d5f8cf573b9cc614af483557ba51dba945e0","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"},{"line_number":228,"context_line":"                          self.controller.show,"},{"line_number":229,"context_line":"                          req, \u0027200\u0027)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_snapshot_query_schema_isolation(self):"},{"line_number":232,"context_line":"        base \u003d snapshot_schemas.index_request_query[\u0027properties\u0027]"},{"line_number":233,"context_line":"        v236 \u003d snapshot_schemas.index_request_query_v236[\u0027properties\u0027]"},{"line_number":234,"context_line":"        v273 \u003d snapshot_schemas.index_request_query_v273[\u0027properties\u0027]"},{"line_number":235,"context_line":"        v279 \u003d snapshot_schemas.index_request_query_v279[\u0027properties\u0027]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Prove the dictionaries are completely separate objects"},{"line_number":238,"context_line":"        self.assertIsNot(base, v236)"},{"line_number":239,"context_line":"        self.assertIsNot(v236, v273)"},{"line_number":240,"context_line":"        self.assertIsNot(v273, v279)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        # Prove the base schema is clean"},{"line_number":243,"context_line":"        self.assertNotIn(\u0027name~\u0027, base)"},{"line_number":244,"context_line":"        self.assertNotIn(\u0027description~\u0027, base)"},{"line_number":245,"context_line":"        self.assertNotIn(\u0027metadata\u0027, base)"},{"line_number":246,"context_line":"        self.assertNotIn(\u0027with_count\u0027, base)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # Prove v2.36 only has its specific additions"},{"line_number":249,"context_line":"        self.assertIn(\u0027name~\u0027, v236)"},{"line_number":250,"context_line":"        self.assertIn(\u0027description~\u0027, v236)"},{"line_number":251,"context_line":"        self.assertNotIn(\u0027metadata\u0027, v236)"},{"line_number":252,"context_line":"        self.assertNotIn(\u0027with_count\u0027, v236)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        # Prove v2.73 only has its specific additions"},{"line_number":255,"context_line":"        self.assertIn(\u0027metadata\u0027, v273)"},{"line_number":256,"context_line":"        self.assertNotIn(\u0027with_count\u0027, v273)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        # Prove v2.79 has the final addition"},{"line_number":259,"context_line":"        self.assertIn(\u0027with_count\u0027, v279)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def test_snapshot_list_with_count_validation_v20(self):"},{"line_number":262,"context_line":"        # with_count is not in the 2.0 schema, so additionalProperties lets it"},{"line_number":263,"context_line":"        # through and the controller drops it"},{"line_number":264,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshots?with_count\u003dbanana\u0027,"},{"line_number":265,"context_line":"                                      version\u003d\u00272.0\u0027)"},{"line_number":266,"context_line":"        self.mock_object(self.controller.share_api, \u0027get_all_snapshots\u0027,"},{"line_number":267,"context_line":"                         mock.Mock(return_value\u003d[]))"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        result \u003d self.controller.index(req)"},{"line_number":270,"context_line":"        self.assertIn(\u0027snapshots\u0027, result)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_snapshot_list_with_count_validation_v279(self):"},{"line_number":273,"context_line":"        # At 2.79+, with_count must be a boolean, so \u0027banana\u0027 raises an error"},{"line_number":274,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshots?with_count\u003dbanana\u0027,"},{"line_number":275,"context_line":"                                      version\u003d\u00272.79\u0027)"},{"line_number":276,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":277,"context_line":"                          self.controller.index, req)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def test_snapshot_list_summary(self):"},{"line_number":280,"context_line":"        self.mock_object(share_api.API, \u0027get_all_snapshots\u0027,"},{"line_number":281,"context_line":"                         stubs.stub_snapshot_get_all_by_project)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0daf333e_8442613c","line":278,"range":{"start_line":230,"start_character":1,"end_line":278,"end_character":1},"in_reply_to":"ab68b894_997f43e7","updated":"2026-11-06 09:47:10.000000000","message":"\u003e Should it only check the files in manila/api/schemas, or the whole codebase?\n\nJust this directory, I think. That\u0027s a reasonable approach and [something we do in e.g. openstacksdk](https://github.com/openstack/openstacksdk/blob/b85141f1b943fd4dccf831a62b3aa1da42f0bb5d/openstack/_hacking/checks.py#L53).","commit_id":"1675e71b730dbd07724b50cb05b022b01406015c"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"0de50b69767815a6b25e277675684c34a7db807a","unresolved":true,"context_lines":[{"line_number":227,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"},{"line_number":228,"context_line":"                          self.controller.show,"},{"line_number":229,"context_line":"                          req, \u0027200\u0027)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_snapshot_query_schema_isolation(self):"},{"line_number":232,"context_line":"        base \u003d snapshot_schemas.index_request_query[\u0027properties\u0027]"},{"line_number":233,"context_line":"        v236 \u003d snapshot_schemas.index_request_query_v236[\u0027properties\u0027]"},{"line_number":234,"context_line":"        v273 \u003d snapshot_schemas.index_request_query_v273[\u0027properties\u0027]"},{"line_number":235,"context_line":"        v279 \u003d snapshot_schemas.index_request_query_v279[\u0027properties\u0027]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Prove the dictionaries are completely separate objects"},{"line_number":238,"context_line":"        self.assertIsNot(base, v236)"},{"line_number":239,"context_line":"        self.assertIsNot(v236, v273)"},{"line_number":240,"context_line":"        self.assertIsNot(v273, v279)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        # Prove the base schema is clean"},{"line_number":243,"context_line":"        self.assertNotIn(\u0027name~\u0027, base)"},{"line_number":244,"context_line":"        self.assertNotIn(\u0027description~\u0027, base)"},{"line_number":245,"context_line":"        self.assertNotIn(\u0027metadata\u0027, base)"},{"line_number":246,"context_line":"        self.assertNotIn(\u0027with_count\u0027, base)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # Prove v2.36 only has its specific additions"},{"line_number":249,"context_line":"        self.assertIn(\u0027name~\u0027, v236)"},{"line_number":250,"context_line":"        self.assertIn(\u0027description~\u0027, v236)"},{"line_number":251,"context_line":"        self.assertNotIn(\u0027metadata\u0027, v236)"},{"line_number":252,"context_line":"        self.assertNotIn(\u0027with_count\u0027, v236)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        # Prove v2.73 only has its specific additions"},{"line_number":255,"context_line":"        self.assertIn(\u0027metadata\u0027, v273)"},{"line_number":256,"context_line":"        self.assertNotIn(\u0027with_count\u0027, v273)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        # Prove v2.79 has the final addition"},{"line_number":259,"context_line":"        self.assertIn(\u0027with_count\u0027, v279)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def test_snapshot_list_with_count_validation_v20(self):"},{"line_number":262,"context_line":"        # with_count is not in the 2.0 schema, so additionalProperties lets it"},{"line_number":263,"context_line":"        # through and the controller drops it"},{"line_number":264,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshots?with_count\u003dbanana\u0027,"},{"line_number":265,"context_line":"                                      version\u003d\u00272.0\u0027)"},{"line_number":266,"context_line":"        self.mock_object(self.controller.share_api, \u0027get_all_snapshots\u0027,"},{"line_number":267,"context_line":"                         mock.Mock(return_value\u003d[]))"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        result \u003d self.controller.index(req)"},{"line_number":270,"context_line":"        self.assertIn(\u0027snapshots\u0027, result)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_snapshot_list_with_count_validation_v279(self):"},{"line_number":273,"context_line":"        # At 2.79+, with_count must be a boolean, so \u0027banana\u0027 raises an error"},{"line_number":274,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshots?with_count\u003dbanana\u0027,"},{"line_number":275,"context_line":"                                      version\u003d\u00272.79\u0027)"},{"line_number":276,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":277,"context_line":"                          self.controller.index, req)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def test_snapshot_list_summary(self):"},{"line_number":280,"context_line":"        self.mock_object(share_api.API, \u0027get_all_snapshots\u0027,"},{"line_number":281,"context_line":"                         stubs.stub_snapshot_get_all_by_project)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e79cd14c_2aebac20","line":278,"range":{"start_line":230,"start_character":1,"end_line":278,"end_character":1},"in_reply_to":"d61f96c4_8e0b544d","updated":"2026-11-05 13:07:02.000000000","message":"Thanks Stephenfin, that makes sense. I’ll remove the new tests and keep this patch to just the fix and the release note. I’d like to try the hacking check as a follow-up. I recently reviewed Gouthamr’s M360 check, so I have an idea of how they work. Should it only check the files in manila/api/schemas, or the whole codebase?","commit_id":"1675e71b730dbd07724b50cb05b022b01406015c"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"4cea75c0173e9529fe82e25a35826d9f9b78e27c","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"},{"line_number":228,"context_line":"                          self.controller.show,"},{"line_number":229,"context_line":"                          req, \u0027200\u0027)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_snapshot_query_schema_isolation(self):"},{"line_number":232,"context_line":"        base \u003d snapshot_schemas.index_request_query[\u0027properties\u0027]"},{"line_number":233,"context_line":"        v236 \u003d snapshot_schemas.index_request_query_v236[\u0027properties\u0027]"},{"line_number":234,"context_line":"        v273 \u003d snapshot_schemas.index_request_query_v273[\u0027properties\u0027]"},{"line_number":235,"context_line":"        v279 \u003d snapshot_schemas.index_request_query_v279[\u0027properties\u0027]"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        # Prove the dictionaries are completely separate objects"},{"line_number":238,"context_line":"        self.assertIsNot(base, v236)"},{"line_number":239,"context_line":"        self.assertIsNot(v236, v273)"},{"line_number":240,"context_line":"        self.assertIsNot(v273, v279)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        # Prove the base schema is clean"},{"line_number":243,"context_line":"        self.assertNotIn(\u0027name~\u0027, base)"},{"line_number":244,"context_line":"        self.assertNotIn(\u0027description~\u0027, base)"},{"line_number":245,"context_line":"        self.assertNotIn(\u0027metadata\u0027, base)"},{"line_number":246,"context_line":"        self.assertNotIn(\u0027with_count\u0027, base)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        # Prove v2.36 only has its specific additions"},{"line_number":249,"context_line":"        self.assertIn(\u0027name~\u0027, v236)"},{"line_number":250,"context_line":"        self.assertIn(\u0027description~\u0027, v236)"},{"line_number":251,"context_line":"        self.assertNotIn(\u0027metadata\u0027, v236)"},{"line_number":252,"context_line":"        self.assertNotIn(\u0027with_count\u0027, v236)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        # Prove v2.73 only has its specific additions"},{"line_number":255,"context_line":"        self.assertIn(\u0027metadata\u0027, v273)"},{"line_number":256,"context_line":"        self.assertNotIn(\u0027with_count\u0027, v273)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        # Prove v2.79 has the final addition"},{"line_number":259,"context_line":"        self.assertIn(\u0027with_count\u0027, v279)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    def test_snapshot_list_with_count_validation_v20(self):"},{"line_number":262,"context_line":"        # with_count is not in the 2.0 schema, so additionalProperties lets it"},{"line_number":263,"context_line":"        # through and the controller drops it"},{"line_number":264,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshots?with_count\u003dbanana\u0027,"},{"line_number":265,"context_line":"                                      version\u003d\u00272.0\u0027)"},{"line_number":266,"context_line":"        self.mock_object(self.controller.share_api, \u0027get_all_snapshots\u0027,"},{"line_number":267,"context_line":"                         mock.Mock(return_value\u003d[]))"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        result \u003d self.controller.index(req)"},{"line_number":270,"context_line":"        self.assertIn(\u0027snapshots\u0027, result)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_snapshot_list_with_count_validation_v279(self):"},{"line_number":273,"context_line":"        # At 2.79+, with_count must be a boolean, so \u0027banana\u0027 raises an error"},{"line_number":274,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/snapshots?with_count\u003dbanana\u0027,"},{"line_number":275,"context_line":"                                      version\u003d\u00272.79\u0027)"},{"line_number":276,"context_line":"        self.assertRaises(exception.ValidationError,"},{"line_number":277,"context_line":"                          self.controller.index, req)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def test_snapshot_list_summary(self):"},{"line_number":280,"context_line":"        self.mock_object(share_api.API, \u0027get_all_snapshots\u0027,"},{"line_number":281,"context_line":"                         stubs.stub_snapshot_get_all_by_project)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ab68b894_997f43e7","line":278,"range":{"start_line":230,"start_character":1,"end_line":278,"end_character":1},"in_reply_to":"e79cd14c_2aebac20","updated":"2026-11-06 01:16:13.000000000","message":"Done","commit_id":"1675e71b730dbd07724b50cb05b022b01406015c"}]}
