)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"1f4021736622ce59b9153a3352e4de8624241f00","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4317bc38_b23666aa","updated":"2026-10-17 21:23:31.000000000","message":"Nice work on this patch! The schema fields and unit tests look very solid and cover all ten fields from v2.45 onward.\n\nI left two minor inline comments regarding the access_level enum and the request query schema.","commit_id":"4d0a86703ee790e1e46f54558c377fd1abafc9cd"},{"author":{"_account_id":38967,"name":"Fiyin Peter","display_name":"Fiyin Peter","email":"insitupeter@gmail.com","username":"kitana"},"change_message_id":"7c4c9595063ace43e8e6471a0ca4a6d856959b4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6b5e6d7_5ec9723b","in_reply_to":"4317bc38_b23666aa","updated":"2026-10-19 08:17:21.000000000","message":"Done","commit_id":"4d0a86703ee790e1e46f54558c377fd1abafc9cd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a7eb7b2e8cd497672daf3a84ef118908569cc692","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9aa25620_8cfc6252","updated":"2026-10-21 20:14:51.000000000","message":"Thank you for working on this change. Please take a look at the comments inline","commit_id":"a188ca92922290a621900995efa6338be27f6173"}],"manila/api/schemas/share_accesses.py":[{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"1f4021736622ce59b9153a3352e4de8624241f00","unresolved":true,"context_lines":[{"line_number":18,"context_line":"            \u0027properties\u0027: {"},{"line_number":19,"context_line":"                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":20,"context_line":"                \u0027share_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":21,"context_line":"                \u0027access_level\u0027: {"},{"line_number":22,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":23,"context_line":"                    \u0027enum\u0027: [\u0027rw\u0027, \u0027ro\u0027],"},{"line_number":24,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":1,"id":"40614c59_6cfbd8f6","line":21,"range":{"start_line":21,"start_character":17,"end_line":21,"end_character":29},"updated":"2026-10-17 21:23:31.000000000","message":"Elsewhere in Manila schemas, we use list(constants.ACCESS_LEVELS) rather than hardcoding [\u0027rw\u0027, \u0027ro\u0027]. Using the constant keeps the schema automatically synced if access levels ever change.","commit_id":"4d0a86703ee790e1e46f54558c377fd1abafc9cd"},{"author":{"_account_id":38967,"name":"Fiyin Peter","display_name":"Fiyin Peter","email":"insitupeter@gmail.com","username":"kitana"},"change_message_id":"7c4c9595063ace43e8e6471a0ca4a6d856959b4f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \u0027properties\u0027: {"},{"line_number":19,"context_line":"                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":20,"context_line":"                \u0027share_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":21,"context_line":"                \u0027access_level\u0027: {"},{"line_number":22,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":23,"context_line":"                    \u0027enum\u0027: [\u0027rw\u0027, \u0027ro\u0027],"},{"line_number":24,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":1,"id":"1122c7fd_2ab9e24a","line":21,"range":{"start_line":21,"start_character":17,"end_line":21,"end_character":29},"in_reply_to":"05b102ac_5fa5c269","updated":"2026-10-19 08:17:21.000000000","message":"Done","commit_id":"4d0a86703ee790e1e46f54558c377fd1abafc9cd"},{"author":{"_account_id":38967,"name":"Fiyin Peter","display_name":"Fiyin Peter","email":"insitupeter@gmail.com","username":"kitana"},"change_message_id":"ffe6dd387d1ff6292d3e3f8714699d71d08ba970","unresolved":true,"context_lines":[{"line_number":18,"context_line":"            \u0027properties\u0027: {"},{"line_number":19,"context_line":"                \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":20,"context_line":"                \u0027share_id\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":21,"context_line":"                \u0027access_level\u0027: {"},{"line_number":22,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":23,"context_line":"                    \u0027enum\u0027: [\u0027rw\u0027, \u0027ro\u0027],"},{"line_number":24,"context_line":"                },"}],"source_content_type":"text/x-python","patch_set":1,"id":"05b102ac_5fa5c269","line":21,"range":{"start_line":21,"start_character":17,"end_line":21,"end_character":29},"in_reply_to":"40614c59_6cfbd8f6","updated":"2026-10-18 05:24:48.000000000","message":"Thank you for the review, Folashade! This was an oversight on my part; I\u0027ll be sure to implement that","commit_id":"4d0a86703ee790e1e46f54558c377fd1abafc9cd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a7eb7b2e8cd497672daf3a84ef118908569cc692","unresolved":true,"context_lines":[{"line_number":44,"context_line":"                    \u0027format\u0027: \u0027date-time\u0027,"},{"line_number":45,"context_line":"                },"},{"line_number":46,"context_line":"                \u0027metadata\u0027: {"},{"line_number":47,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":48,"context_line":"                    \u0027additionalProperties\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":49,"context_line":"                },"},{"line_number":50,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":2,"id":"95a99ffd_857eb27c","line":47,"updated":"2026-10-21 20:14:51.000000000","message":"maybe we can be more specific: https://review.opendev.org/c/openstack/manila/+/974649/12/manila/api/schemas/shares.py#293","commit_id":"a188ca92922290a621900995efa6338be27f6173"}],"manila/api/v2/share_accesses.py":[{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"1f4021736622ce59b9153a3352e4de8624241f00","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":46,"context_line":"    @wsgi.Controller.authorize(\u0027get\u0027)"},{"line_number":47,"context_line":"    @validation.response_body_schema(schema.show_response_body)"},{"line_number":48,"context_line":"    def show(self, req, id):"},{"line_number":49,"context_line":"        \"\"\"Return data about the given share access rule.\"\"\""},{"line_number":50,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3d23e8bd_dc27d0ba","line":47,"updated":"2026-10-17 21:23:31.000000000","message":"Looks great! Are you planning to add @validation.request_query_schema(schema.show_request_query) for the request side as well, or is that left for a separate patch?","commit_id":"4d0a86703ee790e1e46f54558c377fd1abafc9cd"},{"author":{"_account_id":38967,"name":"Fiyin Peter","display_name":"Fiyin Peter","email":"insitupeter@gmail.com","username":"kitana"},"change_message_id":"ffe6dd387d1ff6292d3e3f8714699d71d08ba970","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":46,"context_line":"    @wsgi.Controller.authorize(\u0027get\u0027)"},{"line_number":47,"context_line":"    @validation.response_body_schema(schema.show_response_body)"},{"line_number":48,"context_line":"    def show(self, req, id):"},{"line_number":49,"context_line":"        \"\"\"Return data about the given share access rule.\"\"\""},{"line_number":50,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dcc67846_42f3f256","line":47,"in_reply_to":"3d23e8bd_dc27d0ba","updated":"2026-10-18 05:24:48.000000000","message":"Thanks for highlighting this, Folashade. I was worried the patch was a little too verbose as it was. I assumed reviewers might appreciate a single-focus patch. However, this might be just as well. Thank you again!","commit_id":"4d0a86703ee790e1e46f54558c377fd1abafc9cd"},{"author":{"_account_id":38967,"name":"Fiyin Peter","display_name":"Fiyin Peter","email":"insitupeter@gmail.com","username":"kitana"},"change_message_id":"7c4c9595063ace43e8e6471a0ca4a6d856959b4f","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":46,"context_line":"    @wsgi.Controller.authorize(\u0027get\u0027)"},{"line_number":47,"context_line":"    @validation.response_body_schema(schema.show_response_body)"},{"line_number":48,"context_line":"    def show(self, req, id):"},{"line_number":49,"context_line":"        \"\"\"Return data about the given share access rule.\"\"\""},{"line_number":50,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1df6bbcf_5a564b8c","line":47,"in_reply_to":"dcc67846_42f3f256","updated":"2026-10-19 08:17:21.000000000","message":"Done","commit_id":"4d0a86703ee790e1e46f54558c377fd1abafc9cd"}],"manila/tests/api/v2/test_share_accesses.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a7eb7b2e8cd497672daf3a84ef118908569cc692","unresolved":true,"context_lines":[{"line_number":197,"context_line":"            mock.Mock(return_value\u003dself.access))"},{"line_number":198,"context_line":"        req \u003d self._get_show_request()"},{"line_number":199,"context_line":"        req.query_string \u003d \u0027unexpected\u003d%FF\u0027"},{"line_number":200,"context_line":"        req.headers[\u0027X-Openstack-Manila-Api-Version\u0027] \u003d \u00272.45\u0027"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        response \u003d req.get_response(fakes.app())"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a5e87907_f641e18a","line":200,"range":{"start_line":200,"start_character":0,"end_line":200,"end_character":62},"updated":"2026-10-21 20:14:51.000000000","message":"you can do this on the request already","commit_id":"a188ca92922290a621900995efa6338be27f6173"},{"author":{"_account_id":38967,"name":"Fiyin Peter","display_name":"Fiyin Peter","email":"insitupeter@gmail.com","username":"kitana"},"change_message_id":"618483b90b16e6b81dde39498987f03da6aaa897","unresolved":true,"context_lines":[{"line_number":197,"context_line":"            mock.Mock(return_value\u003dself.access))"},{"line_number":198,"context_line":"        req \u003d self._get_show_request()"},{"line_number":199,"context_line":"        req.query_string \u003d \u0027unexpected\u003d%FF\u0027"},{"line_number":200,"context_line":"        req.headers[\u0027X-Openstack-Manila-Api-Version\u0027] \u003d \u00272.45\u0027"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        response \u003d req.get_response(fakes.app())"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0a3f2f85_20016f5c","line":200,"range":{"start_line":200,"start_character":0,"end_line":200,"end_character":62},"in_reply_to":"a5e87907_f641e18a","updated":"2026-11-05 15:38:16.000000000","message":"Thank you for the review, Carlos. I have made the requisite revisions and would be happy for review of the new iteration","commit_id":"a188ca92922290a621900995efa6338be27f6173"}]}
