)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38967,"name":"Fiyin Peter","display_name":"Fiyin Peter","email":"insitupeter@gmail.com","username":"kitana"},"change_message_id":"2953d196dc5fa2c7f35553a834685aad2b65bbca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"020048a1_93770693","updated":"2026-10-18 14:52:28.000000000","message":"Nice work on the patch, Fola.The invalid-access-level test now makes the intended check. I found an empty-body regression.An empty body request return 500(KeyError: \u0027body), compared with 400 before the patch. You might want to add an HTTP test for this case to maintain the 400 response.","commit_id":"60cf0125f891883b7072bf1e374f31cdb8104c65"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"a746c42df15eade669ade1e79ecad86de98c4189","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93c4411b_5146a597","updated":"2026-10-17 01:22:52.000000000","message":"Since 2.88 is experimental, should the inner additionalProperties be False now rather than following the house-style True?","commit_id":"60cf0125f891883b7072bf1e374f31cdb8104c65"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"177d71d4261b3a5b2c6de37e8fd734b1ae1d7c9f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7e1fdf9_b5e8f4c2","in_reply_to":"020048a1_93770693","updated":"2026-10-21 11:48:32.000000000","message":"Thanks for catching this! I reproduced it locally. It turns out that for a PUT with no body and no Content-Type, _process_stack (wsgi.py lines 797–800) never passes the body argument at all. The old code got a TypeError, which ResourceExceptionHandler turned into a 400.\n\nNow, the request_body_schema decorator reads kwargs[\u0027body\u0027] (validation/__init__.py line 104) before the method even runs, raising a KeyError (which becomes a 500). This actually affects any non-action PUT/POST using request_body_schema (action methods are safe since the dispatcher requires a body key).I\u0027ll ask our mentors now how they\u0027d like this handled globally!","commit_id":"60cf0125f891883b7072bf1e374f31cdb8104c65"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"29605ba8ddc4b4bd73293dcf48ad8d5f3e34fc81","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29ffd56e_87872132","in_reply_to":"02c7aca8_0a60e993","updated":"2026-10-23 15:30:56.000000000","message":"I have uploaded a global fix for the decorator bug here: [https://review.opendev.org/c/openstack/manila/+/1012052]. I will add a Depends-On trailer to this patch so it waits for the fix to merge first!","commit_id":"60cf0125f891883b7072bf1e374f31cdb8104c65"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"6e1889a36ef17a4e88db55869bac857b92d5bf2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4562e45_fce77c9d","in_reply_to":"14ccf5bd_fa03d785","updated":"2026-10-22 08:43:34.000000000","message":"Done","commit_id":"60cf0125f891883b7072bf1e374f31cdb8104c65"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"42b15076cd6cac0db172584c41e1f70381afdee2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99b23db1_950cf6ea","in_reply_to":"29ffd56e_87872132","updated":"2026-10-27 11:49:18.000000000","message":"Done","commit_id":"60cf0125f891883b7072bf1e374f31cdb8104c65"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"177d71d4261b3a5b2c6de37e8fd734b1ae1d7c9f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"14ccf5bd_fa03d785","in_reply_to":"93c4411b_5146a597","updated":"2026-10-21 11:48:32.000000000","message":"-","commit_id":"60cf0125f891883b7072bf1e374f31cdb8104c65"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"6e1889a36ef17a4e88db55869bac857b92d5bf2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"02c7aca8_0a60e993","in_reply_to":"f7e1fdf9_b5e8f4c2","updated":"2026-10-22 08:43:34.000000000","message":"Done","commit_id":"60cf0125f891883b7072bf1e374f31cdb8104c65"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"72f9e4659329b96f3f5535cf190b746fe40bbb4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ece35f78_2606806b","updated":"2026-10-25 16:09:49.000000000","message":"Added the response schema for update()","commit_id":"f90fdb430b017be1f1e5451770cc41012af37fd7"}],"manila/tests/api/v2/test_share_accesses.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"1b4bebdeb98bc49e4adf53575ac4fe139e3108cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a51d1b9_21995a4d","line":353,"updated":"2026-10-23 17:51:41.000000000","message":"pep8: F821 undefined name \u0027copy\u0027","commit_id":"2cc6859d9182c444f948778cf2e1d5f8e856e616"}]}
