)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":39274,"name":"Yaron Bar","display_name":"Yaron Bar","email":"yaron.bar@weka.io","username":"yaronbar"},"change_message_id":"e0b24dc9332e43cd4a897bd901f902f7138b4bbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9701f21b_9b9e1be1","updated":"2026-10-19 11:24:27.000000000","message":"run-weka-ci","commit_id":"40ae7e6d313fa18afb459c84282885eb79abb92a"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"ea3c973d81fa5df6bc692e29fdbefd54a8126105","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"55d93025_49aca310","updated":"2026-10-19 18:40:40.000000000","message":"Hey folasade, this is nice work! I just have a few comments to drop and I am also willing to collaborate with you on this, i.e build on top of what you currently have but that\u0027s if it\u0027s okay by you","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"97dd9976c7b72c58d091b3fc001edb16f69a5e03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2a1e42e6_864ec333","updated":"2026-10-19 11:49:58.000000000","message":"Patch set 2: the new test now passes its own mock instead of the helper’s shared default mock.Mock(), which could make it order-dependent and flaky. Patch set 3 corrects the commit message regarding the WSGI dispatcher behavior.","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":39274,"name":"Yaron Bar","display_name":"Yaron Bar","email":"yaron.bar@weka.io","username":"yaronbar"},"change_message_id":"a8560bc6477f6479123c1f9b1446b3e2fcd3fb1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"379a5d0f_a291c838","updated":"2026-10-20 08:55:50.000000000","message":"run-weka-ci","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"7e0bed8804a03cb1d73e02981f6d01ef60be4e5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d5698326_27710f28","in_reply_to":"55d93025_49aca310","updated":"2026-10-19 20:04:20.000000000","message":"Of course, are these questions about a related topic you are working on? DM me let\u0027s collaborate. Take it easy!","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"}],"manila/api/schemas/share_networks.py":[{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"b1094932e567235e3ac2079de04cd9ae63cf7ac5","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        \u0027update_security_service\u0027: {"},{"line_number":22,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":23,"context_line":"            \u0027properties\u0027: {"},{"line_number":24,"context_line":"                \u0027current_service_id\u0027: _service_id,"},{"line_number":25,"context_line":"                \u0027new_service_id\u0027: _service_id,"},{"line_number":26,"context_line":"            },"},{"line_number":27,"context_line":"            \u0027required\u0027: [\u0027current_service_id\u0027, \u0027new_service_id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"106f555b_df756c9e","line":24,"updated":"2026-10-19 19:21:46.000000000","message":"for the properties parameter, the right name would be current_security_service","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"7e0bed8804a03cb1d73e02981f6d01ef60be4e5e","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        \u0027update_security_service\u0027: {"},{"line_number":22,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":23,"context_line":"            \u0027properties\u0027: {"},{"line_number":24,"context_line":"                \u0027current_service_id\u0027: _service_id,"},{"line_number":25,"context_line":"                \u0027new_service_id\u0027: _service_id,"},{"line_number":26,"context_line":"            },"},{"line_number":27,"context_line":"            \u0027required\u0027: [\u0027current_service_id\u0027, \u0027new_service_id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"171c0f34_8d2783cd","line":24,"in_reply_to":"106f555b_df756c9e","updated":"2026-10-19 20:04:20.000000000","message":"Thanks for the review! I kept it as current_service_id because that is the exact key the controller extracts from the request body today (data[\u0027current_service_id\u0027]), and it matches the official API reference (api-ref/source/share-networks.inc). If we change it in the schema, valid requests from existing clients will fail validation. Or did you mean a different name, such as the _service_id helper?","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"0847207dc857a2fe41e39acd260bcf995cb1b37a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        \u0027update_security_service\u0027: {"},{"line_number":22,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":23,"context_line":"            \u0027properties\u0027: {"},{"line_number":24,"context_line":"                \u0027current_service_id\u0027: _service_id,"},{"line_number":25,"context_line":"                \u0027new_service_id\u0027: _service_id,"},{"line_number":26,"context_line":"            },"},{"line_number":27,"context_line":"            \u0027required\u0027: [\u0027current_service_id\u0027, \u0027new_service_id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"e9bec65d_55c8de72","line":24,"in_reply_to":"171c0f34_8d2783cd","updated":"2026-10-22 08:41:26.000000000","message":"Done","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"b1094932e567235e3ac2079de04cd9ae63cf7ac5","unresolved":true,"context_lines":[{"line_number":22,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":23,"context_line":"            \u0027properties\u0027: {"},{"line_number":24,"context_line":"                \u0027current_service_id\u0027: _service_id,"},{"line_number":25,"context_line":"                \u0027new_service_id\u0027: _service_id,"},{"line_number":26,"context_line":"            },"},{"line_number":27,"context_line":"            \u0027required\u0027: [\u0027current_service_id\u0027, \u0027new_service_id\u0027],"},{"line_number":28,"context_line":"            # TODO(folasadef): Set to False in a future microversion"}],"source_content_type":"text/x-python","patch_set":3,"id":"616f139b_a2714d5b","line":25,"updated":"2026-10-19 19:21:46.000000000","message":"for the properties parameter, the right name would be new_security_service","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"7e0bed8804a03cb1d73e02981f6d01ef60be4e5e","unresolved":true,"context_lines":[{"line_number":22,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":23,"context_line":"            \u0027properties\u0027: {"},{"line_number":24,"context_line":"                \u0027current_service_id\u0027: _service_id,"},{"line_number":25,"context_line":"                \u0027new_service_id\u0027: _service_id,"},{"line_number":26,"context_line":"            },"},{"line_number":27,"context_line":"            \u0027required\u0027: [\u0027current_service_id\u0027, \u0027new_service_id\u0027],"},{"line_number":28,"context_line":"            # TODO(folasadef): Set to False in a future microversion"}],"source_content_type":"text/x-python","patch_set":3,"id":"e9d5ab04_5a41229e","line":25,"in_reply_to":"616f139b_a2714d5b","updated":"2026-10-19 20:04:20.000000000","message":"Same as above, the schema property names must exactly match what existing clients are already sending in their request bodies (data[\u0027new_service_id\u0027]) to avoid breaking backwards compatibility.","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"0847207dc857a2fe41e39acd260bcf995cb1b37a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":23,"context_line":"            \u0027properties\u0027: {"},{"line_number":24,"context_line":"                \u0027current_service_id\u0027: _service_id,"},{"line_number":25,"context_line":"                \u0027new_service_id\u0027: _service_id,"},{"line_number":26,"context_line":"            },"},{"line_number":27,"context_line":"            \u0027required\u0027: [\u0027current_service_id\u0027, \u0027new_service_id\u0027],"},{"line_number":28,"context_line":"            # TODO(folasadef): Set to False in a future microversion"}],"source_content_type":"text/x-python","patch_set":3,"id":"25133612_e1b5474c","line":25,"in_reply_to":"e9d5ab04_5a41229e","updated":"2026-10-22 08:41:26.000000000","message":"Done","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"b1094932e567235e3ac2079de04cd9ae63cf7ac5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cede679b_eadc3108","line":35,"updated":"2026-10-19 19:21:46.000000000","message":"Ideally, a response body is required for this endpoint since it returns a status of 200","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"0847207dc857a2fe41e39acd260bcf995cb1b37a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6e588d96_79287220","line":35,"in_reply_to":"8647866c_362f5dd9","updated":"2026-10-22 08:41:26.000000000","message":"Done","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"},{"author":{"_account_id":39535,"name":"Folasade Falodun","display_name":"Folasade Falodun","email":"falodunfolasade@gmail.com","username":"folasadef"},"change_message_id":"7e0bed8804a03cb1d73e02981f6d01ef60be4e5e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8647866c_362f5dd9","line":35,"in_reply_to":"cede679b_eadc3108","updated":"2026-10-19 20:04:20.000000000","message":"Good point! Small note: it\u0027s decorated with @wsgi.response(202), but your point still applies since it returns a body. However, this patch is strictly scoped to request body validation (as tracked in Taiga #55). I\u0027d be happy to tackle the response schemas in a follow-up patch if the maintainers prefer!","commit_id":"a210ddbd18797038154b7ba2098527cb055eb7db"}]}