)]}'
{"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"c8799e199fa69d8027a79fdbf32d32fcbc517dda","unresolved":true,"context_lines":[{"line_number":2388,"context_line":"            search_opts.update({\u0027availability_zone\u0027: \u0027fake_az\u0027})"},{"line_number":2389,"context_line":"        if use_admin_context:"},{"line_number":2390,"context_line":"            search_opts[\u0027host\u0027] \u003d \u0027fake_host\u0027"},{"line_number":2391,"context_line":"        # fake_key should be filtered for non-admin"},{"line_number":2392,"context_line":"        url \u003d \u0027/v2/fake/shares/detail?fake_key\u003dfake_value\u0027"},{"line_number":2393,"context_line":"        for k, v in search_opts.items():"},{"line_number":2394,"context_line":"            url \u003d url + \u0027\u0026\u0027 + k + \u0027\u003d\u0027 + str(v)"}],"source_content_type":"text/x-python","patch_set":3,"id":"43c4410d_b9eea6b2","side":"PARENT","line":2391,"updated":"2026-11-20 06:52:12.000000000","message":"Secondly @gouthampravi@gmail.com @ces.eduardo98@gmail.com I set additionalProperties to False and this had to be removed. Why?\n\nThis checks already that fake_key is filtered out, i.e, ignored. But my schema already does this before it reaches the API.\n\nYou might wonder why not still set the additionalProperties to true?\nThe reasoning behind it being False is that there are versioned query parameters, and allowing additionalProperties would allow sending requests that include a parameter not yet available in a microversion to pass.\n\nAn example is the test I wrote def test_share_list_detail_availability_zone_before_v297. With additionalProperties True, it fails. This is because it is allowed in v2.96 when its available only from v2.97 onwards","commit_id":"c1bdce74db3b496857f7db2838184c7fa417c403"},{"author":{"_account_id":37843,"name":"Olamide Ojo","display_name":"olamidepeterojo","email":"peterojoolamide@gmail.com","username":"olamidepeterojo"},"change_message_id":"c8799e199fa69d8027a79fdbf32d32fcbc517dda","unresolved":true,"context_lines":[{"line_number":2307,"context_line":"            \u0027shares\u0027: ["},{"line_number":2308,"context_line":"                {"},{"line_number":2309,"context_line":"                    \u0027name\u0027: \u0027displayname\u0027,"},{"line_number":2310,"context_line":"                    \u0027id\u0027: FAKE_UUID,"},{"line_number":2311,"context_line":"                    \u0027links\u0027: ["},{"line_number":2312,"context_line":"                        {"},{"line_number":2313,"context_line":"                            \u0027href\u0027: ("}],"source_content_type":"text/x-python","patch_set":3,"id":"1b2b3db8_cfc1dae6","line":2310,"updated":"2026-11-20 06:52:12.000000000","message":"Hello @gouthampravi@gmail.com @ces.eduardo98@gmail.com\n\n@gouthampravi@gmail.com I know you said for request queries we should make them loose and not as strict as request bodies and responses, which I agree with.\n\nI also told you I made some changes to the existing manila tests then you said Manila is strict about changing existing tests especially where there isn’t a case where the test was doing something that should obviously not work which I also agree with. But in this case, these particular changes are made due to my response strictness, like enforcing uuid and date-time which I believe we are meant to be strict about.\n\nMaybe after taking a review, you could let me know your opinions on this?","commit_id":"bda501c29f45addfa5cc423135fccbad2916336c"}]}
