)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8527996f4d8fc1ab1197fd2cc9eba16b6aae0fe0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{create,delete}_snapshot are implemented."},{"line_number":10,"context_line":"create_from snapshot is still missing."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5ebef2ca51ffa945da0a6893999915640b38cada"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_fe140945","line":11,"updated":"2015-03-16 04:07:16.000000000","message":"Can you register a blueprint and reference it here?","commit_id":"44db7156f460c3633493032f05f9e7547f590796"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"50519b0ddfaa0c1fd2f6452287440c486dc288b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{create,delete}_snapshot are implemented."},{"line_number":10,"context_line":"create_from snapshot is still missing."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5ebef2ca51ffa945da0a6893999915640b38cada"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_e867bd4f","line":11,"in_reply_to":"9a80dd14_fe140945","updated":"2015-03-17 01:36:10.000000000","message":"It\u0027s expected to be eligible to fit into K-3 without a BP.","commit_id":"44db7156f460c3633493032f05f9e7547f590796"}],"manila/share/drivers/glusterfs_native.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8527996f4d8fc1ab1197fd2cc9eba16b6aae0fe0","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":436,"context_line":"        \"\"\"Creates a snapshot.\"\"\""},{"line_number":437,"context_line":"        vol \u003d self.db.share_get(context,"},{"line_number":438,"context_line":"                                snapshot[\u0027share_id\u0027])[\u0027export_location\u0027]"},{"line_number":439,"context_line":"        if vol in self.gluster_nosnap_vols_dict:"},{"line_number":440,"context_line":"            opret, operrno \u003d -1, 0"},{"line_number":441,"context_line":"            operrstr \u003d self.gluster_nosnap_vols_dict[vol]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_5ba36742","line":438,"updated":"2015-03-16 04:07:16.000000000","message":"We discussed at one of the IRC meetings whether driver should be directly access the db.  Not sure if you were there.\n\nAlso \u0027export_location\u0027 is no longer a column name in shares table.  It is changed by the following patch:\n\nhttps://review.openstack.org/#/c/159927/12/manila/db/sqlalchemy/models.py","commit_id":"44db7156f460c3633493032f05f9e7547f590796"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"50519b0ddfaa0c1fd2f6452287440c486dc288b9","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":436,"context_line":"        \"\"\"Creates a snapshot.\"\"\""},{"line_number":437,"context_line":"        vol \u003d self.db.share_get(context,"},{"line_number":438,"context_line":"                                snapshot[\u0027share_id\u0027])[\u0027export_location\u0027]"},{"line_number":439,"context_line":"        if vol in self.gluster_nosnap_vols_dict:"},{"line_number":440,"context_line":"            opret, operrno \u003d -1, 0"},{"line_number":441,"context_line":"            operrstr \u003d self.gluster_nosnap_vols_dict[vol]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_e8cb3d48","line":438,"in_reply_to":"9a80dd14_5ba36742","updated":"2015-03-17 01:36:10.000000000","message":"re: db: Discussed with Ben -- fine for the moment, we\u0027ll need to fix it in manager, now just adding a FIXME note.\n\nre: export_location: the patch you refer to takes care of providing a compat shim for export_location: see referred file change, line 179, so we should be fine using it.","commit_id":"44db7156f460c3633493032f05f9e7547f590796"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8527996f4d8fc1ab1197fd2cc9eba16b6aae0fe0","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            if not out:"},{"line_number":454,"context_line":"                raise exception.GlusterfsException("},{"line_number":455,"context_line":"                    \u0027gluster volume info %s: no data received\u0027 %"},{"line_number":456,"context_line":"                    self.volume"},{"line_number":457,"context_line":"                )"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"            outxml \u003d etree.fromstring(out)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_9e04ed15","line":456,"updated":"2015-03-16 04:07:16.000000000","message":"pylint error:\n\nmanila/share/drivers/glusterfs_native.py:456: [E1101, GlusterfsNativeShareDriver.create_snapshot] Instance of \u0027GlusterfsNativeShareDriver\u0027 has no \u0027volume\u0027 member","commit_id":"44db7156f460c3633493032f05f9e7547f590796"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"50519b0ddfaa0c1fd2f6452287440c486dc288b9","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            if not out:"},{"line_number":454,"context_line":"                raise exception.GlusterfsException("},{"line_number":455,"context_line":"                    \u0027gluster volume info %s: no data received\u0027 %"},{"line_number":456,"context_line":"                    self.volume"},{"line_number":457,"context_line":"                )"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"            outxml \u003d etree.fromstring(out)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_08d97122","line":456,"in_reply_to":"9a80dd14_9e04ed15","updated":"2015-03-17 01:36:10.000000000","message":"Done","commit_id":"44db7156f460c3633493032f05f9e7547f590796"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8527996f4d8fc1ab1197fd2cc9eba16b6aae0fe0","unresolved":false,"context_lines":[{"line_number":479,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":480,"context_line":"        \"\"\"Deletes a snapshot.\"\"\""},{"line_number":481,"context_line":"        vol \u003d self.db.share_get(context,"},{"line_number":482,"context_line":"                                snapshot[\u0027share_id\u0027])[\u0027export_location\u0027]"},{"line_number":483,"context_line":"        gluster_mgr \u003d self.gluster_used_vols_dict[vol]"},{"line_number":484,"context_line":"        args \u003d (\u0027--xml\u0027, \u0027snapshot\u0027, \u0027delete\u0027, snapshot[\u0027id\u0027])"},{"line_number":485,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_bb39c3f3","line":482,"updated":"2015-03-16 04:07:16.000000000","message":"Same as above","commit_id":"44db7156f460c3633493032f05f9e7547f590796"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"50519b0ddfaa0c1fd2f6452287440c486dc288b9","unresolved":false,"context_lines":[{"line_number":479,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":480,"context_line":"        \"\"\"Deletes a snapshot.\"\"\""},{"line_number":481,"context_line":"        vol \u003d self.db.share_get(context,"},{"line_number":482,"context_line":"                                snapshot[\u0027share_id\u0027])[\u0027export_location\u0027]"},{"line_number":483,"context_line":"        gluster_mgr \u003d self.gluster_used_vols_dict[vol]"},{"line_number":484,"context_line":"        args \u003d (\u0027--xml\u0027, \u0027snapshot\u0027, \u0027delete\u0027, snapshot[\u0027id\u0027])"},{"line_number":485,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_48028973","line":482,"in_reply_to":"9a80dd14_bb39c3f3","updated":"2015-03-17 01:36:10.000000000","message":"Reply same as above","commit_id":"44db7156f460c3633493032f05f9e7547f590796"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8527996f4d8fc1ab1197fd2cc9eba16b6aae0fe0","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        if not out:"},{"line_number":493,"context_line":"            raise exception.GlusterfsException("},{"line_number":494,"context_line":"                \u0027gluster volume info %s: no data received\u0027 %"},{"line_number":495,"context_line":"                self.volume"},{"line_number":496,"context_line":"            )"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        outxml \u003d etree.fromstring(out)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_be07f116","line":495,"updated":"2015-03-16 04:07:16.000000000","message":"Same","commit_id":"44db7156f460c3633493032f05f9e7547f590796"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"50519b0ddfaa0c1fd2f6452287440c486dc288b9","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        if not out:"},{"line_number":493,"context_line":"            raise exception.GlusterfsException("},{"line_number":494,"context_line":"                \u0027gluster volume info %s: no data received\u0027 %"},{"line_number":495,"context_line":"                self.volume"},{"line_number":496,"context_line":"            )"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        outxml \u003d etree.fromstring(out)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_68074d82","line":495,"in_reply_to":"9a80dd14_be07f116","updated":"2015-03-17 01:36:10.000000000","message":"Done","commit_id":"44db7156f460c3633493032f05f9e7547f590796"}]}