)]}'
{"doc/source/devref/ganesha.rst":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"a74ede5125b8c22b816d29244c7d3c5745737ddf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"      under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Ganesha library"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The Ganesha library provides base classes that can be used by drivers"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_cca0dbf6","line":17,"updated":"2015-03-19 00:21:11.000000000","message":"s/library/Library/  would look better here","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"001e20543abc21052d9273d5606e892e2159dea3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"      under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Ganesha library"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The Ganesha library provides base classes that can be used by drivers"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_c147af4a","line":17,"in_reply_to":"9a80dd14_cca0dbf6","updated":"2015-03-19 12:05:31.000000000","message":"Done","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"243d7469de83907028df3f83bac94a2aa82241d5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Supported Operations"},{"line_number":25,"context_line":"--------------------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Allow NFS Share access"},{"line_number":28,"context_line":"- Deny NFS Share access"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Requirements"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_95ced581","line":27,"updated":"2015-03-19 10:44:30.000000000","message":"RW? RO? IP? Username? Certs?\n\nWould be really useful to provide info about above ^","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"a74ede5125b8c22b816d29244c7d3c5745737ddf","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NFS-Ganesha 2.1 or newer."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"NFS-Ganesha configuration"},{"line_number":36,"context_line":"-------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The library is agnostic of general NFS-Ganesha (in sequel: Ganesha)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_4c930ba3","line":35,"updated":"2015-03-19 00:21:11.000000000","message":"We\u0027re less consistent with caps in these sections.  I would capitalize Configuration.","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"001e20543abc21052d9273d5606e892e2159dea3","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NFS-Ganesha 2.1 or newer."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"NFS-Ganesha configuration"},{"line_number":36,"context_line":"-------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The library is agnostic of general NFS-Ganesha (in sequel: Ganesha)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_6170c3a4","line":35,"in_reply_to":"9a80dd14_4c930ba3","updated":"2015-03-19 12:05:31.000000000","message":"Kept low-case by virtue of taking generic driver doc as reference.","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"a74ede5125b8c22b816d29244c7d3c5745737ddf","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The above paths can be customized though Manila configuration."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Using Ganesha library in drivers"},{"line_number":52,"context_line":"--------------------------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"A driver that wants to use the Ganesha library has to inherit"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_4cda2b79","line":51,"updated":"2015-03-19 00:21:11.000000000","message":"Same issue/question of whether to capitalize library and drivers (don\u0027t cap \u0027in\u0027 ever).","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"001e20543abc21052d9273d5606e892e2159dea3","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The above paths can be customized though Manila configuration."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Using Ganesha library in drivers"},{"line_number":52,"context_line":"--------------------------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"A driver that wants to use the Ganesha library has to inherit"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_816857bb","line":51,"in_reply_to":"9a80dd14_4cda2b79","updated":"2015-03-19 12:05:31.000000000","message":"ditto","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"a74ede5125b8c22b816d29244c7d3c5745737ddf","unresolved":false,"context_lines":[{"line_number":76,"context_line":"(eg.: ``{\"Name\": \"GLUSTER\"}``). Further content of it is"},{"line_number":77,"context_line":"optional and FSAL specific."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Customizing Ganesha exports"},{"line_number":80,"context_line":"---------------------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"As noted, the Ganesha library provides sane general defaults."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_ccd53b44","line":79,"updated":"2015-03-19 00:21:11.000000000","message":"same for Exports","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"86ae3d84ec612a6dd1c782089cc80622b74a9293","unresolved":false,"context_lines":[{"line_number":92,"context_line":"equivalent to arrayless JSON), with two special placeholders"},{"line_number":93,"context_line":"for values: ``@config`` and ``@runtime``.  ``@config`` means a"},{"line_number":94,"context_line":"value that shall be filled from Manila config, and ``@runtime``"},{"line_number":95,"context_line":"means a value that\u0027s filled at runtime with dynamic data."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The library\u0027s defults are stored in"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_001d5762","line":95,"updated":"2015-03-19 00:50:45.000000000","message":"I assume an real JSON example here would be better ?","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"001e20543abc21052d9273d5606e892e2159dea3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"equivalent to arrayless JSON), with two special placeholders"},{"line_number":93,"context_line":"for values: ``@config`` and ``@runtime``.  ``@config`` means a"},{"line_number":94,"context_line":"value that shall be filled from Manila config, and ``@runtime``"},{"line_number":95,"context_line":"means a value that\u0027s filled at runtime with dynamic data."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The library\u0027s defults are stored in"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_a1655be2","line":95,"in_reply_to":"9a80dd14_001d5762","updated":"2015-03-19 12:05:31.000000000","message":"Done","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"a74ede5125b8c22b816d29244c7d3c5745737ddf","unresolved":false,"context_lines":[{"line_number":94,"context_line":"value that shall be filled from Manila config, and ``@runtime``"},{"line_number":95,"context_line":"means a value that\u0027s filled at runtime with dynamic data."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The library\u0027s defults are stored in"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"*manila/share/drivers/ganesha/conf/00-base-export-template.conf*"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_ecc67f9b","line":97,"updated":"2015-03-19 00:21:11.000000000","message":"s/defults/defaults/","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"001e20543abc21052d9273d5606e892e2159dea3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"value that shall be filled from Manila config, and ``@runtime``"},{"line_number":95,"context_line":"means a value that\u0027s filled at runtime with dynamic data."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"The library\u0027s defults are stored in"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"*manila/share/drivers/ganesha/conf/00-base-export-template.conf*"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_61a7e30b","line":97,"in_reply_to":"9a80dd14_ecc67f9b","updated":"2015-03-19 12:05:31.000000000","message":"Done","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"243d7469de83907028df3f83bac94a2aa82241d5","unresolved":false,"context_lines":[{"line_number":114,"context_line":"  works over a flat network, where the tenants share a network."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"The :mod:`manila.share.drivers.ganesha` Module"},{"line_number":117,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":".. automodule:: manila.share.drivers.ganesha"},{"line_number":120,"context_line":"    :noindex:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_15058579","line":117,"updated":"2015-03-19 10:44:30.000000000","message":"Looks like underline is longer than above line. Need to make them consistent.","commit_id":"c3a0a2730408ce4b5ecd744e41a4fa546b93849b"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"59477124c5310ba68b2c9ddf7bc2ec05f32b80c7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The Ganesha Library provides base classes that can be used by drivers"},{"line_number":21,"context_line":"to implement provisioning shares via NFS (NFSv3 and NFSv4), utilizing"},{"line_number":22,"context_line":"the NFS-Ganesha NFS server."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Supported Operations"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_7b6395b1","line":21,"updated":"2015-03-23 11:43:37.000000000","message":"How about, \".... to provision shares ...\"?","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The Ganesha Library provides base classes that can be used by drivers"},{"line_number":21,"context_line":"to implement provisioning shares via NFS (NFSv3 and NFSv4), utilizing"},{"line_number":22,"context_line":"the NFS-Ganesha NFS server."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Supported Operations"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_70f8ffe5","line":21,"in_reply_to":"1a6ced46_7b6395b1","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"59477124c5310ba68b2c9ddf7bc2ec05f32b80c7","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The Ganesha Library provides base classes that can be used by drivers"},{"line_number":21,"context_line":"to implement provisioning shares via NFS (NFSv3 and NFSv4), utilizing"},{"line_number":22,"context_line":"the NFS-Ganesha NFS server."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Supported Operations"},{"line_number":25,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_db71e978","line":22,"updated":"2015-03-23 11:43:37.000000000","message":"The second occurrence of NFS is superfluous. \"... the NFS-Ganesha server.\", will do.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The Ganesha Library provides base classes that can be used by drivers"},{"line_number":21,"context_line":"to implement provisioning shares via NFS (NFSv3 and NFSv4), utilizing"},{"line_number":22,"context_line":"the NFS-Ganesha NFS server."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Supported Operations"},{"line_number":25,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_306607ee","line":22,"in_reply_to":"1a6ced46_db71e978","updated":"2015-04-23 19:03:27.000000000","message":"\"NFS-Ganesha\" is the name of the project, \"NFS server\" is its category.\n\"server\" I think would be a too broad category -- I think it\u0027s fine as is, albeit a little bit weird.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6bbcc15d0f252a12b567382073252776ddac5e09","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Supported Operations"},{"line_number":25,"context_line":"--------------------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Allow NFS Share access"},{"line_number":28,"context_line":"- Deny NFS Share access"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Requirements"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_ee6317db","line":27,"updated":"2015-03-24 05:51:08.000000000","message":"Description ip or user support.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Supported Operations"},{"line_number":25,"context_line":"--------------------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Allow NFS Share access"},{"line_number":28,"context_line":"- Deny NFS Share access"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Requirements"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_8d3b80eb","line":27,"in_reply_to":"1a6ced46_ee6317db","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7e2f23a6cc4ffc5af84e1bdb750793bc47626626","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Requirements"},{"line_number":31,"context_line":"------------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NFS-Ganesha 2.1 or newer."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"NFS-Ganesha configuration"},{"line_number":36,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_3d9aff14","line":33,"updated":"2015-03-22 15:01:04.000000000","message":"Can you add a link to NFS-Ganesha download link?","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Requirements"},{"line_number":31,"context_line":"------------"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NFS-Ganesha 2.1 or newer."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"NFS-Ganesha configuration"},{"line_number":36,"context_line":"-------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_8de8207e","line":33,"in_reply_to":"1a6ced46_3d9aff14","updated":"2015-04-23 19:03:27.000000000","message":"The download link is ambiguous request because there are multiple versions conforming this spec and people might prefer either a git checkout or distro package over a source tarball. I\u0027m at least linking to the project\u0027s homepage then.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7e2f23a6cc4ffc5af84e1bdb750793bc47626626","unresolved":false,"context_lines":[{"line_number":35,"context_line":"NFS-Ganesha configuration"},{"line_number":36,"context_line":"-------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The library is agnostic of general NFS-Ganesha (in sequel: Ganesha)"},{"line_number":39,"context_line":"configuration as much as it\u0027s possible. Ganesha\u0027s concept of storage"},{"line_number":40,"context_line":"backend modules are called FSAL (\"File System Abstraction Layer\")."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_189b91ca","line":38,"updated":"2015-03-22 15:01:04.000000000","message":"What does \"in sequel\" mean here?","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"425aa4148ec4c7f3b61cafa80a54ece569600714","unresolved":false,"context_lines":[{"line_number":35,"context_line":"NFS-Ganesha configuration"},{"line_number":36,"context_line":"-------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The library is agnostic of general NFS-Ganesha (in sequel: Ganesha)"},{"line_number":39,"context_line":"configuration as much as it\u0027s possible. Ganesha\u0027s concept of storage"},{"line_number":40,"context_line":"backend modules are called FSAL (\"File System Abstraction Layer\")."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_f8d94b84","line":38,"in_reply_to":"1a6ced46_189b91ca","updated":"2015-03-23 07:51:26.000000000","message":"Correctly, it should be \"in _the_ sequel\", as I\u0027m using it below -- see further discussion there.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"NFS-Ganesha configuration"},{"line_number":36,"context_line":"-------------------------"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The library is agnostic of general NFS-Ganesha (in sequel: Ganesha)"},{"line_number":39,"context_line":"configuration as much as it\u0027s possible. Ganesha\u0027s concept of storage"},{"line_number":40,"context_line":"backend modules are called FSAL (\"File System Abstraction Layer\")."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_4de8c8e2","line":38,"in_reply_to":"1a6ced46_189b91ca","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a482d496ecb3f60cd4803294de7146cc1b2d1e9f","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The library is agnostic of general NFS-Ganesha (in sequel: Ganesha)"},{"line_number":39,"context_line":"configuration as much as it\u0027s possible. Ganesha\u0027s concept of storage"},{"line_number":40,"context_line":"backend modules are called FSAL (\"File System Abstraction Layer\")."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"We of course demand the enablement of the FSAL the driver code intends"},{"line_number":43,"context_line":"to leverage. Beyond that (with default Manila config) we need the following"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_c2cd875f","line":40,"updated":"2015-03-23 00:20:43.000000000","message":"\"Ganesha\u0027s concept of storage backend modules is called...\"","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The library is agnostic of general NFS-Ganesha (in sequel: Ganesha)"},{"line_number":39,"context_line":"configuration as much as it\u0027s possible. Ganesha\u0027s concept of storage"},{"line_number":40,"context_line":"backend modules are called FSAL (\"File System Abstraction Layer\")."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"We of course demand the enablement of the FSAL the driver code intends"},{"line_number":43,"context_line":"to leverage. Beyond that (with default Manila config) we need the following"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_cdd3b837","line":40,"in_reply_to":"1a6ced46_c2cd875f","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7e2f23a6cc4ffc5af84e1bdb750793bc47626626","unresolved":false,"context_lines":[{"line_number":39,"context_line":"configuration as much as it\u0027s possible. Ganesha\u0027s concept of storage"},{"line_number":40,"context_line":"backend modules are called FSAL (\"File System Abstraction Layer\")."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"We of course demand the enablement of the FSAL the driver code intends"},{"line_number":43,"context_line":"to leverage. Beyond that (with default Manila config) we need the following"},{"line_number":44,"context_line":"line in the ganesha config file (that defaults to /etc/ganesha/ganesha.conf):"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_3d4f5f94","line":42,"updated":"2015-03-22 15:01:04.000000000","message":"Suggest not to use \"we...demand\" in the doc.  How about something like this:\n\nFSAL needs to be enabled for the driver to leverage NFS-Ganesha.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"configuration as much as it\u0027s possible. Ganesha\u0027s concept of storage"},{"line_number":40,"context_line":"backend modules are called FSAL (\"File System Abstraction Layer\")."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"We of course demand the enablement of the FSAL the driver code intends"},{"line_number":43,"context_line":"to leverage. Beyond that (with default Manila config) we need the following"},{"line_number":44,"context_line":"line in the ganesha config file (that defaults to /etc/ganesha/ganesha.conf):"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_6d2b8c31","line":42,"in_reply_to":"1a6ced46_3d4f5f94","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7e2f23a6cc4ffc5af84e1bdb750793bc47626626","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"We of course demand the enablement of the FSAL the driver code intends"},{"line_number":43,"context_line":"to leverage. Beyond that (with default Manila config) we need the following"},{"line_number":44,"context_line":"line in the ganesha config file (that defaults to /etc/ganesha/ganesha.conf):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"``%include /etc/ganesha/export.d/INDEX.conf``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_bd5a6f4e","line":44,"updated":"2015-03-22 15:01:04.000000000","message":"Beyond that (with default Manila config), the following line is needed in the ganesha config file ......","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a482d496ecb3f60cd4803294de7146cc1b2d1e9f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"We of course demand the enablement of the FSAL the driver code intends"},{"line_number":43,"context_line":"to leverage. Beyond that (with default Manila config) we need the following"},{"line_number":44,"context_line":"line in the ganesha config file (that defaults to /etc/ganesha/ganesha.conf):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"``%include /etc/ganesha/export.d/INDEX.conf``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_02d87f1c","line":44,"updated":"2015-03-23 00:20:43.000000000","message":"Ganesha (caps?)","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"We of course demand the enablement of the FSAL the driver code intends"},{"line_number":43,"context_line":"to leverage. Beyond that (with default Manila config) we need the following"},{"line_number":44,"context_line":"line in the ganesha config file (that defaults to /etc/ganesha/ganesha.conf):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"``%include /etc/ganesha/export.d/INDEX.conf``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_af7cff72","line":44,"in_reply_to":"1a6ced46_02d87f1c","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"We of course demand the enablement of the FSAL the driver code intends"},{"line_number":43,"context_line":"to leverage. Beyond that (with default Manila config) we need the following"},{"line_number":44,"context_line":"line in the ganesha config file (that defaults to /etc/ganesha/ganesha.conf):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"``%include /etc/ganesha/export.d/INDEX.conf``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_2fe8ef0f","line":44,"in_reply_to":"1a6ced46_bd5a6f4e","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"59477124c5310ba68b2c9ddf7bc2ec05f32b80c7","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"``%include /etc/ganesha/export.d/INDEX.conf``"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The above paths can be customized though Manila configuration."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Using Ganesha Library in drivers"},{"line_number":52,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_21748bce","line":49,"updated":"2015-03-23 11:43:37.000000000","message":"I thinks it would be nice to be more specific on how they can be customized. So,\nthe \u0027/etc/ganesha/ganesha.conf\u0027 path can be customized using \u0027ganesha_config_path\u0027 option, and \u0027/etc/ganesha/export.d\u0027 path using \u0027ganesha_export_dir\u0027 option.\n\nAlso wondering if it would be useful to mention all the configurable options specific to this library?","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7e2f23a6cc4ffc5af84e1bdb750793bc47626626","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"``%include /etc/ganesha/export.d/INDEX.conf``"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The above paths can be customized though Manila configuration."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Using Ganesha Library in drivers"},{"line_number":52,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_dd800b8e","line":49,"updated":"2015-03-22 15:01:04.000000000","message":"though -\u003e through","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"``%include /etc/ganesha/export.d/INDEX.conf``"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The above paths can be customized though Manila configuration."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Using Ganesha Library in drivers"},{"line_number":52,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_4f6683ee","line":49,"in_reply_to":"1a6ced46_21748bce","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"``%include /etc/ganesha/export.d/INDEX.conf``"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The above paths can be customized though Manila configuration."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Using Ganesha Library in drivers"},{"line_number":52,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_cfa053f7","line":49,"in_reply_to":"1a6ced46_dd800b8e","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7e2f23a6cc4ffc5af84e1bdb750793bc47626626","unresolved":false,"context_lines":[{"line_number":59,"context_line":"``allow_access`` and ``deny_access`` methods to it (when appropriate,"},{"line_number":60,"context_line":"ie. when ``access_proto`` is NFS)."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"In the sequel we explain what has to be implemented by the"},{"line_number":63,"context_line":"``ganesha.GaneshaNASHelper`` subclass (to which we refer as \"helper"},{"line_number":64,"context_line":"class\").."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_3d367f04","line":62,"updated":"2015-03-22 15:01:04.000000000","message":"I assume you mean \"In the following\" by saying \"In the sequel\" here?\n\nSuggest rewording to something like this:\n\nWhat has to be implemented by the ....... is explained in the following.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"425aa4148ec4c7f3b61cafa80a54ece569600714","unresolved":false,"context_lines":[{"line_number":59,"context_line":"``allow_access`` and ``deny_access`` methods to it (when appropriate,"},{"line_number":60,"context_line":"ie. when ``access_proto`` is NFS)."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"In the sequel we explain what has to be implemented by the"},{"line_number":63,"context_line":"``ganesha.GaneshaNASHelper`` subclass (to which we refer as \"helper"},{"line_number":64,"context_line":"class\").."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_b81433f6","line":62,"in_reply_to":"1a6ced46_3d367f04","updated":"2015-03-23 07:51:26.000000000","message":"Yes. Is this expression not familiar to you, or it is familiar but you find it not properly used here? Consulting with this resource: http://english.stackexchange.com/questions/23851/use-of-in-the-sequel\n\nit seems to me that \"in the sequel\" is exchangeable with \"in the following\", although has a certain academic taste. I\u0027m not aware of such nuances, not being native speaker, I just picked it up from studying scientifc literature.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"``allow_access`` and ``deny_access`` methods to it (when appropriate,"},{"line_number":60,"context_line":"ie. when ``access_proto`` is NFS)."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"In the sequel we explain what has to be implemented by the"},{"line_number":63,"context_line":"``ganesha.GaneshaNASHelper`` subclass (to which we refer as \"helper"},{"line_number":64,"context_line":"class\").."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_a9575f01","line":62,"in_reply_to":"1a6ced46_b81433f6","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7e2f23a6cc4ffc5af84e1bdb750793bc47626626","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"In the sequel we explain what has to be implemented by the"},{"line_number":63,"context_line":"``ganesha.GaneshaNASHelper`` subclass (to which we refer as \"helper"},{"line_number":64,"context_line":"class\").."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Ganesha exports (in Ganesha 2.*) are described by so-called"},{"line_number":67,"context_line":"*Ganesha export blocks*, that is, snippets of Ganesha config"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_38520d14","line":64,"updated":"2015-03-22 15:01:04.000000000","message":"Remove the extra \".\" at the end.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"In the sequel we explain what has to be implemented by the"},{"line_number":63,"context_line":"``ganesha.GaneshaNASHelper`` subclass (to which we refer as \"helper"},{"line_number":64,"context_line":"class\").."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Ganesha exports (in Ganesha 2.*) are described by so-called"},{"line_number":67,"context_line":"*Ganesha export blocks*, that is, snippets of Ganesha config"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_c61de074","line":64,"in_reply_to":"1a6ced46_38520d14","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6bbcc15d0f252a12b567382073252776ddac5e09","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        \"Tag\": \"@runtime\","},{"line_number":113,"context_line":"        \"CLIENT\": {"},{"line_number":114,"context_line":"          \"Clients\": \"@runtime\","},{"line_number":115,"context_line":"          \"Access_Type\": \"RW\""},{"line_number":116,"context_line":"        },"},{"line_number":117,"context_line":"        \"Squash\": \"None\""},{"line_number":118,"context_line":"      }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_ee91579b","line":115,"updated":"2015-03-24 05:51:08.000000000","message":"Add the \",\" at the end.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        \"Tag\": \"@runtime\","},{"line_number":113,"context_line":"        \"CLIENT\": {"},{"line_number":114,"context_line":"          \"Clients\": \"@runtime\","},{"line_number":115,"context_line":"          \"Access_Type\": \"RW\""},{"line_number":116,"context_line":"        },"},{"line_number":117,"context_line":"        \"Squash\": \"None\""},{"line_number":118,"context_line":"      }"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_86400858","line":115,"in_reply_to":"1a6ced46_ee91579b","updated":"2015-04-23 19:03:27.000000000","message":"That would break JSON validity.","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a482d496ecb3f60cd4803294de7146cc1b2d1e9f","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"*manila/share/drivers/ganesha/conf/00-base-export-template.conf*"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"where the same data stored in Ganesha conf format (also supplied with"},{"line_number":126,"context_line":"comments)."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"For customization, the driver has to extend the ``_default_config_hook``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_c23bc736","line":125,"updated":"2015-03-23 00:20:43.000000000","message":"\"...data is stored...\"","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"*manila/share/drivers/ganesha/conf/00-base-export-template.conf*"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"where the same data stored in Ganesha conf format (also supplied with"},{"line_number":126,"context_line":"comments)."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"For customization, the driver has to extend the ``_default_config_hook``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_e69584e4","line":125,"in_reply_to":"1a6ced46_c23bc736","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"59477124c5310ba68b2c9ddf7bc2ec05f32b80c7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"specfic location in the Manila source tree (to change defaults)"},{"line_number":132,"context_line":"or from a user exposed external location (to allow user to make changes),"},{"line_number":133,"context_line":"and merging the argument export block template with the loaded export block"},{"line_number":134,"context_line":"templates using the ``ganesha_utils.patch`` method."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Known Restrictions"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_944f3b92","line":134,"updated":"2015-03-23 11:43:37.000000000","message":"This paragraph seems hard to follow. Perhaps, break the paragraph into smaller sentences? Or maybe you can provide a perm link to an example or reference implementation?","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"specfic location in the Manila source tree (to change defaults)"},{"line_number":132,"context_line":"or from a user exposed external location (to allow user to make changes),"},{"line_number":133,"context_line":"and merging the argument export block template with the loaded export block"},{"line_number":134,"context_line":"templates using the ``ganesha_utils.patch`` method."},{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Known Restrictions"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_e6eea48a","line":134,"in_reply_to":"1a6ced46_944f3b92","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a482d496ecb3f60cd4803294de7146cc1b2d1e9f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Known Restrictions"},{"line_number":138,"context_line":"------------------"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"- The library does not support network segmented multi-tenancy model instead"},{"line_number":141,"context_line":"  works over a flat network, where the tenants share a network."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"The :mod:`manila.share.drivers.ganesha` Module"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6ced46_4217d7a3","line":140,"updated":"2015-03-23 00:20:43.000000000","message":"\"...but instead...\"","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"6405b0b88423c65a67cc99c97282c26fd435f05e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"Known Restrictions"},{"line_number":138,"context_line":"------------------"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"- The library does not support network segmented multi-tenancy model instead"},{"line_number":141,"context_line":"  works over a flat network, where the tenants share a network."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"The :mod:`manila.share.drivers.ganesha` Module"}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab921fb_cfadfa89","line":140,"in_reply_to":"1a6ced46_4217d7a3","updated":"2015-04-23 19:03:27.000000000","message":"Done","commit_id":"5ea5e3ea102e4487d44611dc715e9275e28fc135"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":21,"context_line":"provision shares via NFS (NFSv3 and NFSv4), utilizing the NFS-Ganesha NFS"},{"line_number":22,"context_line":"server."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Supported Operations"},{"line_number":25,"context_line":"--------------------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Allow NFS Share access"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_8d796c32","line":24,"updated":"2015-04-28 20:41:12.000000000","message":"I like this capital \"S\" and \"O\", but when you look at the generated docs you\u0027ll see you aren\u0027t consistent.  Also we\u0027re not consistent across drivers.  I\u0027d suggest you pick one style and make at least your doc consistent.","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"provision shares via NFS (NFSv3 and NFSv4), utilizing the NFS-Ganesha NFS"},{"line_number":22,"context_line":"server."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Supported Operations"},{"line_number":25,"context_line":"--------------------"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- Allow NFS Share access"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_9be75840","line":24,"in_reply_to":"5ad0253b_8d796c32","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":38,"context_line":"NFS-Ganesha configuration"},{"line_number":39,"context_line":"-------------------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The library has just modest requirements against general  NFS-Ganesha (in the"},{"line_number":42,"context_line":"following: Ganesha) configuration; a best effort was made to remain as much"},{"line_number":43,"context_line":"agnostic towards it as possbile.  This section describes the few requirements"},{"line_number":44,"context_line":"we have."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_b23fe924","line":41,"updated":"2015-04-28 20:41:12.000000000","message":"extra space before NFS-Ganesha","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"NFS-Ganesha configuration"},{"line_number":39,"context_line":"-------------------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The library has just modest requirements against general  NFS-Ganesha (in the"},{"line_number":42,"context_line":"following: Ganesha) configuration; a best effort was made to remain as much"},{"line_number":43,"context_line":"agnostic towards it as possbile.  This section describes the few requirements"},{"line_number":44,"context_line":"we have."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_dbaf10e2","line":41,"in_reply_to":"5ad0253b_b23fe924","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The library has just modest requirements against general  NFS-Ganesha (in the"},{"line_number":42,"context_line":"following: Ganesha) configuration; a best effort was made to remain as much"},{"line_number":43,"context_line":"agnostic towards it as possbile.  This section describes the few requirements"},{"line_number":44,"context_line":"we have."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Note that Ganesha\u0027s concept of storage backend modules is called FSAL (\"File"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_d2eca591","line":43,"updated":"2015-04-28 20:41:12.000000000","message":"s/as much agnostic towards it/agnostic towards it as much/\ns/possbile/possible/","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"The library has just modest requirements against general  NFS-Ganesha (in the"},{"line_number":42,"context_line":"following: Ganesha) configuration; a best effort was made to remain as much"},{"line_number":43,"context_line":"agnostic towards it as possbile.  This section describes the few requirements"},{"line_number":44,"context_line":"we have."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Note that Ganesha\u0027s concept of storage backend modules is called FSAL (\"File"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_5b9b00ca","line":43,"in_reply_to":"5ad0253b_d2eca591","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":41,"context_line":"The library has just modest requirements against general  NFS-Ganesha (in the"},{"line_number":42,"context_line":"following: Ganesha) configuration; a best effort was made to remain as much"},{"line_number":43,"context_line":"agnostic towards it as possbile.  This section describes the few requirements"},{"line_number":44,"context_line":"we have."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Note that Ganesha\u0027s concept of storage backend modules is called FSAL (\"File"},{"line_number":47,"context_line":"System Abstraction Layer\"). The FSAL the driver intends to leverage needs to be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_329519e4","line":44,"updated":"2015-04-28 20:41:12.000000000","message":"remove \"we have\"","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"The library has just modest requirements against general  NFS-Ganesha (in the"},{"line_number":42,"context_line":"following: Ganesha) configuration; a best effort was made to remain as much"},{"line_number":43,"context_line":"agnostic towards it as possbile.  This section describes the few requirements"},{"line_number":44,"context_line":"we have."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Note that Ganesha\u0027s concept of storage backend modules is called FSAL (\"File"},{"line_number":47,"context_line":"System Abstraction Layer\"). The FSAL the driver intends to leverage needs to be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_7b48fc5b","line":44,"in_reply_to":"5ad0253b_329519e4","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    ``%include \u003cganesha_export_dir\u003e/INDEX.conf``"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    must be present in the content of `ganesha_config_path`"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Further Ganesha related Manila configuration"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_adf8a87d","line":68,"updated":"2015-04-28 20:41:12.000000000","message":"In the final formatting I think it would look better if you didn\u0027t have this traiing part of the sentence.  Maybe you could change s/, ie./. For example, the following must be present in the content of `ganesha_config_path\u0027.  Up to you. It is readable as-is.","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    ``%include \u003cganesha_export_dir\u003e/INDEX.conf``"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    must be present in the content of `ganesha_config_path`"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Further Ganesha related Manila configuration"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_db41503b","line":68,"in_reply_to":"5ad0253b_adf8a87d","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":71,"context_line":"Further Ganesha related Manila configuration"},{"line_number":72,"context_line":"------------------------------------------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"There are further Ganesha related options in Manila (which, while affect the"},{"line_number":75,"context_line":"behavior of Ganesha, do not affect how to set up the Ganesha service itself)."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"These are:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_ed56a005","line":74,"updated":"2015-04-28 20:41:12.000000000","message":"Reword \"which, while affect\".  Perhaps: (which affect the behavior of Ganesha, but do not affect...)","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"Further Ganesha related Manila configuration"},{"line_number":72,"context_line":"------------------------------------------------"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"There are further Ganesha related options in Manila (which, while affect the"},{"line_number":75,"context_line":"behavior of Ganesha, do not affect how to set up the Ganesha service itself)."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"These are:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_e05e9944","line":74,"in_reply_to":"5ad0253b_ed56a005","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":119,"context_line":"However, the driver is allowed to:"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"- customize defaults;"},{"line_number":122,"context_line":"- allow users to customize exports."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The config format for Ganesha Library is called *export block"},{"line_number":125,"context_line":"template*. They are syntactically either Ganesha export blocks,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_eda46009","line":122,"updated":"2015-04-28 20:41:12.000000000","message":"I think these bullets would look better without the ending ; and .  -- but styles vary.","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"However, the driver is allowed to:"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"- customize defaults;"},{"line_number":122,"context_line":"- allow users to customize exports."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The config format for Ganesha Library is called *export block"},{"line_number":125,"context_line":"template*. They are syntactically either Ganesha export blocks,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_001195ac","line":122,"in_reply_to":"5ad0253b_eda46009","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      }"},{"line_number":154,"context_line":"    }"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"The Ganesha Library takes this values from"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"*manila/share/drivers/ganesha/conf/00-base-export-template.conf*"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_6d2050f8","line":156,"updated":"2015-04-28 20:41:12.000000000","message":"s/this values/this value/ or \u0027these values\u0027","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      }"},{"line_number":154,"context_line":"    }"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"The Ganesha Library takes this values from"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"*manila/share/drivers/ganesha/conf/00-base-export-template.conf*"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_4068adf5","line":156,"in_reply_to":"5ad0253b_6d2050f8","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":166,"context_line":"-  take the result of the super method (a dict representing an export"},{"line_number":167,"context_line":"   block template);"},{"line_number":168,"context_line":"-  set up another export block dict that include your custom values,"},{"line_number":169,"context_line":"   either by:"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"   -  using a predefined export block dict stored in code"},{"line_number":172,"context_line":"   -  loading a predefined export block from the Manila source tree"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_6d905096","line":169,"updated":"2015-04-28 20:41:12.000000000","message":"if you remove the trailing punctuation above, then same advice here.","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"-  take the result of the super method (a dict representing an export"},{"line_number":167,"context_line":"   block template);"},{"line_number":168,"context_line":"-  set up another export block dict that include your custom values,"},{"line_number":169,"context_line":"   either by:"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"   -  using a predefined export block dict stored in code"},{"line_number":172,"context_line":"   -  loading a predefined export block from the Manila source tree"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_200c9193","line":169,"in_reply_to":"5ad0253b_6d905096","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":174,"context_line":"      user configuration)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"   (loading export blocks can be done through the utility method"},{"line_number":177,"context_line":"   ``_load_conf_dir``);"},{"line_number":178,"context_line":"-  merge the two export block dict using the ``ganesha_utils.patch``"},{"line_number":179,"context_line":"   method;"},{"line_number":180,"context_line":"-  return the result."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_6de5f0a6","line":177,"updated":"2015-04-28 20:41:12.000000000","message":"When you look at the formatted doc, you might decide to move this line.  Not sure where tho.","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"      user configuration)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"   (loading export blocks can be done through the utility method"},{"line_number":177,"context_line":"   ``_load_conf_dir``);"},{"line_number":178,"context_line":"-  merge the two export block dict using the ``ganesha_utils.patch``"},{"line_number":179,"context_line":"   method;"},{"line_number":180,"context_line":"-  return the result."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_20b6d18a","line":177,"in_reply_to":"5ad0253b_6de5f0a6","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"aa6b140166839046952a9dbd83d80814d4837567","unresolved":false,"context_lines":[{"line_number":177,"context_line":"   ``_load_conf_dir``);"},{"line_number":178,"context_line":"-  merge the two export block dict using the ``ganesha_utils.patch``"},{"line_number":179,"context_line":"   method;"},{"line_number":180,"context_line":"-  return the result."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Known Restrictions"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_2de9381b","line":180,"updated":"2015-04-28 20:41:12.000000000","message":"and here","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"36447096b0aebedbb173726cff448321c5a79c0c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"   ``_load_conf_dir``);"},{"line_number":178,"context_line":"-  merge the two export block dict using the ``ganesha_utils.patch``"},{"line_number":179,"context_line":"   method;"},{"line_number":180,"context_line":"-  return the result."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Known Restrictions"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ad0253b_601289b6","line":180,"in_reply_to":"5ad0253b_2de9381b","updated":"2015-04-29 08:11:58.000000000","message":"Done","commit_id":"4aa347d4bc46ec398d2dee51855d1b2b29d02360"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"fe98b6433a6a76be6ddfe9f57ba452accd629dda","unresolved":false,"context_lines":[{"line_number":97,"context_line":"``ganesha.GaneshaNASHelper`` subclass (to which we refer as \"helper"},{"line_number":98,"context_line":"class\")."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Ganesha exports (in Ganesha 2.*) are described by so-called"},{"line_number":101,"context_line":"*Ganesha export blocks*, that is, snippets of Ganesha config"},{"line_number":102,"context_line":"specifying key-pair values."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3acd31a7_9caab018","line":100,"updated":"2015-04-30 06:14:34.000000000","message":"imho the mentioned version is not needed. It\u0027s written in the requirements that \u003e\u003d 2.1 is needed.","commit_id":"a16d5e11779db763bc59707d96e5b8007f175873"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"73e23fd0bd484f880c7432079d4e5685b82b6e54","unresolved":false,"context_lines":[{"line_number":97,"context_line":"``ganesha.GaneshaNASHelper`` subclass (to which we refer as \"helper"},{"line_number":98,"context_line":"class\")."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Ganesha exports (in Ganesha 2.*) are described by so-called"},{"line_number":101,"context_line":"*Ganesha export blocks*, that is, snippets of Ganesha config"},{"line_number":102,"context_line":"specifying key-pair values."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"3acd31a7_b3d104d0","line":100,"in_reply_to":"3acd31a7_9caab018","updated":"2015-04-30 15:37:30.000000000","message":"That\u0027s a subtle concern.\n\nSee this analogy: say you have a product that can operate with NFS v4. Say your product utilizes the pseudofs feature of NFS v4, and you want to explain the concept of pseudofs in the product\u0027s doc. Then you can\u0027t just say \"NFS has a special synthetic filesystem export called pseudofs such that...\", because that\u0027s not true. If you put it this way, it will still be an universal statement about NFS (regardless of your earlier statement about requirements), and pseudofs is not universally present in NFS. This statement is made about NFS, the requirements statement is made about your product. The latter does not limit the scope of the former.\n\nSimilarly, I wanted to scope my description of Ganesha export blocks accurately. Export blocks exist only in Ganesha \u003e\u003d 2.0.\n\nI\u0027m happy to hear any suggestion to improve wording!","commit_id":"a16d5e11779db763bc59707d96e5b8007f175873"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"dc10454e320fa15753335d4f55c1092d91e825e6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"``ganesha.GaneshaNASHelper`` subclass (to which we refer as \"helper"},{"line_number":98,"context_line":"class\")."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Ganesha exports (in Ganesha 2.*) are described by so-called"},{"line_number":101,"context_line":"*Ganesha export blocks*, that is, snippets of Ganesha config"},{"line_number":102,"context_line":"specifying key-pair values."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a0c5dc1_1a60fc34","line":100,"in_reply_to":"3acd31a7_b3d104d0","updated":"2015-05-12 10:19:53.000000000","message":"No idea howto improve wording. But I\u0027m fine with leaving the version in...","commit_id":"a16d5e11779db763bc59707d96e5b8007f175873"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"e1a6f2daccb5464b08ced1c657228c3593e26898","unresolved":false,"context_lines":[{"line_number":97,"context_line":"``ganesha.GaneshaNASHelper`` subclass (to which we refer as \"helper"},{"line_number":98,"context_line":"class\")."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Ganesha exports (in Ganesha 2.*) are described by so-called"},{"line_number":101,"context_line":"*Ganesha export blocks*, that is, snippets of Ganesha config"},{"line_number":102,"context_line":"specifying key-pair values."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a0c5dc1_791dc565","line":100,"in_reply_to":"9a0c5dc1_1a60fc34","updated":"2015-05-12 10:48:53.000000000","message":"I changed it a little bit, I hope it allows the intent I had when provided this bit of information to shine through better.","commit_id":"a16d5e11779db763bc59707d96e5b8007f175873"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"ae17d01967e6d8ff01165ac863f0ba6131123784","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  instead works over a flat network, where the tenants share a network."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"The :mod:`manila.share.drivers.ganesha` Module"},{"line_number":189,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":".. automodule:: manila.share.drivers.ganesha"},{"line_number":192,"context_line":"    :noindex:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3acd31a7_be169653","line":189,"updated":"2015-04-29 16:58:27.000000000","message":"There was an earlier comment about this underline being the wrong length.  I don\u0027t see a problem in the output or the Jenkins results though.","commit_id":"a16d5e11779db763bc59707d96e5b8007f175873"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"e1a6f2daccb5464b08ced1c657228c3593e26898","unresolved":false,"context_lines":[{"line_number":186,"context_line":"  instead works over a flat network, where the tenants share a network."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"The :mod:`manila.share.drivers.ganesha` Module"},{"line_number":189,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":".. automodule:: manila.share.drivers.ganesha"},{"line_number":192,"context_line":"    :noindex:"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a0c5dc1_9a774cd4","line":189,"in_reply_to":"3acd31a7_be169653","updated":"2015-05-12 10:48:53.000000000","message":"Done","commit_id":"a16d5e11779db763bc59707d96e5b8007f175873"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0ba8c2a3f90691fcc571bac1d57f4f06f5f2a17f","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Further Ganesha related Manila configuration"},{"line_number":70,"context_line":"------------------------------------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"There are further Ganesha related options in Manila (which affect the"},{"line_number":73,"context_line":"behavior of Ganesha, but do not affect how to set up the Ganesha service"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a0c5dc1_f9409509","line":70,"updated":"2015-05-12 10:54:20.000000000","message":"here too.","commit_id":"f67145668ca0c7dac438d27074be4c5738f15799"},{"author":{"_account_id":9521,"name":"Csaba Henk","email":"chenk@redhat.com","username":"chenk"},"change_message_id":"5ad6804a49ffaf5faf7ab3793d12913b276a37bf","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Further Ganesha related Manila configuration"},{"line_number":70,"context_line":"------------------------------------------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"There are further Ganesha related options in Manila (which affect the"},{"line_number":73,"context_line":"behavior of Ganesha, but do not affect how to set up the Ganesha service"}],"source_content_type":"text/x-rst","patch_set":7,"id":"9a0c5dc1_8d4fea91","line":70,"in_reply_to":"9a0c5dc1_f9409509","updated":"2015-05-13 08:52:56.000000000","message":"Done","commit_id":"f67145668ca0c7dac438d27074be4c5738f15799"}]}