)]}'
{"manila/api/openstack/wsgi.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"3e4933a95f295d97f8a2de1624c3a14b4e9a9f2b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        return self.get_db_items(key).get(item_key)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def cache_db_share_types(self, share_types):"},{"line_number":169,"context_line":"        self.cache_db_items(\u0027share_types\u0027, share_types, \u0027id\u0027)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def cache_db_share_type(self, share_type):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_0a6c6333","line":168,"updated":"2015-04-10 15:02:20.000000000","message":"Are you expecting to add cache access methods here for each type of resource that you can cache?  Why can\u0027t the API code that uses the cache just call the above methods (cache_db_items(\u0027share_types\u0027, ...)  It appears these four share_type methods aren\u0027t used.","commit_id":"0f77e071a3b85b8b601e17407422cf9f50ebff0d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a2cd2f579de812e97a2586755d683deb1e61d68d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        return self.get_db_items(key).get(item_key)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def cache_db_share_types(self, share_types):"},{"line_number":169,"context_line":"        self.cache_db_items(\u0027share_types\u0027, share_types, \u0027id\u0027)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def cache_db_share_type(self, share_type):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_e16240ad","line":168,"in_reply_to":"9aa53dc9_0a6c6333","updated":"2015-04-10 16:21:04.000000000","message":"Reused methods. And yes, we should implement caching for all extensions.","commit_id":"0f77e071a3b85b8b601e17407422cf9f50ebff0d"}]}