)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9c7bdf228f277daad190a9030f7f4583b8f822d0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implementation of oslo.versionedobjects."},{"line_number":10,"context_line":"This commit consists basic mechanism and first objects."},{"line_number":11,"context_line":"This should be base of implementation versoning to other objects"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint versioned-objects"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_42450015","line":11,"updated":"2015-04-15 06:55:56.000000000","message":"versoning? versioning?\n\nAdd \u0027.\u0027 in the end.","commit_id":"a165f2388e5a64c56c6458300fe8ee1380bd9021"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"64324e48f8959fbd2a41fa13492bb8c98b5ea3b9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Li, Chen \u003cchen.li@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-20 15:31:04 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"First object - ShareExportLocation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implementation of oslo.versionedobjects."},{"line_number":10,"context_line":"This commit consists basic mechanism and the first object: ShareExportLocation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dac4157f_242b4e96","line":7,"updated":"2015-04-21 16:22:33.000000000","message":"Topic of commit should be rewritten, for example:\n\n\"\"\"\n\nImplement versioned object for share export locations\n\n\"\"\"","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a09068839099900bc5c0477f4fe89ce2b03d7418","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Li, Chen \u003cchen.li@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-20 15:31:04 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"First object - ShareExportLocation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implementation of oslo.versionedobjects."},{"line_number":10,"context_line":"This commit consists basic mechanism and the first object: ShareExportLocation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dac4157f_ff4cae71","line":7,"in_reply_to":"dac4157f_242b4e96","updated":"2015-04-22 01:35:33.000000000","message":"Done","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"64324e48f8959fbd2a41fa13492bb8c98b5ea3b9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"First object - ShareExportLocation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implementation of oslo.versionedobjects."},{"line_number":10,"context_line":"This commit consists basic mechanism and the first object: ShareExportLocation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint versioned-objects"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dac4157f_3827f2b7","line":10,"updated":"2015-04-21 16:22:33.000000000","message":"Please, describe here the change. It is completely not obvious what is done and why with current description.","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a09068839099900bc5c0477f4fe89ce2b03d7418","unresolved":false,"context_lines":[{"line_number":7,"context_line":"First object - ShareExportLocation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implementation of oslo.versionedobjects."},{"line_number":10,"context_line":"This commit consists basic mechanism and the first object: ShareExportLocation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint versioned-objects"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dac4157f_df47aa49","line":10,"in_reply_to":"dac4157f_3827f2b7","updated":"2015-04-22 01:35:33.000000000","message":"Done","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"64324e48f8959fbd2a41fa13492bb8c98b5ea3b9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Implementation of oslo.versionedobjects."},{"line_number":10,"context_line":"This commit consists basic mechanism and the first object: ShareExportLocation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint versioned-objects"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia277f6a347a1332a0142ca924ea1c8ed8b3b987c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dac4157f_1851ce0e","line":12,"updated":"2015-04-21 16:22:33.000000000","message":"It is partial implementation, so, should be as following:\n\n\"\"\"\n\nPartially implements blueprint versioned-objects\n\n\"\"\"","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a09068839099900bc5c0477f4fe89ce2b03d7418","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Implementation of oslo.versionedobjects."},{"line_number":10,"context_line":"This commit consists basic mechanism and the first object: ShareExportLocation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint versioned-objects"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia277f6a347a1332a0142ca924ea1c8ed8b3b987c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dac4157f_bf751699","line":12,"in_reply_to":"dac4157f_1851ce0e","updated":"2015-04-22 01:35:33.000000000","message":"Done","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"64324e48f8959fbd2a41fa13492bb8c98b5ea3b9","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"                \u0027deleted\u0027: 0,"},{"line_number":1737,"context_line":"            })"},{"line_number":1738,"context_line":"            location_ref.save(session\u003dsession)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"        return _share_export_locations_get("},{"line_number":1741,"context_line":"            context, share_id, session\u003dsession)"},{"line_number":1742,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_49041bbf","line":1739,"updated":"2015-04-21 16:22:33.000000000","message":"Why previously existed code was removed? - \n\n\"\"\"\n\nif delete:\n\n    return export_locations\n\n\"\"\"\n\nAbove code allows us to avoid redundant request to DB.","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a09068839099900bc5c0477f4fe89ce2b03d7418","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"                \u0027deleted\u0027: 0,"},{"line_number":1737,"context_line":"            })"},{"line_number":1738,"context_line":"            location_ref.save(session\u003dsession)"},{"line_number":1739,"context_line":""},{"line_number":1740,"context_line":"        return _share_export_locations_get("},{"line_number":1741,"context_line":"            context, share_id, session\u003dsession)"},{"line_number":1742,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_bcef6486","line":1739,"in_reply_to":"dac4157f_49041bbf","updated":"2015-04-22 01:35:33.000000000","message":"Thanks! Done!","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"da707bd79efbe121a4969135af243e3d3d860e85","unresolved":false,"context_lines":[{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"@require_context"},{"line_number":1664,"context_line":"@require_share_exists"},{"line_number":1665,"context_line":"def share_export_locations_get(context, share_id):"},{"line_number":1666,"context_line":"    return _share_export_locations_get(context, share_id)"},{"line_number":1667,"context_line":""},{"line_number":1668,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_6a6ed530","line":1665,"updated":"2015-04-30 14:36:21.000000000","message":"Why do you need this proxy method? Combine this method with following one.","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":7652,"name":"Luis Pabón","email":"lpabon@gmail.com","username":"lpabon"},"change_message_id":"bf95c0a21c73b038130c52b62cec8d06a527e11f","unresolved":false,"context_lines":[{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"@require_context"},{"line_number":1664,"context_line":"@require_share_exists"},{"line_number":1665,"context_line":"def share_export_locations_get(context, share_id):"},{"line_number":1666,"context_line":"    return _share_export_locations_get(context, share_id)"},{"line_number":1667,"context_line":""},{"line_number":1668,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_a8682a88","line":1665,"in_reply_to":"3acd31a7_6a6ed530","updated":"2015-05-04 18:27:58.000000000","message":"agree, unless there is a reason.","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"ce83320faed18b056743bb437b37f2dff99c7915","unresolved":false,"context_lines":[{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"@require_context"},{"line_number":1664,"context_line":"@require_share_exists"},{"line_number":1665,"context_line":"def share_export_locations_get(context, share_id):"},{"line_number":1666,"context_line":"    return _share_export_locations_get(context, share_id)"},{"line_number":1667,"context_line":""},{"line_number":1668,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_b0c3dd56","line":1665,"in_reply_to":"3acd31a7_a8682a88","updated":"2015-05-05 08:55:49.000000000","message":"In order to remove the proxy method, we have to put  @require_context \u0026 @require_share_exists above the  following method, and remove the \"_\" for the method name, am I right ?\n\nI tested for that and there is a issue. \n\n_share_export_locations_get would be called by method share_export_locations_update which is also decorated by @require_context \u0026 @require_share_exists.\n\nI\u0027m not very sure about the exact reason, but  the return value for share_export_locations_update is  \"set([])\".\n\nAny suggestions ?","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"91e01bb85c86230a30b6f2db813e959178d022eb","unresolved":false,"context_lines":[{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"@require_context"},{"line_number":1664,"context_line":"@require_share_exists"},{"line_number":1665,"context_line":"def share_export_locations_get(context, share_id):"},{"line_number":1666,"context_line":"    return _share_export_locations_get(context, share_id)"},{"line_number":1667,"context_line":""},{"line_number":1668,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7a016987_1dc0c7df","line":1665,"in_reply_to":"3acd31a7_b0c3dd56","updated":"2015-05-15 14:17:21.000000000","message":"OK, lets keep it as is.","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"fad8d6e60113dd9c09ec194414ef622ac1a1217c","unresolved":false,"context_lines":[{"line_number":1662,"context_line":""},{"line_number":1663,"context_line":"@require_context"},{"line_number":1664,"context_line":"@require_share_exists"},{"line_number":1665,"context_line":"def share_export_locations_get(context, share_id):"},{"line_number":1666,"context_line":"    return _share_export_locations_get(context, share_id)"},{"line_number":1667,"context_line":""},{"line_number":1668,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7a016987_bc3872a1","line":1665,"in_reply_to":"7a016987_1dc0c7df","updated":"2015-05-18 01:41:04.000000000","message":"ok","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"}],"manila/exception.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"64324e48f8959fbd2a41fa13492bb8c98b5ea3b9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"exc_log_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027fatal_exception_format_errors\u0027,"},{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d\u0027Whether to make exception message format errors fatal.\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_099623f0","side":"PARENT","line":37,"updated":"2015-04-21 16:22:33.000000000","message":"In lib \"oslo_versionedobjects\" this option registered under different config group - \"oslo_versionedobjects\".\n\nSo, it was in [DEFAULT] and starts being registered in [oslo_versionedobjects]. And in all places where it is used will be raised error of absent option, because all code usages are trying to call it from old default group.\n\nSee line 98 in this file, for example.","commit_id":"7cc4fc08f7f928225761ce793480dd09e1c562de"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a09068839099900bc5c0477f4fe89ce2b03d7418","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"exc_log_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027fatal_exception_format_errors\u0027,"},{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d\u0027Whether to make exception message format errors fatal.\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_1cc1b080","side":"PARENT","line":37,"in_reply_to":"dac4157f_099623f0","updated":"2015-04-22 01:35:33.000000000","message":"Done","commit_id":"7cc4fc08f7f928225761ce793480dd09e1c562de"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"3f0322521709477d165115ff053b124cbcabe6c3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"exc_log_opts \u003d ["},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027fatal_exception_format_errors\u0027,"},{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d\u0027Whether to make exception message format errors fatal.\u0027),"},{"line_number":40,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_7f13fe66","side":"PARENT","line":37,"in_reply_to":"dac4157f_099623f0","updated":"2015-04-22 02:32:24.000000000","message":"Just tried.\n\nAfter changed line 98 to CONF.oslo_versionedobjects.fatal_exception_format_errors, unit test would not pass and complains about  oslo.cfg can\u0027t find config group oslo_versionedobjects.\n\nLooks like \"fatal_exception_format_errors\" should still be in [DEFAULT]  because I have add  \"oslo_versionedobjects.exception.exc_log_opts\" directly into the _global_opt_lists.\n\nUnit test should already covered this. :)\nSo, I think we\u0027re safe here.","commit_id":"7cc4fc08f7f928225761ce793480dd09e1c562de"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"64324e48f8959fbd2a41fa13492bb8c98b5ea3b9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                LOG.exception(_LE(\u0027Exception in string format operation.\u0027))"},{"line_number":95,"context_line":"                for name, value in six.iteritems(kwargs):"},{"line_number":96,"context_line":"                    LOG.error(_LE(\"%(name)s: %(value)s\"), {"},{"line_number":97,"context_line":"                        \u0027name\u0027: name, \u0027value\u0027: value})"},{"line_number":98,"context_line":"                if CONF.fatal_exception_format_errors:"},{"line_number":99,"context_line":"                    raise e"},{"line_number":100,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_c4fed26a","side":"PARENT","line":97,"updated":"2015-04-21 16:22:33.000000000","message":"Should be \"CONF.oslo_versionedobjects.fatal_exception_format_errors\".\n\nSame for all usages of this configuration option.","commit_id":"7cc4fc08f7f928225761ce793480dd09e1c562de"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a09068839099900bc5c0477f4fe89ce2b03d7418","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                LOG.exception(_LE(\u0027Exception in string format operation.\u0027))"},{"line_number":95,"context_line":"                for name, value in six.iteritems(kwargs):"},{"line_number":96,"context_line":"                    LOG.error(_LE(\"%(name)s: %(value)s\"), {"},{"line_number":97,"context_line":"                        \u0027name\u0027: name, \u0027value\u0027: value})"},{"line_number":98,"context_line":"                if CONF.fatal_exception_format_errors:"},{"line_number":99,"context_line":"                    raise e"},{"line_number":100,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_9c0940e0","side":"PARENT","line":97,"in_reply_to":"dac4157f_c4fed26a","updated":"2015-04-22 01:35:33.000000000","message":"Thanks very much !!","commit_id":"7cc4fc08f7f928225761ce793480dd09e1c562de"}],"manila/objects/base.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ebb88da1944a53a3077ce1cc81931c1f24561517","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@base.VersionedObjectRegistry.register"},{"line_number":24,"context_line":"class ManilaiObject(base.VersionedObject):"},{"line_number":25,"context_line":"    OBJ_SERIAL_NAMESPACE \u003d \u0027manila_object\u0027"},{"line_number":26,"context_line":"    OBJ_PROJECT_NAMESPACE \u003d \u0027manila\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab921fb_aa4e46bf","line":24,"updated":"2015-04-23 08:56:45.000000000","message":"why ManilaiObject? not ManilaObject?","commit_id":"658af67bff6a5d375f6b35e0cf55d89cdaaae4c5"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"699706ca28b27d6dfe9cc5761751fad9df87cddf","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@base.VersionedObjectRegistry.register"},{"line_number":24,"context_line":"class ManilaiObject(base.VersionedObject):"},{"line_number":25,"context_line":"    OBJ_SERIAL_NAMESPACE \u003d \u0027manila_object\u0027"},{"line_number":26,"context_line":"    OBJ_PROJECT_NAMESPACE \u003d \u0027manila\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab921fb_25826701","line":24,"in_reply_to":"bab921fb_453c3b93","updated":"2015-04-23 09:21:16.000000000","message":"Done.\n\nSorry :)","commit_id":"658af67bff6a5d375f6b35e0cf55d89cdaaae4c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab34904c7f29f5d0253e5cbc4c77edf6d66d8345","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@base.VersionedObjectRegistry.register"},{"line_number":24,"context_line":"class ManilaiObject(base.VersionedObject):"},{"line_number":25,"context_line":"    OBJ_SERIAL_NAMESPACE \u003d \u0027manila_object\u0027"},{"line_number":26,"context_line":"    OBJ_PROJECT_NAMESPACE \u003d \u0027manila\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab921fb_ca74dad0","line":24,"in_reply_to":"bab921fb_aa4e46bf","updated":"2015-04-23 08:57:57.000000000","message":"Common nit for users of VIM.","commit_id":"658af67bff6a5d375f6b35e0cf55d89cdaaae4c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7e8f1fe20a9f68cfa81eae243b78f211da0e9279","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@base.VersionedObjectRegistry.register"},{"line_number":24,"context_line":"class ManilaiObject(base.VersionedObject):"},{"line_number":25,"context_line":"    OBJ_SERIAL_NAMESPACE \u003d \u0027manila_object\u0027"},{"line_number":26,"context_line":"    OBJ_PROJECT_NAMESPACE \u003d \u0027manila\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab921fb_453c3b93","line":24,"in_reply_to":"bab921fb_ca74dad0","updated":"2015-04-23 09:05:26.000000000","message":"+1, should be \"ManilaObject\".","commit_id":"658af67bff6a5d375f6b35e0cf55d89cdaaae4c5"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"294284a34f6d78a5fc29a7f68b3102468e4ff42b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo_versionedobjects import base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@base.VersionedObjectRegistry.register"},{"line_number":24,"context_line":"class ManilaObject(base.VersionedObject):"},{"line_number":25,"context_line":"    OBJ_SERIAL_NAMESPACE \u003d \u0027manila_object\u0027"},{"line_number":26,"context_line":"    OBJ_PROJECT_NAMESPACE \u003d \u0027manila\u0027"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_12b15be1","line":23,"updated":"2015-07-01 10:26:11.000000000","message":"I don\u0027t think this should be registered - this is an object without fields, which will never be sent over RPC.","commit_id":"b6c687202643734330d3242d189769f91417a5b4"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"da0f67792a195b3d821017696c23ed70ce6c0ed6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo_versionedobjects import base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@base.VersionedObjectRegistry.register"},{"line_number":24,"context_line":"class ManilaObject(base.VersionedObject):"},{"line_number":25,"context_line":"    OBJ_SERIAL_NAMESPACE \u003d \u0027manila_object\u0027"},{"line_number":26,"context_line":"    OBJ_PROJECT_NAMESPACE \u003d \u0027manila\u0027"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_4c781590","line":23,"in_reply_to":"ba3cc151_12b15be1","updated":"2015-07-06 02:05:49.000000000","message":"Done!\n\nThanks!","commit_id":"b6c687202643734330d3242d189769f91417a5b4"}],"manila/objects/share_export_location.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"64324e48f8959fbd2a41fa13492bb8c98b5ea3b9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from manila.db import api as db_api"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareExportLocation("},{"line_number":27,"context_line":"    base.VersionedObject,"},{"line_number":28,"context_line":"    base.VersionedObjectDictCompat,"},{"line_number":29,"context_line":"):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_f039d842","line":26,"updated":"2015-04-21 16:22:33.000000000","message":"Where is declaration of version for this \"versioned\" object? Also, I guess, absent version of object should be used somehow...","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"5ad3a70939204da37f6270e968c36e1b8a5dcdc1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from manila.db import api as db_api"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareExportLocation("},{"line_number":27,"context_line":"    base.VersionedObject,"},{"line_number":28,"context_line":"    base.VersionedObjectDictCompat,"},{"line_number":29,"context_line":"):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab921fb_e526af15","line":26,"in_reply_to":"bab921fb_65ff3f02","updated":"2015-04-23 09:20:24.000000000","message":"o. Will do later.\n\nI\u0027m planing to share it in the design summit, \n\nWrite some sample code for review first, so we will have more real things to discuss..","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e7cad48c44bda9284d4f264465da26562bf8c7f6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from manila.db import api as db_api"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareExportLocation("},{"line_number":27,"context_line":"    base.VersionedObject,"},{"line_number":28,"context_line":"    base.VersionedObjectDictCompat,"},{"line_number":29,"context_line":"):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab921fb_65ff3f02","line":26,"in_reply_to":"dac4157f_1ca0908f","updated":"2015-04-23 09:04:28.000000000","message":"Please, describe it in commit message. Would be great to have it in BP too. Share your intentions. So, everyone will have clear understanding.","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a09068839099900bc5c0477f4fe89ce2b03d7418","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from manila.db import api as db_api"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareExportLocation("},{"line_number":27,"context_line":"    base.VersionedObject,"},{"line_number":28,"context_line":"    base.VersionedObjectDictCompat,"},{"line_number":29,"context_line":"):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_1ca0908f","line":26,"in_reply_to":"dac4157f_f039d842","updated":"2015-04-22 01:35:33.000000000","message":"I\u0027m thinking of do the whole work in the order of:\n\n1) Integrate oslo_object with existing code without version supported and add/modify necessary test case. \n\n2) Implement object register method. \n\n3) Add version support. \n\nI suppose this would be more safe, and with the min risk to break the whole project.","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"64324e48f8959fbd2a41fa13492bb8c98b5ea3b9","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def _from_db_object(context, exl, db_exl):"},{"line_number":42,"context_line":"        if db_exl is None:"},{"line_number":43,"context_line":"            return None"},{"line_number":44,"context_line":"        for field in exl.fields:"},{"line_number":45,"context_line":"            exl[field] \u003d db_exl[field]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_ed5c5fef","line":42,"updated":"2015-04-21 16:22:33.000000000","message":"What is \"exl\"? What is \"db_exl\"? Difference?","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a09068839099900bc5c0477f4fe89ce2b03d7418","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def _from_db_object(context, exl, db_exl):"},{"line_number":42,"context_line":"        if db_exl is None:"},{"line_number":43,"context_line":"            return None"},{"line_number":44,"context_line":"        for field in exl.fields:"},{"line_number":45,"context_line":"            exl[field] \u003d db_exl[field]"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_bcbbe4e4","line":42,"in_reply_to":"dac4157f_ed5c5fef","updated":"2015-04-22 01:35:33.000000000","message":"ex \u003d\u003e export\n\nl \u003d\u003e location\n\ndb_exl is things we get from db_api\n\nexl is the \"object\" \u003d\u003e an instance of class ShareExportLocation","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"64324e48f8959fbd2a41fa13492bb8c98b5ea3b9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        return exl"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ShareExportLocationsList("},{"line_number":52,"context_line":"    base.ObjectListBase,"},{"line_number":53,"context_line":"    base.VersionedObject,"},{"line_number":54,"context_line":"):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_a4d4febc","line":51,"updated":"2015-04-21 16:22:33.000000000","message":"Why \"List\" is in name of class? I guess plural version \"ShareExportLocations\" will be enough.","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a09068839099900bc5c0477f4fe89ce2b03d7418","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        return exl"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ShareExportLocationsList("},{"line_number":52,"context_line":"    base.ObjectListBase,"},{"line_number":53,"context_line":"    base.VersionedObject,"},{"line_number":54,"context_line":"):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_dcc0d82c","line":51,"in_reply_to":"dac4157f_a4d4febc","updated":"2015-04-22 01:35:33.000000000","message":"I think \"ShareExportLocations\" would be a little easy to be mixed with ShareExportLocation.\n\nAnd, it is a list, inherit from \"ObjectListBase\", and all other projects  have named objects with \"List\".\n\n:)","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"64324e48f8959fbd2a41fa13492bb8c98b5ea3b9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                  db_exls)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def get_path_by_share_id(cls, context, share_id):"},{"line_number":70,"context_line":"        exls \u003d cls.get_by_share_id(context, share_id)"},{"line_number":71,"context_line":"        return [location[\u0027path\u0027] for location in exls]"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_a4a2be49","line":69,"updated":"2015-04-21 16:22:33.000000000","message":"Name of method assumes only one export location to be returned, that is not true indeed.","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"5ad3a70939204da37f6270e968c36e1b8a5dcdc1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                  db_exls)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def get_path_by_share_id(cls, context, share_id):"},{"line_number":70,"context_line":"        exls \u003d cls.get_by_share_id(context, share_id)"},{"line_number":71,"context_line":"        return [location[\u0027path\u0027] for location in exls]"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab921fb_c523ab04","line":69,"in_reply_to":"bab921fb_c5accbef","updated":"2015-04-23 09:20:24.000000000","message":"Done","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e7cad48c44bda9284d4f264465da26562bf8c7f6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                  db_exls)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def get_path_by_share_id(cls, context, share_id):"},{"line_number":70,"context_line":"        exls \u003d cls.get_by_share_id(context, share_id)"},{"line_number":71,"context_line":"        return [location[\u0027path\u0027] for location in exls]"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bab921fb_c5accbef","line":69,"in_reply_to":"dac4157f_7ce8acb4","updated":"2015-04-23 09:04:28.000000000","message":"\"get_export_locations_by_share_id\" is good.","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a09068839099900bc5c0477f4fe89ce2b03d7418","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                  db_exls)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def get_path_by_share_id(cls, context, share_id):"},{"line_number":70,"context_line":"        exls \u003d cls.get_by_share_id(context, share_id)"},{"line_number":71,"context_line":"        return [location[\u0027path\u0027] for location in exls]"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dac4157f_7ce8acb4","line":69,"in_reply_to":"dac4157f_a4a2be49","updated":"2015-04-22 01:35:33.000000000","message":"How about \"get_paths_by_share_id\" or  \"\"get_export_locations_by_share_id\"\" ?","commit_id":"bd59940dfefd212ed6eeb947ec8851d8acd92e18"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ac0d9bb71384f4d50e9cf7d037f1cd16dfd6a0f0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def get_by_share_id(cls, context, share_id):"},{"line_number":68,"context_line":"        db_exls \u003d db_api.share_export_locations_get(context,"},{"line_number":69,"context_line":"                                                    share_id)"},{"line_number":70,"context_line":"        return base.obj_make_list(context,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab921fb_eb8e00cf","line":67,"updated":"2015-04-25 10:09:40.000000000","message":"Could you please tell me when to using this function?","commit_id":"e042a6e8b62ae370d09b012e63af81e60420cd82"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"b3124f60fa5b88d632377a06d6b8d71a65953bb9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def get_by_share_id(cls, context, share_id):"},{"line_number":68,"context_line":"        db_exls \u003d db_api.share_export_locations_get(context,"},{"line_number":69,"context_line":"                                                    share_id)"},{"line_number":70,"context_line":"        return base.obj_make_list(context,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab921fb_b66a8fb1","line":67,"in_reply_to":"bab921fb_eb8e00cf","updated":"2015-04-27 00:49:26.000000000","message":"When we create object \"Share\", it will have a member with the type of \"ShareExportLocationsList\".\n\nin the \"_from_db_object\" method of object \"Share\", it will call this method to fulfill its member value.","commit_id":"e042a6e8b62ae370d09b012e63af81e60420cd82"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ac0d9bb71384f4d50e9cf7d037f1cd16dfd6a0f0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def share_export_locations_update(cls, context, share_id,"},{"line_number":82,"context_line":"                                      export_locations, delete\u003dTrue):"},{"line_number":83,"context_line":"        return db_api.share_export_locations_update("},{"line_number":84,"context_line":"            context, share_id, export_locations, delete)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab921fb_667fc566","line":84,"updated":"2015-04-25 10:09:40.000000000","message":"I really do not understand. What is different with Original method？\n\nIn manila/share/api.py:\nself.db.share_export_locations_update(context, share[\u0027id\u0027], export_location)","commit_id":"e042a6e8b62ae370d09b012e63af81e60420cd82"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"b3124f60fa5b88d632377a06d6b8d71a65953bb9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def share_export_locations_update(cls, context, share_id,"},{"line_number":82,"context_line":"                                      export_locations, delete\u003dTrue):"},{"line_number":83,"context_line":"        return db_api.share_export_locations_update("},{"line_number":84,"context_line":"            context, share_id, export_locations, delete)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab921fb_9640ab35","line":84,"in_reply_to":"bab921fb_667fc566","updated":"2015-04-27 00:49:26.000000000","message":"There us no real difference between \"methods\".\n\nBut, introduce versioned objects into the code have benefits.\n\nI believe we\u0027ll have more discussions in the design summit.","commit_id":"e042a6e8b62ae370d09b012e63af81e60420cd82"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"da707bd79efbe121a4969135af243e3d3d860e85","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027id\u0027: fields.IntegerField(),"},{"line_number":34,"context_line":"        \u0027created_at\u0027: fields.DateTimeField(read_only\u003dTrue),"},{"line_number":35,"context_line":"        \u0027updated_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027deleted_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027deleted\u0027: fields.IntegerField(),"},{"line_number":38,"context_line":"        \u0027share_id\u0027: fields.StringField(),"},{"line_number":39,"context_line":"        \u0027path\u0027: fields.StringField(),"}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_24a49355","line":36,"updated":"2015-04-30 14:36:21.000000000","message":"I think \u0027deleted\u0027 and \u0027deleted_at\u0027 fields should be removed from fields because these fields are internal DB implementation details and should NOT be exposed through new objects to Manila world :)","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"eb0b62cd5c73cfe93e9380fc172c49ed5befb583","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027id\u0027: fields.IntegerField(),"},{"line_number":34,"context_line":"        \u0027created_at\u0027: fields.DateTimeField(read_only\u003dTrue),"},{"line_number":35,"context_line":"        \u0027updated_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027deleted_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027deleted\u0027: fields.IntegerField(),"},{"line_number":38,"context_line":"        \u0027share_id\u0027: fields.StringField(),"},{"line_number":39,"context_line":"        \u0027path\u0027: fields.StringField(),"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aca2d91_ddffedff","line":36,"in_reply_to":"3acd31a7_24a49355","updated":"2015-05-07 01:46:56.000000000","message":"Done","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"da707bd79efbe121a4969135af243e3d3d860e85","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027updated_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027deleted_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027deleted\u0027: fields.IntegerField(),"},{"line_number":38,"context_line":"        \u0027share_id\u0027: fields.StringField(),"},{"line_number":39,"context_line":"        \u0027path\u0027: fields.StringField(),"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_6ad25502","line":38,"updated":"2015-04-30 14:36:21.000000000","message":"fields.UUID() ?","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"eb0b62cd5c73cfe93e9380fc172c49ed5befb583","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027updated_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027deleted_at\u0027: fields.DateTimeField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027deleted\u0027: fields.IntegerField(),"},{"line_number":38,"context_line":"        \u0027share_id\u0027: fields.StringField(),"},{"line_number":39,"context_line":"        \u0027path\u0027: fields.StringField(),"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1aca2d91_bd043115","line":38,"in_reply_to":"3acd31a7_6ad25502","updated":"2015-05-07 01:46:56.000000000","message":"Done","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"da707bd79efbe121a4969135af243e3d3d860e85","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def get_by_share_id(cls, context, share_id):"},{"line_number":68,"context_line":"        db_exls \u003d db_api.share_export_locations_get(context,"},{"line_number":69,"context_line":"                                                    share_id)"},{"line_number":70,"context_line":"        return base.obj_make_list(context,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_c4c83f77","line":67,"updated":"2015-04-30 14:36:21.000000000","message":"Why you don\u0027t use @remotable_classmethod here?\n\nAlso why do you use this old-fashion ugly names for methods?\nShould be replaced with simple get()","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"ad0b8d9ae94b6a5325164cd67b3a6c72d94555ba","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def get_by_share_id(cls, context, share_id):"},{"line_number":68,"context_line":"        db_exls \u003d db_api.share_export_locations_get(context,"},{"line_number":69,"context_line":"                                                    share_id)"},{"line_number":70,"context_line":"        return base.obj_make_list(context,"}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_d5ed5226","line":67,"in_reply_to":"3acd31a7_c4c83f77","updated":"2015-05-04 01:52:25.000000000","message":"@remotable_classmethod would call \"indirection_api\".\n\nCurrently, in nova, the indirection_api is APIs in nova-conductor.\n\nWhile, a bad news is the implementation for versionedobject is not all completed yet,  a bp in heat is trying to fulfill the gap : https://review.openstack.org/#/c/176654/1/specs/liberty/indirection-api.rst\n\nI\u0027m not sure how to decide this part yet, should we implement \"indirection_api\" in Manila by ourselves or we wait for heat -\u003e oslo incubator -\u003e oslo lib ? \n\n\n\n\nFor the names for methods:\n\nThe VersionedObjectDictCompat mix-in provides dictionary key access compat, it has a get/update method.\nhttps://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L687\n\nI use the old-fashion names, so they would not be mixed.\n\nMaybe we can do not use VersionedObjectDictCompat  at all as this mix-in would be deleted eventually as said in its comments ??","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"91e01bb85c86230a30b6f2db813e959178d022eb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def get_by_share_id(cls, context, share_id):"},{"line_number":68,"context_line":"        db_exls \u003d db_api.share_export_locations_get(context,"},{"line_number":69,"context_line":"                                                    share_id)"},{"line_number":70,"context_line":"        return base.obj_make_list(context,"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a016987_7d4a1bc7","line":67,"in_reply_to":"3acd31a7_d5ed5226","updated":"2015-05-15 14:17:21.000000000","message":"About \"indirection_api\":\n\nI think that we should wait for general approach in oslo lib.","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"fad8d6e60113dd9c09ec194414ef622ac1a1217c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def get_by_share_id(cls, context, share_id):"},{"line_number":68,"context_line":"        db_exls \u003d db_api.share_export_locations_get(context,"},{"line_number":69,"context_line":"                                                    share_id)"},{"line_number":70,"context_line":"        return base.obj_make_list(context,"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a016987_dcba0e0a","line":67,"in_reply_to":"7a016987_7d4a1bc7","updated":"2015-05-18 01:41:04.000000000","message":"ok","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"da707bd79efbe121a4969135af243e3d3d860e85","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                                  ShareExportLocation,"},{"line_number":73,"context_line":"                                  db_exls)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @classmethod"},{"line_number":76,"context_line":"    def get_export_locations_by_share_id(cls, context, share_id):"},{"line_number":77,"context_line":"        exls \u003d cls.get_by_share_id(context, share_id)"},{"line_number":78,"context_line":"        return [location[\u0027path\u0027] for location in exls]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_a490a3ed","line":75,"updated":"2015-04-30 14:36:21.000000000","message":"This method should be normal instance method with name to_list().","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"eb0b62cd5c73cfe93e9380fc172c49ed5befb583","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                                  ShareExportLocation,"},{"line_number":73,"context_line":"                                  db_exls)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @classmethod"},{"line_number":76,"context_line":"    def get_export_locations_by_share_id(cls, context, share_id):"},{"line_number":77,"context_line":"        exls \u003d cls.get_by_share_id(context, share_id)"},{"line_number":78,"context_line":"        return [location[\u0027path\u0027] for location in exls]"}],"source_content_type":"text/x-python","patch_set":19,"id":"1aca2d91_1d6325de","line":75,"in_reply_to":"3acd31a7_a490a3ed","updated":"2015-05-07 01:46:56.000000000","message":"to_list() sounds more like change something not list to list format.\n\nThis method actually return the member \"path\" in ShareExportLocation from ShareExportLocationsList.\n\ni think to_list is OK, but get_export_locations_by_share_id is OK too.","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"da707bd79efbe121a4969135af243e3d3d860e85","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return [location[\u0027path\u0027] for location in exls]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def share_export_locations_update(cls, context, share_id,"},{"line_number":82,"context_line":"                                      export_locations, delete\u003dTrue):"},{"line_number":83,"context_line":"        return db_api.share_export_locations_update("},{"line_number":84,"context_line":"            context, share_id, export_locations, delete)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_eaff85ff","line":81,"updated":"2015-04-30 14:36:21.000000000","message":"Name of method should be replaced by simple update()","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"ad0b8d9ae94b6a5325164cd67b3a6c72d94555ba","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        return [location[\u0027path\u0027] for location in exls]"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def share_export_locations_update(cls, context, share_id,"},{"line_number":82,"context_line":"                                      export_locations, delete\u003dTrue):"},{"line_number":83,"context_line":"        return db_api.share_export_locations_update("},{"line_number":84,"context_line":"            context, share_id, export_locations, delete)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3acd31a7_95f7daf4","line":81,"in_reply_to":"3acd31a7_eaff85ff","updated":"2015-05-04 01:52:25.000000000","message":"The name reason is same as above.","commit_id":"8e7181cf67d622c8cbd15783b84e9b838a6b9098"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"752a468afd558a40f7648e410f9ab3be41cc16c2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @classmethod"},{"line_number":65,"context_line":"    def get_by_share_id(cls, context, share_id):"},{"line_number":66,"context_line":"        db_exls \u003d db_api.share_export_locations_get(context,"},{"line_number":67,"context_line":"                                                    share_id)"},{"line_number":68,"context_line":"        return base.obj_make_list(context,"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a016987_fdd16bce","line":65,"updated":"2015-05-15 14:17:12.000000000","message":"About name of this method:\n\nVersionedObjectDictCompat mix-in used in ShareExportLocation class, and NOT in ShareExportLocationsList object, so you can use get() and update() for method names in this class.","commit_id":"5ec93e37a51ea275597a399e9c750a1874913192"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a400e07b7874f023cd38b68bfb0485816ae64fd7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @classmethod"},{"line_number":65,"context_line":"    def get_by_share_id(cls, context, share_id):"},{"line_number":66,"context_line":"        db_exls \u003d db_api.share_export_locations_get(context,"},{"line_number":67,"context_line":"                                                    share_id)"},{"line_number":68,"context_line":"        return base.obj_make_list(context,"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a016987_bc9cf2c0","line":65,"in_reply_to":"7a016987_fdd16bce","updated":"2015-05-18 01:38:24.000000000","message":"Done","commit_id":"5ec93e37a51ea275597a399e9c750a1874913192"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"752a468afd558a40f7648e410f9ab3be41cc16c2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                  db_exls)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"},{"line_number":74,"context_line":"    def get_export_locations_by_share_id(cls, context, share_id):"},{"line_number":75,"context_line":"        exls \u003d cls.get_by_share_id(context, share_id)"},{"line_number":76,"context_line":"        return [location[\u0027path\u0027] for location in exls]"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"7a016987_9de39705","line":74,"updated":"2015-05-15 14:17:12.000000000","message":"This method is not used. Remove it.","commit_id":"5ec93e37a51ea275597a399e9c750a1874913192"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a400e07b7874f023cd38b68bfb0485816ae64fd7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                  db_exls)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"},{"line_number":74,"context_line":"    def get_export_locations_by_share_id(cls, context, share_id):"},{"line_number":75,"context_line":"        exls \u003d cls.get_by_share_id(context, share_id)"},{"line_number":76,"context_line":"        return [location[\u0027path\u0027] for location in exls]"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"7a016987_9c9ff6b3","line":74,"in_reply_to":"7a016987_9de39705","updated":"2015-05-18 01:38:24.000000000","message":"Done","commit_id":"5ec93e37a51ea275597a399e9c750a1874913192"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"752a468afd558a40f7648e410f9ab3be41cc16c2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return [location[\u0027path\u0027] for location in exls]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @classmethod"},{"line_number":79,"context_line":"    def share_export_locations_update(cls, context, share_id,"},{"line_number":80,"context_line":"                                      export_locations, delete\u003dTrue):"},{"line_number":81,"context_line":"        return db_api.share_export_locations_update("},{"line_number":82,"context_line":"            context, share_id, export_locations, delete)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a016987_fd35eb45","line":79,"updated":"2015-05-15 14:17:12.000000000","message":"Call of this method looks ugly:\nobject_exl.ShareExportLocationsList.share_export_locations_update()\n\n\u0027share export locations\u0027 is used twice, it\u0027s redundant. Rename this method:\nshare_export_locations_update -\u003e update()","commit_id":"5ec93e37a51ea275597a399e9c750a1874913192"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"a400e07b7874f023cd38b68bfb0485816ae64fd7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        return [location[\u0027path\u0027] for location in exls]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @classmethod"},{"line_number":79,"context_line":"    def share_export_locations_update(cls, context, share_id,"},{"line_number":80,"context_line":"                                      export_locations, delete\u003dTrue):"},{"line_number":81,"context_line":"        return db_api.share_export_locations_update("},{"line_number":82,"context_line":"            context, share_id, export_locations, delete)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7a016987_dc5e8e11","line":79,"in_reply_to":"7a016987_fd35eb45","updated":"2015-05-18 01:38:24.000000000","message":"Done","commit_id":"5ec93e37a51ea275597a399e9c750a1874913192"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"9e18acfeda70ff59b18c8553abff3df78f47613f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def _from_db_object(context, exl, db_exl):"},{"line_number":42,"context_line":"        if db_exl is None:"},{"line_number":43,"context_line":"            return None"},{"line_number":44,"context_line":"        for field in exl.fields:"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa32b979_2dc13ae4","line":41,"updated":"2015-06-25 10:43:42.000000000","message":"What means \u0027exl\u0027 and \u0027db_exl\u0027? Are we running out of chars? :-)","commit_id":"b6c687202643734330d3242d189769f91417a5b4"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"da0f67792a195b3d821017696c23ed70ce6c0ed6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @staticmethod"},{"line_number":41,"context_line":"    def _from_db_object(context, exl, db_exl):"},{"line_number":42,"context_line":"        if db_exl is None:"},{"line_number":43,"context_line":"            return None"},{"line_number":44,"context_line":"        for field in exl.fields:"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_ecc809ab","line":41,"in_reply_to":"fa32b979_2dc13ae4","updated":"2015-07-06 02:05:49.000000000","message":"Comments Added !","commit_id":"b6c687202643734330d3242d189769f91417a5b4"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"9e18acfeda70ff59b18c8553abff3df78f47613f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027ShareExportLocation\u0027),"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    child_versions \u003d {"},{"line_number":61,"context_line":"        \u00271.0\u0027: \u00271.0\u0027,"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"fa32b979_903c1dc9","line":60,"updated":"2015-06-25 10:43:42.000000000","message":"What is this good for? In which cases should it be updated? The oslo-versionedobjects doc seems to be useless...","commit_id":"b6c687202643734330d3242d189769f91417a5b4"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"da1b572894d5afe3cc3b5bfdfb2f65406c8b6763","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027ShareExportLocation\u0027),"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    child_versions \u003d {"},{"line_number":61,"context_line":"        \u00271.0\u0027: \u00271.0\u0027,"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_2c035178","line":60,"in_reply_to":"ba3cc151_2ccfd1b4","updated":"2015-07-06 02:37:23.000000000","message":"The link of spec if you\u0027re interested:\n\nhttps://review.openstack.org/#/c/196670/2/specs/liberty/object-compatibility-mode.rst","commit_id":"b6c687202643734330d3242d189769f91417a5b4"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"da0f67792a195b3d821017696c23ed70ce6c0ed6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027ShareExportLocation\u0027),"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    child_versions \u003d {"},{"line_number":61,"context_line":"        \u00271.0\u0027: \u00271.0\u0027,"},{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba3cc151_2ccfd1b4","line":60,"in_reply_to":"fa32b979_903c1dc9","updated":"2015-07-06 02:05:49.000000000","message":"child_version is used to sync versions between ShareExportLocationsList(the father) \u0026 ShareExportLocation(the child).\n\nBut this might be changed after the second part of  VO, as in heat, they\u0027re discussing \"compatibility mode\" which looks like may make all objects under a unified version.\n\nI removed this part as it is useless at this stage.","commit_id":"b6c687202643734330d3242d189769f91417a5b4"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"9e18acfeda70ff59b18c8553abff3df78f47613f","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @classmethod"},{"line_number":65,"context_line":"    def get(cls, context, share_id):"},{"line_number":66,"context_line":"        db_exls \u003d db_api.share_export_locations_get(context,"},{"line_number":67,"context_line":"                                                    share_id)"},{"line_number":68,"context_line":"        return base.obj_make_list(context,"},{"line_number":69,"context_line":"                                  cls(),"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa32b979_8d2726c9","line":66,"updated":"2015-06-25 10:43:42.000000000","message":"Ah. Now I assume db_exls is a list of export locations...","commit_id":"b6c687202643734330d3242d189769f91417a5b4"}]}
