)]}'
{"contrib/tempest/tempest/scenario/test_share_basic_ops.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f037edeb7687c4d9637def37d42b6707280abfd8","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            private_key\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":104,"context_line":"        self.share \u003d self.shares_client.get_share(self.share[\u0027id\u0027])"},{"line_number":105,"context_line":"        server_ip \u003d self.share[\u0027export_location\u0027].split(\":\")[0]"},{"line_number":106,"context_line":"        if do_ping:"},{"line_number":107,"context_line":"            ssh_client.exec_command(\"ping -c 1 %s\" % server_ip)"},{"line_number":108,"context_line":"        return ssh_client"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_88655a1f","line":106,"updated":"2015-04-22 17:07:29.000000000","message":"Why do you need ping? ICMP can be disabled and shares still can work.","commit_id":"da682d8f6448107929130af4e7c2365dbacca8ad"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"3b324d6187e218e3e1a2600836cf0ba57dbdb8c1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            private_key\u003dself.keypair[\u0027private_key\u0027])"},{"line_number":104,"context_line":"        self.share \u003d self.shares_client.get_share(self.share[\u0027id\u0027])"},{"line_number":105,"context_line":"        server_ip \u003d self.share[\u0027export_location\u0027].split(\":\")[0]"},{"line_number":106,"context_line":"        if do_ping:"},{"line_number":107,"context_line":"            ssh_client.exec_command(\"ping -c 1 %s\" % server_ip)"},{"line_number":108,"context_line":"        return ssh_client"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_85e4933b","line":106,"in_reply_to":"dac4157f_88655a1f","updated":"2015-04-23 09:04:01.000000000","message":"Correct, I address that with https://review.openstack.org/#/c/176647/","commit_id":"da682d8f6448107929130af4e7c2365dbacca8ad"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"f03d97b9dcc3ba5f13361401c6e3ca956c3da3bc","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.allow_access_ip(self.share[\u0027id\u0027], instance\u003dinstance2)"},{"line_number":185,"context_line":"        ssh_client_inst2 \u003d self.init_ssh(instance2)"},{"line_number":186,"context_line":"        self.mount_share(first_location, ssh_client_inst2)"},{"line_number":187,"context_line":"        self.read_data(test_data, ssh_client_inst2)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self.umount_share(ssh_client_inst1)"},{"line_number":190,"context_line":"        self.umount_share(ssh_client_inst2)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_f6437211","line":187,"updated":"2015-04-25 20:33:40.000000000","message":"I\u0027d prefer to see the assertion here in the test.  That way, read_data remains a generic method that could be reused by other tests (such as a read-only access test).","commit_id":"5f6ae2414967c120a7bb763918bea285de0c629a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"49709a83c7353376e944b95de756f9030166a620","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self._allow_access(share_id, access_type\u003d\u0027ip\u0027, access_to\u003dip)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":154,"context_line":"    def test_server_basicops(self):"},{"line_number":155,"context_line":"        self.security_group \u003d self._create_security_group()"},{"line_number":156,"context_line":"        self.create_share_network()"},{"line_number":157,"context_line":"        self.create_share(self.share_net[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abe1de1_d10ee4e4","line":154,"updated":"2015-04-27 10:46:22.000000000","message":"Just payed attention to name of test. \"basicops\" is ambiguous here. Test does \"mount\" and \"unmount\" operations for each export location. What do you think about renaming it something more specific? For example: \"test_mount_and_unmount_share\"","commit_id":"560a6ae8988e61ca2500d1c6335ccd89ef8c585a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"49709a83c7353376e944b95de756f9030166a620","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.servers_client.delete_server(instance[\u0027id\u0027])"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":167,"context_line":"    def test_server_multi_vm(self):"},{"line_number":168,"context_line":"        \"\"\"Boots two vms and writes/reads data on it.\"\"\""},{"line_number":169,"context_line":"        test_data \u003d \"Some test data to write\""},{"line_number":170,"context_line":"        self.security_group \u003d self._create_security_group()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abe1de1_f130c8a0","line":167,"updated":"2015-04-27 10:46:22.000000000","message":"And here \"test_write_and_read_data_using_two_vms\" or something similar?","commit_id":"560a6ae8988e61ca2500d1c6335ccd89ef8c585a"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"251aa6e16ee6e83d3a83d8693cd06fc52133fb73","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        ssh_client.exec_command(\"sudo umount /mnt\")"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def write_data(self, data, ssh_client):"},{"line_number":117,"context_line":"        ssh_client.exec_command(\"sudo echo \\\"%s\\\" \u003e /mnt/t1 \" % data)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def read_data(self, ssh_client):"},{"line_number":120,"context_line":"        data \u003d ssh_client.exec_command(\"sudo cat /mnt/t1\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ad0253b_0fb0a6f3","line":117,"updated":"2015-04-29 05:46:13.000000000","message":"The \u003e defeats the sudo.  If you want to write as root you can pipe to sudo tee.","commit_id":"fe1a3440e6a142831bd8719f0e83b6e9abedc307"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"faa3e2cfde83ef2183cf006a883b17008f1c2ea0","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        ssh_client.exec_command(\"sudo umount /mnt\")"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def write_data(self, data, ssh_client):"},{"line_number":117,"context_line":"        ssh_client.exec_command(\"sudo echo \\\"%s\\\" \u003e /mnt/t1 \" % data)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def read_data(self, ssh_client):"},{"line_number":120,"context_line":"        data \u003d ssh_client.exec_command(\"sudo cat /mnt/t1\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ad0253b_7673734e","line":117,"in_reply_to":"5ad0253b_0fb0a6f3","updated":"2015-04-29 08:44:35.000000000","message":"Thanks! correct.. should be fixed.","commit_id":"fe1a3440e6a142831bd8719f0e83b6e9abedc307"},{"author":{"_account_id":7652,"name":"Luis Pabón","email":"lpabon@gmail.com","username":"lpabon"},"change_message_id":"dc6c4b59d620b4420ee7fd0495edeccb4f67e57e","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        data \u003d self.read_data(ssh_client_inst2)"},{"line_number":188,"context_line":"        self.assertEqual(test_data, data)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        self.umount_share(ssh_client_inst1)"},{"line_number":191,"context_line":"        self.umount_share(ssh_client_inst2)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ad0253b_d39c906b","line":190,"updated":"2015-04-29 12:15:50.000000000","message":"Question: Should unmont.share() be in a finally: clause in case any of the previous functions throw an exception?","commit_id":"81ef6cc697cf1923469cf22e6734957c76a24bde"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5ee6c543bca75e9e4288d288803f3a88523ff343","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        data \u003d self.read_data(ssh_client_inst2)"},{"line_number":188,"context_line":"        self.assertEqual(test_data, data)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        self.umount_share(ssh_client_inst1)"},{"line_number":191,"context_line":"        self.umount_share(ssh_client_inst2)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ad0253b_b39594e5","line":190,"in_reply_to":"5ad0253b_33274414","updated":"2015-04-29 12:23:36.000000000","message":"It is useless in CI, but useful for testing in existing environment that is reused.","commit_id":"81ef6cc697cf1923469cf22e6734957c76a24bde"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"eb17facb5ffb4514b387aee276183630e244c274","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        data \u003d self.read_data(ssh_client_inst2)"},{"line_number":188,"context_line":"        self.assertEqual(test_data, data)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        self.umount_share(ssh_client_inst1)"},{"line_number":191,"context_line":"        self.umount_share(ssh_client_inst2)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ad0253b_33274414","line":190,"in_reply_to":"5ad0253b_d39c906b","updated":"2015-04-29 12:22:40.000000000","message":"+1\n\nOperation  \"unmount\" should be performed in all cases.","commit_id":"81ef6cc697cf1923469cf22e6734957c76a24bde"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"4f941156438c212f91e2acb4623a5c55b4c219c8","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        ssh_client.exec_command(\"sudo umount /mnt\")"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def write_data(self, data, ssh_client):"},{"line_number":117,"context_line":"        ssh_client.exec_command(\"sudo echo \\\"%s\\\" | sudo tee /mnt/t1\" % data)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def read_data(self, ssh_client):"},{"line_number":120,"context_line":"        data \u003d ssh_client.exec_command(\"sudo cat /mnt/t1\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"3acd31a7_939bafc9","line":117,"updated":"2015-04-30 12:59:35.000000000","message":"You don\u0027t need the first sudo. This will work:\n\nssh_client.exec_command(\"echo \\\"%s\\\" | sudo tee /mnt/t1\" % data)","commit_id":"0b32f031ccaa7ac955dfbf6bd2eb40d2f2f8cdef"}]}
